mesh-build-go: build_go_test takes packages as a typed list too, so checks run again (issue 1925) #465

2026-10-23T20:36:26Z

mesh-tools commented

2026-10-23 20:36:26 +00:00

Fixes issue 1925 (critical): since R4g every Go repository's try and merge check was refused at the unit level with 'packages is a list of package patterns', running no test. On the ask path mesh-sdk's buildstep.RunAsk hands packages as a typed []string in process; packagesArg accepted only the JSON-decoded []any. It now takes both shapes with the same per-element checks.

Tests: packages_shape_test.go — 1925/AC1 (both shapes, refusals), 1925/AC2 (the real build_go_test body through buildstep.RunAsk with a digest naming a package). Both fail against main and pass here.

Try: try-1792786906999177133 passed (unit 4422, integration 4463, 0 failed; judged by the candidate's mesh-build-go).

Moves mesh-build-go (g14, novox, shanks). Small fix, playbook 08; goes alone because it is broken for the operator now (no check can pass).

Reviewed-by: review-1925@shanks at 70ef99595a
Pushed-by: fix-1925@shanks

Fixes issue 1925 (critical): since R4g every Go repository's try and merge check was refused at the unit level with 'packages is a list of package patterns', running no test. On the ask path mesh-sdk's buildstep.RunAsk hands `packages` as a typed `[]string` in process; `packagesArg` accepted only the JSON-decoded `[]any`. It now takes both shapes with the same per-element checks. Tests: `packages_shape_test.go` — 1925/AC1 (both shapes, refusals), 1925/AC2 (the real build_go_test body through buildstep.RunAsk with a digest naming a package). Both fail against main and pass here. Try: try-1792786906999177133 passed (unit 4422, integration 4463, 0 failed; judged by the candidate's mesh-build-go). Moves mesh-build-go (g14, novox, shanks). Small fix, playbook 08; goes alone because it is broken for the operator now (no check can pass). Reviewed-by: review-1925@shanks at 70ef99595aa904f25e75f3662eabef1fdf76198a Pushed-by: fix-1925@shanks

mesh-tools added 1 commit 2026-10-23 20:36:26 +00:00

mesh-build-go: build_go_test takes packages as a typed list too (issue 1925)

mesh/delivery delivered

Details

mesh/check failed: shanks: the check of novox/mesh-catalog#465 failed: the unit level: packages is a list of package patterns | 70ef99595aa9 on e52024…

70ef99595a

mesh-tools commented

2026-10-23 20:36:31 +00:00

Delivery novox/mesh-catalog@70ef99595aa9 — delivered since 2026-10-23T20:46:08Z

Delivery plan — builds mesh-build-go → g14, novox, shanks; no bus step

tier 0: mesh-build-go
g14: receives mesh-build-go
novox: receives mesh-build-go
shanks: receives mesh-build-go
grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-build-go is judged on its first machine

Machines

mesh-build-go on every machine running it: sent

Transitions

2026-10-23 20:36 (new) → proposed (announced): novox/mesh-catalog#465's head announced
2026-10-23 20:43 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
2026-10-23 20:43 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-23 20:44 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-23 20:44 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
2026-10-23 20:46 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@70ef99595aa9` — **delivered** since 2026-10-23T20:46:08Z **Delivery plan** — builds mesh-build-go → g14, novox, shanks; no bus step - tier 0: mesh-build-go - g14: receives mesh-build-go - novox: receives mesh-build-go - shanks: receives mesh-build-go - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-build-go is judged on its first machine **Machines** - mesh-build-go on every machine running it: sent **Transitions** - 2026-10-23 20:36 (new) → proposed (announced): novox/mesh-catalog#465's head announced - 2026-10-23 20:43 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-23 20:43 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-23 20:44 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-23 20:44 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-23 20:46 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools merged commit e5202445ba into main

2026-10-23 20:44:10 +00:00

mesh-tools deleted branch fix/1925-packages-shape

2026-10-23 20:44:10 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#465