R4g finish: mesh-build-go's compose job, the reads-outside marker in the digest, merge-check.sh gone (issues 1295, 1621-1623, 1935) #473

Merged

jschoubben merged 15 commits from feat/r4g-finish into main 2026-10-24 20:56:50 +00:00

Conversation 2 Commits 15 Files Changed 65

+736 -43

mesh-tools commented 2026-10-24 11:49:16 +00:00

Member

Copy Link

Copy Source

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan.

This member: mesh-build-go runs the compose job on node-build-go's check stream (go/cmd/mesh-compose; 1621, 1622, 1623); the digest never keeps a package marked reads-outside and folds the module's non-Go files in (1935), with 41 markers; merge-check.sh gone (1295); mesh-build-go pinned to the group's mesh-sdk head bfc3883a. Main merged in (#471). The group's check judges it.

Reviewed-by: review-r4g-r3@shanks at 2fabbe556e
Pushed-by: lead-47@shanks

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan. This member: mesh-build-go runs the compose job on node-build-go's check stream (go/cmd/mesh-compose; 1621, 1622, 1623); the digest never keeps a package marked reads-outside and folds the module's non-Go files in (1935), with 41 markers; merge-check.sh gone (1295); mesh-build-go pinned to the group's mesh-sdk head bfc3883a. Main merged in (#471). The group's check judges it. Reviewed-by: review-r4g-r3@shanks at 2fabbe556e73e0625e755435815f52192823afbc Pushed-by: lead-47@shanks

mesh-tools added 13 commits 2026-10-24 11:49:17 +00:00

Make a missing trunk copy a failure again, now the checker places it (issue 1295) ae6f7d5b54

mesh-build-go: a package marked reads-outside is never kept, so tests that read files outside their directory run on every check (issue 1935) b6ed8599c8

mesh-build-go: a catalogue module's non-Go files enter its packages' digests; markers where tests read other modules (issue 1935) a715c8821f

Run a compose ask on the Go build seat: build mesh-sdk's composer at the asked commit once, fill its manifests from the indexer and run it shut off (issue 1622) 6a70735489

Merge remote-tracking branch 'origin/feat/r4g-finish-1935' into HEAD ebb25757a2

Merge remote-tracking branch 'origin/feat/r4g-finish-composer' into HEAD e8a59171c7

Pin to the finish group's mesh-sdk head dd0d156b, so every member names one SDK (issue 1622) e870a7f65f

Say in realtree_test that a missing trunk fails, not skips (issue 1295) f04465537b

Mark the packages whose tests read files outside their directory, found by the review (issue 1935) 16d7b1898d

Merge main into feat/r4g-finish (#471) 91c3e954ae

Pin mesh-build-go to the group's mesh-sdk head after main's merge, so it builds on the SDK the group delivers f910b0ceb8

Mark pacman-tools as reading outside its directory: its upgrade-order test reads the root predefined.json, which its digest does not cover (issue 1935) 03524ecd13

Say what pacman-tools reads outside: the root predefined.json (issue 1935) 865f3b6455

mesh-tools commented 2026-10-24 11:49:28 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-catalog@2fabbe556e73 — delivered since 2026-10-24T21:11:25Z

Delivery plan — builds adwaita, blueman, brother, forticlient, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-notifier, mesh-mail-reader, mesh-provisioner-client, minio, networkmanager, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, postgres, slack, systemd-networkd, xorg, xterm → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person

• tier 0: adwaita, blueman, brother, forticlient, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-notifier, mesh-mail-reader, mesh-provisioner-client, minio, networkmanager, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, postgres, slack, systemd-networkd, xorg, xterm
• ace: receives mesh-provisioner-client, pacman; waits for a person: networkmanager, postgres
• g14: receives adwaita, blueman, i3, lemurs, mesh-build-go, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm; waits for a person: forticlient, networkmanager
• novox: receives mesh-build-go, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-reader, mesh-provisioner-client, pacman; waits for a person: minio, postgres, systemd-networkd
• shanks: receives adwaita, blueman, brother, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm; waits for a person: forticlient, networkmanager
• forticlient waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
• minio waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
• minio provides s3-bucket: its consumers are sent again after it
• minio keeps data (ADR 0233): what it holds is backed up before it moves
• networkmanager waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
• postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
• postgres provides postgres-database: its consumers are sent again after it
• postgres keeps data (ADR 0233): what it holds is backed up before it moves
• systemd-networkd waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
• xorg provides x11-display: its consumers are sent again after it
• grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before adwaita, blueman, brother, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm is judged on its first machine

Group feat/r4g-finish: novox/hq@2249d30151, novox/mesh-catalog@2fabbe556e, novox/mesh-controller@ecbb317dc3, novox/mesh-delivery@65496fc4f7, novox/mesh-host@13bdcb694b, novox/mesh-media-catalog@6392690b90, novox/mesh-sdk@bfc3883af9

• composed together: pass — the checker's verdict at the members' heads (590ced519c20)

Machines

• adwaita on every machine running it: sent
• blueman on every machine running it: sent
• brother on every machine running it: sent
• forticlient on every machine running it: sent
• i3 on every machine running it: sent
• lemurs on every machine running it: sent
• mesh-build-image on every machine running it: sent
• mesh-build-node on every machine running it: sent
• mesh-delivery-builder on every machine running it: sent
• mesh-delivery-checker on every machine running it: sent
• mesh-delivery-gate on every machine running it: sent
• mesh-delivery-indexer on every machine running it: sent
• mesh-delivery-teller on every machine running it: sent
• mesh-delivery-watchman on every machine running it: sent
• mesh-host on every machine running it: sent
• mesh-issues on every machine running it: sent
• mesh-knowledge on every machine running it: sent
• mesh-mail on every machine running it: sent
• mesh-mail-notifier on every machine running it: sent
• mesh-mail-reader on every machine running it: sent
• mesh-provisioner-client on every machine running it: sent
• mesh-sdk on every machine running it: sent
• minio on every machine running it: sent
• networkmanager on every machine running it: sent
• nextcloud-client on every machine running it: sent
• nm-applet on every machine running it: sent
• openrazer on every machine running it: sent
• pacman on every machine running it: sent
• polychromatic on every machine running it: sent
• postgres on every machine running it: sent
• slack on every machine running it: sent
• systemd-networkd on every machine running it: sent
• xorg on every machine running it: sent
• xterm on every machine running it: sent
• mesh-controller on every machine running it: sent
• mesh-build-go on every machine running it: sent
• mesh-delivery-assigner on every machine running it: sent

Transitions

• 2026-10-24 12:57 (new) → proposed (announced): novox/mesh-catalog#473's head announced
• 2026-10-24 13:12 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-24 13:12 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
• 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass 2fabbe556e on 25176e1ccd | judged by the candidate's mesh-build-go at 1c0eb1a8c88c
• 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-24 19:47 ready → proposed (trunk moved): out of date: judged against trunk 25176e1ccd, the trunk is now ee216e4e63f1; judged again on a recheck or when it is merged
• 2026-10-24 20:56 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on
• 2026-10-24 20:59 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's plans go
• 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@2fabbe556e73` — **delivered** since 2026-10-24T21:11:25Z **Delivery plan** — builds adwaita, blueman, brother, forticlient, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-notifier, mesh-mail-reader, mesh-provisioner-client, minio, networkmanager, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, postgres, slack, systemd-networkd, xorg, xterm → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person - tier 0: adwaita, blueman, brother, forticlient, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-notifier, mesh-mail-reader, mesh-provisioner-client, minio, networkmanager, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, postgres, slack, systemd-networkd, xorg, xterm - ace: receives mesh-provisioner-client, pacman; waits for a person: networkmanager, postgres - g14: receives adwaita, blueman, i3, lemurs, mesh-build-go, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm; waits for a person: forticlient, networkmanager - novox: receives mesh-build-go, mesh-build-node, mesh-delivery-gate, mesh-issues, mesh-knowledge, mesh-mail, mesh-mail-reader, mesh-provisioner-client, pacman; waits for a person: minio, postgres, systemd-networkd - shanks: receives adwaita, blueman, brother, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm; waits for a person: forticlient, networkmanager - forticlient waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - minio waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - minio provides s3-bucket: its consumers are sent again after it - minio keeps data (ADR 0233): what it holds is backed up before it moves - networkmanager waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - postgres provides postgres-database: its consumers are sent again after it - postgres keeps data (ADR 0233): what it holds is backed up before it moves - systemd-networkd waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - xorg provides x11-display: its consumers are sent again after it - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before adwaita, blueman, brother, i3, lemurs, mesh-build-go, mesh-build-image, mesh-build-node, mesh-mail-notifier, mesh-provisioner-client, nextcloud-client, nm-applet, openrazer, pacman, polychromatic, slack, xorg, xterm is judged on its first machine **Group** `feat/r4g-finish`: novox/hq@2249d30151e8, novox/mesh-catalog@2fabbe556e73, novox/mesh-controller@ecbb317dc324, novox/mesh-delivery@65496fc4f7a6, novox/mesh-host@13bdcb694be0, novox/mesh-media-catalog@6392690b90c2, novox/mesh-sdk@bfc3883af980 - composed together: pass — the checker's verdict at the members' heads (590ced519c20) **Machines** - adwaita on every machine running it: sent - blueman on every machine running it: sent - brother on every machine running it: sent - forticlient on every machine running it: sent - i3 on every machine running it: sent - lemurs on every machine running it: sent - mesh-build-image on every machine running it: sent - mesh-build-node on every machine running it: sent - mesh-delivery-builder on every machine running it: sent - mesh-delivery-checker on every machine running it: sent - mesh-delivery-gate on every machine running it: sent - mesh-delivery-indexer on every machine running it: sent - mesh-delivery-teller on every machine running it: sent - mesh-delivery-watchman on every machine running it: sent - mesh-host on every machine running it: sent - mesh-issues on every machine running it: sent - mesh-knowledge on every machine running it: sent - mesh-mail on every machine running it: sent - mesh-mail-notifier on every machine running it: sent - mesh-mail-reader on every machine running it: sent - mesh-provisioner-client on every machine running it: sent - mesh-sdk on every machine running it: sent - minio on every machine running it: sent - networkmanager on every machine running it: sent - nextcloud-client on every machine running it: sent - nm-applet on every machine running it: sent - openrazer on every machine running it: sent - pacman on every machine running it: sent - polychromatic on every machine running it: sent - postgres on every machine running it: sent - slack on every machine running it: sent - systemd-networkd on every machine running it: sent - xorg on every machine running it: sent - xterm on every machine running it: sent - mesh-controller on every machine running it: sent - mesh-build-go on every machine running it: sent - mesh-delivery-assigner on every machine running it: sent **Transitions** - 2026-10-24 12:57 (new) → proposed (announced): novox/mesh-catalog#473's head announced - 2026-10-24 13:12 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 13:12 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass 2fabbe556e73 on 25176e1ccdb3 | judged by the candidate's mesh-build-go at 1c0eb1a8c88c - 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-24 19:47 ready → proposed (trunk moved): out of date: judged against trunk 25176e1ccdb3, the trunk is now ee216e4e63f1; judged again on a recheck or when it is merged - 2026-10-24 20:56 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on - 2026-10-24 20:59 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's `plans go` - 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

jschoubben added 1 commit 2026-10-24 12:12:12 +00:00

Pin to the group's new mesh-sdk head 19c1d359, whose composer names the reader's pinned SDK instead of a bare (devel) (ADR 0482 clause 5) 89b9212c4d

jschoubben added 1 commit 2026-10-24 12:57:36 +00:00

Pin to the group's new mesh-sdk head bfc3883a, whose composer reads a fallback to a predefined key as the indexer does (ADR 0348 §7) 2fabbe556e

mesh-tools commented 2026-10-24 19:55:04 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

jschoubben merged commit 6fb0ceeef8 into main 2026-10-24 20:56:50 +00:00

jschoubben deleted branch feat/r4g-finish 2026-10-24 20:56:52 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#473