Gate: hand every member of an approved group in pin order, settle pull requests closed on the forge, and say a stopped pass as a condition (issue 1275)

Conversation 1 Commits 3 Files Changed 18

+887 -75

3 Commits

Author	SHA1	Message	Date
jschoubben	0c216d99d0	Gate takes a merge learnt after the fact as past: no trunk move, the forge's time, never source.main (issue 1275, review round 2) mesh/delivery held for a person: merged without a passing check: only a person decides what follows Details mesh/check pass 0c216d99d0c0 on 9d9dfda19b7e \| unit 2181 run, 2147 kept, 5 skipped \| integration 2203 run, 2166 kept, 9 skipped \| over bound: unit, in… A pull request found merged only by its absence from the open list went through PullMerged, which moved every other open delivery of its repository back to an old trunk (ready ones to proposed, composed checks out of date), dated the merge now, and so let a later catch-up write the old commit into source.main. pullMerged now takes such a merge as late: its own delivery is merged and its group closed, no other trunk moves, its time is the forge's or none, and LearntLate keeps it out of source.main in finish, settleForgeMerges and the catch-up. The gitea tool gitea_commit_statuses now answers the pull request's merged_at, and the gate reads a gone pull request by its number alone, so a deleted branch does not fail the read.	2026-10-25 18:37:59 +01:00
jschoubben	145c54d19c	Gate settles pull requests closed with no event, looks again at a line's bound, and keeps a waiting head's condition over a restart (issue 1275, review round 1) The conditions the gate now says would otherwise be wrong three ways: - A pull request closed or merged on the forge with no event heard stayed ready here for days (de-spiegel #4, closed 2026-10-17) and would raise a condition. After a complete read of the open list (shorter than the forge tool's 1000), each delivery not final whose pull request is missing is read from the forge and taken as its close or merge; a merge learnt so does not move source.main, as it is undated and could move it back. - A line that comes due on the clock (a state's bound, the author's bound, an answered refusal, an out-of-date refusal turning urgent after 10 minutes) waited for an unrelated event. The gate now asks a look at the earliest such time. - After a restart the heads waiting on the forge start their bound again, so their conditions were cleared and raised again later. A condition is cleared only once the open list was read since start, and not while the forge still shows its head open and waiting. Also: an empty path list ranks with a truncated one in the merge order, and a seat that keeps refusing conditions is retried on the clock 10 looks in a row, then at events only, said once in the log.	2026-10-25 18:32:19 +01:00
jschoubben	67092161bd	Gate hands every member of an approved group, in pin order, and says a stopped pass (issue 1275) Met again 2026-10-25: group fix/puller-wakes-on-capacity was merged half. Three causes in the gate: - The next member's turn compared the group's state with "delivering", a word GroupState no longer says since release 6 renamed it "merging" (ready.go groupTurnToMerge). Once the first member's merge was heard from the forge the group read merging, and the second member waited for ever. Group states are now named constants, the turn goes on in ready and merging (groupMayMerge), and a test holds every word to it. - Members merged in id order, so mesh-catalog went before the mesh-sdk commit it pins. membersOf now orders by mergeRank: mesh-sdk first, then members that change no go.mod or go.sum, then those that do. - No condition was raised: the controller's self-check that read `stalled` went with release 6 (mesh-controller dc456d56). The gate now says its stalled lines as conditions itself on the operator-channel seat (ADR 0437 §9) after every look, clears those listed no more, and keeps which it raised in its new bucket conditions. A held group's line says "half merged" when a member merged. A pass held for a required status no longer retries on a timer: the status turning success is the event that asks the merge again.	2026-10-25 18:20:58 +01:00

Author

SHA1

Message

Date

jschoubben

0c216d99d0

Gate takes a merge learnt after the fact as past: no trunk move, the forge's time, never source.main (issue 1275, review round 2)

mesh/delivery held for a person: merged without a passing check: only a person decides what follows

Details

mesh/check pass 0c216d99d0c0 on 9d9dfda19b7e | unit 2181 run, 2147 kept, 5 skipped | integration 2203 run, 2166 kept, 9 skipped | over bound: unit, in…

A pull request found merged only by its absence from the open list went through PullMerged, which moved every
other open delivery of its repository back to an old trunk (ready ones to proposed, composed checks out of
date), dated the merge now, and so let a later catch-up write the old commit into source.main. pullMerged now
takes such a merge as late: its own delivery is merged and its group closed, no other trunk moves, its time is
the forge's or none, and LearntLate keeps it out of source.main in finish, settleForgeMerges and the catch-up.

The gitea tool gitea_commit_statuses now answers the pull request's merged_at, and the gate reads a gone pull
request by its number alone, so a deleted branch does not fail the read.

2026-10-25 18:37:59 +01:00

jschoubben

145c54d19c

Gate settles pull requests closed with no event, looks again at a line's bound, and keeps a waiting head's condition over a restart (issue 1275, review round 1)

The conditions the gate now says would otherwise be wrong three ways:

- A pull request closed or merged on the forge with no event heard stayed ready here for days (de-spiegel #4,
  closed 2026-10-17) and would raise a condition. After a complete read of the open list (shorter than the
  forge tool's 1000), each delivery not final whose pull request is missing is read from the forge and taken as
  its close or merge; a merge learnt so does not move source.main, as it is undated and could move it back.
- A line that comes due on the clock (a state's bound, the author's bound, an answered refusal, an
  out-of-date refusal turning urgent after 10 minutes) waited for an unrelated event. The gate now asks a look
  at the earliest such time.
- After a restart the heads waiting on the forge start their bound again, so their conditions were cleared and
  raised again later. A condition is cleared only once the open list was read since start, and not while the
  forge still shows its head open and waiting.

Also: an empty path list ranks with a truncated one in the merge order, and a seat that keeps refusing
conditions is retried on the clock 10 looks in a row, then at events only, said once in the log.

2026-10-25 18:32:19 +01:00

jschoubben

67092161bd

Gate hands every member of an approved group, in pin order, and says a stopped pass (issue 1275)

Met again 2026-10-25: group fix/puller-wakes-on-capacity was merged half. Three causes in the gate:

- The next member's turn compared the group's state with "delivering", a word GroupState no longer says
  since release 6 renamed it "merging" (ready.go groupTurnToMerge). Once the first member's merge was heard
  from the forge the group read merging, and the second member waited for ever. Group states are now named
  constants, the turn goes on in ready and merging (groupMayMerge), and a test holds every word to it.
- Members merged in id order, so mesh-catalog went before the mesh-sdk commit it pins. membersOf now orders
  by mergeRank: mesh-sdk first, then members that change no go.mod or go.sum, then those that do.
- No condition was raised: the controller's self-check that read `stalled` went with release 6
  (mesh-controller dc456d56). The gate now says its stalled lines as conditions itself on the
  operator-channel seat (ADR 0437 §9) after every look, clears those listed no more, and keeps which it
  raised in its new bucket conditions. A held group's line says "half merged" when a member merged.

A pass held for a required status no longer retries on a timer: the status turning success is the event
that asks the merge again.

2026-10-25 18:20:58 +01:00

Gate: hand every member of an approved group in pin order, settle pull requests closed on the forge, and say a stopped pass as a condition (issue 1275) #480