novox/mesh-catalog
18
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesh-build-go: count skipped tests per package, so the checker keeps no pass that skipped (issue 890) #492

Merged
mesh-tools merged 1 commits from fix/checker-skips-not-kept into main 2026-10-26 12:01:13 +00:00
Conversation 2 Commits 1 Files Changed 2
+25
mesh-tools commented 2026-10-26 11:44:24 +00:00
Member
Copy Link
Copy Source

Group fix/checker-skips-not-kept with mesh-delivery, one Approve. Issue 890 (note 18): a check that skipped tests (for example mesh-build-node's toolchain tests on a node without a Node toolchain) passed and the checker kept that pass by digest, so no node might ever run those tests for that change. mesh-build-go now counts skips per package (PackageResult.Skipped, omitempty), beside the result's total. Test: TestEachPackageCountsItsOwnSkippedTests. Try try-1793014166503732275 passed. Either delivery order is safe (the checker reads JSON; an older checker ignores the field).

Reviewed-by: review-nodetc@shanks at ea53b2f920

Group fix/checker-skips-not-kept with mesh-delivery, one Approve. Issue 890 (note 18): a check that skipped tests (for example mesh-build-node's toolchain tests on a node without a Node toolchain) passed and the checker kept that pass by digest, so no node might ever run those tests for that change. mesh-build-go now counts skips per package (PackageResult.Skipped, omitempty), beside the result's total. Test: TestEachPackageCountsItsOwnSkippedTests. Try try-1793014166503732275 passed. Either delivery order is safe (the checker reads JSON; an older checker ignores the field). Reviewed-by: review-nodetc@shanks at ea53b2f920b526ed169c665a717f6169d010f81d
mesh-tools added 1 commit 2026-10-26 11:44:24 +00:00
mesh-build-go: each package counts its skipped tests (issue 890)
mesh/delivery merged: source.main moved to novox/mesh-catalog@71e094b2de59
Details
mesh/delivery-group group fix/checker-skips-not-kept merged: every member is merged
Details
mesh/check failed: ace: the check of novox/mesh-catalog#492 refused: the installed go version could not be read: `go version` with GOTOOLCHAIN=local f…
ea53b2f920
mesh-tools commented 2026-10-26 11:44:28 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-catalog@ea53b2f920b5 — merged since 2026-10-26T12:01:15Z

Source — source.main moved to novox/mesh-catalog@71e094b2de. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/checker-skips-not-kept: novox/mesh-catalog@ea53b2f920, novox/mesh-delivery@e1f1b5d18b

Transitions

  • 2026-10-26 11:44 (new) → proposed (announced): novox/mesh-catalog#492's head announced
  • 2026-10-26 11:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 12:01 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@ea53b2f920b5` — **merged** since 2026-10-26T12:01:15Z **Source** — source.main moved to novox/mesh-catalog@71e094b2de59. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/checker-skips-not-kept`: novox/mesh-catalog@ea53b2f920b5, novox/mesh-delivery@e1f1b5d18bf0 **Transitions** - 2026-10-26 11:44 (new) → proposed (announced): novox/mesh-catalog#492's head announced - 2026-10-26 11:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 12:01 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools commented 2026-10-26 11:44:31 +00:00
Author
Member
Copy Link
Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools merged commit 71e094b2de into main 2026-10-26 12:01:13 +00:00
mesh-tools deleted branch fix/checker-skips-not-kept 2026-10-26 12:01:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#492