mesh-build-go says which packages it cannot test here, and mesh-build-node's tests need the Node toolchain (issue 890, ADR 0552) #498

2026-10-26T13:26:45Z

mesh-tools commented

2026-10-26 13:26:45 +00:00

Issue 890, ADR 0552. Group feat/890-placement with mesh-sdk and mesh-delivery.

mesh-build-go pins mesh-sdk 33395f68; its integration digest reports needs; Has("node-build-node") is true only with node, npm and bwrap on the path and a toolchain installed whole (.installed mark and a readable package-lock.json), read at every ask.
modules/mesh-build-node/cmd/mesh-build-node/check-needs names node-build-node.

Tests: TestAPackageWithTheReadsOutsideMarkerIsNeverKept, TestANodeWithoutNodeToolchainsRunsTheLevelWithNothingMoreBound (four cases). Try try-1793020273525084660 passed (unit 4357, integration 4396).

Reviewed-by: review-890@shanks at d3423f54ed

Issue 890, ADR 0552. Group feat/890-placement with mesh-sdk and mesh-delivery. - mesh-build-go pins mesh-sdk 33395f68; its integration digest reports needs; `Has("node-build-node")` is true only with node, npm and bwrap on the path and a toolchain installed whole (`.installed` mark and a readable package-lock.json), read at every ask. - `modules/mesh-build-node/cmd/mesh-build-node/check-needs` names `node-build-node`. Tests: TestAPackageWithTheReadsOutsideMarkerIsNeverKept, TestANodeWithoutNodeToolchainsRunsTheLevelWithNothingMoreBound (four cases). Try try-1793020273525084660 passed (unit 4357, integration 4396). Reviewed-by: review-890@shanks at d3423f54ed587a387f2b8ff67a1fcaef984c0627

mesh-tools added 4 commits 2026-10-26 13:26:46 +00:00

mesh-build-go: report the needs a package's check-needs marker names, test it only where the node has them, decline an ask needing what the node lacks (issue 890) 67d6a5a7c1

mesh-build-node's integration tests read the Node toolchain installed only where the node holds node-build-node, and
skipped on ace: its package now declares node-build-node beside its tests; the integration digest names it, a node
lacking it leaves the package unmet for the checker to place, and declines a placed ask. Re-pins mesh-sdk feat/890-placement.

mesh-build-go: node-build-node also needs bubblewrap and a toolchain installed whole (its mark and lock), as mesh-build-node's integration tests do; pins mesh-sdk 45564e69 (issue 890, review round 1) d21b81b00a

mesh-build-go: pin mesh-sdk 33395f68, feat/890-placement merged with main (issue 890) 0e322d087f

mesh-build-go: resolve the go.mod and go.sum the main merge left in conflict; pin mesh-sdk 33395f68 (issue 890)

mesh/delivery merged: source.main moved to novox/mesh-catalog@9a8e54d988fe

Details

mesh/delivery-group group feat/890-placement merged: every member is merged

Details

mesh/check checking d3423f54ed58 on 9a8e54d988fe | novox/mesh-catalog#498 in group feat/890-placement

d3423f54ed

mesh-tools commented

2026-10-26 13:26:53 +00:00

Delivery novox/mesh-catalog@d3423f54ed58 — merged since 2026-10-26T13:40:44Z

Source — source.main moved to novox/mesh-catalog@9a8e54d988. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group feat/890-placement: novox/mesh-catalog@d3423f54ed, novox/mesh-delivery@3073495a06, novox/mesh-sdk@33395f68b3

Transitions

2026-10-26 13:26 (new) → proposed (announced): novox/mesh-catalog#498's head announced
2026-10-26 13:26 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 13:40 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@d3423f54ed58` — **merged** since 2026-10-26T13:40:44Z **Source** — source.main moved to novox/mesh-catalog@9a8e54d988fe. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `feat/890-placement`: novox/mesh-catalog@d3423f54ed58, novox/mesh-delivery@3073495a0670, novox/mesh-sdk@33395f68b309 **Transitions** - 2026-10-26 13:26 (new) → proposed (announced): novox/mesh-catalog#498's head announced - 2026-10-26 13:26 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 13:40 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-10-26 13:26:58 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit 9a8e54d988 into main

2026-10-26 13:40:41 +00:00

mesh-tools deleted branch feat/890-placement

2026-10-26 13:40:41 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#498