A reads-outside marker lists what its tests read, so its package's check is reused until one of those files changes (issue 1936) #513

Merged

mesh-tools merged 4 commits from fix/1936-declared-reads into main 2026-10-26 21:18:14 +00:00

Conversation 1 Commits 4 Files Changed 51

+617 -78

4 Commits

Author	SHA1	Message	Date
jschoubben	488b7bfc58	checks/health: its marker names health-undeclared for what it counts (issue 1936)	2026-10-26 22:13:14 +01:00
jschoubben	d58249d0d8	checks/health: its marker lists the predefined keys, the modules' templates and health-undeclared it reads (issue 1936) ... ReadTreeManifest reads predefined.json and each templated module's templates (WithTemplatesFrom), and the test reads the root's health-undeclared through Kept: none was listed, so a change to them reused a stale verdict. No other marker's package reads manifests through ReadTreeManifest beyond what it lists. Review finding F1 on ba49a7f0.	2026-10-26 22:13:01 +01:00
jschoubben	d224b74ff1	mesh-build-go: a marked package's digest hashes every file of its own directory, Go files its build tags exclude too (issue 1936) ... go list leaves a file its build tags exclude (an integration test) in IgnoredGoFiles, which the digest did not hash; mesh-provisioner-client's unit test globs *_test.go and reads two of them, so a change there reused a stale unit pass. Review finding F2 on ba49a7f0.	2026-10-26 22:13:01 +01:00
jschoubben	ba49a7f0f9	mesh-build-go: a reads-outside marker lists what its tests read, so its package is kept until one of those files changes (issue 1936) ... 47 packages carried the marker and were never kept: about 2000 tests per level ran on every check, whatever it changed. The marker now lists, as paths or globs from the repository's root (? before a path whose absence is read), what the package's tests read outside it; the digest hashes those files with the package's own non-Go files. A marker that lists nothing, names an unclean path, or a line that matches nothing keeps today's never-kept digest. The 46 markers list their reads; checks/deps and checks/trunk lose theirs (their tests read only temporary directories). Digest form 6. Quick fix of issue 1936, chosen by the operator 2026-10-26 21:56; the thorough fix (the Go test log's files kept with each verdict) stays on the issue.	2026-10-26 22:02:58 +01:00