Every build module clears at start what a previous process left running, held by the catalogue's check (issue 1890) #518

Merged
mesh-tools merged 2 commits from fix/1890-step-owner into main 2026-10-27 07:19:39 +00:00
Member

Issue 1890, delivery group fix/1890-step-owner with novox/mesh-sdk.

  • mesh-build-go, mesh-build-node, mesh-build-image pin mesh-sdk db1007ffdda1 exactly; each calls endLeftRunning at start and runs it through the kit (TestTheStartSweepEndsWhatAPreviousProcessLeft).
  • checks/failurekit refuses a module claiming a node-build-* seat whose tests do not call conformance.LeftRunning (no exemption).
  • mesh-build-image's captured step fixtures normalise the new owner field; its pin moves from mesh-sdk 805b4d9a and takes in the already-merged mesh-sdk #100-#104.

Tests: go vet, go vet -tags integration, go test in the three modules and checks/failurekit pass; failurekit judges the real catalogue. Counts (integration/unit of 50/500): mesh-build-go 38/153, mesh-build-node 8/93, mesh-build-image 6/55.

Reviewed-by: review-1890@shanks at 39419b1892

Issue 1890, delivery group fix/1890-step-owner with novox/mesh-sdk. - mesh-build-go, mesh-build-node, mesh-build-image pin mesh-sdk db1007ffdda1 exactly; each calls `endLeftRunning` at start and runs it through the kit (`TestTheStartSweepEndsWhatAPreviousProcessLeft`). - checks/failurekit refuses a module claiming a node-build-* seat whose tests do not call `conformance.LeftRunning` (no exemption). - mesh-build-image's captured step fixtures normalise the new `owner` field; its pin moves from mesh-sdk 805b4d9a and takes in the already-merged mesh-sdk #100-#104. Tests: go vet, go vet -tags integration, go test in the three modules and checks/failurekit pass; failurekit judges the real catalogue. Counts (integration/unit of 50/500): mesh-build-go 38/153, mesh-build-node 8/93, mesh-build-image 6/55. Reviewed-by: review-1890@shanks at 39419b1892c9f025b7efbcb9bd82ab835df1d64a
mesh-tools added 2 commits 2026-10-27 00:32:34 +00:00
A replaced mesh-build-go left a check ask's step running and its start
sweep spared it (issue 1890, note 21). mesh-build-go, mesh-build-node and
mesh-build-image pin mesh-sdk 981a35b5, whose steps name their owner and
whose sweep ends another owner's at once; each runs the sweep through one
method that main calls and that its test runs through the conformance
kit's left-running case. The failurekit check now refuses a build module
whose tests do not run that case, test step or not.
Pin the build modules to mesh-sdk db1007ff, which deletes a gone process's ask key so its redelivery still answers (issue 1890)
mesh/delivery merged: source.main moved to novox/mesh-catalog@5ae337b14def
mesh/delivery-group group fix/1890-step-owner merged: every member is merged
mesh/check checking 39419b1892c9 on 5ae337b14def
39419b1892
Author
Member

Delivery novox/mesh-catalog@39419b1892c9 — merged since 2026-10-27T07:19:41Z

Source — source.main moved to novox/mesh-catalog@5ae337b14d. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1890-step-owner: novox/mesh-catalog@39419b1892, novox/mesh-sdk@db1007ffdd

  • composed together: pass — the checker's verdict at the members' heads (712e7f959492)

Transitions

  • 2026-10-27 00:32 (new) → proposed (announced): novox/mesh-catalog#518's head announced
  • 2026-10-27 00:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-27 07:19 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@39419b1892c9` — **merged** since 2026-10-27T07:19:41Z **Source** — source.main moved to novox/mesh-catalog@5ae337b14def. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1890-step-owner`: novox/mesh-catalog@39419b1892c9, novox/mesh-sdk@db1007ffdda1 - composed together: pass — the checker's verdict at the members' heads (712e7f959492) **Transitions** - 2026-10-27 00:32 (new) → proposed (announced): novox/mesh-catalog#518's head announced - 2026-10-27 00:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 07:19 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 5ae337b14d into main 2026-10-27 07:19:39 +00:00
mesh-tools deleted branch fix/1890-step-owner 2026-10-27 07:19:39 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#518