mesh-issues: cover a merged fix from the delivery view's reached head, not only its once-said event (issue 1950) #522

2026-10-27T20:20:25Z

mesh-tools commented

2026-10-27 20:20:25 +00:00

Fixes issue 1950 (reopened at its second meeting).

Fault. The tracker learns "delivered" only from the edge event mesh-delivery-view.delivered, which the view says once per source revision. A fix named after that saying is never matched: mesh-sdk#108 (issue 1242) reads "fix merged, not delivered" while the view's reach for novox/mesh-sdk is its merge 9f92233a.

Fix (thorough). coverReached reads the view's level (mesh-delivery-view.view_reach, once per repository per sweep) at the start of every Sweep and in LearnFixes, and marks a merged undelivered fix delivered when its merge is the reached head or its ancestor by the forge's word and not in the view's not-yet set (parseReach mirrors the view's notYetOf). OnDelivered and the sweep share markDelivered. A view or forge that cannot answer marks nothing.

Quick fix weighed: re-ask learn-fixes by hand for each stuck issue; rejected, since every fix named after the event meets it (note 6 on 1950).

Tests. Rows in delivered_test.go from captured live view_reach answers (mesh-sdk#108 by the sweep, mesh-delivery#87 by ancestry, parse, not-yet); each fails without the sweep call. No new test functions. Unit suite and go vet -tags integration clean.

Review notes kept for later (non-blocking): no per-sweep cap on forge Contains asks; LearnFixes fails on another issue's store error; log noise for repositories the view does not derive.

Reviewed-by: review-1950b@shanks at 116751130f

Fixes issue 1950 (reopened at its second meeting). **Fault.** The tracker learns "delivered" only from the edge event `mesh-delivery-view.delivered`, which the view says once per source revision. A fix named after that saying is never matched: mesh-sdk#108 (issue 1242) reads "fix merged, not delivered" while the view's reach for novox/mesh-sdk is its merge 9f92233a. **Fix (thorough).** `coverReached` reads the view's level (`mesh-delivery-view.view_reach`, once per repository per sweep) at the start of every Sweep and in LearnFixes, and marks a merged undelivered fix delivered when its merge is the reached head or its ancestor by the forge's word and not in the view's not-yet set (`parseReach` mirrors the view's `notYetOf`). OnDelivered and the sweep share `markDelivered`. A view or forge that cannot answer marks nothing. Quick fix weighed: re-ask learn-fixes by hand for each stuck issue; rejected, since every fix named after the event meets it (note 6 on 1950). **Tests.** Rows in delivered_test.go from captured live view_reach answers (mesh-sdk#108 by the sweep, mesh-delivery#87 by ancestry, parse, not-yet); each fails without the sweep call. No new test functions. Unit suite and `go vet -tags integration` clean. Review notes kept for later (non-blocking): no per-sweep cap on forge Contains asks; LearnFixes fails on another issue's store error; log noise for repositories the view does not derive. Reviewed-by: review-1950b@shanks at 116751130f5cc741b86c92738933cf8860f6b3a1

mesh-tools added 1 commit 2026-10-27 20:20:26 +00:00

Cover a merged fix from the delivery view's reached head in the sweep, not only from its once-said event, so a fix named after the saying is delivered (issue 1950)

mesh/delivery merged: source.main moved to novox/mesh-catalog@9bd824791509

Details

mesh/check being carried to 116751130f5c on 9bd824791509 | from c05aa5e6eafd

116751130f

mesh-tools commented

2026-10-27 20:20:30 +00:00

Delivery novox/mesh-catalog@116751130f5c — merged since 2026-10-27T20:32:24Z

Source — source.main moved to novox/mesh-catalog@9bd8247915. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-27 20:20 (new) → proposed (announced): novox/mesh-catalog#522's head announced
2026-10-27 20:20 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-27 20:32 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@116751130f5c` — **merged** since 2026-10-27T20:32:24Z **Source** — source.main moved to novox/mesh-catalog@9bd824791509. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-27 20:20 (new) → proposed (announced): novox/mesh-catalog#522's head announced - 2026-10-27 20:20 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 20:32 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 9bd8247915 into main

2026-10-27 20:32:22 +00:00

mesh-tools deleted branch fix/1950-delivered-on-machines

2026-10-27 20:32:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#522