Take the placement files out again: since the seed no delivery reaches any node (issue 1126, revert of #525) #526

Closed
mesh-tools wants to merge 1 commits from revert/1126-seed-2 into main
Member

Revert of #525 (the placement seed, merged 22:02:41Z).

Why (corrected 22:48Z). No node agent switched to composing its own modules: each read its placement at its last start (21:35-21:37Z) while the bus still refused that read, and on a read error it took the controller's compositions (the fault mesh-host #154 fixes). Since the seed, the assigner writes self wants (no composition digest) for every module, so agents on the controller's compositions apply nothing ('its want names ; nothing is applied until they agree'). No delivery reaches any node, including mesh-host #154 itself (199f6b4) and its rollout.

What this does. Deletes placement/{ace,g14,novox,shanks}.json. The nodes already run the controller's compositions, so nothing on them changes; the assigner returns to wants naming the controller's digests and deliveries flow again (199f6b4 included).

Its check fails falsely: every engine still runs the old shadow (before 199f6b4), which answers a deleted placement as 'everything removed'. That verdict is false here: nothing is removed, the nodes already run the controller's compositions.

The seed comes back once 199f6b4 runs on all four nodes and its shadow answers 'same'.

Reviewed-by: lead-47@shanks at 7297c972b7

Revert of #525 (the placement seed, merged 22:02:41Z). **Why (corrected 22:48Z).** No node agent switched to composing its own modules: each read its placement at its last start (21:35-21:37Z) while the bus still refused that read, and on a read error it took the controller's compositions (the fault mesh-host #154 fixes). Since the seed, the assigner writes self wants (no composition digest) for every module, so agents on the controller's compositions apply nothing ('its want names ; nothing is applied until they agree'). No delivery reaches any node, including mesh-host #154 itself (199f6b4) and its rollout. **What this does.** Deletes placement/{ace,g14,novox,shanks}.json. The nodes already run the controller's compositions, so nothing on them changes; the assigner returns to wants naming the controller's digests and deliveries flow again (199f6b4 included). **Its check fails falsely:** every engine still runs the old shadow (before 199f6b4), which answers a deleted placement as 'everything removed'. That verdict is false here: nothing is removed, the nodes already run the controller's compositions. The seed comes back once 199f6b4 runs on all four nodes and its shadow answers 'same'. Reviewed-by: lead-47@shanks at 7297c972b70d254842a50ecfe4e507bc37140722
mesh-tools added 1 commit 2026-10-27 22:05:55 +00:00
Author
Member

Delivery novox/mesh-catalog@7297c972b70d — closed since 2026-10-27T22:19:28Z

Transitions

  • 2026-10-27 22:05 (new) → proposed (announced): novox/mesh-catalog#526's head announced
  • 2026-10-27 22:05 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-27 22:19 ready → closed (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@7297c972b70d` — **closed** since 2026-10-27T22:19:28Z **Transitions** - 2026-10-27 22:05 (new) → proposed (announced): novox/mesh-catalog#526's head announced - 2026-10-27 22:05 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 22:19 ready → closed (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools closed this pull request 2026-10-27 22:19:28 +00:00
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: its head 7297c972b7 is no longer the pull request's head, or the pull request closed. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: its head 7297c972b70d is no longer the pull request's head, or the pull request closed. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools reopened this pull request 2026-10-27 22:47:10 +00:00
mesh-tools changed title from Take the placement files out again until ace and novox can compose their own modules (issue 1126, revert of #525) to Take the placement files out again: since the seed no delivery reaches any node (issue 1126, revert of #525) 2026-10-27 22:47:20 +00:00
mesh-tools closed this pull request 2026-10-27 22:47:56 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#526