mesh-build-image: a node that cannot build here now stays healthy and says not eligible, so it never holds the delivery (issue 1126) #546

2026-10-28T14:02:44Z

mesh-tools commented

2026-10-28 14:02:44 +00:00

Issue 1126 notes 77, 79, 80. Group fix/ace-tun made mesh-build-image report a node without a working /dev/net/tun as unhealthy. The assigner reads unhealthy as a failed delivery, so it held the new build d43ede40 for every node and moved ace back to the pre-fix build, which takes image asks and fails them.

Now only 'cannot run' is unhealthy: the runtime directory cannot be made, buildah missing, no subuid or subgid range, no user namespace, or the disk under its floor (issue 1839 AC1). Without tun the node stays healthy and says 'not eligible to build images, so it takes no image ask: '. The reason is in Eligible() (Capacity.Ineligible, capacity 0, so no ask is pulled), in Status's new eligible field, and in a log line on each change. Steps still end refused with the cause.

Quick vs thorough: quick (the split in this module); the thorough form, mesh-sdk buildstep carrying the split for every build module, waits until a second build module gets an eligibility check (note 79).
Tests: TestANodeWithoutTunIsHealthyAndSaysItIsNotEligible (fails first) and TestWithoutBuildahTheNodeIsUnhealthyNotIneligible; 57 unit + 6 integration (budget 500/50). The 22 catalog checks pass. The README says the new behaviour.

Reviewed-by: rev-ineligible@shanks at 363039f337

Issue 1126 notes 77, 79, 80. Group fix/ace-tun made mesh-build-image report a node without a working /dev/net/tun as unhealthy. The assigner reads unhealthy as a failed delivery, so it held the new build d43ede40 for every node and moved ace back to the pre-fix build, which takes image asks and fails them. Now only 'cannot run' is unhealthy: the runtime directory cannot be made, buildah missing, no subuid or subgid range, no user namespace, or the disk under its floor (issue 1839 AC1). Without tun the node stays healthy and says 'not eligible to build images, so it takes no image ask: <cause>'. The reason is in Eligible() (Capacity.Ineligible, capacity 0, so no ask is pulled), in Status's new `eligible` field, and in a log line on each change. Steps still end refused with the cause. Quick vs thorough: quick (the split in this module); the thorough form, mesh-sdk buildstep carrying the split for every build module, waits until a second build module gets an eligibility check (note 79). Tests: TestANodeWithoutTunIsHealthyAndSaysItIsNotEligible (fails first) and TestWithoutBuildahTheNodeIsUnhealthyNotIneligible; 57 unit + 6 integration (budget 500/50). The 22 catalog checks pass. The README says the new behaviour. Reviewed-by: rev-ineligible@shanks at 363039f337ad1684865f989391a65ff067547e64

mesh-tools added 2 commits 2026-10-28 14:02:44 +00:00

mesh-build-image stays healthy on a node that cannot build here now (no tun) and says it is not eligible: the assigner read unhealthy as a failed delivery and held the build (issue 1126) 644a34cf49

mesh-build-image README: a node without tun is healthy and not eligible, as the module now says (issue 1126)

mesh/delivery merged: source.main moved to novox/mesh-catalog@387ee59140c4

Details

mesh/check checking 363039f337ad on 387ee59140c4

363039f337

mesh-tools commented

2026-10-28 14:02:48 +00:00

Delivery novox/mesh-catalog@363039f337ad — merged since 2026-10-28T14:20:45Z

Source — source.main moved to novox/mesh-catalog@387ee59140. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-28 14:02 (new) → proposed (announced): novox/mesh-catalog#546's head announced
2026-10-28 14:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-28 14:20 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@363039f337ad` — **merged** since 2026-10-28T14:20:45Z **Source** — source.main moved to novox/mesh-catalog@387ee59140c4. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-28 14:02 (new) → proposed (announced): novox/mesh-catalog#546's head announced - 2026-10-28 14:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 14:20 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 387ee59140 into main

2026-10-28 14:20:41 +00:00

mesh-tools deleted branch fix/1126-ineligible-healthy

2026-10-28 14:20:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#546