novox/mesh-catalog
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesh-build-go runs the tests after a formatting or vet failure, so one check names every failure (ADR 0591) #596

Closed
mesh-tools wants to merge 3 commits from fix/check-every-failure into main
pull from: fix/check-every-failure
merge into: :main
Conversation 2 Commits 3 Files Changed 7
+32 -26
mesh-tools commented 2026-11-02 15:34:16 +00:00
Member
Copy Link
Copy Source

Delivery group fix/check-every-failure: mesh-sdk, mesh-catalog, mesh-delivery. ADR 0591: a failed check runs to its end and names every failure. Here: mesh-build-go no longer skips the unit tests after gofmt or vet fails, and appends the test failures after the lint failures; mesh-build-go and mesh-build-node pin the group's mesh-sdk head; two integration tests that expected the old stop after gofmt or vet now expect ADR 0591's order. Issue 1921.

Tests: the lint test asserts the tests run after a vet failure (written first); TestUnitLevelRunsTheRealGoOnTheFixtureRepositories and TestAnUnformattedFileFailsTheRealUnitLevel updated; integration suites of mesh-build-go and mesh-build-node run locally and pass; vet both tags.

Reviewed-by: review-1126@shanks at 831f34e59a

https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Delivery group fix/check-every-failure: mesh-sdk, mesh-catalog, mesh-delivery. ADR 0591: a failed check runs to its end and names every failure. Here: mesh-build-go no longer skips the unit tests after gofmt or vet fails, and appends the test failures after the lint failures; mesh-build-go and mesh-build-node pin the group's mesh-sdk head; two integration tests that expected the old stop after gofmt or vet now expect ADR 0591's order. Issue 1921. Tests: the lint test asserts the tests run after a vet failure (written first); TestUnitLevelRunsTheRealGoOnTheFixtureRepositories and TestAnUnformattedFileFailsTheRealUnitLevel updated; integration suites of mesh-build-go and mesh-build-node run locally and pass; vet both tags. Reviewed-by: review-1126@shanks at 831f34e59ac7ec5ba7f50345602479b7ed561dd5 https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-tools added 2 commits 2026-11-02 15:34:16 +00:00
mesh-build-go: a unit level whose gofmt or vet fails still runs its tests, so one check names every failure 06358f94bd 
The operator, 2026-11-02: a failed check showed only its first fault, and a group needed a run per fault.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-build-go, mesh-build-node: Pin mesh-sdk at 43788bb, the group's head: a check ask runs every level after a failure
mesh/delivery-group group fix/check-every-failure rejected: composed together: the checker's verdict at the members' heads (468d3ec8bcb2): integration: meshbui…
Details
mesh/delivery closed: a newer head of the same pull request
Details
mesh/check failed (2 tests): integration: meshbuildgo/cmd/mes… | 86be0149073c on c52afdf88b84 | judged by the candidate's mesh-build-go at a42cbc56ec2e
86be014907 
Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-tools commented 2026-11-02 15:34:20 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-catalog@831f34e59ac7 — closed since 2026-11-02T16:07:21Z

Group fix/check-every-failure:

Transitions

  • 2026-11-02 16:01 (new) → proposed (announced): novox/mesh-catalog#596's head announced
  • 2026-11-02 16:01 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-02 16:07 ready → closed (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@831f34e59ac7` — **closed** since 2026-11-02T16:07:21Z **Group** `fix/check-every-failure`: **Transitions** - 2026-11-02 16:01 (new) → proposed (announced): novox/mesh-catalog#596's head announced - 2026-11-02 16:01 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-02 16:07 ready → closed (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-11-02 16:01:30 +00:00
mesh-build-go: the real-go integration tests expect the tests to run after a failed gofmt or vet (ADR 0591)
mesh/delivery-group group fix/check-every-failure checking: 2 of 2 member(s) ready
Details
mesh/delivery closed: the pull request closed unmerged
Details
mesh/check checking 831f34e59ac7 on c52afdf88b84 | novox/mesh-catalog#596 in group fix/check-every-failure
831f34e59a 
The group's check named TestUnitLevelRunsTheRealGoOnTheFixtureRepositories and
TestAnUnformattedFileFailsTheRealUnitLevel: both asserted the old stop after the lint.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-tools commented 2026-11-02 16:01:34 +00:00
Author
Member
Copy Link
Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools closed this pull request 2026-11-02 16:07:20 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#596