nats removes a push consumer; gitea, mesh-conditions, mesh-issues and messenger drop what named the removed controller (issue 1126) #607

Merged

mesh-tools merged 7 commits from fix/consumer-remove-any into main 2026-11-04 10:36:41 +00:00

Conversation 1 Commits 7 Files Changed 27

+139 -1458

7 Commits

Author	SHA1	Message	Date
jschoubben	080aed6855	gitea: the merge refusal no longer says how long the last check took; nothing writes that record (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:06:48 +01:00
jschoubben	4f67143a78	gitea: remove what only tests called: the gate writer's verdict and its ask and history weighing, the late-verdict comment, the check-duration writer, the sibling record's two writers (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:05:50 +01:00
jschoubben	1572ab9b25	messenger: remove the old controller's walk decoder and its plan-moved names; the view's events are the only walks (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:02:56 +01:00
jschoubben	b0b7dfc5eb	mesh-issues: the removed controller is no registered owner and no core owner; old issues keep what they name (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:02:12 +01:00
jschoubben	bf4ce7ef7b	mesh-conditions: remove the hold's controller special case, bound to a module that is no more (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:01:11 +01:00
jschoubben	052fb473d0	gitea: remove the code bound to no event since ADR 0571 clause 13: the verdict setter, the controller's checked and plan types, the build seat's started (issue 1126) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 11:00:53 +01:00
jschoubben	bff850f798	nats: nats_consumer_remove reads a push consumer too (issue 1126) ... js.Consumer refuses a push consumer ("consumer is not a pull consumer"), so the controller's leftovers on EVENTS and CONTROL could not be read and were not removed. The tool now reads a consumer of either kind (CONSUMER.INFO only, which is all its grant gives), before the delete and for the confirmation after it. Quick fix: this change, in the tool, one function, about an hour with its test rows (a pull and a push consumer). Thorough fix: the same tool also needs its grant to cover the KV_* streams' consumers (mesh-controller-take-in, mesh-controller-config-follow), and that grant is composed by mesh-sdk's BusRemovalGrants from a closed set (ControllerLeftoverConsumersOn), not by the manifest, so it is not in this commit: it needs a change in mesh-sdk and a group delivery. Chosen here: the quick fix for the read, since it is one place and blocks the operator's removal now; the grant is reported to the lead. Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 10:45:00 +01:00