mesh-knowledge: a closing is reviewed on its closing alone, a graduation on every became link it carries (issue 784) #611

2026-11-04T15:01:28Z

mesh-tools commented

2026-11-04 15:01:28 +00:00

Issue 784 follow-up to #610 (knowledge-base.close, ADR 0630).

Why: the review of a closing was fed every record the effort links, clause by clause, so research efforts with many long linked decisions (075, 073, 049) went over the 61440-byte judgement limit and could not be parked; and the review asked a parked idea for links ADR 0630 §1 forbids.

review.go: reviewOne passes only the records ClosingLinks names, each once.
close.go: ClosingLinks: for graduated every became link the record carries (carried and added, ADR 0630 §2); otherwise only the added links. ClosingQuestion holds number, title, from/to status, the closing's section and note, and those links with title and status; no old text, no clauses; it tells the reviewer a closing to idea takes no links.
close_test.go: TestAClosingOfARecordOverTheJudgementLimitIsReviewed made a table (idea, graduated with a carried became link); no new test function. It fails with only the added links (graduated case) and with every link (idea case).

Quick fix: raise the judgement limit. Thorough fix (chosen): the closing's question holds only what the closing decides, so no effort's size can block its closing again.

Tests: go vet ./..., go vet -tags integration ./..., go test ./... in modules/mesh-knowledge pass (21 s).

Reviewed-by: mesh-code-reviewer@shanks at 46505d42d8 (round 2; round 1 found carried became links judged blind on graduation, fixed)

https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

Issue 784 follow-up to #610 (knowledge-base.close, ADR 0630). Why: the review of a closing was fed every record the effort links, clause by clause, so research efforts with many long linked decisions (075, 073, 049) went over the 61440-byte judgement limit and could not be parked; and the review asked a parked idea for links ADR 0630 §1 forbids. - review.go: reviewOne passes only the records ClosingLinks names, each once. - close.go: ClosingLinks: for graduated every became link the record carries (carried and added, ADR 0630 §2); otherwise only the added links. ClosingQuestion holds number, title, from/to status, the closing's section and note, and those links with title and status; no old text, no clauses; it tells the reviewer a closing to idea takes no links. - close_test.go: TestAClosingOfARecordOverTheJudgementLimitIsReviewed made a table (idea, graduated with a carried became link); no new test function. It fails with only the added links (graduated case) and with every link (idea case). Quick fix: raise the judgement limit. Thorough fix (chosen): the closing's question holds only what the closing decides, so no effort's size can block its closing again. Tests: go vet ./..., go vet -tags integration ./..., go test ./... in modules/mesh-knowledge pass (21 s). Reviewed-by: mesh-code-reviewer@shanks at 46505d42d8fbb1defd30487baa6628df012db66d (round 2; round 1 found carried became links judged blind on graduation, fixed) https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

mesh-tools added 2 commits 2026-11-04 15:01:29 +00:00

A closing is reviewed on its closing alone: the question holds the move, the note and the added links, never old text or linked clauses (issue 784, ADR 0630) a198a959fe

Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

A graduated closing is judged on every became link the effort carries, carried ones too, each with its record's title and status (issue 784, ADR 0630 §2)

mesh/check being carried to 46505d42d8fb on 8acad77d33f9 | from d2f326dff40e

mesh/delivery merged: source.main moved to novox/mesh-catalog@8acad77d33f9

Details

46505d42d8

Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

mesh-tools commented

2026-11-04 15:01:31 +00:00

Delivery novox/mesh-catalog@46505d42d8fb — merged since 2026-11-04T15:13:56Z

Source — source.main moved to novox/mesh-catalog@8acad77d33. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-04 15:01 (new) → proposed (announced): novox/mesh-catalog#611's head announced
2026-11-04 15:01 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-04 15:13 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@46505d42d8fb` — **merged** since 2026-11-04T15:13:56Z **Source** — source.main moved to novox/mesh-catalog@8acad77d33f9. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-04 15:01 (new) → proposed (announced): novox/mesh-catalog#611's head announced - 2026-11-04 15:01 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-04 15:13 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 8acad77d33 into main

2026-11-04 15:13:56 +00:00

mesh-tools deleted branch fix/784-closing-question

2026-11-04 15:13:56 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#611