The gate part reads no pull request description: no review-line wait before the Approve (ADR 0659) #630

2026-11-07T22:43:10Z

mesh-tools commented

2026-11-07 22:43:10 +00:00

The operator, 2026-11-07 ~23:00: "please remove any gate that reads a merge request description"; "gate's must use nats". ADR 0659 (accepted on the operator's Approve) supersedes ADR 0496 whole and changes ADR 0493 §5, §6, §9, §12, §13.

Change (modules/mesh-delivery-gate, subtask G4 of the approve-on-build prepare): the review hold goes: reviewWaits, reviewWords, the Reviewed-by regexp, ReviewIn, the review status branch, the review line in the ask, the withdrawal on a description edit, the group's review hold. Three word-only reads stay (issue numbers, author, after-line notice), tracked by issue 1921. module.json:105's setting words no longer name a review.

Tests. TestAPullRequestIsAskedWhateverItsDescriptionSays and TestNoWaitReadsADescription (ADR 0659 clause 6) fail on the old gate and pass here; issue1803_test.go and issue1079_test.go (the review hold) go. go vet, go vet -tags integration, go test (-race) pass; 180 unit / 5 integration tests. The manifest check accepts trunk and head alike. Reviewed in two rounds (mesh-code-reviewer), approved at 908f3918de.

Undo. Revert the merge commit.

https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

The operator, 2026-11-07 ~23:00: "please remove any gate that reads a merge request description"; "gate's must use nats". ADR 0659 (accepted on the operator's Approve) supersedes ADR 0496 whole and changes ADR 0493 §5, §6, §9, §12, §13. **Change** (modules/mesh-delivery-gate, subtask G4 of the approve-on-build prepare): the review hold goes: `reviewWaits`, `reviewWords`, the `Reviewed-by` regexp, `ReviewIn`, the review status branch, the review line in the ask, the withdrawal on a description edit, the group's review hold. Three word-only reads stay (issue numbers, author, after-line notice), tracked by issue 1921. module.json:105's setting words no longer name a review. **Tests.** `TestAPullRequestIsAskedWhateverItsDescriptionSays` and `TestNoWaitReadsADescription` (ADR 0659 clause 6) fail on the old gate and pass here; issue1803_test.go and issue1079_test.go (the review hold) go. go vet, go vet -tags integration, go test (-race) pass; 180 unit / 5 integration tests. The manifest check accepts trunk and head alike. Reviewed in two rounds (mesh-code-reviewer), approved at 908f3918de24426d5ed91b54cab16dc59ece1fd0. **Undo.** Revert the merge commit. https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

mesh-tools added 3 commits 2026-11-07 22:43:10 +00:00

The merge gate reads no pull request description: the review hold goes (reviewWaits, reviewWords, the Reviewed-by line) 9698bcd934

The operator, 2026-11-07: remove any gate that reads a description. An unreviewed pull request whose
other waits are met is asked, and the ask names no review line.

Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

Cite ADR 0659 where the gate reads no description; check-gates-merge words no longer wait for a review 8b84ac7487

Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

A test over the gate's waits: no wait reads a description (ADR 0659 clause 6)

mesh/delivery merged: source.main moved to novox/mesh-catalog@0cd706b044ae

Details

908f3918de

Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

mesh-tools commented

2026-11-07 22:43:14 +00:00

Delivery novox/mesh-catalog@908f3918de24 — merged since 2026-11-07T22:55:02Z

Source — source.main moved to novox/mesh-catalog@0cd706b044. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-07 22:43 (new) → proposed (announced): novox/mesh-catalog#630's head announced
2026-11-07 22:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-07 22:55 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@908f3918de24` — **merged** since 2026-11-07T22:55:02Z **Source** — source.main moved to novox/mesh-catalog@0cd706b044ae. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-07 22:43 (new) → proposed (announced): novox/mesh-catalog#630's head announced - 2026-11-07 22:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-07 22:55 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 0cd706b044 into main

2026-11-07 22:55:00 +00:00

mesh-tools deleted branch fix/gate-reads-no-description

2026-11-07 22:55:02 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#630