Orphaned durables: removable by the bus module, left out of the behind check, not composed again.
Design lines
H-A-472 and its three addenda, in hq's lead answers on branch design/47-H1-answers-59: 4f9c6410, 8ae2aab2, e520f4a5, bf02dc3a.
What changed
mesh-catalog (modules/nats), this pull request:nats_consumer_remove removes an orphaned durable whose twin is current, and only a durable that is itself an orphan; the bound of a current twin is the setting twin-current-hours.
mesh-delivery (modules/mesh-grants), its group member: the behind check leaves orphaned durables out and names them apart in the condition durable-orphaned; the composer makes the plain twin (a module's program consumer) only for a module with its own program; the bound of a current twin is the setting twin-current-hours.
Reviewed-by: mesh-code-reviewer@shanks at 3443760205
Pushed-by: lead-47@shanks
Orphaned durables: removable by the bus module, left out of the behind check, not composed again.
## Design lines
H-A-472 and its three addenda, in hq's lead answers on branch `design/47-H1-answers-59`: 4f9c6410, 8ae2aab2, e520f4a5, bf02dc3a.
## What changed
- **mesh-catalog (modules/nats), this pull request:** `nats_consumer_remove` removes an orphaned durable whose twin is current, and only a durable that is itself an orphan; the bound of a current twin is the setting `twin-current-hours`.
- **mesh-delivery (modules/mesh-grants), its group member:** the behind check leaves orphaned durables out and names them apart in the condition `durable-orphaned`; the composer makes the plain twin (a module's program consumer) only for a module with its own program; the bound of a current twin is the setting `twin-current-hours`.
## Tests run
- Each module's unit suite, whole.
- The integration tests, once.
- `checks/*`.
- The manifest validator, accepting both manifests.
Group: mesh-catalog #737 + mesh-delivery #328 (one merge call)
Reviewed-by: mesh-code-reviewer@shanks at 3443760205ab2902ece4303b746b49966f325fab
Pushed-by: lead-47@shanks
A module that moved into the tool runner left its program's durable
<node>_<module>, and one that runs its own program again left
<node>_<module>_tools: about 110 such orphans the tool refused by name.
It now removes a module's durable when its twin on the same stream has
pulls waiting and a delivery within the day, and names the twin in the
hand act; a module's only durable stays refused.
Builds: design 47 H2 H-A-472 (1), H-A-127, H-A-128, G A-340
Review round 1: a durable whose twin is current was removed without
reading the durable itself, so of the five live pairs where both twins
have pulls waiting either one would have gone. The tool now reads the
named durable too and refuses it while pulls wait on it, both read from
the bus at the call. "Current" is the setting twin-current-hours (24 by
default) of the manifest, read from the configuration at each call, the
field name the grants part's manifest names too.
Builds: design 47 H2 H-A-472 (1) and its third addendum (1), (2); review round 1 findings (1), (2)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Orphaned durables: removable by the bus module, left out of the behind check, not composed again.
Design lines
H-A-472 and its three addenda, in hq's lead answers on branch
design/47-H1-answers-59: 4f9c6410, 8ae2aab2, e520f4a5, bf02dc3a.What changed
nats_consumer_removeremoves an orphaned durable whose twin is current, and only a durable that is itself an orphan; the bound of a current twin is the settingtwin-current-hours.durable-orphaned; the composer makes the plain twin (a module's program consumer) only for a module with its own program; the bound of a current twin is the settingtwin-current-hours.Tests run
checks/*.Group: mesh-catalog #737 + mesh-delivery #328 (one merge call)
Reviewed-by: mesh-code-reviewer@shanks at
3443760205Pushed-by: lead-47@shanks