Name the issue the event consumer fix answers: 248

This commit is contained in:
jochen
2026-10-05 17:15:49 +02:00
parent 89ec48b9a9
commit 5761737687
4 changed files with 4 additions and 4 deletions
+1 -1
View File
@@ -412,7 +412,7 @@ func brokerCommand(ctx context.Context, args []string) error {
}
// consumerReset re-makes one consumer on a stream that keeps history to start from now (novox/hq issue
// 244): the way out of a consumer replaying a week of announcements, said rather than done by hand. A
// 248): the way out of a consumer replaying a week of announcements, said rather than done by hand. A
// person's act — what was pending is dropped — so it is a command, and nothing calls it on its own.
func consumerReset(args []string) error {
if len(args) != 2 {
+1 -1
View File
@@ -10,7 +10,7 @@ import (
)
// A consumer that reacts to announcements, made on a stream that keeps a week of them, starts from now:
// made from the start it replays every merge and build of that week (novox/hq issue 244). And a reset
// made from the start it replays every merge and build of that week (novox/hq issue 248). And a reset
// re-makes a stuck one from now, its configuration otherwise kept, and refuses a work queue.
//
// docker run -d --rm --name t -p 14231:4222 nats:2.10-alpine -js
+1 -1
View File
@@ -48,7 +48,7 @@ type Consumer struct {
// With one outstanding, the server holds the rest, and the heartbeat is keeping the message.
MaxAckPending int
// FromNow makes a consumer that does not exist yet start at the stream's end rather than its
// beginning (novox/hq issue 244). For a consumer that reacts to announcements — a merge, a build's
// beginning (novox/hq issue 248). For a consumer that reacts to announcements — a merge, a build's
// outcome — on a stream that keeps a week of them: the server's default, everything the stream
// holds, replays every merge and every build of that week as if it had just happened. A consumer
// that exists keeps where it is, whatever this says; only its making is decided here.
+1 -1
View File
@@ -336,7 +336,7 @@ func stateOf(info *nats.ConsumerInfo) ConsumerState {
}
// ResetConsumer re-makes a consumer to start from now, its configuration otherwise unchanged (novox/hq
// issue 244): what it had not yet delivered or acknowledged is dropped, which is the point — on a stream
// issue 248): what it had not yet delivered or acknowledged is dropped, which is the point — on a stream
// that keeps history, a consumer replaying a week of announcements does nothing anyone wants. Refused on
// a work queue, where what is pending is work nobody else will do.
func (j *JetStream) ResetConsumer(stream, name string) (before, after ConsumerState, err error) {