Raise no condition for a take-in, a layout or a put cut by a cancellation (issue 1945)

Thirty urgent fingerprint-not-composed conditions were live on 2026-10-25, each a
done key's take-in a stop or a restart cut with "context canceled". A
cancellation is no fault of the build, the chain or the bucket: a take-in or a
layout whose controller stops returns and the next one does it; one whose own
step was cancelled is tried again without a condition; a send cut by a
cancellation counts as no failure to put its files.

The put test now starts and leaves the node's failure count at nothing, so a
second run of it (-count=2) finds no count left by the first.

cmd/mesh-controller/acts.go

@@ -399,8 +399,6 @@ func blockedElsewhere(ctx context.Context, open *stores, except string) string {
 // purpose, never by re-assigning); and when the bus cannot be reached from here, the line names the
 // verb and the push that would refuse the module until it is run — never a silent placeholder (novox/hq issue 203).
 func issueOnAssign(ctx context.Context, open *stores, node, module string) string {
-	// Mint only what no row names: the assignments' watch hears the same write and may issue at once (ADR 0543).
-	ctx = onlyIfAbsent(ctx)
 	inv := open.inventory
 	shelf, err := inv.Catalogue(ctx)
 	if err != nil {

cmd/mesh-controller/assignment_accounts.go

@@ -1,387 +0,0 @@
-package main
-
-import (
-	"context"
-	"encoding/json"
-	"errors"
-	"fmt"
-	"strings"
-	"sync"
-	"time"
-
-	"git.novox.be/novox/mesh-sdk/go/catalogue"
-
-	"github.com/novox/mesh-controller/internal/broker"
-	"github.com/novox/mesh-controller/internal/chain"
-	"github.com/novox/mesh-controller/internal/inventory"
-)
-
-// An assignment that stands issues its node's bus accounts and the module's grant (novox/hq ADR 0543, issue 1945; a
-// step of research 072's grants: the memberships and credentials heard from placement, not from a send or a build).
-//
-// ADR 0539 clause 7 issues a module's credential and grant when its build is done. A module already built and assigned
-// to one more node never has a build done again, so nothing issued that node's account: on 2026-10-25 at 17:19
-// mesh-build-node and mesh-build-go were assigned to ace, composed for it, and the bus's user list never named
-// ace.mesh-build-node nor ace.mesh-build-go; one runtime found no credential, the other was refused by the bus, both
-// restarting every 5 s. The assign act composes the assigned node alone (composedAfterAct): never the node holding the
-// bus, never the grant.
-//
-// So the write of an assignments key is the event. When a key `<node>.<module>` of the assignments bucket comes to stand
-// (a new key, or one that was ended or pending), the lease holder issues the module's accounts on that node that are not
-// minted (idempotent: a minted account is never issued again, a rotation is on purpose), composes the node holding the
-// bus so its user list carries them, and writes the grants. A rewrite of an assignment that already stood (the
-// provisioner's plan kept in its value) does nothing. A starting controller looks at every standing assignment once,
-// from one reading of the catalogue: it issues what is missing, then composes the bus's node and writes the grants
-// once. The assign act issues too; both mint only an account no row names, in one statement, so exactly one of them
-// mints and seals it (mintBusUser, the review of issue 1945).
-
-// assignmentAccountSteps are what an assignment that comes to stand does, each a step a test may stand in for.
-type assignmentAccountSteps struct {
-	// holds says this controller holds the lease: only its holder issues.
-	holds func(ctx context.Context) bool
-	// catalogue reads the catalogue once, for every assignment a look issues for.
-	catalogue func(ctx context.Context) (map[string]catalogue.Manifest, error)
-	// issue issues the module's accounts on the node that are not minted, from the catalogue read; issued says it
-	// minted one, line what it did.
-	issue func(ctx context.Context, shelf map[string]catalogue.Manifest, node, module string) (issued bool, line string, err error)
-	// busHolder is the node holding the bus, "" for none.
-	busHolder func(ctx context.Context) (string, error)
-	// compose writes the nodes' compositions; grants writes the grants issued.
-	compose func(ctx context.Context, nodes []string) error
-	grants  func(ctx context.Context) error
-}
-
-// settle issues what the standing assignment of module on node lacks. fresh says the assignment just came to stand: the
-// bus's node is composed and the grants written even when every account was minted before (a module assigned again
-// keeps its account, and the bus's user list left it out while it was unassigned). It answers what it did, "" for
-// nothing.
-func (s assignmentAccountSteps) settle(ctx context.Context, node, module string) (string, error) {
-	if module == controllerModule {
-		// The controller's own module is issued at the terminal alone: its `broker` secret is the credential it is
-		// using (rollout.go), and it is assigned and unassigned there only (refusedMovingTheController).
-		return "", nil
-	}
-	if !s.holds(ctx) {
-		return "", errNotHolding
-	}
-	shelf, err := s.catalogue(ctx)
-	if err != nil {
-		return "", fmt.Errorf("the catalogue cannot be read: %w", err)
-	}
-	_, line, err := s.issue(ctx, shelf, node, module)
-	if err != nil {
-		return "", fmt.Errorf("its bus accounts on %s are not issued: %w", node, err)
-	}
-	said, err := s.cover(ctx)
-	prefix := module + " on " + node + ": "
-	if line != "" {
-		prefix += line + "; "
-	}
-	return prefix + said, err
-}
-
-// look is the start's look: the accounts every standing assignment lacks, issued one after another from one reading of
-// the catalogue, then the bus's node composed and the grants written once, when it looked at any assignment, whatever
-// it issued (an assignment that came to stand while no controller heard it may have its accounts and still lack its
-// place in the bus's user list or its grant). It answers what it did.
-func (s assignmentAccountSteps) look(ctx context.Context, standing []chain.Assignment) (string, error) {
-	var looked []chain.Assignment
-	for _, a := range standing {
-		if a.Module != controllerModule {
-			looked = append(looked, a)
-		}
-	}
-	if len(looked) == 0 {
-		return "", nil
-	}
-	if !s.holds(ctx) {
-		return "", errNotHolding
-	}
-	shelf, err := s.catalogue(ctx)
-	if err != nil {
-		return "", fmt.Errorf("the catalogue cannot be read: %w", err)
-	}
-	var lines []string
-	for _, a := range looked {
-		if ctx.Err() != nil {
-			return "", ctx.Err()
-		}
-		if _, line, err := s.issue(ctx, shelf, a.Node, a.Module); err != nil {
-			return "", fmt.Errorf("%s's bus accounts on %s are not issued: %w", a.Module, a.Node, err)
-		} else if line != "" {
-			lines = append(lines, a.Module+" on "+a.Node+": "+line)
-		}
-	}
-	said, err := s.cover(ctx)
-	lines = append(lines, fmt.Sprintf("%d standing assignment(s) looked at; %s", len(looked), said))
-	return strings.Join(lines, "\n"), err
-}
-
-// errNotHolding is a controller that does not hold the lease: it issues nothing, and tries again until it holds it.
-var errNotHolding = errors.New("this controller does not hold the lease")
-
-// cover composes the node holding the bus and writes the grants, and says so.
-func (s assignmentAccountSteps) cover(ctx context.Context) (string, error) {
-	holder, err := s.busHolder(ctx)
-	if err != nil {
-		return "", fmt.Errorf("the node holding the bus cannot be read: %w", err)
-	}
-	if holder != "" {
-		if err := s.compose(ctx, []string{holder}); err != nil {
-			return "", fmt.Errorf("the bus's user list on %s is not composed: %w", holder, err)
-		}
-	}
-	if err := s.grants(ctx); err != nil {
-		return "", err
-	}
-	if holder != "" {
-		return "the bus's user list composed on " + holder + ", the grants written", nil
-	}
-	return "the grants written", nil
-}
-
-// assignmentStands says a value of the assignments bucket holds an assignment that stands: made (a module only pulled in
-// by another names no time assigned), not ended and in no state (chain.Assignment.Stands).
-func assignmentStands(a chain.Assignment) bool {
-	return !a.Assigned.IsZero() && a.Stands() && a.Node != "" && a.Module != ""
-}
-
-// assignmentTurns keeps which keys of the assignments bucket stood when last heard, to tell an assignment that comes to
-// stand from a rewrite of one that stood.
-type assignmentTurns struct {
-	mu    sync.Mutex
-	stood map[string]bool
-}
-
-// heard records a value of key (nil for a delete or a purge) and answers whether it holds an assignment that just came
-// to stand.
-func (t *assignmentTurns) heard(key string, value []byte) (chain.Assignment, bool) {
-	var a chain.Assignment
-	stands := false
-	if value != nil && json.Unmarshal(value, &a) == nil {
-		stands = assignmentStands(a)
-	}
-	t.mu.Lock()
-	defer t.mu.Unlock()
-	if t.stood == nil {
-		t.stood = map[string]bool{}
-	}
-	was := t.stood[key]
-	t.stood[key] = stands
-	return a, stands && !was
-}
-
-// ownAccountOf is the username of the account a module speaks on the bus with on node, its own and no process's: the
-// module's when it reads a `broker` own secret, else its provisioner client's when it runs one; false when it has none
-// (a module whose accounts are its processes' alone, or one that does not speak on the bus).
-func ownAccountOf(m catalogue.Manifest, node string) (string, bool) {
-	if _, reads := m.OwnSecrets["broker"]; reads {
-		return broker.Principal{Kind: broker.KindModule, Node: node, Module: m.Module}.Username(), true
-	}
-	if runsTheProvisionerClient(m) {
-		return broker.Principal{Kind: broker.KindProvisioner, Node: node, Module: m.Module}.Username(), true
-	}
-	return "", false
-}
-
-// issueAssignmentAccounts issues module's accounts on node that are not minted: its own (issueOnTheNewBus) and its
-// processes' (issueMissingProcessAccounts). A module the catalogue does not hold, or one with nowhere to deliver an
-// account (mayIssue), has nothing to issue; an account minted before is kept.
-func issueAssignmentAccounts(ctx context.Context, inv *inventory.Inventory, shelf map[string]catalogue.Manifest,
-	node, module string) (bool, string, error) {
-	// Mint only what no row names: the assign act hears its own write and may issue at once (the review of issue 1945).
-	ctx = onlyIfAbsent(ctx)
-	m, known := shelf[module]
-	if !known || mayIssue(m) != nil {
-		return false, "", nil
-	}
-	if user, own := ownAccountOf(m, node); own {
-		_, minted, err := inv.BusUserHash(ctx, user)
-		if err != nil {
-			return false, "", fmt.Errorf("whether %s is minted cannot be read: %w", user, err)
-		}
-		if !minted {
-			busAddress, err := broker.BusAddress()
-			if err != nil {
-				return false, "", err
-			}
-			// Its processes' accounts too: issueOnTheNewBus issues every one of them with the module's own.
-			if err := issueOnTheNewBus(ctx, inv, m, node, busAddress); err != nil {
-				return false, "", err
-			}
-			return true, "its bus credential issued as " + user, nil
-		}
-	}
-	line, err := issueMissingProcessAccounts(ctx, inv, m, node)
-	if err != nil {
-		return false, "", err
-	}
-	return line != "", line, nil
-}
-
-// liveAssignmentAccountSteps are the steps on the controller's own stores and the bus: the composer's passes, as the
-// done keys' take-ins use them, so a node asked for by both is composed once a pass.
-func liveAssignmentAccountSteps(open *stores) assignmentAccountSteps {
-	inv := open.inventory
-	return assignmentAccountSteps{
-		holds: func(ctx context.Context) bool {
-			// The lease's gate, as every act's: a serving controller the bus does not grant the lease yet acts unleased.
-			_, err := theLease.epoch(ctx)
-			return err == nil
-		},
-		catalogue: func(ctx context.Context) (map[string]catalogue.Manifest, error) { return inv.Catalogue(ctx) },
-		issue: func(ctx context.Context, shelf map[string]catalogue.Manifest, node, module string) (bool, string, error) {
-			return issueAssignmentAccounts(ctx, inv, shelf, node, module)
-		},
-		busHolder: func(ctx context.Context) (string, error) {
-			holders, err := seatHolders(ctx, inv)
-			if err != nil {
-				return "", err
-			}
-			return holders[catalogue.BrokerSeat].Node, nil
-		},
-		compose: func(ctx context.Context, nodes []string) error {
-			return composerFor(open).compose(ctx, nodes, false)
-		},
-		grants: func(ctx context.Context) error {
-			return composerFor(open).compose(ctx, nil, true)
-		},
-	}
-}
-
-// assignmentAccountsRetry is how long a settle that failed waits before it tries again.
-var assignmentAccountsRetry = 30 * time.Second
-
-// untilSettled runs settle until it works or ctx ends: a failure, or a controller not holding the lease, is said and
-// tried again every assignmentAccountsRetry, never dropped, since no later write of the key may come.
-func untilSettled(ctx context.Context, what string, settle func(context.Context) (string, error)) {
-	for {
-		said, err := settle(ctx)
-		if err == nil {
-			if said != "" {
-				for _, line := range strings.Split(said, "\n") {
-					fmt.Printf("assignments: %s\n", line)
-				}
-			}
-			return
-		}
-		if ctx.Err() != nil {
-			return
-		}
-		fmt.Printf("assignments: %s: %v; tried again in %s\n", what, err, assignmentAccountsRetry)
-		select {
-		case <-ctx.Done():
-			return
-		case <-time.After(assignmentAccountsRetry):
-		}
-	}
-}
-
-// watchAssignmentAccounts settles every assignment of the assignments bucket that comes to stand, for as long as ctx: the
-// bucket's current values first (the start's look, settled as not fresh), then each write. A watch that ends, or a
-// bucket not there yet, is watched again a minute later.
-func watchAssignmentAccounts(ctx context.Context, open *stores) {
-	steps := liveAssignmentAccountSteps(open)
-	goServing(ctx, func() {
-		runAssignmentWatches(ctx, open.inventory.WatchAssignments, func(a chain.Assignment) {
-			inBackground(ctx, func() {
-				untilSettled(ctx, a.Module+" on "+a.Node, func(ctx context.Context) (string, error) {
-					return steps.settle(ctx, a.Node, a.Module)
-				})
-			})
-		}, func(look []chain.Assignment) {
-			// The start's look, once in the process: one reading of the catalogue, one assignment after another,
-			// then one composition of the bus's node and the grants (issues 1945 and 1277).
-			inBackground(ctx, func() {
-				untilSettled(ctx, "the start's look", func(ctx context.Context) (string, error) {
-					return steps.look(ctx, look)
-				})
-			})
-		}, func() bool {
-			select {
-			case <-ctx.Done():
-				return false
-			case <-time.After(time.Minute):
-				return true
-			}
-		})
-	})
-}
-
-// runAssignmentWatches watches the assignments again each time a watch ends, until ctx ends or pause says stop: each
-// assignment that comes to stand is handed to fresh, and the standing ones of the first watch that reads them all (its
-// Caught mark) to look, once. A watch that ends, or fails to open, before the start's look ran is no start's look: the
-// next one is, with what it hears from nothing (a fresh assignmentTurns), so no key it handed is dropped and no burst of
-// fresh settles replaces the look (the review of issue 1945).
-func runAssignmentWatches(ctx context.Context, watch func(context.Context) (<-chan chain.Entry, error),
-	fresh func(chain.Assignment), look func([]chain.Assignment), pause func() bool) {
-	turns := &assignmentTurns{}
-	first := true
-	for {
-		var atStart []chain.Assignment
-		if err := watchAssignmentsOnce(ctx, watch, turns, first, func(a chain.Assignment, isFresh bool) {
-			if !isFresh {
-				atStart = append(atStart, a)
-				return
-			}
-			fresh(a)
-		}, func() {
-			first = false
-			look(atStart)
-			atStart = nil
-		}); err != nil && ctx.Err() == nil {
-			fmt.Printf("assignments: the assignments are not heard, so a new assignment's bus accounts wait: %v\n", err)
-		}
-		if first {
-			turns = &assignmentTurns{} // the start's look has not run: the next watch hears every standing key anew
-		}
-		if ctx.Err() != nil || !pause() {
-			return
-		}
-	}
-}
-
-// watchAssignmentsOnce watches the assignments until the watch or ctx ends, handing each assignment that comes to stand
-// to settle. On the process's first watch, the current values are the start's look (not fresh) and read is called once
-// they are all handed (the chain's Caught mark); every other value, and every value of a watch opened again after one
-// ended, is fresh: an assignment that came to stand while no watch heard it is settled whole, never as the start's look
-// (the review of issue 1945).
-func watchAssignmentsOnce(ctx context.Context, watch func(context.Context) (<-chan chain.Entry, error),
-	turns *assignmentTurns, first bool, settle func(a chain.Assignment, fresh bool), read func()) error {
-	ctx, stop := context.WithCancel(ctx)
-	defer stop()
-	entries, err := watch(ctx)
-	if err != nil {
-		return err
-	}
-	current := true
-	for {
-		select {
-		case <-ctx.Done():
-			return nil
-		case e, ok := <-entries:
-			if !ok {
-				if ctx.Err() != nil {
-					return nil
-				}
-				return fmt.Errorf("the watch ended")
-			}
-			if e.Caught {
-				if current {
-					current = false // the current values are read: what follows is written from now on
-					if first {
-						read()
-					}
-				}
-				continue
-			}
-			var value []byte
-			if !e.Deleted {
-				value = e.Value
-			}
-			if a, turned := turns.heard(e.Key, value); turned {
-				settle(a, !current || !first)
-			}
-		}
-	}
-}

cmd/mesh-controller/assignment_accounts_test.go

@@ -1,344 +0,0 @@
-package main
-
-import (
-	"context"
-	"encoding/json"
-	"errors"
-	"fmt"
-	"strings"
-	"testing"
-	"time"
-
-	"git.novox.be/novox/mesh-sdk/go/catalogue"
-	"github.com/novox/mesh-controller/internal/broker"
-	"github.com/novox/mesh-controller/internal/chain"
-)
-
-// An assignment that comes to stand issues its node's bus accounts and the module's grant (ADR 0543, issue 1945): on
-// 2026-10-25 at 17:19 mesh-build-node and mesh-build-go, built long before, were assigned to ace, and nothing issued
-// ace's accounts nor put them in the bus's user list.
-
-func anAssignmentValue(t *testing.T, a chain.Assignment) []byte {
-	t.Helper()
-	raw, err := json.Marshal(a)
-	if err != nil {
-		t.Fatal(err)
-	}
-	return raw
-}
-
-// Only a write that makes the key stand turns it: a rewrite of a standing assignment (the provisioner's plan kept in its
-// value), an ended one, a pending one or a module only pulled in by another does not. The process's first watch hands
-// the assignments standing when it starts to the start's look (not fresh), says once that they are all read, and hands
-// each assignment written afterwards as fresh; a watch opened again after one ended hands every standing assignment it
-// has not seen stand as fresh and never calls the start's look (the review of issue 1945).
-func TestAnAssignmentThatComesToStand(t *testing.T) {
-	at := time.Date(2026, 10, 25, 16, 19, 42, 0, time.UTC)
-	stands := chain.Assignment{Node: "ace", Module: "mesh-build-node", Assigned: at}
-	ended := stands
-	ended.Ended = at.Add(time.Hour)
-	pending := stands
-	pending.State = chain.StatePending
-	pulled := chain.Assignment{Node: "ace", Module: "mesh-build-node", RequiredBy: "mesh-build-go"}
-	replanned := stands
-	replanned.Provisioning = json.RawMessage(`{"plan":1}`)
-
-	type write struct {
-		value   *chain.Assignment // nil for a delete
-		turning bool
-	}
-	for _, c := range []struct {
-		name   string
-		writes []write
-	}{
-		{"a new assignment turns", []write{{&stands, true}}},
-		{"a rewrite of one that stands does not", []write{{&stands, true}, {&replanned, false}, {&stands, false}}},
-		{"an ended one does not", []write{{&ended, false}}},
-		{"assigned again after it ended turns again", []write{{&stands, true}, {&ended, false}, {&stands, true}}},
-		{"a pending one does not, and turns once made", []write{{&pending, false}, {&stands, true}}},
-		{"a module only pulled in does not", []write{{&pulled, false}}},
-		{"one deleted and written again turns again", []write{{&stands, true}, {nil, false}, {&stands, true}}},
-	} {
-		t.Run(c.name, func(t *testing.T) {
-			turns := &assignmentTurns{}
-			for i, w := range c.writes {
-				var value []byte
-				if w.value != nil {
-					value = anAssignmentValue(t, *w.value)
-				}
-				a, turned := turns.heard("ace.mesh-build-node", value)
-				if turned != w.turning {
-					t.Fatalf("write %d: turned %v, want %v", i, turned, w.turning)
-				}
-				if turned && (a.Node != "ace" || a.Module != "mesh-build-node") {
-					t.Fatalf("write %d: the assignment turned is %s on %s", i, a.Module, a.Node)
-				}
-			}
-		})
-	}
-
-	type handed struct {
-		key   string
-		fresh bool
-	}
-	for _, first := range []bool{true, false} {
-		t.Run(fmt.Sprintf("the watch, first %v", first), func(t *testing.T) {
-			bucket := chain.NewMemory()
-			put := func(a chain.Assignment) {
-				t.Helper()
-				value := anAssignmentValue(t, a)
-				if e, held, _ := bucket.Get(t.Context(), a.Key()); held {
-					if _, err := bucket.Update(t.Context(), a.Key(), value, e.Revision); err != nil {
-						t.Fatal(err)
-					}
-					return
-				}
-				if _, err := bucket.Create(t.Context(), a.Key(), value); err != nil {
-					t.Fatal(err)
-				}
-			}
-			put(chain.Assignment{Node: "g14", Module: "mesh-build-go", Assigned: at})
-			got := make(chan handed, 8)
-			read := make(chan struct{}, 8)
-			ctx, stop := context.WithCancel(t.Context())
-			done := make(chan error, 1)
-			go func() {
-				done <- watchAssignmentsOnce(ctx, bucket.Watch, &assignmentTurns{}, first,
-					func(a chain.Assignment, fresh bool) { got <- handed{a.Key(), fresh} },
-					func() { read <- struct{}{} })
-			}()
-			next := func() handed {
-				t.Helper()
-				select {
-				case h := <-got:
-					return h
-				case <-time.After(5 * time.Second):
-					t.Fatal("nothing handed")
-					return handed{}
-				}
-			}
-			// Standing when the watch opened: the start's look on the first watch, fresh on any other.
-			if h := next(); h != (handed{"g14.mesh-build-go", !first}) {
-				t.Fatalf("the standing assignment was handed %+v", h)
-			}
-			put(chain.Assignment{Node: "g14", Module: "mesh-build-go", Assigned: at, Provisioning: json.RawMessage(`{"plan":2}`)})
-			put(chain.Assignment{Node: "ace", Module: "mesh-build-node", Assigned: at})
-			if h := next(); h != (handed{"ace.mesh-build-node", true}) {
-				t.Fatalf("handed %+v, want ace.mesh-build-node as fresh (and nothing for the rewrite before it)", h)
-			}
-			stop()
-			if err := <-done; err != nil {
-				t.Fatal(err)
-			}
-			if want := map[bool]int{true: 1, false: 0}[first]; len(read) != want {
-				t.Fatalf("the start's look was called %d time(s), want %d", len(read), want)
-			}
-		})
-	}
-	// A first watch that fails to open, or ends before its Caught mark, is no start's look: the next watch is, and hands
-	// every standing assignment to it once, none as fresh (the review of issue 1945: a burst of fresh settles, or keys
-	// handed and dropped).
-	for _, firstWatch := range []string{"fails to open", "ends before its Caught mark"} {
-		t.Run("a first watch that "+firstWatch, func(t *testing.T) {
-			bucket := chain.NewMemory()
-			standing := chain.Assignment{Node: "g14", Module: "mesh-build-go", Assigned: at}
-			if _, err := bucket.Create(t.Context(), standing.Key(), anAssignmentValue(t, standing)); err != nil {
-				t.Fatal(err)
-			}
-			watches := 0
-			watch := func(ctx context.Context) (<-chan chain.Entry, error) {
-				watches++
-				if watches > 1 {
-					return bucket.Watch(ctx)
-				}
-				if firstWatch == "fails to open" {
-					return nil, errors.New("the chain is not open yet")
-				}
-				cut := make(chan chain.Entry, 1)
-				cut <- chain.Entry{Key: standing.Key(), Value: anAssignmentValue(t, standing)}
-				close(cut)
-				return cut, nil
-			}
-			var looks [][]chain.Assignment
-			var fresh []chain.Assignment
-			ctx, stop := context.WithCancel(t.Context())
-			defer stop()
-			runAssignmentWatches(ctx, watch, func(a chain.Assignment) { fresh = append(fresh, a) },
-				func(look []chain.Assignment) { looks = append(looks, look); stop() },
-				func() bool { return ctx.Err() == nil })
-			if len(looks) != 1 || len(looks[0]) != 1 || looks[0][0].Key() != standing.Key() || len(fresh) != 0 {
-				t.Fatalf("after %d watch(es): looks %v, fresh %v; want one look at %s and nothing fresh",
-					watches, looks, fresh, standing.Key())
-			}
-		})
-	}
-}
-
-// settle issues what is missing and then puts it on the bus: the node holding the bus composed (its user list) and the
-// grants written, even when every account was minted before (a module assigned again keeps its account). The start's
-// look reads the catalogue once, issues for each standing assignment, and composes the bus's node and writes the grants
-// once when it looked at any. Neither acts for a controller that does not hold the lease, nor for the controller's own
-// module.
-func TestSettlingAndTheStartsLook(t *testing.T) {
-	ace := func(m string) chain.Assignment { return chain.Assignment{Node: "ace", Module: m} }
-	cases := []struct {
-		name               string
-		look               []chain.Assignment // nil: settle mesh-build-node on ace
-		module             string
-		notHolding         bool
-		issued             bool
-		issueErr, composeE error
-		holder             string
-		wantIssues         int
-		wantComposed       []string
-		wantGrants         bool
-		wantErr            string
-	}{
-		{name: "an account not minted", module: "mesh-build-node", issued: true, holder: "novox", wantIssues: 1,
-			wantComposed: []string{"novox"}, wantGrants: true},
-		{name: "an account minted before: the bus and the grants still", module: "mesh-build-go", holder: "novox",
-			wantIssues: 1, wantComposed: []string{"novox"}, wantGrants: true},
-		{name: "no lease: nothing, and tried again", module: "mesh-build-node", notHolding: true, issued: true,
-			holder: "novox", wantErr: errNotHolding.Error()},
-		{name: "the controller's own module is the terminal's", module: controllerModule, issued: true, holder: "novox"},
-		{name: "no bus holder: the grants still", module: "mesh-build-node", issued: true, wantIssues: 1, wantGrants: true},
-		{name: "an issue that fails is the error, nothing composed", module: "mesh-build-node",
-			issueErr: errors.New("the bus cannot be reached"), holder: "novox", wantIssues: 1, wantErr: "the bus cannot be reached"},
-		{name: "a composition that fails is the error, no grant", module: "mesh-build-node", issued: true, holder: "novox",
-			composeE: errors.New("store refused"), wantIssues: 1, wantComposed: []string{"novox"}, wantErr: "store refused"},
-		{name: "the start's look: each issued, the bus and the grants once",
-			look: []chain.Assignment{ace("mesh-build-node"), ace(controllerModule), ace("mesh-build-go")}, issued: true,
-			holder: "novox", wantIssues: 2, wantComposed: []string{"novox"}, wantGrants: true},
-		{name: "the start's look with every account minted still covers once",
-			look: []chain.Assignment{ace("mesh-build-node"), ace("mesh-build-go")}, holder: "novox", wantIssues: 2,
-			wantComposed: []string{"novox"}, wantGrants: true},
-		{name: "the start's look at nothing does nothing", look: []chain.Assignment{ace(controllerModule)}, holder: "novox"},
-	}
-	for _, c := range cases {
-		t.Run(c.name, func(t *testing.T) {
-			var composed []string
-			issues, catalogues, grants := 0, 0, 0
-			steps := assignmentAccountSteps{
-				holds: func(context.Context) bool { return !c.notHolding },
-				catalogue: func(context.Context) (map[string]catalogue.Manifest, error) {
-					catalogues++
-					return map[string]catalogue.Manifest{}, nil
-				},
-				issue: func(context.Context, map[string]catalogue.Manifest, string, string) (bool, string, error) {
-					issues++
-					if c.issued {
-						return true, "its bus credential issued", c.issueErr
-					}
-					return false, "", c.issueErr
-				},
-				busHolder: func(context.Context) (string, error) { return c.holder, nil },
-				compose: func(_ context.Context, nodes []string) error {
-					composed = append(composed, nodes...)
-					return c.composeE
-				},
-				grants: func(context.Context) error { grants++; return nil },
-			}
-			var said string
-			var err error
-			if c.look != nil {
-				said, err = steps.look(t.Context(), c.look)
-			} else {
-				said, err = steps.settle(t.Context(), "ace", c.module)
-			}
-			if c.wantErr != "" {
-				if err == nil || !strings.Contains(err.Error(), c.wantErr) {
-					t.Fatalf("error %v, want one saying %q", err, c.wantErr)
-				}
-			} else if err != nil {
-				t.Fatal(err)
-			}
-			if issues != c.wantIssues || catalogues > 1 {
-				t.Fatalf("%d issue(s) from %d reading(s) of the catalogue, want %d from at most one", issues, catalogues, c.wantIssues)
-			}
-			if strings.Join(composed, ",") != strings.Join(c.wantComposed, ",") {
-				t.Fatalf("composed %v, want %v", composed, c.wantComposed)
-			}
-			if want := map[bool]int{true: 1}[c.wantGrants]; grants != want {
-				t.Fatalf("grants written %d time(s), want %d", grants, want)
-			}
-			if c.wantGrants && c.wantErr == "" && !strings.Contains(said, "the grants written") {
-				t.Fatalf("said %q, want it to name the grants", said)
-			}
-		})
-	}
-}
-
-// The accounts a module speaks with on a node: the module's own when it reads `broker`, its provisioner client's when
-// it runs one alone, none when its accounts are its processes' or it does not speak on the bus. A process's account is
-// held in the provisioner client's form, named for the process and carrying no claims, and may be issued only when
-// the process declares its own secret broker-<process id> (ADR 0436 §2; issue 1181).
-func TestTheAccountsAModuleSpeaksWithOnANode(t *testing.T) {
-	client := aProvisioner()
-	delete(client.OwnSecrets, "broker")
-	for _, c := range []struct {
-		name string
-		m    catalogue.Manifest
-		user string
-		own  bool
-	}{
-		{"a module reading broker", catalogue.Manifest{Module: "mesh-build-node",
-			OwnSecrets: catalogue.OwnSecrets{"broker": {Path: "/var/lib/mesh-build-node/broker"}}},
-			broker.Principal{Kind: broker.KindModule, Node: "ace", Module: "mesh-build-node"}.Username(), true},
-		{"a module reading broker and running the client", aProvisioner(),
-			broker.Principal{Kind: broker.KindModule, Node: "ace", Module: "mesh-provisioner"}.Username(), true},
-		{"the provisioner client alone", client,
-			broker.Principal{Kind: broker.KindProvisioner, Node: "ace", Module: "mesh-provisioner"}.Username(), true},
-		{"no broker, no client", catalogue.Manifest{Module: "hello-web"}, "", false},
-	} {
-		t.Run(c.name, func(t *testing.T) {
-			user, own := ownAccountOf(c.m, "ace")
-			if user != c.user || own != c.own {
-				t.Fatalf("got %q %v, want %q %v", user, own, c.user, c.own)
-			}
-		})
-	}
-
-	t.Run("a process's account", func(t *testing.T) {
-		user := broker.Principal{Kind: broker.KindProcess, Node: "novox", Module: "mesh-mail", Process: "send"}.Username()
-		if user != "novox.mesh-mail.send" {
-			t.Fatalf("the process's username: %q", user)
-		}
-		held, err := heldProcessAccount(broker.Broker{Fingerprint: "abc"}, "novox.example:4222", "novox", "mesh-mail",
-			user, "a-password")
-		if err != nil {
-			t.Fatal(err)
-		}
-		var got map[string]any
-		if err := json.Unmarshal(held, &got); err != nil {
-			t.Fatal(err)
-		}
-		want := map[string]any{"url": "nats://novox.example:4222", "fingerprint": "abc", "node": "novox",
-			"module": "mesh-mail", "user": "novox.mesh-mail.send", "password": "a-password"}
-		for k, v := range want {
-			if got[k] != v {
-				t.Errorf("%s: %v, want %v", k, got[k], v)
-			}
-		}
-		if len(got) != len(want) {
-			t.Errorf("the held account carries %v; want exactly %v (never claims — a process holds no seat)", got, want)
-		}
-	})
-
-	t.Run("a process may be issued only with its own broker secret", func(t *testing.T) {
-		// mesh-mail's real shape: no `broker` of its own, its process declaring bus (review round 1 of issue 1181).
-		if err := mayIssue(mailSenderWithProcess()); err != nil {
-			t.Fatalf("a module with no broker of its own, whose process declares bus, was refused: %v", err)
-		}
-		m := mailSenderWithProcess()
-		delete(m.OwnSecrets, "broker-send")
-		err := mayIssue(m)
-		if err == nil {
-			t.Fatal("a process with no broker-<id> own secret was issued an account")
-		}
-		for _, want := range []string{"mesh-mail", "send", "broker-send", "own-secrets"} {
-			if !strings.Contains(err.Error(), want) {
-				t.Errorf("the refusal does not say %q: %v", want, err)
-			}
-		}
-	})
-}

cmd/mesh-controller/compose_sdk.go

@@ -326,13 +326,9 @@ func restOfTheMesh(ctx context.Context, open *stores, shelf map[string]catalogue
 	return world, nil
 }
 
-// restOfTheMeshOf is restOfTheMesh for a caller that holds the inventory alone: on the serving controller's stores where it
-// lends them (sharedStores), never a pool per call; elsewhere (a verb run as its own process) the other stores the Input
-// reads are opened for the call and let go of again.
+// restOfTheMeshOf is restOfTheMesh for a caller that holds the inventory alone: the other stores the Input reads are opened for
+// the call and let go of again.
 func restOfTheMeshOf(ctx context.Context, inv *inventory.Inventory, shelf map[string]catalogue.Manifest, exclude string) (catalogue.World, error) {
-	if shared, ok := sharedStoresOf(inv); ok {
-		return restOfTheMeshOn(ctx, shared, shelf, exclude)
-	}
 	open := &stores{inventory: inv}
 	defer func() {
 		if open.licences != nil {
@@ -342,12 +338,9 @@ func restOfTheMeshOf(ctx context.Context, inv *inventory.Inventory, shelf map[st
 			open.identity.Close()
 		}
 	}()
-	return restOfTheMeshOn(ctx, open, shelf, exclude)
+	return restOfTheMesh(ctx, open, shelf, exclude)
 }
 
-// restOfTheMeshOn is restOfTheMesh; a variable so a test reads which stores it is handed.
-var restOfTheMeshOn = restOfTheMesh
-
 // sayFound says the lines a composition found while composing, once each: a machine left out of the rest of the mesh, a seat
 // that two claimants could take, the bus's users left out for want of a credential.
 func sayFound(ctx context.Context, d compose.Declared) {

cmd/mesh-controller/composed_integration_test.go

@@ -140,35 +140,4 @@ func TestTheDeclarationsStreamGoesOnceEveryNodeRunsTheNewEngine(t *testing.T) {
 	if !declarationsRetiredNow(ctx, m.open.inventory) {
 		t.Errorf("a raise after the retirement would assert the stream again")
 	}
-
-	// Issue 1945: a node-engine other than the registered one landing on laptop (a newer build on its way) leaves the
-	// declarations retired, so what the health check, the probes and healer H3 expect of the bus names neither the
-	// stream nor a node's consumer on it, and asserting the bus's objects again does not make the stream anew.
-	have("laptop", fpOf('7'))
-	if !declarationsRetiredNow(ctx, m.open.inventory) {
-		t.Fatalf("with laptop on another node-engine after the stream went, the declarations are no longer retired")
-	}
-	streams, consumers, err := expectedBusObjects(ctx, m.open.inventory)
-	if err != nil {
-		t.Fatal(err)
-	}
-	for _, s := range streams {
-		if s.Name == broker.DeclarationsStream {
-			t.Errorf("the bus's health check and probe D7 still expect the stream %s", s.Name)
-		}
-	}
-	for _, c := range consumers {
-		if c.Stream == broker.DeclarationsStream {
-			t.Errorf("the bus's health check and probe D6 still expect %s on %s", c.Name, c.Stream)
-		}
-	}
-	bus, err := broker.Dial(m.conn.ConnectedUrl())
-	if err != nil {
-		t.Fatal(err)
-	}
-	t.Cleanup(bus.Close)
-	_ = assertOnSend(ctx, m.open.inventory, bus, "  ")
-	if _, err := m.js.Stream(ctx, broker.DeclarationsStream); !errors.Is(err, jetstream.ErrStreamNotFound) {
-		t.Errorf("healer H3's assertion of the bus's objects made the stream anew: %v", err)
-	}
 }

cmd/mesh-controller/composed_keys.go

@@ -163,15 +163,13 @@ func followDoneKey(ctx context.Context, open *stores, module string) {
 	saidWait := ""
 	for {
 		doneKeysLookAgain.Delete(module) // what this look reads covers every wake before it
-		err := takeOnceInSlot(ctx, open, module)
+		err := doneKeyTakeOnce(ctx, open, module)
 		o := doneKeyObservation(module)
 		if err == nil {
-			// Cleared on every success, whoever raised it: a controller before a restart or another follower (issue
-			// 1945). A condition that is not open costs one read.
-			if keeper := conditionsFrom; keeper != nil {
+			if keeper := conditionsFrom; keeper != nil && failed {
 				_, _ = keeper.Clear(ctx, o.Key(), "composed and granted")
+				failed = false
 			}
-			failed = false
 			if _, again := doneKeysLookAgain.LoadAndDelete(module); again {
 				continue // a wake came while this one ran: once more, for the key written meanwhile
 			}
@@ -309,7 +307,7 @@ func watchDoneKeys(ctx context.Context, open *stores) {
 		return
 	}
 	if err := builderkeys.Watch(ctx, keys.JS, func(module string) {
-		inBackground(ctx, func() { takeDoneKey(ctx, open, module) })
+		inBackground(func() { takeDoneKey(ctx, open, module) })
 	}); err != nil {
 		closeKeys()
 		fmt.Printf("done keys: the builder's keys are not watched: %v\n", err)
@@ -320,7 +318,7 @@ func watchDoneKeys(ctx context.Context, open *stores) {
 		closeKeys()
 	})
 	// And every module once now, after the watch is open so no write falls between the two.
-	inBackground(ctx, func() {
+	inBackground(func() {
 		doneKeysAtStart(ctx, catalogedModules(open), func(module string) { takeDoneKeyAtStart(ctx, open, module) })
 	})
 }
@@ -355,25 +353,9 @@ func doneKeysAtStart(ctx context.Context, modules func(context.Context) ([]strin
 	wg.Wait()
 }
 
-// startTakeIns is how many take-ins the start's look runs at once, and how many run at once in all.
+// startTakeIns is how many take-ins the start's look runs at once.
 const startTakeIns = 16
 
-// takeInSlots are the take-ins that may run at once in this process, the watch's and the start's look's together: a
-// burst of done keys (about 120 at 16:07:36 on 2026-10-25) once started a take-in each, all at once, and their reads
-// filled the store until it refused every connection (issues 1945 and 1277).
-var takeInSlots = make(chan struct{}, startTakeIns)
-
-// takeOnceInSlot is one take-in once a slot is free; a take-in that waits for its next try holds none.
-func takeOnceInSlot(ctx context.Context, open *stores, module string) error {
-	select {
-	case takeInSlots <- struct{}{}:
-	case <-ctx.Done():
-		return ctx.Err()
-	}
-	defer func() { <-takeInSlots }()
-	return doneKeyTakeOnce(ctx, open, module)
-}
-
 // takeDoneKeyAtStart is one take-in of the start's look, under the module's lock; one that fails is handed to takeDoneKey,
 // which tries again every doneKeyRetry, loudly, so a failing module never holds up the look at the others.
 func takeDoneKeyAtStart(ctx context.Context, open *stores, module string) {
@@ -384,14 +366,14 @@ func takeDoneKeyAtStart(ctx context.Context, open *stores, module string) {
 		return
 	}
 	doneKeysLookAgain.Delete(module) // what this look reads covers every wake before it
-	err := takeOnceInSlot(ctx, open, module)
+	err := doneKeyTakeOnce(ctx, open, module)
 	mu.(*sync.Mutex).Unlock()
 	// Read after letting go, as every holder of a module's lock does: a wake during this look only marked the module
 	// (the review of issue 1945).
 	_, again := doneKeysLookAgain.LoadAndDelete(module)
 	if err != nil || again {
 		// A failure, a wait or a wake meanwhile is followed by takeDoneKey, which says it and looks again.
-		inBackground(ctx, func() { takeDoneKey(ctx, open, module) })
+		inBackground(func() { takeDoneKey(ctx, open, module) })
 	}
 }
 

cmd/mesh-controller/composed_keys_cancel_test.go

@@ -59,25 +59,3 @@ func TestATakeInCutByACancellationRaisesNothing(t *testing.T) {
 		})
 	}
 }
-
-// A take-in that succeeds clears the module's fingerprint-not-composed condition whoever raised it: a controller before a
-// restart, or another follower (issue 1945: the operator read "a build needs a look" for take-ins that had since worked).
-func TestASucceedingTakeInClearsAConditionAnotherRaised(t *testing.T) {
-	was, wasRetry, wasSay, wasKeeper := doneKeyTakeOnce, doneKeyRetry, doneKeysSay, conditionsFrom
-	t.Cleanup(func() { doneKeyTakeOnce, doneKeyRetry, doneKeysSay, conditionsFrom = was, wasRetry, wasSay, wasKeeper })
-	store := conditions.NewInMemory()
-	k := conditions.NewKeeper(t.Context(), conditions.Options{Store: store, History: store, Teller: &conditions.Told{}})
-	t.Cleanup(func() { k.Close(context.Background()) })
-	conditionsFrom = k
-	doneKeysSay = func(string) {}
-	o := doneKeyObservation("raised-before")
-	o.Summary += "the store refused the connection"
-	if _, err := k.Observe(t.Context(), o); err != nil {
-		t.Fatal(err)
-	}
-	doneKeyTakeOnce = func(context.Context, *stores, string) error { return nil }
-	takeDoneKey(t.Context(), nil, "raised-before")
-	if c, found, err := conditions.ReadOne(t.Context(), store, o.Key()); err != nil || found {
-		t.Fatalf("a take-in that succeeded left the condition another raised: %+v (found %v, %v)", c, found, err)
-	}
-}

cmd/mesh-controller/composed_keys_cap_test.go

@@ -1,58 +0,0 @@
-package main
-
-import (
-	"context"
-	"fmt"
-	"sync"
-	"sync/atomic"
-	"testing"
-	"time"
-)
-
-// A burst of done keys runs at most startTakeIns take-ins at once, the watch's and the start's look together: at
-// 16:07:36 on 2026-10-25 the builder rewrote about 120 done keys at once, each woke its own take-in, and each opened
-// pools of its own until novox's store refused every connection (issues 1945 and 1277).
-func TestABurstOfDoneKeysRunsAtMostSixteenTakeInsAtOnce(t *testing.T) {
-	was := doneKeyTakeOnce
-	t.Cleanup(func() { doneKeyTakeOnce = was })
-	var running, most atomic.Int64
-	var taken atomic.Int64
-	doneKeyTakeOnce = func(context.Context, *stores, string) error {
-		now := running.Add(1)
-		for {
-			m := most.Load()
-			if now <= m || most.CompareAndSwap(m, now) {
-				break
-			}
-		}
-		time.Sleep(2 * time.Millisecond)
-		running.Add(-1)
-		taken.Add(1)
-		return nil
-	}
-	ctx := context.Background()
-	var wg sync.WaitGroup
-	// The watch's wakes: one take-in each, in the background, as watchDoneKeys starts them.
-	for i := range 120 {
-		wg.Add(1)
-		go func() { defer wg.Done(); takeDoneKey(ctx, nil, fmt.Sprintf("burst-%03d", i)) }()
-	}
-	// And the start's look at the same moment, over other modules.
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
-		var start []string
-		for i := range 40 {
-			start = append(start, fmt.Sprintf("start-%03d", i))
-		}
-		doneKeysAtStart(ctx, func(context.Context) ([]string, error) { return start, nil },
-			func(m string) { takeDoneKeyAtStart(ctx, nil, m) })
-	}()
-	wg.Wait()
-	if got := taken.Load(); got != 160 {
-		t.Fatalf("took in %d modules, want 160", got)
-	}
-	if m := most.Load(); m > startTakeIns {
-		t.Fatalf("ran %d take-ins at once, want at most %d", m, startTakeIns)
-	}
-}

cmd/mesh-controller/composed_rejudge.go

@@ -152,7 +152,7 @@ func watchHavesForJudgement(ctx context.Context, open *stores) {
 				if err != nil || isNode {
 					continue
 				}
-				inBackground(ctx, func() {
+				inBackground(func() {
 					if err := rejudgeOn(ctx, open, []string{node}, module); err != nil {
 						fmt.Printf("compositions: %s on %s is not judged again: %v\n", module, node, err)
 					}

cmd/mesh-controller/composed_start.go

@@ -135,18 +135,9 @@ func declarationsDone(nodes []string, runs map[string]string, current string) bo
 	return true
 }
 
-// declarationsRetiredOn reads whether the declarations are done on the mesh now: their stream gone from the bus, or
-// every node's have of the node-engine against the fingerprint it is registered at.
-//
-// **A stream that is gone stays gone** (issue 1945). Release 6 sends no declaration (ADR 0539 clauses 5 and 11), so a
-// stream made again would hold no node's last declaration and help no node; and the done test alone is not lasting:
-// a node-engine newer than the one registered landing, or a node asleep on an older have, makes it false again after
-// the start deleted the stream, and then the raise, the bus's health check (H-bus), the probes (D6, D7) and healer H3
-// expected the stream and every node's consumer again, raised them missing and made them anew (2026-10-25 14:52).
+// declarationsRetiredOn reads whether the declarations are done on the mesh now: every node's have of the node-engine
+// against the fingerprint it is registered at.
 func declarationsRetiredOn(ctx context.Context, inv *inventory.Inventory, js jetstream.JetStream) (bool, error) {
-	if _, err := js.Stream(ctx, broker.DeclarationsStream); errors.Is(err, jetstream.ErrStreamNotFound) {
-		return true, nil
-	}
 	fps, err := currentFingerprints(ctx, inv)
 	if err != nil {
 		return false, err
@@ -171,8 +162,7 @@ func declarationsRetiredOn(ctx context.Context, inv *inventory.Inventory, js jet
 }
 
 // retireDeclarations deletes the declarations' stream, with every node's consumer on it, once every node runs the new
-// node-engine, and says it once; a stream already gone is said by nobody, and is done. It answers whether the
-// declarations are done.
+// node-engine, and says it once; a stream already gone is said by nobody. It answers whether the declarations are done.
 func retireDeclarations(ctx context.Context, open *stores) (bool, error) {
 	if _, err := theLease.epoch(ctx); err != nil {
 		return false, err
@@ -334,9 +324,8 @@ func replacedComposition(in compose.Input, r replacedController) (sdkdelivery.Co
 	return c, nil
 }
 
-// declarationsRetiredNow says the declarations are done on the mesh now, for a raise of the bus's objects and for what
-// the health check, the probes and the healers expect of the bus; a bus or a store it cannot read is not done, so a
-// stream still there is asserted as before.
+// declarationsRetiredNow says the declarations are done on the mesh now, for a raise of the bus's objects; a bus or a
+// store it cannot read is not done, so the stream is asserted as before.
 func declarationsRetiredNow(ctx context.Context, inv *inventory.Inventory) bool {
 	bus, err := aBus()
 	if err != nil {

cmd/mesh-controller/composed_start_test.go

@@ -3,7 +3,6 @@ package main
 import (
 	"context"
 	"encoding/json"
-	"fmt"
 	"strings"
 	"testing"
 
@@ -111,28 +110,3 @@ func TestTheDeclarationsGoOnlyOnceEveryNodeRunsTheNewEngine(t *testing.T) {
 		t.Errorf("done with no fingerprint registered, or no node")
 	}
 }
-
-// streamsGone is a bus that holds none of the streams asked for; every other part of it is unread.
-type streamsGone struct{ jetstream.JetStream }
-
-func (streamsGone) Stream(context.Context, string) (jetstream.Stream, error) {
-	return nil, jetstream.ErrStreamNotFound
-}
-
-// Issue 1945 (the alarm of a stream the start deleted): once the declarations' stream is gone from the bus, the
-// declarations are retired whatever the nodes run now, so no raise, health check, probe or healer expects the stream
-// or a node's consumer on it again. A node-engine newer than the registered one, or a node asleep on an older have,
-// made the done test false after the stream went, and the bus's objects named it missing again (2026-10-25 14:52).
-func TestTheDeclarationsStayRetiredOnceTheirStreamIsGone(t *testing.T) {
-	retired, err := func() (retired bool, err error) {
-		defer func() {
-			if p := recover(); p != nil {
-				err = fmt.Errorf("it read what the nodes run although the stream is gone: %v", p)
-			}
-		}()
-		return declarationsRetiredOn(t.Context(), nil, streamsGone{})
-	}()
-	if err != nil || !retired {
-		t.Fatalf("with no declarations' stream on the bus: retired %v (%v), want retired", retired, err)
-	}
-}

cmd/mesh-controller/given.go

@@ -195,7 +195,7 @@ func watchHavesForGiven(ctx context.Context, open *stores) {
 				if at.IsZero() {
 					continue
 				}
-				inBackground(ctx, func() { replaceGiven(ctx, open, node, map[string]time.Time{module: at}) })
+				inBackground(func() { replaceGiven(ctx, open, node, map[string]time.Time{module: at}) })
 			}
 		}
 	})

cmd/mesh-controller/modules.go

@@ -965,26 +965,6 @@ func processPrincipalFor(m catalogue.Manifest, processID string) (broker.Process
 	return broker.ProcessPrincipal{}, false
 }
 
-// mintOnlyIfAbsent marks a context whose issue mints only accounts no row names yet (onlyIfAbsent).
-type mintOnlyIfAbsent struct{}
-
-// onlyIfAbsent is ctx for an issue that must never replace a minted account: the assign act's and the assignments'
-// watch's, which may run at once for one account (novox/hq ADR 0543, the review of issue 1945).
-func onlyIfAbsent(ctx context.Context) context.Context {
-	return context.WithValue(ctx, mintOnlyIfAbsent{}, true)
-}
-
-// mintBusUser mints u's password. By default it replaces whatever stands (a rotation: `module issue`); under
-// onlyIfAbsent it mints only when no row names u, and won false says another caller minted it first and seals it,
-// so this one seals nothing.
-func mintBusUser(ctx context.Context, inv *inventory.Inventory, u inventory.BusUser) (string, bool, error) {
-	if only, _ := ctx.Value(mintOnlyIfAbsent{}).(bool); only {
-		return inv.MintBusPasswordIfAbsent(ctx, u)
-	}
-	password, err := inv.MintBusPassword(ctx, u)
-	return password, err == nil, err
-}
-
 // issueOnTheNewBus gives an assigned module its credential on the bus being built.
 //
 // **Three things differ from a management call, and each is the point of the move.** The credential
@@ -1010,16 +990,14 @@ func issueOnTheNewBus(ctx context.Context, inv *inventory.Inventory, m catalogue
 	}
 	if _, reads := m.OwnSecrets["broker"]; reads {
 		user := broker.Principal{Kind: broker.KindModule, Node: node, Module: m.Module}.Username()
-		password, won, err := mintBusUser(ctx, inv, inventory.BusUser{
+		password, err := inv.MintBusPassword(ctx, inventory.BusUser{
 			Username: user, Kind: busKindOf(m.Module), Node: node, Module: m.Module,
 		})
 		if err != nil {
 			return err
 		}
-		if won {
-			if err := issueWith(ctx, inv, m, node, busAddress, known, reachable, user, password); err != nil {
-				return err
-			}
+		if err := issueWith(ctx, inv, m, node, busAddress, known, reachable, user, password); err != nil {
+			return err
 		}
 	}
 	// Every process with a bus declaration gets an account of its own (novox/hq ADR 0436 §1, §2), minted and
@@ -1043,11 +1021,11 @@ func issueOnTheNewBus(ctx context.Context, inv *inventory.Inventory, m catalogue
 func issueProcess(ctx context.Context, inv *inventory.Inventory, m catalogue.Manifest, pr broker.ProcessPrincipal,
 	node, busAddress string, known broker.Broker, reachable string) error {
 	user := broker.Principal{Kind: broker.KindProcess, Node: node, Module: m.Module, Process: pr.Process}.Username()
-	password, won, err := mintBusUser(ctx, inv, inventory.BusUser{
+	password, err := inv.MintBusPassword(ctx, inventory.BusUser{
 		Username: user, Kind: inventory.BusProcess, Node: node, Module: m.Module,
 	})
-	if err != nil || !won {
-		return err // lost: the caller that minted it seals it
+	if err != nil {
+		return err
 	}
 	name := processSecretName(pr.Process)
 	held, err := heldProcessAccount(known, reachable, node, m.Module, user, password)
@@ -1113,11 +1091,11 @@ func runsTheProvisionerClient(m catalogue.Manifest) bool {
 func issueProvisionerClient(ctx context.Context, inv *inventory.Inventory, m catalogue.Manifest, node string,
 	known broker.Broker, reachable string) error {
 	user := broker.Principal{Kind: broker.KindProvisioner, Node: node, Module: m.Module}.Username()
-	password, won, err := mintBusUser(ctx, inv, inventory.BusUser{
+	password, err := inv.MintBusPassword(ctx, inventory.BusUser{
 		Username: user, Kind: inventory.BusProvisioner, Node: node, Module: m.Module,
 	})
-	if err != nil || !won {
-		return err // lost: the caller that minted it seals it
+	if err != nil {
+		return err
 	}
 	held, err := json.Marshal(struct {
 		URL         string `json:"url"`

cmd/mesh-controller/new_modules.go

@@ -200,17 +200,14 @@ func newModuleObservations(now time.Time) []conditions.Observation {
 // watchNewModules wakes the take-in of new modules for each module the builder or the indexer writes, until ctx ends, and
 // looks at every module once now. A bucket not there yet is said: the look at start and a first merge's word still work.
 func watchNewModules(ctx context.Context, open *stores) {
-	inBackground(ctx, func() {
+	inBackground(func() {
 		takeNewModules(ctx, open)
 	})
 	// And, beside it, the start's pass of release 6 and the take-in of each registered module's new done key (novox/hq
 	// ADR 0539 clauses 5, 7, 10 and 13; composed_start.go, composed_keys.go): the plans' buckets deleted, every node
 	// composed, the replaced controller composed, and from now on each new fingerprint registered, composed and granted.
-	inBackground(ctx, func() { composeAtStart(ctx, open) })
+	inBackground(func() { composeAtStart(ctx, open) })
 	watchDoneKeys(ctx, open)
-	// And each assignment that comes to stand issues its node's bus accounts and the module's grant (ADR 0543): a module
-	// built long before is assigned to one more node with no build done again (issue 1945, assignment_accounts.go).
-	watchAssignmentAccounts(ctx, open)
 	watchHavesForJudgement(ctx, open)
 	// And the keep set keeps the builds every want names (ADR 0539 clause 1), with no plan left to name them.
 	open.inventory.SetWanted(wantedOnTheBus)
@@ -235,7 +232,7 @@ func watchNewModules(ctx context.Context, open *stores) {
 // wakeNewModule takes module in when the catalogue does not hold it: never on the watch's own goroutine, which must keep
 // draining.
 func wakeNewModule(ctx context.Context, open *stores, module string) {
-	inBackground(ctx, func() {
+	inBackground(func() {
 		entries, err := open.inventory.Catalogued(ctx)
 		if err != nil {
 			return
@@ -253,17 +250,14 @@ func wakeNewModule(ctx context.Context, open *stores, module string) {
 // ends only once the work its mesh started has.
 var background sync.WaitGroup
 
-// inBackground runs work beside the caller, counted in background and, under a serving controller, in its serving group,
-// so serve's stop waits for it and a serve that is stopping starts none (serving_group.go). A variable so a test of what a
-// walk does around a take-in may run it in the caller's turn and need not wait for it.
-var inBackground = func(ctx context.Context, work func()) {
+// inBackground runs work beside the caller, counted in background. A variable so a test of what a walk does around a
+// take-in may run it in the caller's turn and need not wait for it.
+var inBackground = func(work func()) {
 	background.Add(1)
-	if !goServing(ctx, func() {
+	go func() {
 		defer background.Done()
 		work()
-	}) {
-		background.Done()
-	}
+	}()
 }
 
 // newModulesOf are the modules the indexer holds in a repository: what a first merge's word wakes.

cmd/mesh-controller/process_accounts.go

@@ -72,8 +72,6 @@ func issueMissingProcessAccounts(ctx context.Context, inv *inventory.Inventory,
 	if len(m.ProcessBuses()) == 0 || mayIssue(m) != nil {
 		return "", nil
 	}
-	// Only the missing: never a second password over one another caller minted between this look and the mint.
-	ctx = onlyIfAbsent(ctx)
 	minted, err := inv.BusMinted(ctx)
 	if err != nil {
 		return "", err

cmd/mesh-controller/process_issue_test.go

@@ -1,9 +1,12 @@
 package main
 
 import (
+	"encoding/json"
+	"strings"
 	"testing"
 
 	"git.novox.be/novox/mesh-sdk/go/catalogue"
+	"github.com/novox/mesh-controller/internal/broker"
 )
 
 // mailSenderWithProcess is mesh-mail's real manifest shape (novox/hq ADR 0436 §7, §8, the lead's fixture):
@@ -22,6 +25,61 @@ func mailSenderWithProcess() catalogue.Manifest {
 	return m
 }
 
+// review round 1, finding 1 (1181): a module declaring no `broker` of its own at all — mesh-mail's real
+// shape, tools served by the tool runner — still passes mayIssue on its process's bus declaration alone.
+func TestAModuleWithNoBrokerAndOnlyAProcessMayBeIssued(t *testing.T) {
+	if err := mayIssue(mailSenderWithProcess()); err != nil {
+		t.Fatalf("a module with no broker of its own, whose process declares bus, was refused: %v", err)
+	}
+}
+
+// 1181/AC1: a process with a bus declaration and no own secret broker-<process id> cannot be issued — the
+// same refusal mayIssue already gives a module with no `broker` (novox/hq ADR 0436 §2).
+func TestAProcessWithNoBrokerSecretCannotBeIssued(t *testing.T) {
+	m := mailSenderWithProcess()
+	delete(m.OwnSecrets, "broker-send")
+	err := mayIssue(m)
+	if err == nil {
+		t.Fatal("a process with no broker-<id> own secret was issued an account")
+	}
+	for _, want := range []string{"mesh-mail", "send", "broker-send", "own-secrets"} {
+		if !strings.Contains(err.Error(), want) {
+			t.Errorf("the refusal does not say %q: %v", want, err)
+		}
+	}
+	if err := mayIssue(mailSenderWithProcess()); err != nil {
+		t.Errorf("a process declaring its own broker-<id> secret was refused: %v", err)
+	}
+}
+
+// 1181/AC1: the account held for a process is the provisioner client's form — {url, fingerprint, node,
+// module, user, password} — named for the process, never the module's own account.
+func TestAProcesssHeldAccountIsTheProvisionersForm(t *testing.T) {
+	user := broker.Principal{Kind: broker.KindProcess, Node: "novox", Module: "mesh-mail", Process: "send"}.Username()
+	if user != "novox.mesh-mail.send" {
+		t.Fatalf("the process's username: %q", user)
+	}
+	held, err := heldProcessAccount(broker.Broker{Fingerprint: "abc"}, "novox.example:4222", "novox", "mesh-mail",
+		user, "a-password")
+	if err != nil {
+		t.Fatal(err)
+	}
+	var got map[string]any
+	if err := json.Unmarshal(held, &got); err != nil {
+		t.Fatal(err)
+	}
+	want := map[string]any{"url": "nats://novox.example:4222", "fingerprint": "abc", "node": "novox",
+		"module": "mesh-mail", "user": "novox.mesh-mail.send", "password": "a-password"}
+	for k, v := range want {
+		if got[k] != v {
+			t.Errorf("%s: %v, want %v", k, got[k], v)
+		}
+	}
+	if len(got) != len(want) {
+		t.Errorf("the held account carries %v; want exactly %v (never claims — a process holds no seat)", got, want)
+	}
+}
+
 // 1181/AC1: composed, the process's own secret belongs to its own account at 0600 (novox/hq ADR 0436 §1, §2;
 // the owner mechanism is issue 1170's, proven generically there — this is mesh-mail's own shape).
 func TestAProcessesOwnSecretIsOwnedByItsOwnAccount(t *testing.T) {

cmd/mesh-controller/push.go

@@ -59,9 +59,6 @@ func serve(ctx context.Context) (err error) {
 	}
 	defer open.Close()
 	inv := open.inventory
-	// Lent to every reader in this process that holds only the inventory, so none opens pools of its own per call
-	// (issues 1945 and 1277: about 120 take-ins at once filled novox's store at 16:08 on 2026-10-25).
-	defer shareStores(open)()
 	// **What this build reads of the store's schema, on record** (novox/hq issue 352): the highest migration
 	// it carries, by its version, so a gate that would put this build back later knows it reads the store
 	// as it is then. A build that does not know its version records nothing, and is never put back.
@@ -78,11 +75,11 @@ func serve(ctx context.Context) (err error) {
 			"recorded, and a gate will never put it back\n", RunningBuildVar)
 	}
 
-	// The controller's own identity store, the one its readers share (closed with open), not a second pool.
-	ident, err := open.Identity(ctx)
+	ident, err := openIdentity(ctx)
 	if err != nil {
 		return err
 	}
+	defer ident.Close()
 
 	// Established at start rather than on first use. A control plane that cannot sign is one
 	// whose declarations every node correctly refuses, and that should be a startup failure
@@ -179,7 +176,6 @@ func serve(ctx context.Context) (err error) {
 	keeper := openServingConditions(ctx, open, bus)
 	if keeper != nil {
 		defer closeConditions(keeper)
-		defer stopRunning() // on an error return, the goroutines end before the keeper closes
 	}
 
 	// The bus's own objects, asserted on every start. **Not created once at genesis**: a stream
@@ -248,12 +244,10 @@ func serve(ctx context.Context) (err error) {
 	// next test's `conditions` with "connection closed", issue 1945).
 	handActConn = bus.Conn
 	defer func() { handActConn = nil }()
-	defer stopRunning() // on an error return, the goroutines end before handActConn is put back
 	// And everything else this controller does on the bus for a moment (novox/hq issue 327).
 	servingBus.Store(server.JetStream())
 	// No longer serving: nothing is lent, and dead-letters says it is not read here (novox/hq issue 330).
 	defer servingBus.Store(nil)
-	defer stopRunning() // on an error return, the goroutines end before the bus is taken back
 	// And says when it replaced a value given by hand (novox/hq ADR 0228).
 	givenEvents = bus
 	// And a pull request's merge check, asked when the forge announces its head and said when judged

cmd/mesh-controller/serving_group.go

@@ -29,17 +29,17 @@ func withServingGroup(ctx context.Context) (context.Context, *servingGroup) {
 
 // goServing runs work beside the caller, counted in the group ctx carries, so serve's stop waits for it. Under a group
 // whose stop began it runs nothing; under a context with no group (a part run alone, by a test or a verb) it is a plain
-// goroutine, as before. It says whether it started work.
-func goServing(ctx context.Context, work func()) bool {
+// goroutine, as before.
+func goServing(ctx context.Context, work func()) {
 	g, _ := ctx.Value(servingGroupKey{}).(*servingGroup)
 	if g == nil {
 		go work()
-		return true
+		return
 	}
 	g.mu.Lock()
 	if g.stopped {
 		g.mu.Unlock()
-		return false
+		return
 	}
 	g.wg.Add(1)
 	g.mu.Unlock()
@@ -47,7 +47,6 @@ func goServing(ctx context.Context, work func()) bool {
 		defer g.wg.Done()
 		work()
 	}()
-	return true
 }
 
 // stop starts nothing more and waits for what was started; the caller ends their context first. A second stop waits

cmd/mesh-controller/shared_stores_test.go

@@ -1,86 +0,0 @@
-package main
-
-import (
-	"context"
-	"sync"
-	"sync/atomic"
-	"testing"
-
-	"git.novox.be/novox/mesh-sdk/go/catalogue"
-	"github.com/novox/mesh-controller/internal/identity"
-	"github.com/novox/mesh-controller/internal/inventory"
-	"github.com/novox/mesh-controller/internal/licences"
-)
-
-// The serving controller's reads of the rest of the mesh open no pool per call: the licences and identity stores are the
-// controller's own, opened once and shared. On 2026-10-25 at 16:08 each take-in opened two pools of its own
-// (restOfTheMeshOf), about 120 at once, and novox's store refused every new connection (issues 1945 and 1277).
-func TestRestOfTheMeshOfOpensNoPoolPerCall(t *testing.T) {
-	wasIdent, wasLic, wasRest := identityOpener, licencesOpener, restOfTheMeshOn
-	t.Cleanup(func() { identityOpener, licencesOpener, restOfTheMeshOn = wasIdent, wasLic, wasRest })
-	var identities, licencesOpened atomic.Int64
-	identityOpener = func(context.Context) (*identity.Identity, error) {
-		identities.Add(1)
-		return &identity.Identity{}, nil
-	}
-	licencesOpener = func(context.Context) (*licences.Licences, error) {
-		licencesOpened.Add(1)
-		return &licences.Licences{}, nil
-	}
-	// The read of the Input reaches both stores, as readComposeInput does.
-	restOfTheMeshOn = func(ctx context.Context, open *stores, _ map[string]catalogue.Manifest, _ string) (catalogue.World, error) {
-		if _, err := open.Licences(ctx); err != nil {
-			return catalogue.World{}, err
-		}
-		if _, err := open.Identity(ctx); err != nil {
-			return catalogue.World{}, err
-		}
-		return catalogue.World{}, nil
-	}
-	inv := &inventory.Inventory{}
-	serving := &stores{inventory: inv}
-	unshare := shareStores(serving)
-	t.Cleanup(unshare)
-
-	var wg sync.WaitGroup
-	for range 120 {
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
-			if _, err := restOfTheMeshOf(context.Background(), inv, nil, ""); err != nil {
-				t.Error(err)
-			}
-		}()
-	}
-	wg.Wait()
-	if n := licencesOpened.Load(); n != 1 {
-		t.Fatalf("opened the licences store %d times for 120 reads, want once", n)
-	}
-	if n := identities.Load(); n != 1 {
-		t.Fatalf("opened the identity store %d times for 120 reads, want once", n)
-	}
-	if serving.licences == nil || serving.identity == nil {
-		t.Fatal("the reads did not use the serving controller's stores")
-	}
-}
-
-// A process that shares no stores (a verb run as its own short process) still opens them for the call and lets go.
-func TestRestOfTheMeshOfOpensItsOwnWhereNoneAreShared(t *testing.T) {
-	wasIdent, wasLic, wasRest := identityOpener, licencesOpener, restOfTheMeshOn
-	t.Cleanup(func() { identityOpener, licencesOpener, restOfTheMeshOn = wasIdent, wasLic, wasRest })
-	var opened atomic.Int64
-	licencesOpener = func(context.Context) (*licences.Licences, error) { opened.Add(1); return &licences.Licences{}, nil }
-	restOfTheMeshOn = func(ctx context.Context, open *stores, _ map[string]catalogue.Manifest, _ string) (catalogue.World, error) {
-		_, err := open.Licences(ctx)
-		return catalogue.World{}, err
-	}
-	inv := &inventory.Inventory{}
-	for range 2 {
-		if _, err := restOfTheMeshOf(context.Background(), inv, nil, ""); err != nil {
-			t.Fatal(err)
-		}
-	}
-	if n := opened.Load(); n != 2 {
-		t.Fatalf("opened %d times, want once per call", n)
-	}
-}

cmd/mesh-controller/states_announced.go

@@ -67,7 +67,7 @@ func keepAnnouncements(ctx context.Context, js *broker.JetStream, open *stores)
 			return
 		}
 		if changed {
-			inBackground(ctx, func() { composeAnnouncedReads(context.WithoutCancel(ctx), open) })
+			inBackground(func() { composeAnnouncedReads(context.WithoutCancel(ctx), open) })
 		}
 	})
 	if err != nil {

cmd/mesh-controller/stores.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"os"
-	"sync"
 	"time"
 
 	"git.novox.be/novox/mesh-sdk/go/catalogue"
@@ -164,13 +163,6 @@ func openLicences(ctx context.Context) (*licences.Licences, error) {
 	return held, nil
 }
 
-// identityOpener and licencesOpener open a store the first time a set of stores needs it; variables so a test counts
-// the pools opened.
-var (
-	identityOpener = openIdentity
-	licencesOpener = openLicences
-)
-
 // stores is what one command has open.
 //
 // **Opened once, not once per machine.** Working out what a machine should be reaches the identity
@@ -184,9 +176,6 @@ type stores struct {
 	inventory *inventory.Inventory
 	identity  *identity.Identity
 	licences  *licences.Licences
-	// mu keeps one opening of each store at a time: a serving controller's stores are shared by readers that run side
-	// by side (sharedStores).
-	mu sync.Mutex
 }
 
 // open connects to the inventory, which every command that touches the mesh needs.
@@ -200,12 +189,10 @@ func openStores(ctx context.Context) (*stores, error) {
 
 // Identity is this control plane's own identity context, opened if it has not been.
 func (h *stores) Identity(ctx context.Context) (*identity.Identity, error) {
-	h.mu.Lock()
-	defer h.mu.Unlock()
 	if h.identity != nil {
 		return h.identity, nil
 	}
-	opened, err := identityOpener(ctx)
+	opened, err := openIdentity(ctx)
 	if err != nil {
 		return nil, err
 	}
@@ -215,12 +202,10 @@ func (h *stores) Identity(ctx context.Context) (*identity.Identity, error) {
 
 // Licences is the context holding model access, opened if it has not been.
 func (h *stores) Licences(ctx context.Context) (*licences.Licences, error) {
-	h.mu.Lock()
-	defer h.mu.Unlock()
 	if h.licences != nil {
 		return h.licences, nil
 	}
-	opened, err := licencesOpener(ctx)
+	opened, err := openLicences(ctx)
 	if err != nil {
 		return nil, err
 	}
@@ -241,22 +226,3 @@ func (h *stores) Close() {
 		h.inventory.Close()
 	}
 }
-
-// sharedStores are the stores a serving controller lends, by its inventory, to every reader in the process that holds
-// only the inventory (restOfTheMeshOf): one pool of each store for the controller, never one per call (issues 1945 and
-// 1277, 2026-10-25 16:08: about 120 take-ins opened two pools each and filled novox's store).
-var sharedStores sync.Map // *inventory.Inventory -> *stores
-
-// shareStores lends open by its inventory until the function returned is called.
-func shareStores(open *stores) func() {
-	sharedStores.Store(open.inventory, open)
-	return func() { sharedStores.CompareAndDelete(open.inventory, open) }
-}
-
-// sharedStoresOf are the stores lent for inv, if any are.
-func sharedStoresOf(inv *inventory.Inventory) (*stores, bool) {
-	if open, ok := sharedStores.Load(inv); ok {
-		return open.(*stores), true
-	}
-	return nil, false
-}

cmd/mesh-controller/watchdogs.go

@@ -512,9 +512,7 @@ func (w *watchdogs) lostConsumers(ctx context.Context, heard []link.Advisory) (m
 	for _, a := range deleted {
 		_, err := w.js.Context().ConsumerInfo(a.Stream, a.Consumer)
 		switch {
-		// A consumer whose stream is gone is gone with it: the retired declarations' stream took every node's
-		// consumer, and its deletion said each as deleted (issue 1945).
-		case errors.Is(err, nats.ErrConsumerNotFound) || errors.Is(err, nats.ErrStreamNotFound):
+		case errors.Is(err, nats.ErrConsumerNotFound):
 			out[a.Stream+"."+a.Consumer] = want[a.Stream+"."+a.Consumer]
 		case err != nil:
 			return nil, fmt.Errorf("whether %s exists cannot be read: %w", link.ConsumerInWords(a.Stream, a.Consumer), err)

internal/broker/composed.go

@@ -165,8 +165,7 @@ func HandPathWrites(nodes []string) ([]string, error) {
 // DeclarationsStream is the stream of each node's last declaration, `mesh.node.<node>.declare` (issue 107). Release 6
 // sends none (ADR 0539 clauses 5 and 11): the stream is kept, with each node's consumer, only so a node away during the
 // switch finds its last declaration and with it the new node-engine; the controller deletes it once every node's have
-// names the new node-engine, and from then on neither asserts it nor any node's consumer on it; nor makes it again once
-// it is gone from the bus for any reason, since a stream made anew would hold no node's last declaration (issue 1945).
+// names the new node-engine, and from then on neither asserts it nor any node's consumer on it.
 const DeclarationsStream = "NODES"
 
 // RaiseAfterDeclarations is Raise once the declarations' stream is retired: the mesh's streams and consumers but the

internal/inventory/bususers.go

@@ -114,37 +114,6 @@ func (i *Inventory) writeBusUser(ctx context.Context, u BusUser, hash string) er
 	return nil
 }
 
-// MintBusPasswordIfAbsent mints u's password only when no row names u yet, in one statement: of two callers that both
-// found the account missing, exactly one wins, and the other is told it lost (won false, no password) and must seal
-// nothing, so the hash the bus holds is always the password the node is sealed (novox/hq ADR 0543, the review of
-// issue 1945: the assign act and the assignments' watch once each minted, the later hash beside the earlier seal).
-func (i *Inventory) MintBusPasswordIfAbsent(ctx context.Context, u BusUser) (string, bool, error) {
-	if u.Username == "" || u.Kind == "" {
-		return "", false, errors.New("a bus user needs a username and a kind")
-	}
-	raw := make([]byte, 32)
-	if _, err := rand.Read(raw); err != nil {
-		return "", false, fmt.Errorf("cannot generate a bus password: %w", err)
-	}
-	password := base64.RawURLEncoding.EncodeToString(raw)
-	hash, err := hashBusPassword(password)
-	if err != nil {
-		return "", false, fmt.Errorf("cannot hash a bus password: %w", err)
-	}
-	tag, err := i.store.Pool().Exec(ctx,
-		`insert into bus_user (username, kind, node, module, password_hash)
-		 values ($1, $2, $3, $4, $5)
-		 on conflict (username) do nothing`,
-		u.Username, u.Kind, u.Node, u.Module, string(hash))
-	if err != nil {
-		return "", false, fmt.Errorf("cannot record the bus user %s: %w", u.Username, err)
-	}
-	if tag.RowsAffected() == 0 {
-		return "", false, nil
-	}
-	return password, true, nil
-}
-
 func (i *Inventory) MintBusPassword(ctx context.Context, u BusUser) (string, error) {
 	if u.Username == "" || u.Kind == "" {
 		return "", errors.New("a bus user needs a username and a kind")

internal/inventory/bususers_integration_test.go

@@ -33,7 +33,7 @@ func TestABusPasswordIsReturnedOnceAndOnlyItsHashIsKept(t *testing.T) {
 	}
 }
 
-func TestMintingAgainRotatesAndMintingIfAbsentHasOneWinner(t *testing.T) {
+func TestMintingAgainRotatesRatherThanAddsAUser(t *testing.T) {
 	inv := ForTest(t)
 	ctx := context.Background()
 
@@ -62,50 +62,6 @@ func TestMintingAgainRotatesAndMintingIfAbsentHasOneWinner(t *testing.T) {
 	if bcrypt.CompareHashAndPassword([]byte(hash), []byte(first)) == nil {
 		t.Fatal("the previous password still verifies, so a rotation revoked nothing")
 	}
-
-	// **Minting only if absent never rotates, and of several at once exactly one wins** (ADR 0543, the review of issue
-	// 1945): the assign act and the assignments' watch may both find an account missing; the winner's password is the
-	// one the store's hash verifies, so the one it seals is the one the bus accepts, and a loser seals nothing.
-	if _, won, err := inv.MintBusPasswordIfAbsent(ctx, aBusUser("shop")); err != nil || won {
-		t.Fatalf("a mint-if-absent over a minted account won %v (%v): it would replace a sealed password", won, err)
-	}
-	const racers = 8
-	type minted struct {
-		password string
-		won      bool
-		err      error
-	}
-	results := make(chan minted, racers)
-	for range racers {
-		go func() {
-			p, won, err := inv.MintBusPasswordIfAbsent(ctx, aBusUser("racer"))
-			results <- minted{p, won, err}
-		}()
-	}
-	var winner string
-	wins := 0
-	for range racers {
-		r := <-results
-		if r.err != nil {
-			t.Fatal(r.err)
-		}
-		if r.won {
-			wins++
-			winner = r.password
-		} else if r.password != "" {
-			t.Fatal("a caller that lost was handed a password to seal")
-		}
-	}
-	if wins != 1 {
-		t.Fatalf("%d of %d concurrent mints won, want exactly one", wins, racers)
-	}
-	stored, _, err := inv.BusUserHash(ctx, "one.racer")
-	if err != nil {
-		t.Fatal(err)
-	}
-	if err := bcrypt.CompareHashAndPassword([]byte(stored), []byte(winner)); err != nil {
-		t.Fatal("the stored hash is not the winner's password: the node would be sealed a password the bus refuses")
-	}
 }
 
 func TestForgettingANodeTakesItsBusUsersWithIt(t *testing.T) {

internal/inventory/chain_assignments.go

@@ -361,13 +361,3 @@ func (i *Inventory) AssignmentValue(ctx context.Context, node, module string) (c
 	k, found, err := c.Assignments.Get(ctx, assignmentKey(node, module))
 	return k.Value, found, err
 }
-
-// WatchAssignments is the assignments bucket's raw entries, as the chain's watch gives them: every current value, a Caught
-// mark, then each write (novox/hq ADR 0543: an assignment that comes to stand issues its node's bus accounts).
-func (i *Inventory) WatchAssignments(ctx context.Context) (<-chan chain.Entry, error) {
-	c, err := i.theChain(ctx)
-	if err != nil {
-		return nil, err
-	}
-	return c.Assignments.Watch(ctx)
-}

internal/store/ready_test.go

@@ -1,82 +0,0 @@
-package store
-
-import (
-	"context"
-	"strings"
-	"testing"
-	"time"
-
-	"github.com/jackc/pgx/v5/pgconn"
-)
-
-// A full store (SQLSTATE 53300, "too many clients already") is not asked again every 250 ms: Ready backs off,
-// doubling its wait up to a bound, and says once that the store is full (issues 1945 and 1277, 2026-10-25 16:08: the
-// controller's retries kept novox's store full).
-func TestReadyBacksOffOnAFullStore(t *testing.T) {
-	wasPing, wasWait, wasSay := pingStore, readyWait, readySay
-	t.Cleanup(func() { pingStore, readyWait, readySay = wasPing, wasWait, wasSay })
-	asked := 0
-	pingStore = func(context.Context, *Store) error {
-		asked++
-		if asked <= 8 {
-			return &pgconn.PgError{Code: "53300", Message: "sorry, too many clients already"}
-		}
-		return nil
-	}
-	var waits []time.Duration
-	readyWait = func(_ context.Context, d time.Duration) error { waits = append(waits, d); return nil }
-	var said []string
-	readySay = func(line string) { said = append(said, line) }
-
-	if err := (&Store{context: "example"}).Ready(context.Background(), time.Hour); err != nil {
-		t.Fatalf("Ready: %v", err)
-	}
-	if len(waits) != 8 {
-		t.Fatalf("waited %d times, want 8: %v", len(waits), waits)
-	}
-	for i := 1; i < len(waits); i++ {
-		if waits[i] < waits[i-1] {
-			t.Fatalf("wait %d (%s) is shorter than the one before (%s): %v", i, waits[i], waits[i-1], waits)
-		}
-	}
-	if waits[1] <= waits[0] {
-		t.Fatalf("Ready does not back off on a full store: %v", waits)
-	}
-	if most := waits[len(waits)-1]; most > fullStoreMostWait {
-		t.Fatalf("the wait grew past its bound %s: %v", fullStoreMostWait, waits)
-	}
-	full := 0
-	for _, l := range said {
-		if strings.Contains(l, "full") {
-			full++
-		}
-	}
-	if full != 1 {
-		t.Fatalf("said that the store is full %d times, want once: %q", full, said)
-	}
-}
-
-// A store that does not answer for another reason (not up yet) is still asked again every 250 ms.
-func TestReadyWaitsShortlyOnAStoreNotUp(t *testing.T) {
-	wasPing, wasWait, wasSay := pingStore, readyWait, readySay
-	t.Cleanup(func() { pingStore, readyWait, readySay = wasPing, wasWait, wasSay })
-	asked := 0
-	pingStore = func(context.Context, *Store) error {
-		asked++
-		if asked <= 3 {
-			return context.DeadlineExceeded
-		}
-		return nil
-	}
-	var waits []time.Duration
-	readyWait = func(_ context.Context, d time.Duration) error { waits = append(waits, d); return nil }
-	readySay = func(string) {}
-	if err := (&Store{context: "example"}).Ready(context.Background(), time.Hour); err != nil {
-		t.Fatalf("Ready: %v", err)
-	}
-	for _, w := range waits {
-		if w != 250*time.Millisecond {
-			t.Fatalf("waits %v, want 250ms each", waits)
-		}
-	}
-}

internal/store/store.go

@@ -24,7 +24,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/jackc/pgx/v5/pgconn"
 	"github.com/jackc/pgx/v5/pgxpool"
 
 	"github.com/novox/mesh-controller/internal/envfile"
@@ -214,7 +213,7 @@ func (s *Store) Pool() *pgxpool.Pool { return s.pool }
 
 // Close releases the connections.
 func (s *Store) Close() {
-	if s != nil && s.pool != nil {
+	if s.pool != nil {
 		s.pool.Close()
 	}
 }
@@ -228,10 +227,8 @@ func (s *Store) Close() {
 func (s *Store) Ready(ctx context.Context, within time.Duration) error {
 	deadline := time.Now().Add(within)
 	var last error
-	wait := 250 * time.Millisecond
-	saidFull := false
 	for {
-		err := pingStore(ctx, s)
+		err := s.pool.Ping(ctx)
 		if err == nil {
 			return nil
 		}
@@ -243,48 +240,10 @@ func (s *Store) Ready(ctx context.Context, within time.Duration) error {
 			return fmt.Errorf(
 				"the %s store did not answer within %s: %w", s.context, within, last)
 		}
-		// A full store (SQLSTATE 53300) is not asked again every 250 ms: each ask is one more connection it refuses
-		// while it is full. The wait doubles up to fullStoreMostWait, and the journal says once why (issues 1945 and
-		// 1277, 2026-10-25 16:08: the controller's own retries kept the store full).
-		if isFull(err) {
-			if !saidFull {
-				readySay(fmt.Sprintf("the %s store is full (too many clients already); asked again at a growing "+
-					"interval, at most every %s, for at most %s in all", s.context, fullStoreMostWait, within))
-				saidFull = true
-			}
-		} else {
-			wait = 250 * time.Millisecond
-		}
-		if err := readyWait(ctx, wait); err != nil {
-			return errors.Join(err, last)
-		}
-		if isFull(err) {
-			wait = min(wait*2, fullStoreMostWait)
+		select {
+		case <-ctx.Done():
+			return errors.Join(ctx.Err(), last)
+		case <-time.After(250 * time.Millisecond):
 		}
 	}
 }
-
-// pingStore asks the store once whether it answers; a variable so a test needs no database.
-var pingStore = func(ctx context.Context, s *Store) error { return s.pool.Ping(ctx) }
-
-// readyWait waits d or until ctx ends; a variable so a test waits in no real time.
-var readyWait = func(ctx context.Context, d time.Duration) error {
-	select {
-	case <-ctx.Done():
-		return ctx.Err()
-	case <-time.After(d):
-		return nil
-	}
-}
-
-// readySay says a line of Ready's wait in the journal; a variable so a test reads it.
-// isFull says whether err is the store refusing a connection because it is full (SQLSTATE 53300).
-func isFull(err error) bool {
-	var pg *pgconn.PgError
-	return errors.As(err, &pg) && pg.Code == "53300"
-}
-
-// fullStoreMostWait bounds the wait between two asks of a full store.
-const fullStoreMostWait = 5 * time.Second
-
-var readySay = func(line string) { fmt.Fprintln(os.Stderr, line) }