Require the service manager's reset-failed, wanted-by and unlink-dangling verbs (issue 332) #248

Merged
mesh-admin merged 2 commits from fix/332-require-service-manager-verbs into main 2026-10-12 10:53:21 +00:00
Contributor

What

Step 3 of ADR 0246 (a seat's new verb is promised before it is required) for issue 332: the node-service-manager seat's reset-failed, wanted-by and unlink-dangling verbs lose their optional mark in internal/catalogue/seats.go, so serving them is now a condition of holding the seat.

This is the only part of issue 332 left. Steps 1 and 2 are done: the controller promised the verbs as optional (#158, #160) and the systemd module serves them (mesh-catalog #137, #138).

Why now

  • The systemd module is the seat's only holder in the catalogue, and its module.json on mesh-catalog main serves all twelve verbs (the captured copy in testdata/beside does too).
  • mesh_search shows node-service-manager.unlink-dangling on ace, g14, novox and shanks, and reset-failed and wanted-by answer on novox (discovery from the other three was incomplete at that moment). All three verbs came in the same systemd version.

failed stays optional. It is outside issue 332, and requiring it is a separate step.

How it was tested

  • TestResetFailedWantedByAndUnlinkDanglingAreRequiredVerbsOfTheServiceManager (replaces the optional-verbs test): a holder serving only the nine verbs from before issue 332 is refused; a holder missing any one of the three is refused with does not serve <verb>; a holder serving all twelve holds the seat; the verbs are no longer optional; and the same holds for a seat set read back from the store's rows. It fails on main.
  • TestFailedIsAnOptionalVerbOfTheServiceManager and TestAnOptionalVerbStaysOptionalInASetReadFromTheStore now expect only failed to be optional.
  • go test ./... passes; sh merge-check.sh passes locally (store tests skipped, because no MESH_TEST_POSTGRES is set here).

Fixes issue 332.

## What Step 3 of ADR 0246 (a seat's new verb is promised before it is required) for issue 332: the `node-service-manager` seat's `reset-failed`, `wanted-by` and `unlink-dangling` verbs lose their optional mark in `internal/catalogue/seats.go`, so serving them is now a condition of holding the seat. This is the only part of issue 332 left. Steps 1 and 2 are done: the controller promised the verbs as optional (#158, #160) and the `systemd` module serves them (mesh-catalog #137, #138). ## Why now - The `systemd` module is the seat's only holder in the catalogue, and its `module.json` on mesh-catalog main serves all twelve verbs (the captured copy in `testdata/beside` does too). - `mesh_search` shows `node-service-manager.unlink-dangling` on ace, g14, novox and shanks, and `reset-failed` and `wanted-by` answer on novox (discovery from the other three was incomplete at that moment). All three verbs came in the same `systemd` version. `failed` stays optional. It is outside issue 332, and requiring it is a separate step. ## How it was tested - `TestResetFailedWantedByAndUnlinkDanglingAreRequiredVerbsOfTheServiceManager` (replaces the optional-verbs test): a holder serving only the nine verbs from before issue 332 is refused; a holder missing any one of the three is refused with `does not serve <verb>`; a holder serving all twelve holds the seat; the verbs are no longer optional; and the same holds for a seat set read back from the store's rows. It fails on main. - `TestFailedIsAnOptionalVerbOfTheServiceManager` and `TestAnOptionalVerbStaysOptionalInASetReadFromTheStore` now expect only `failed` to be optional. - `go test ./...` passes; `sh merge-check.sh` passes locally (store tests skipped, because no `MESH_TEST_POSTGRES` is set here). Fixes issue 332.
mesh-admin added 1 commit 2026-10-12 10:03:50 +00:00
Require the service manager's reset-failed, wanted-by and unlink-dangling verbs now every holder serves them (issue 332)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check fail: its merge-check.sh failed: --- FAIL: TestAVerbsOwnProcessNamesItsConnection (4.62s); and TestASeatsVerbGainsTheArgumentsTheBinaryNames
mesh/delivery superseded: a newer head of the same pull request
0a0f5b4a5a
ADR 0246 step 3: the systemd module, the seat's only holder, serves all three on every node,
so a holder that stops serving one is refused rather than leaving a node without them.
Author
Contributor

Delivery novox/mesh-controller@61d00a234af7 — delivered since 2026-10-12T11:05:29Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Machines

  • mesh-controller on novox: passed — healthy 3 times over 4m8s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m20s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-12 10:25 (new) → proposed (announced): novox/mesh-controller#248's head announced
  • 2026-10-12 10:32 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 10:32 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 10:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 10:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 11:05 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@61d00a234af7` — **delivered** since 2026-10-12T11:05:29Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Machines** - mesh-controller on novox: passed — healthy 3 times over 4m8s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m20s - build-agent on the rest running it: sent **Transitions** - 2026-10-12 10:25 (new) → proposed (announced): novox/mesh-controller#248's head announced - 2026-10-12 10:32 proposed → checked (checked): the verdict names this commit - 2026-10-12 10:32 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 10:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 10:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 11:05 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 0a0f5b4a

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: FAIL — its merge-check.sh failed: --- FAIL: TestAVerbsOwnProcessNamesItsConnection (4.62s); and TestASeatsVerbGainsTheArgumentsTheBinaryNames

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: internal/catalogue/operators_machine_test.go

Run by the build seat on shanks as build-1791799443532143221 (builds --log build-1791799443532143221).

plan-gate: done — novox/mesh-catalog at c2, 1 tier(s)
plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes
status could not be composed (after 0s): the store did not answer — `status` answers the last summary, with its age
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
notes on laptop:
  + places.data.owner
  + places.data.path
  + x
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
notes on laptop:
  ~ x
  the layer it replaced is kept: settings show notes --node laptop --history
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
{
  "places": {
    "data": {
      "owner": "1001:1001",
      "path": "/srv/notes"
    }
  },
  "x": 1
}
  set by an unnamed account at a shell on Shanks through settings at 2026-10-12 10:10
keycloak on anchor:
  + issuer
  + x
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
power on anchor:
  + lid
  + x
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
keycloak on anchor:
  ~ x
  the layer it replaced is kept: settings show keycloak --node anchor --history
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
claude-code on laptop:
  + managed_settings.permissions.allow
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
claude-code on the whole mesh:
  + mcp_servers.listener.type
  + mcp_servers.listener.url
  run `push --behind` to send it to the machines running it
{
  "managed_settings": {
    "permissions": {
      "allow": [
        "Bash"
      ]
    }
  }
}
  set at the controller's terminal by an unnamed account at a shell on Shanks at 2026-10-12 10:10
keycloak on anchor:
  + url
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
{
  "url": "https://id.example"
}
  set at the controller's terminal by an unnamed account at a shell on Shanks at 2026-10-12 10:10
notifier on anchor:
  + font
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
plan-tier: tier 0 built; sent 12 module(s) to anchor first in one send (m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12), the rest once its gate passes
plan-tier: m01 passed its gate on anchor (healthy 3 times over 0s); the rest are sent
plan-tier: tier 0 built; sent m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12 to laptop, one send each
plan-tier: done — novox/mesh-catalog at c2, 1 tier(s)
plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, node-tools), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound)
plan-tier: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); app1 passed on its own and is kept; passed on their own and kept: app2; node-tools failed its gate on anchor in tier 0: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); put back node-tools to c1 on anchor, in one send; none reported left as it was
plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, app3), the rest once its gate passes
app1's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
app2's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
app3's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
plan-tier: app1 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app2 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app3 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; put back app1 to c1, app2 to c1, app3 to c1 on anchor, in one send; none reported left as it was
plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes
plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back
plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back; none reported left as it was
  tier 0: plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer
plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts
plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; node-tools was put back when it broke; passed on their own and kept: app1; none reported left as it was
plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (app1, node-tools), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer
plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts
plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; app1 passed on its own and is kept; none reported left as it was
plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes
plan-tier: node-tools passed its gate on anchor (healthy 3 times over 0s); the rest are sent
plan-tier: tier 0 built; sent node-tools, app1 to laptop, one send each
plan-tier: done — novox/mesh-catalog at c2, 1 tier(s)
FAIL
FAIL	github.com/novox/mesh-controller/cmd/mesh-controller	246.487s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.071s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.069s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.035s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.226s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.095s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.527s
ok  	github.com/novox/mesh-controller/internal/builder	19.070s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.144s
ok  	github.com/novox/mesh-controller/internal/conditions	2.649s
ok  	github.com/novox/mesh-controller/internal/envfile	1.048s
ok  	github.com/novox/mesh-controller/internal/facts	1.074s
ok  	github.com/novox/mesh-controller/internal/identity	5.146s
--- FAIL: TestASeatsVerbGainsTheArgumentsTheBinaryNames (0.40s)
    seats_test.go:212: the seat read from the store refuses today's holder: systemd claims node-service-manager but does not serve reset-failed, wanted-by, unlink-dangling, which that seat's protocol promises (novox/hq ADR 0132) — a holder names every verb its seat declares, under the claim's serves or among its own tools
2026/10/12 10:08:03 the stored manifest of later has a key this controller does not know (a state is either a name or {name, history, ttl-seconds, per-machine}: json: unknown field "a-field-from-later" (read without state[0].a-field-from-later)): a newer controller registered it, and later is left out of every machine until this controller is updated (novox/hq ADR 0262)
FAIL
FAIL	github.com/novox/mesh-controller/internal/inventory	97.197s
ok  	github.com/novox/mesh-controller/internal/lease	17.724s
ok  	github.com/novox/mesh-controller/internal/licences	4.666s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.046s
ok  	github.com/novox/mesh-controller/internal/link	61.427s
ok  	github.com/novox/mesh-controller/internal/lint	2.476s
ok  	github.com/novox/mesh-controller/internal/outward	1.081s
ok  	github.com/novox/mesh-controller/internal/overlay	1.086s
ok  	github.com/novox/mesh-controller/internal/secrets	1.567s
ok  	github.com/novox/mesh-controller/internal/store	3.552s
ok  	github.com/novox/mesh-controller/internal/testbus	1.276s
ok  	github.com/novox/mesh-controller/internal/token	1.015s
FAIL
--- what failed, picked from the whole of its output (the whole is in the build's log)
--- FAIL: TestAVerbsOwnProcessNamesItsConnection (4.62s)
    reconnects_test.go:89: the verb's connection was named ["mesh-controller verb settings"]
FAIL	github.com/novox/mesh-controller/cmd/mesh-controller	246.487s
--- FAIL: TestASeatsVerbGainsTheArgumentsTheBinaryNames (0.40s)
    seats_test.go:212: the seat read from the store refuses today's holder: systemd claims node-service-manager but does not serve reset-failed, wanted-by, unlink-dangling, which that seat's protocol promises (novox/hq ADR 0132) — a holder names every verb its seat declares, under the claim's serves or among its own tools
FAIL	github.com/novox/mesh-controller/internal/inventory	97.197s
**Merge check** at `0a0f5b4a` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **FAIL** — its merge-check.sh failed: --- FAIL: TestAVerbsOwnProcessNamesItsConnection (4.62s); and TestASeatsVerbGainsTheArgumentsTheBinaryNames **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: internal/catalogue/operators_machine_test.go Run by the build seat on shanks as `build-1791799443532143221` (`builds --log build-1791799443532143221`). ``` plan-gate: done — novox/mesh-catalog at c2, 1 tier(s) plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes status could not be composed (after 0s): the store did not answer — `status` answers the last summary, with its age anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node notes on laptop: + places.data.owner + places.data.path + x run `plan laptop --diff` to see what it changes, `push laptop` to send it notes on laptop: ~ x the layer it replaced is kept: settings show notes --node laptop --history run `plan laptop --diff` to see what it changes, `push laptop` to send it { "places": { "data": { "owner": "1001:1001", "path": "/srv/notes" } }, "x": 1 } set by an unnamed account at a shell on Shanks through settings at 2026-10-12 10:10 keycloak on anchor: + issuer + x run `plan anchor --diff` to see what it changes, `push anchor` to send it power on anchor: + lid + x run `plan anchor --diff` to see what it changes, `push anchor` to send it keycloak on anchor: ~ x the layer it replaced is kept: settings show keycloak --node anchor --history run `plan anchor --diff` to see what it changes, `push anchor` to send it claude-code on laptop: + managed_settings.permissions.allow run `plan laptop --diff` to see what it changes, `push laptop` to send it claude-code on the whole mesh: + mcp_servers.listener.type + mcp_servers.listener.url run `push --behind` to send it to the machines running it { "managed_settings": { "permissions": { "allow": [ "Bash" ] } } } set at the controller's terminal by an unnamed account at a shell on Shanks at 2026-10-12 10:10 keycloak on anchor: + url run `plan anchor --diff` to see what it changes, `push anchor` to send it { "url": "https://id.example" } set at the controller's terminal by an unnamed account at a shell on Shanks at 2026-10-12 10:10 notifier on anchor: + font run `plan anchor --diff` to see what it changes, `push anchor` to send it plan-tier: tier 0 built; sent 12 module(s) to anchor first in one send (m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12), the rest once its gate passes plan-tier: m01 passed its gate on anchor (healthy 3 times over 0s); the rest are sent plan-tier: tier 0 built; sent m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12 to laptop, one send each plan-tier: done — novox/mesh-catalog at c2, 1 tier(s) plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, node-tools), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound) plan-tier: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); app1 passed on its own and is kept; passed on their own and kept: app2; node-tools failed its gate on anchor in tier 0: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); put back node-tools to c1 on anchor, in one send; none reported left as it was plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, app3), the rest once its gate passes app1's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full app2's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full app3's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full plan-tier: app1 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app2 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app3 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; put back app1 to c1, app2 to c1, app3 to c1 on anchor, in one send; none reported left as it was plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back; none reported left as it was tier 0: plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; node-tools was put back when it broke; passed on their own and kept: app1; none reported left as it was plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (app1, node-tools), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; app1 passed on its own and is kept; none reported left as it was plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes plan-tier: node-tools passed its gate on anchor (healthy 3 times over 0s); the rest are sent plan-tier: tier 0 built; sent node-tools, app1 to laptop, one send each plan-tier: done — novox/mesh-catalog at c2, 1 tier(s) FAIL FAIL github.com/novox/mesh-controller/cmd/mesh-controller 246.487s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.071s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.069s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.035s ok github.com/novox/mesh-controller/examples/route-proxy 1.226s ok github.com/novox/mesh-controller/internal/artifacts 1.095s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.527s ok github.com/novox/mesh-controller/internal/builder 19.070s ok github.com/novox/mesh-controller/internal/catalogue 8.144s ok github.com/novox/mesh-controller/internal/conditions 2.649s ok github.com/novox/mesh-controller/internal/envfile 1.048s ok github.com/novox/mesh-controller/internal/facts 1.074s ok github.com/novox/mesh-controller/internal/identity 5.146s --- FAIL: TestASeatsVerbGainsTheArgumentsTheBinaryNames (0.40s) seats_test.go:212: the seat read from the store refuses today's holder: systemd claims node-service-manager but does not serve reset-failed, wanted-by, unlink-dangling, which that seat's protocol promises (novox/hq ADR 0132) — a holder names every verb its seat declares, under the claim's serves or among its own tools 2026/10/12 10:08:03 the stored manifest of later has a key this controller does not know (a state is either a name or {name, history, ttl-seconds, per-machine}: json: unknown field "a-field-from-later" (read without state[0].a-field-from-later)): a newer controller registered it, and later is left out of every machine until this controller is updated (novox/hq ADR 0262) FAIL FAIL github.com/novox/mesh-controller/internal/inventory 97.197s ok github.com/novox/mesh-controller/internal/lease 17.724s ok github.com/novox/mesh-controller/internal/licences 4.666s ok github.com/novox/mesh-controller/internal/licences/adapters 1.046s ok github.com/novox/mesh-controller/internal/link 61.427s ok github.com/novox/mesh-controller/internal/lint 2.476s ok github.com/novox/mesh-controller/internal/outward 1.081s ok github.com/novox/mesh-controller/internal/overlay 1.086s ok github.com/novox/mesh-controller/internal/secrets 1.567s ok github.com/novox/mesh-controller/internal/store 3.552s ok github.com/novox/mesh-controller/internal/testbus 1.276s ok github.com/novox/mesh-controller/internal/token 1.015s FAIL --- what failed, picked from the whole of its output (the whole is in the build's log) --- FAIL: TestAVerbsOwnProcessNamesItsConnection (4.62s) reconnects_test.go:89: the verb's connection was named ["mesh-controller verb settings"] FAIL github.com/novox/mesh-controller/cmd/mesh-controller 246.487s --- FAIL: TestASeatsVerbGainsTheArgumentsTheBinaryNames (0.40s) seats_test.go:212: the seat read from the store refuses today's holder: systemd claims node-service-manager but does not serve reset-failed, wanted-by, unlink-dangling, which that seat's protocol promises (novox/hq ADR 0132) — a holder names every verb its seat declares, under the claim's serves or among its own tools FAIL github.com/novox/mesh-controller/internal/inventory 97.197s ```
jschoubben added 1 commit 2026-10-12 10:25:07 +00:00
Give the store tests' service manager holders the three verbs it now must serve (issue 332)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
61d00a234a
They named only the eight verbs from before issue 332 and were refused once the seat required
reset-failed, wanted-by and unlink-dangling.
Author
Contributor

Merge check at 61d00a23

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/seat_dependencies_test.go, internal/catalogue/operators_machine_test.go, internal/inventory/seats_test.go

Run by the build seat on g14 as build-1791800720115784165 (builds --log build-1791800720115784165).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T10:23:58Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T10:23:58Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/seat_dependencies_test.go, internal/catalogue/operators_machine_test.go and internal/inventory/seats_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.037s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	245.264s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.025s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.188s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.067s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.335s
ok  	github.com/novox/mesh-controller/internal/builder	16.626s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.435s
ok  	github.com/novox/mesh-controller/internal/conditions	2.700s
ok  	github.com/novox/mesh-controller/internal/envfile	1.031s
ok  	github.com/novox/mesh-controller/internal/facts	1.033s
ok  	github.com/novox/mesh-controller/internal/identity	5.211s
ok  	github.com/novox/mesh-controller/internal/inventory	88.539s
ok  	github.com/novox/mesh-controller/internal/lease	17.700s
ok  	github.com/novox/mesh-controller/internal/licences	4.806s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.010s
ok  	github.com/novox/mesh-controller/internal/link	60.235s
ok  	github.com/novox/mesh-controller/internal/lint	2.412s
ok  	github.com/novox/mesh-controller/internal/outward	1.049s
ok  	github.com/novox/mesh-controller/internal/overlay	1.030s
ok  	github.com/novox/mesh-controller/internal/secrets	1.532s
ok  	github.com/novox/mesh-controller/internal/store	3.392s
ok  	github.com/novox/mesh-controller/internal/testbus	1.195s
ok  	github.com/novox/mesh-controller/internal/token	1.022s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.39s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.37s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.38s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.35s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.22s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s)
**Merge check** at `61d00a23` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/seat_dependencies_test.go, internal/catalogue/operators_machine_test.go, internal/inventory/seats_test.go Run by the build seat on g14 as `build-1791800720115784165` (`builds --log build-1791800720115784165`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T10:23:58Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T10:23:58Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/seat_dependencies_test.go, internal/catalogue/operators_machine_test.go and internal/inventory/seats_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.037s ok github.com/novox/mesh-controller/cmd/mesh-controller 245.264s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.019s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.026s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.025s ok github.com/novox/mesh-controller/examples/route-proxy 1.188s ok github.com/novox/mesh-controller/internal/artifacts 1.067s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.335s ok github.com/novox/mesh-controller/internal/builder 16.626s ok github.com/novox/mesh-controller/internal/catalogue 7.435s ok github.com/novox/mesh-controller/internal/conditions 2.700s ok github.com/novox/mesh-controller/internal/envfile 1.031s ok github.com/novox/mesh-controller/internal/facts 1.033s ok github.com/novox/mesh-controller/internal/identity 5.211s ok github.com/novox/mesh-controller/internal/inventory 88.539s ok github.com/novox/mesh-controller/internal/lease 17.700s ok github.com/novox/mesh-controller/internal/licences 4.806s ok github.com/novox/mesh-controller/internal/licences/adapters 1.010s ok github.com/novox/mesh-controller/internal/link 60.235s ok github.com/novox/mesh-controller/internal/lint 2.412s ok github.com/novox/mesh-controller/internal/outward 1.049s ok github.com/novox/mesh-controller/internal/overlay 1.030s ok github.com/novox/mesh-controller/internal/secrets 1.532s ok github.com/novox/mesh-controller/internal/store 3.392s ok github.com/novox/mesh-controller/internal/testbus 1.195s ok github.com/novox/mesh-controller/internal/token 1.022s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.39s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.37s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.38s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.35s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.22s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s) ```
Author
Contributor

Second commit (61d00a2): the first head's mesh/repo-check failed in TestASeatsVerbGainsTheArgumentsTheBinaryNames. It is a store test, so it was skipped locally without MESH_TEST_POSTGRES. It and serviceManagerHolder() in cmd/mesh-controller/seat_dependencies_test.go built a systemd holder serving only the eight verbs from before issue 332, which the seat now refuses. Both holders now serve the three required verbs.

The same run also named TestAVerbsOwnProcessNamesItsConnection. It passed 5 of 5 times under -race here. I think it was flaky in that run, because the change does not touch it.

The whole merge-check.sh then passed against a throwaway postgres, store tests included. At 61d00a2, mesh/merge-gate, mesh/repo-check and mesh/delivery are green.

Second commit (61d00a2): the first head's `mesh/repo-check` failed in `TestASeatsVerbGainsTheArgumentsTheBinaryNames`. It is a store test, so it was skipped locally without `MESH_TEST_POSTGRES`. It and `serviceManagerHolder()` in `cmd/mesh-controller/seat_dependencies_test.go` built a `systemd` holder serving only the eight verbs from before issue 332, which the seat now refuses. Both holders now serve the three required verbs. The same run also named `TestAVerbsOwnProcessNamesItsConnection`. It passed 5 of 5 times under `-race` here. I think it was flaky in that run, because the change does not touch it. The whole `merge-check.sh` then passed against a throwaway postgres, store tests included. At 61d00a2, `mesh/merge-gate`, `mesh/repo-check` and `mesh/delivery` are green.
Author
Contributor

Verdict: approve at 61d00a2

  • Scope matches issue 332 / ADR 0246 step 3: internal/catalogue/seats.go drops Optional on reset-failed, wanted-by and unlink-dangling; failed stays optional, as the PR body says.
  • Step 3's precondition (every holder serves all three today) holds, checked directly rather than taken on the PR's word: node-service-manager is held only by the systemd module on all four nodes (ace, g14, novox, shanks), and mesh_machine shows all three verbs answering live on each — not just unlink-dangling, which is as far as the PR body's own check went (it says discovery for reset-failed/wanted-by on ace, novox and shanks was incomplete). mesh-catalog main's modules/systemd/module.json claims the same twelve verbs. No holder would lose the seat at rollout.
  • mesh/merge-gate (pass: builds ace/g14/novox/shanks, every machine composes with the change) and mesh/repo-check (its merge-check.sh passed) are both green on 61d00a2.
  • Verified the test is real: on origin/main with only this PR's test files applied and seats.go left untouched, TestResetFailedWantedByAndUnlinkDanglingAreRequiredVerbsOfTheServiceManager fails with "a holder serving only the nine verbs before issue 332 holds the seat" — it does fail without the fix.
  • Fresh clone at 61d00a2: go vet ./... clean, gofmt -l clean, make check (full suite under the race detector, plus every test in testdata/store-tests against a throwaway Postgres) green end to end.
  • TestAVerbsOwnProcessNamesItsConnection is flaky, but not on account of this change: 1 failure in 80 runs (-race -count=20, repeated four times), failing with the verb's connection was named ["mesh-controller"]. The cause is in closedNames (cmd/mesh-controller/replay327_test.go): it returns as soon as the bus's closed-connections list is non-empty, which can be the setup connection's own close rather than the verb subprocess's — a pre-existing race in test plumbing, unrelated to catalogue/seats.go.

Side note, not a reason to hold this: the issue's own record shows mesh-controller#160 (ADR 0246 step 1, the optional promise for unlink-dangling) merged but not delivered (superseded), already flagged stuck separately. The live check above shows unlink-dangling answering on every node regardless, so step 2's precondition is met in fact — worth reconciling the tracker's bookkeeping on its own, but it does not block requiring the verb here.

Verdict: approve at 61d00a2 - Scope matches issue 332 / ADR 0246 step 3: `internal/catalogue/seats.go` drops `Optional` on `reset-failed`, `wanted-by` and `unlink-dangling`; `failed` stays optional, as the PR body says. - Step 3's precondition (every holder serves all three today) holds, checked directly rather than taken on the PR's word: `node-service-manager` is held only by the `systemd` module on all four nodes (ace, g14, novox, shanks), and `mesh_machine` shows all three verbs answering live on each — not just `unlink-dangling`, which is as far as the PR body's own check went (it says discovery for `reset-failed`/`wanted-by` on ace, novox and shanks was incomplete). `mesh-catalog` main's `modules/systemd/module.json` claims the same twelve verbs. No holder would lose the seat at rollout. - `mesh/merge-gate` (pass: builds ace/g14/novox/shanks, every machine composes with the change) and `mesh/repo-check` (its `merge-check.sh` passed) are both green on 61d00a2. - Verified the test is real: on `origin/main` with only this PR's test files applied and `seats.go` left untouched, `TestResetFailedWantedByAndUnlinkDanglingAreRequiredVerbsOfTheServiceManager` fails with "a holder serving only the nine verbs before issue 332 holds the seat" — it does fail without the fix. - Fresh clone at 61d00a2: `go vet ./...` clean, `gofmt -l` clean, `make check` (full suite under the race detector, plus every test in `testdata/store-tests` against a throwaway Postgres) green end to end. - `TestAVerbsOwnProcessNamesItsConnection` is flaky, but not on account of this change: 1 failure in 80 runs (`-race -count=20`, repeated four times), failing with `the verb's connection was named ["mesh-controller"]`. The cause is in `closedNames` (`cmd/mesh-controller/replay327_test.go`): it returns as soon as the bus's closed-connections list is non-empty, which can be the setup connection's own close rather than the verb subprocess's — a pre-existing race in test plumbing, unrelated to `catalogue/seats.go`. Side note, not a reason to hold this: the issue's own record shows mesh-controller#160 (ADR 0246 step 1, the optional promise for `unlink-dangling`) merged but not delivered (superseded), already flagged stuck separately. The live check above shows `unlink-dangling` answering on every node regardless, so step 2's precondition is met in fact — worth reconciling the tracker's bookkeeping on its own, but it does not block requiring the verb here.
mesh-admin merged commit fafa3fd9ef into main 2026-10-12 10:53:21 +00:00
mesh-admin deleted branch fix/332-require-service-manager-verbs 2026-10-12 10:53:21 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#248