The forge's tests compose its code as a bundle the node's runtime serves (hq ADR 0198, to-be 38 WP4c) #254

Merged
mesh-admin merged 1 commits from feat/0198-waves-2-3-the-forges-code-is-a-bundle into main 2026-10-03 23:01:17 +00:00
Contributor

Test-only change, paired with mesh-catalog #248 (hq to-be 38 WP4c waves 2-3, stacked on mesh-catalog #245).

Three tests in foundation_manifests_test.go compose gitea from the catalogue beside this checkout:

  • TestTheForgesOwnAddressFollowsThePortTheNodeGaveIt
  • TestTheForgesSshPortIsTheMeshsFixedConventionByDefault
  • TestANodeMayGiveTheForgesSshPortADifferentNumber

They resolved its build as a runtime image and read MESH_GITEA_URL from a gitea.runtime sidecar. gitea's code is now a code bundle the node's runtime serves. The tests therefore:

  • resolve the bundle;
  • compose it beside the runtime, with an artifact store;
  • read the forge's address from the words the runtime hands the module (MESH_TOOL_ENV).

What they hold is unchanged: the code dials the port the node gave the forge, and ssh is published at 222 or at the node's number.

Merge together with mesh-catalog #248. Against a catalogue where gitea still has its container, these three fail. Against the new catalogue, the old versions fail.

go test ./internal/catalogue/... ./cmd/mesh-controller/ passes with #248's catalogue as the sibling, store-backed. The one failure is the known unrelated TestTheResolverIsToldEveryMachineOnTheNetworkAndToldAgainWhenOneLeaves.

Test-only change, paired with mesh-catalog #248 (hq to-be 38 WP4c waves 2-3, stacked on mesh-catalog #245). Three tests in `foundation_manifests_test.go` compose gitea from the catalogue beside this checkout: - `TestTheForgesOwnAddressFollowsThePortTheNodeGaveIt` - `TestTheForgesSshPortIsTheMeshsFixedConventionByDefault` - `TestANodeMayGiveTheForgesSshPortADifferentNumber` They resolved its build as a `runtime` image and read `MESH_GITEA_URL` from a `gitea.runtime` sidecar. gitea's code is now a `code` bundle the node's runtime serves. The tests therefore: - resolve the bundle; - compose it beside the runtime, with an artifact store; - read the forge's address from the words the runtime hands the module (`MESH_TOOL_ENV`). What they hold is unchanged: the code dials the port the node gave the forge, and ssh is published at 222 or at the node's number. **Merge together with mesh-catalog #248.** Against a catalogue where gitea still has its container, these three fail. Against the new catalogue, the old versions fail. `go test ./internal/catalogue/... ./cmd/mesh-controller/` passes with #248's catalogue as the sibling, store-backed. The one failure is the known unrelated `TestTheResolverIsToldEveryMachineOnTheNetworkAndToldAgainWhenOneLeaves`.
mesh-admin added 1 commit 2026-10-03 22:51:21 +00:00
gitea's own code moves out of its runtime container (mesh-catalog, to-be 38 WP4c waves 2-3), so the three tests that composed the forge from the catalogue beside this checkout resolve its build as the code bundle, compose it beside the node's runtime, and read the forge's address from the words the runtime hands the module rather than from a sidecar's env.
mesh-admin merged commit 00037608ae into main 2026-10-03 23:01:17 +00:00
mesh-admin deleted branch feat/0198-waves-2-3-the-forges-code-is-a-bundle 2026-10-03 23:01:17 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#254