The node-reads seat: its verbs, its holder's own account, and the node's secret places (hq ADR 0310, issue 418) #257

Merged
mesh-admin merged 2 commits from fix/418-node-reads into main 2026-10-12 13:20:24 +00:00
Contributor

What (internal/catalogue/reads.go):

  • The seat node-reads (node scope, delivers nothing, decision ADR 0310), with six verbs. Each verb states its bounds and what it replaces (ADR 0245):

    • stat: stat, ls -ld, namei -l, findmnt -T
    • readlink: readlink, readlink -f, realpath
    • list: ls, ls -la
    • read: cat, head, tail, less
    • search: grep, grep -r, grep -F
    • account: getent passwd, getent group, id, groups

    The verbs are not optional: a new seat has no older holder to deadlock with. The store gets the seat through the existing additive seeding.

  • Its holder runs as an account of its own (ADR 0310 §3). ReadsHolderProblems refuses at parse a manifest that claims node-reads without runs-as, because the machine's runtime runs as the operator's account.

  • The holder is told where its node keeps a secret (§5). Its own runtime (ADR 0259 §8) is given MESH_SECRET_PLACES, a JSON list built from the placed manifests:

    • the directory of every module's own secret;
    • every credential file a module is given;
    • every grant directory;
    • the keeps place;
    • every directory of the module that provides secret (the vault).

    The list is sorted, and a place under another is dropped. No other module is given it, and a module that sets the word itself is refused.

Why. Issue 418: no mesh tool read or searched a file, or looked up an account. Those reads went through the login shell's execute as the operator's account, and the approval mark on execute (ADR 0286 §44) waits for them.

Tests (reads_test.go; all three fail on main):

  • TestNodeReadsIsANodeSeatWhoseVerbsSayWhatTheyReplace: cat, grep, getent passwd, getent group, id, stat, readlink and ls each map to their verb.
  • TestAHolderOfNodeReadsWithoutAnAccountOfItsOwnIsRefused
  • TestTheHolderOfNodeReadsIsToldWhereItsNodeKeepsASecret: a vault, two modules of their own account, the runtime, and a module with a credential file and an own secret under the operator's home. The exact list is checked, and a module that is not the holder is not told.
  • The seat count goes from 40 to 41.

sh merge-check.sh passes locally (gofmt, vet, go test -race ./...). The store tests were skipped because MESH_TEST_POSTGRES was not set. A controller built from this head checks every catalogue manifest together with mesh-catalog's mesh-reads: 69 long-running resources without health, as kept.

Order. mesh-sdk #23 first (no dependency here), then this, then mesh-catalog's mesh-reads, which the running controller refuses (the seat is unknown to it). This is a controller rollout: merge only while mesh-controller.plans says done. It touches no file of #253, #254, #251 or #203.

Limits I chose.

  • The ADR's check "a node without a holder fails the merge gate's composition" is not built. If it were enforced now, every node would fail until mesh-reads is assigned everywhere. I propose it as a follow-up once all four nodes hold the seat.
  • The approval mark on execute (ADR 0286 §44) also follows, under issue 418.

Part of issue 418. Not merged.

**What** (`internal/catalogue/reads.go`): - **The seat `node-reads`** (node scope, delivers nothing, decision ADR 0310), with six verbs. Each verb states its bounds and what it replaces (ADR 0245): - `stat`: `stat`, `ls -ld`, `namei -l`, `findmnt -T` - `readlink`: `readlink`, `readlink -f`, `realpath` - `list`: `ls`, `ls -la` - `read`: `cat`, `head`, `tail`, `less` - `search`: `grep`, `grep -r`, `grep -F` - `account`: `getent passwd`, `getent group`, `id`, `groups` The verbs are not optional: a new seat has no older holder to deadlock with. The store gets the seat through the existing additive seeding. - **Its holder runs as an account of its own** (ADR 0310 §3). `ReadsHolderProblems` refuses at parse a manifest that claims `node-reads` without `runs-as`, because the machine's runtime runs as the operator's account. - **The holder is told where its node keeps a secret** (§5). Its own runtime (ADR 0259 §8) is given `MESH_SECRET_PLACES`, a JSON list built from the placed manifests: - the directory of every module's own secret; - every credential file a module is given; - every grant directory; - the `keeps` place; - every directory of the module that provides `secret` (the vault). The list is sorted, and a place under another is dropped. No other module is given it, and a module that sets the word itself is refused. **Why.** Issue 418: no mesh tool read or searched a file, or looked up an account. Those reads went through the login shell's `execute` as the operator's account, and the approval mark on `execute` (ADR 0286 §44) waits for them. **Tests** (`reads_test.go`; all three fail on main): - `TestNodeReadsIsANodeSeatWhoseVerbsSayWhatTheyReplace`: `cat`, `grep`, `getent passwd`, `getent group`, `id`, `stat`, `readlink` and `ls` each map to their verb. - `TestAHolderOfNodeReadsWithoutAnAccountOfItsOwnIsRefused` - `TestTheHolderOfNodeReadsIsToldWhereItsNodeKeepsASecret`: a vault, two modules of their own account, the runtime, and a module with a credential file and an own secret under the operator's home. The exact list is checked, and a module that is not the holder is not told. - The seat count goes from 40 to 41. `sh merge-check.sh` passes locally (gofmt, vet, `go test -race ./...`). The store tests were skipped because `MESH_TEST_POSTGRES` was not set. A controller built from this head checks every catalogue manifest together with mesh-catalog's `mesh-reads`: 69 long-running resources without health, as kept. **Order.** mesh-sdk #23 first (no dependency here), then this, then mesh-catalog's `mesh-reads`, which the running controller refuses (the seat is unknown to it). This is a controller rollout: merge only while `mesh-controller.plans` says done. It touches no file of #253, #254, #251 or #203. **Limits I chose.** - The ADR's check "a node without a holder fails the merge gate's composition" is not built. If it were enforced now, every node would fail until `mesh-reads` is assigned everywhere. I propose it as a follow-up once all four nodes hold the seat. - The approval mark on `execute` (ADR 0286 §44) also follows, under issue 418. Part of issue 418. Not merged.
mesh-admin added 1 commit 2026-10-12 12:05:11 +00:00
Define the node-reads seat, refuse a holder without an account of its own, and tell it where its node keeps a secret (hq ADR 0310, issue 418)
mesh/delivery-group group fix/418-node-reads rejected: a member's own check failed
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
4ead5a3df7
Reading a file, searching one, listing a directory, the owner and mode of each
component of a path and looking up an account had no mesh tool, so they went
through the login shell's execute as the operator's account. node-reads is a
node seat with six verbs, each saying the commands it replaces. Its holder must
run as an account of its own (ADR 0310 §3), and its own runtime is given
MESH_SECRET_PLACES: the directory of every module's own secret, every credential
file and grant directory, the vault's directories and the sealed-secret keep,
so it refuses them by name before any read (§5).
Author
Contributor

Delivery novox/mesh-controller@63a99d43237f — delivered since 2026-10-12T13:27:40Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Group fix/418-node-reads, in order: novox/mesh-controller@63a99d4323 → novox/mesh-sdk@67bfa22132

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m37s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m6s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-12 12:30 (new) → proposed (announced): novox/mesh-controller#257's head announced
  • 2026-10-12 12:36 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 13:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 13:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 13:27 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@63a99d43237f` — **delivered** since 2026-10-12T13:27:40Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Group** `fix/418-node-reads`, in order: novox/mesh-controller@63a99d43237f → novox/mesh-sdk@67bfa22132f2 - novox/mesh-controller@63a99d43237f before novox/mesh-sdk@67bfa22132f2: built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m37s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m6s - build-agent on the rest running it: sent **Transitions** - 2026-10-12 12:30 (new) → proposed (announced): novox/mesh-controller#257's head announced - 2026-10-12 12:36 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 13:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 13:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 13:27 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 4ead5a3d

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: internal/catalogue/reads_test.go, internal/catalogue/seats_test.go

Run by the build seat on g14 as build-1791806741038426919 (builds --log build-1791806741038426919).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:01:38Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:01:38Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/catalogue/reads_test.go and internal/catalogue/seats_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.033s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	253.319s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.012s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.021s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.016s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.162s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.052s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.964s
ok  	github.com/novox/mesh-controller/internal/builder	14.597s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.990s
ok  	github.com/novox/mesh-controller/internal/conditions	2.452s
ok  	github.com/novox/mesh-controller/internal/envfile	1.038s
ok  	github.com/novox/mesh-controller/internal/facts	1.037s
ok  	github.com/novox/mesh-controller/internal/identity	4.226s
ok  	github.com/novox/mesh-controller/internal/inventory	85.013s
ok  	github.com/novox/mesh-controller/internal/lease	17.700s
ok  	github.com/novox/mesh-controller/internal/licences	3.876s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.013s
ok  	github.com/novox/mesh-controller/internal/link	59.207s
ok  	github.com/novox/mesh-controller/internal/lint	2.171s
ok  	github.com/novox/mesh-controller/internal/outward	1.041s
ok  	github.com/novox/mesh-controller/internal/overlay	1.031s
ok  	github.com/novox/mesh-controller/internal/secrets	1.444s
ok  	github.com/novox/mesh-controller/internal/store	3.258s
ok  	github.com/novox/mesh-controller/internal/testbus	1.188s
ok  	github.com/novox/mesh-controller/internal/token	1.019s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.37s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.31s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.37s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.27s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.35s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.36s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.43s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.35s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.41s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.22s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.23s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.22s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s)
**Merge check** at `4ead5a3d` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: internal/catalogue/reads_test.go, internal/catalogue/seats_test.go Run by the build seat on g14 as `build-1791806741038426919` (`builds --log build-1791806741038426919`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:01:38Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:01:38Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/catalogue/reads_test.go and internal/catalogue/seats_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.033s ok github.com/novox/mesh-controller/cmd/mesh-controller 253.319s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.012s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.021s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.016s ok github.com/novox/mesh-controller/examples/route-proxy 1.162s ok github.com/novox/mesh-controller/internal/artifacts 1.052s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.964s ok github.com/novox/mesh-controller/internal/builder 14.597s ok github.com/novox/mesh-controller/internal/catalogue 6.990s ok github.com/novox/mesh-controller/internal/conditions 2.452s ok github.com/novox/mesh-controller/internal/envfile 1.038s ok github.com/novox/mesh-controller/internal/facts 1.037s ok github.com/novox/mesh-controller/internal/identity 4.226s ok github.com/novox/mesh-controller/internal/inventory 85.013s ok github.com/novox/mesh-controller/internal/lease 17.700s ok github.com/novox/mesh-controller/internal/licences 3.876s ok github.com/novox/mesh-controller/internal/licences/adapters 1.013s ok github.com/novox/mesh-controller/internal/link 59.207s ok github.com/novox/mesh-controller/internal/lint 2.171s ok github.com/novox/mesh-controller/internal/outward 1.041s ok github.com/novox/mesh-controller/internal/overlay 1.031s ok github.com/novox/mesh-controller/internal/secrets 1.444s ok github.com/novox/mesh-controller/internal/store 3.258s ok github.com/novox/mesh-controller/internal/testbus 1.188s ok github.com/novox/mesh-controller/internal/token 1.019s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.37s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.36s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.31s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.37s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.27s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.35s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.36s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.43s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.35s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.41s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.22s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.23s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.22s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s) ```
mesh-admin left a comment
Author
Contributor

Verdict: request changes at 4ead5a3df7

Independent review for issue 418 (ADR 0310). go vet ./... is clean and go test -race ./... passes in every package. The seat definition is sound:

  • It is a node seat with six verbs, none optional, each saying what it replaces.
  • ReadsHolderProblems refuses a holder without runs-as.
  • ownRuntimes already refuses the operator's and the agent's accounts, and RunsAsProblems refuses root.
  • MESH_SECRET_PLACES goes only to the holder, and the holder cannot set it itself.

I built the controller from this head and ran mesh-catalog's merge-check.sh on the catalogue PR (MESH_GATE=<that controller> MESH_CHECK_MODULES=mesh-reads). It passes. The catalogue PR's red checks are therefore this seat missing from the running controller, as its description says.

Required: the vault's directories are not in MESH_SECRET_PLACES on a real node. secretPlaces adds a directory of the module that provides secret only from res["path"]. The real modules/mesh-vault/module.json declares state (place: "."), grants, ledger and root without a path. So:

  • ledger (/var/lib/mesh-vault/ledger) and the vault's state root are left out.
  • root is covered only because keeps repeats it as an absolute path.
  • grants is covered only through Grants.

ADR 0310 §5 promises "the vault's directories" by name. The test passes only because its vault manifest states explicit paths. Fix: resolve the provider's directories with dirsFor(m, with) (pass with into secretPlaces). Then change the test's vault to the real shape (pathless, place: "."), so the test fails on the current code.

Required: failure must be loud. add drops, without a word, any path that still holds ${, and so would Keeps if it ever used ${dir:…} (placedManifest does not fill Keeps). A secret place the controller cannot resolve should fail the composition with the module named, not shrink the list.

Should, not blocking:

  • ADR 0310 §3 says the account is "in no group that holds secrets". Only the module's own manifest test checks this today. ReadsHolderProblems could refuse a user resource with groups for a node-reads holder, so the rule is checked where the seat is defined (a module that added docker would be root-equivalent).
  • After rollout, the acceptance check is the composed MESH_SECRET_PLACES on novox, the control-node. It should list the controller's own secret directory, the vault's four directories and the bus server's credentials. I could not check whether the controller and nats manifests declare these as own-secrets or secrets, so that check is the proof.
  • ADR 0310 §1 says the tool runner (mesh-tools) holds the seat. The build holds it in a separate module, mesh-reads, served by the tool runner in a runtime of its own. I agree with the build, because runs-as needs a module of its own. The record should get a progressive insight saying so.

Merge order: mesh-sdk #23, then this PR, then wait for the rollout to say done, then the catalogue module.

Verdict: request changes at 4ead5a3df76cf9deca3e8e8aff6a0418e6d33173 Independent review for issue 418 (ADR 0310). `go vet ./...` is clean and `go test -race ./...` passes in every package. The seat definition is sound: - It is a node seat with six verbs, none optional, each saying what it replaces. - `ReadsHolderProblems` refuses a holder without `runs-as`. - `ownRuntimes` already refuses the operator's and the agent's accounts, and `RunsAsProblems` refuses root. - `MESH_SECRET_PLACES` goes only to the holder, and the holder cannot set it itself. I built the controller from this head and ran mesh-catalog's `merge-check.sh` on the catalogue PR (`MESH_GATE=<that controller> MESH_CHECK_MODULES=mesh-reads`). It passes. The catalogue PR's red checks are therefore this seat missing from the running controller, as its description says. **Required: the vault's directories are not in `MESH_SECRET_PLACES` on a real node.** `secretPlaces` adds a directory of the module that provides `secret` only from `res["path"]`. The real `modules/mesh-vault/module.json` declares `state` (`place: "."`), `grants`, `ledger` and `root` without a path. So: - `ledger` (`/var/lib/mesh-vault/ledger`) and the vault's state root are left out. - `root` is covered only because `keeps` repeats it as an absolute path. - `grants` is covered only through `Grants`. ADR 0310 §5 promises "the vault's directories" by name. The test passes only because its vault manifest states explicit paths. Fix: resolve the provider's directories with `dirsFor(m, with)` (pass `with` into `secretPlaces`). Then change the test's vault to the real shape (pathless, `place: "."`), so the test fails on the current code. **Required: failure must be loud.** `add` drops, without a word, any path that still holds `${`, and so would `Keeps` if it ever used `${dir:…}` (`placedManifest` does not fill `Keeps`). A secret place the controller cannot resolve should fail the composition with the module named, not shrink the list. **Should, not blocking:** - ADR 0310 §3 says the account is "in no group that holds secrets". Only the module's own manifest test checks this today. `ReadsHolderProblems` could refuse a `user` resource with `groups` for a node-reads holder, so the rule is checked where the seat is defined (a module that added `docker` would be root-equivalent). - After rollout, the acceptance check is the composed `MESH_SECRET_PLACES` on novox, the control-node. It should list the controller's own secret directory, the vault's four directories and the bus server's credentials. I could not check whether the controller and nats manifests declare these as own-secrets or secrets, so that check is the proof. - ADR 0310 §1 says the tool runner (`mesh-tools`) holds the seat. The build holds it in a separate module, `mesh-reads`, served by the tool runner in a runtime of its own. I agree with the build, because `runs-as` needs a module of its own. The record should get a progressive insight saying so. Merge order: mesh-sdk #23, then this PR, then wait for the rollout to say done, then the catalogue module.
jschoubben added 1 commit 2026-10-12 12:30:03 +00:00
Name the vault's placed directories among a node's secret places, fail loudly on one that cannot be resolved, and keep the reads account out of every group (review 54, issue 418)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
mesh/delivery-group group fix/418-node-reads merged: every member is merged
63a99d4323
The real mesh-vault manifest declares its directories without a path, so the
list left its state and ledger out, and a place still holding a placeholder
vanished from it without a word. The provider's directories are now resolved
where the node places them, an unresolved place fails the composition naming
the module, and a node-reads holder whose account is put in a group is refused.
Author
Contributor

Merge check at 63a99d43

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: internal/catalogue/reads_test.go, internal/catalogue/seats_test.go

Run by the build seat on ace as build-1791808234353487246 (builds --log build-1791808234353487246).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:29:08Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/catalogue/reads_test.go and internal/catalogue/seats_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.045s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	231.178s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.125s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.036s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.031s
ok  	github.com/novox/mesh-controller/internal/builder	15.753s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.466s
ok  	github.com/novox/mesh-controller/internal/conditions	2.664s
ok  	github.com/novox/mesh-controller/internal/envfile	1.059s
ok  	github.com/novox/mesh-controller/internal/facts	1.097s
ok  	github.com/novox/mesh-controller/internal/identity	4.480s
ok  	github.com/novox/mesh-controller/internal/inventory	86.027s
ok  	github.com/novox/mesh-controller/internal/lease	17.724s
ok  	github.com/novox/mesh-controller/internal/licences	4.099s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.057s
ok  	github.com/novox/mesh-controller/internal/link	59.212s
ok  	github.com/novox/mesh-controller/internal/lint	2.342s
ok  	github.com/novox/mesh-controller/internal/outward	1.078s
ok  	github.com/novox/mesh-controller/internal/overlay	1.111s
ok  	github.com/novox/mesh-controller/internal/secrets	1.505s
ok  	github.com/novox/mesh-controller/internal/store	3.477s
ok  	github.com/novox/mesh-controller/internal/testbus	1.280s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.37s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.34s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.41s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.29s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.40s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.36s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.44s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.41s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.22s)
**Merge check** at `63a99d43` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: internal/catalogue/reads_test.go, internal/catalogue/seats_test.go Run by the build seat on ace as `build-1791808234353487246` (`builds --log build-1791808234353487246`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:29:08Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/catalogue/reads_test.go and internal/catalogue/seats_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.045s ok github.com/novox/mesh-controller/cmd/mesh-controller 231.178s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.014s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.019s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.125s ok github.com/novox/mesh-controller/internal/artifacts 1.036s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.031s ok github.com/novox/mesh-controller/internal/builder 15.753s ok github.com/novox/mesh-controller/internal/catalogue 7.466s ok github.com/novox/mesh-controller/internal/conditions 2.664s ok github.com/novox/mesh-controller/internal/envfile 1.059s ok github.com/novox/mesh-controller/internal/facts 1.097s ok github.com/novox/mesh-controller/internal/identity 4.480s ok github.com/novox/mesh-controller/internal/inventory 86.027s ok github.com/novox/mesh-controller/internal/lease 17.724s ok github.com/novox/mesh-controller/internal/licences 4.099s ok github.com/novox/mesh-controller/internal/licences/adapters 1.057s ok github.com/novox/mesh-controller/internal/link 59.212s ok github.com/novox/mesh-controller/internal/lint 2.342s ok github.com/novox/mesh-controller/internal/outward 1.078s ok github.com/novox/mesh-controller/internal/overlay 1.111s ok github.com/novox/mesh-controller/internal/secrets 1.505s ok github.com/novox/mesh-controller/internal/store 3.477s ok github.com/novox/mesh-controller/internal/testbus 1.280s ok github.com/novox/mesh-controller/internal/token 1.017s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.37s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.34s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.41s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.29s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.40s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.36s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.44s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.41s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.22s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 63a99d4323

Re-review against review 54. go vet ./... is clean, go test -race -count=1 ./... passes in every package, and the forge's mesh/merge-gate and mesh/repo-check are green at this head.

  • The vault's directories are now listed. secretPlaces resolves the secret provider's directories with dirsFor(m, with). The test now places the real mesh-vault manifest and expects /var/lib/mesh-vault. I checked it independently: I parsed and placed all 127 catalogue manifests from mesh-catalog #247's tree, and secretPlaces returns no error for any single module or for all of them together. The list includes /var/lib/mesh-vault, /var/lib/mesh-reads, /var/lib/mesh/nats, /var/lib/mesh/registry, /var/lib/mesh/step-ca, every module's grant directory and every *.secret file. So the loud failure does not break any current module's composition.
  • An unresolvable place now fails loudly. A place still holding ${, a relative path or / fails the composition, naming the module and the field. TestASecretPlaceThatCannotBeResolvedFailsTheComposition covers this.
  • The reads account is kept out of groups. ReadsHolderProblems now refuses a node-reads holder whose user resource puts the account in groups (TestTheReadsAccountIsInNoGroup).

I built the controller from this head. mesh-catalog #247's merge-check.sh (MESH_GATE=<it> MESH_CHECK_MODULES=mesh-reads) passes with exit 0. #247's red checks are the running controller lacking the seat.

Still open, not blocking:

  • The acceptance check after rollout is the composed MESH_SECRET_PLACES on novox, the control-node.
  • ADR 0310 §1's wording ("held by the tool runner") should get a progressive insight, since the holder is the separate module mesh-reads served by the tool runner.

Merge order: mesh-sdk #23, then this PR, then wait for mesh-controller.plans to say done, then mesh-catalog #247.

Verdict: approve at 63a99d43237f6d2c3aa6d90c585a32047d9fb5b8 Re-review against review 54. `go vet ./...` is clean, `go test -race -count=1 ./...` passes in every package, and the forge's `mesh/merge-gate` and `mesh/repo-check` are green at this head. - **The vault's directories are now listed.** `secretPlaces` resolves the secret provider's directories with `dirsFor(m, with)`. The test now places the real `mesh-vault` manifest and expects `/var/lib/mesh-vault`. I checked it independently: I parsed and placed all 127 catalogue manifests from mesh-catalog #247's tree, and `secretPlaces` returns no error for any single module or for all of them together. The list includes `/var/lib/mesh-vault`, `/var/lib/mesh-reads`, `/var/lib/mesh/nats`, `/var/lib/mesh/registry`, `/var/lib/mesh/step-ca`, every module's grant directory and every `*.secret` file. So the loud failure does not break any current module's composition. - **An unresolvable place now fails loudly.** A place still holding `${`, a relative path or `/` fails the composition, naming the module and the field. `TestASecretPlaceThatCannotBeResolvedFailsTheComposition` covers this. - **The reads account is kept out of groups.** `ReadsHolderProblems` now refuses a node-reads holder whose `user` resource puts the account in groups (`TestTheReadsAccountIsInNoGroup`). I built the controller from this head. mesh-catalog #247's `merge-check.sh` (`MESH_GATE=<it> MESH_CHECK_MODULES=mesh-reads`) passes with exit 0. #247's red checks are the running controller lacking the seat. Still open, not blocking: - The acceptance check after rollout is the composed `MESH_SECRET_PLACES` on novox, the control-node. - ADR 0310 §1's wording ("held by the tool runner") should get a progressive insight, since the holder is the separate module `mesh-reads` served by the tool runner. Merge order: mesh-sdk #23, then this PR, then wait for `mesh-controller.plans` to say done, then mesh-catalog #247.
mesh-admin merged commit 72edb458cc into main 2026-10-12 13:20:24 +00:00
mesh-admin deleted branch fix/418-node-reads 2026-10-12 13:20:24 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#257