Make no value for an own secret issued outside the mesh that nobody gave (issue 401) #262

Merged
mesh-admin merged 2 commits from fix/401-an-outside-secret-not-given-is-not-made into main 2026-10-12 15:48:12 +00:00
Contributor

Fixes issue 401 (the mesh makes a random value for an own secret issued outside the mesh that nobody gave). Decided 2026-10-11 under the operator's standing rule (issue 401's note): ADR 0228 decides it, and ADR 0283's "not given" for a family's member extends to a plain own secret issued outside. The operator sees the list below before this merges, because it changes what they see.

Affected today: which modules on which machines

Read-only, on 2026-10-12 ~14:25 local, through mesh-controller.command (node list, node show <node> for all four nodes, module list, hand-acts --days 365, which goes back to 2026-10-06), with the manifests from mesh-catalog main (2772120) and mesh-media-catalog main.

A plain own secret that says "issued-by": "outside", on a module assigned somewhere:

machine module secret given? today after this change
ace letta openai-api-key no give in the hand-act log and no secret-given condition I think a mesh-made random value: letta has run since 2026-10-07, so the send placed one No file at openai-api-key.secret; the node-engine removes the old one as no longer declared. server.env says OPENAI_API_KEY= (empty). letta's container names no restart-on for server.env, so letta keeps the random key in its environment until its next start. After that it runs without the OpenAI provider (a random key never worked with OpenAI anyway).
ace supabase openai the same the same No openai.secret; studio-env.env says OPENAI_API_KEY= (empty); supabase-studio restarts (it restarts on studio-env). Studio's AI assistant is off until a key is given.
ace nzbgeek api-key given at the desk on shanks, 2026-10-11 21:51 the given value unchanged

No other machine is affected: novox, shanks and g14 run no module with a plain own secret issued outside.

Unchanged:

  • Families were never made (ADR 0283): mounts smb-password-* on shanks and nzbget news-server-* on ace.
  • Secrets not marked outside are still made: telegram telegram-token on novox (given 2026-10-09, kept) and kometa tmdb on ace. kometa's tmdb is a TMDB key, so it is issued outside in fact. Marking it is a catalogue change and is not done here.

What the operator will see: no new condition. letta and supabase have no health tool, so neither says it waits; each stays healthy by its container state. For ADR 0283's needs-operator ("Needs you: type … at …'s desk prompt") to show, each module needs a health tool that answers waits. That is catalogue work (follow-up). The one notification this rollout raises is the usual push to ace.

Limit of the list: no controller verb says a module secret's origin (made or given). "Not given" above rests on the hand-act log, which goes back to 2026-10-06, and on the absence of a secret-given condition. A give before 2026-10-06 cannot be ruled out through verbs; if there was one, that module keeps its value unchanged. A verb that lists origins is a gap I did not fill here.

What changes

  • cmd/mesh-controller/plan.go: for a plain own secret issued outside, the composition reads only a value a person gave (inventory.GivenOwnSecret, origin = 'accepted'), on the send path and on every read path. It never calls SecretForModule for one, so nothing is minted. A value the mesh made for one earlier is not read as given. A value given under an old sealing key is refused on the send with the same words as a family's member (givenUnderAnOldKey, now shared by both).
  • internal/catalogue/declaration.go: when such a secret is not given, no file is placed (before: NotMadeError, which in practice never happened because the send had minted one), and nothing restarts on it (secretsReadBy).
  • internal/catalogue/secrets_into_files.go: where a module's file says ${secret:<name>} for such a secret and nobody gave it, the placeholder becomes empty (outsideNotGiven, intoFile). Without this, every module that names its outside secret in an env file (letta, supabase) would stop composing ace as a whole.
  • internal/inventory/secrets.go: GivenOwnSecret.

Design limit I chose: "the module is told it was not given" means no file and an empty value in a file that names it. An empty KEY= is what software reads as "not set". No row is deleted from the store: a made row for an outside secret is ignored, not removed, so nothing is destroyed and secret accept/give overwrites it as before.

How it was tested

  • internal/catalogue/outside_not_given_test.go: not given means no file, the env file says VENDOR_KEY=, it is filled only from the secret the mesh makes, and there is no restart-on. Given means placed, filled and restarted on. A secret the mesh makes that was not made is still a NotMadeError.
  • cmd/mesh-controller/outside_not_given_test.go (store-backed): the send makes no value and places none. A value made earlier with SecretForModule is not placed. After AcceptSecretForModule the given value is placed. Reading and Foreseeing compose without it, foresee nothing and write nothing.
  • All three new behaviour tests fail on main (checked by stashing the fix): "assistant needs a secret called "vendor-key" and none was made for it" and "a secret nobody gave was placed: …".
  • sh merge-check.sh against a throwaway PostgreSQL 17 passes on 62e8eac (gofmt, vet, go test -race ./... and the store tests). The head 5801ab7 only moves givenUnderAnOldKey up the file to stay clear of #253's hunks; build, vet and the catalogue tests pass on it.

Order

A controller rollout: merge only while mesh-controller.plans says done. This PR shares no file with #255 or #257. It shares plan.go with #253 and plan.go and declaration.go with #256, and merges cleanly with both (git merge-tree). It needs nothing from another repository.

Fixes issue 401.

Fixes issue 401 (the mesh makes a random value for an own secret issued outside the mesh that nobody gave). Decided 2026-10-11 under the operator's standing rule (issue 401's note): ADR 0228 decides it, and ADR 0283's "not given" for a family's member extends to a plain own secret issued outside. **The operator sees the list below before this merges**, because it changes what they see. ## Affected today: which modules on which machines Read-only, on 2026-10-12 ~14:25 local, through `mesh-controller.command` (`node list`, `node show <node>` for all four nodes, `module list`, `hand-acts --days 365`, which goes back to 2026-10-06), with the manifests from mesh-catalog main (2772120) and mesh-media-catalog main. A plain own secret that says `"issued-by": "outside"`, on a module assigned somewhere: | machine | module | secret | given? | today | after this change | |---|---|---|---|---|---| | ace | letta | `openai-api-key` | no give in the hand-act log and no `secret-given` condition | I think a mesh-made random value: letta has run since 2026-10-07, so the send placed one | No file at `openai-api-key.secret`; the node-engine removes the old one as no longer declared. `server.env` says `OPENAI_API_KEY=` (empty). letta's container names no `restart-on` for `server.env`, so letta keeps the random key in its environment until its next start. After that it runs without the OpenAI provider (a random key never worked with OpenAI anyway). | | ace | supabase | `openai` | the same | the same | No `openai.secret`; `studio-env.env` says `OPENAI_API_KEY=` (empty); `supabase-studio` restarts (it restarts on `studio-env`). Studio's AI assistant is off until a key is given. | | ace | nzbgeek | `api-key` | given at the desk on shanks, 2026-10-11 21:51 | the given value | unchanged | No other machine is affected: novox, shanks and g14 run no module with a plain own secret issued outside. **Unchanged:** - Families were never made (ADR 0283): mounts `smb-password-*` on shanks and nzbget `news-server-*` on ace. - Secrets not marked outside are still made: telegram `telegram-token` on novox (given 2026-10-09, kept) and kometa `tmdb` on ace. kometa's `tmdb` is a TMDB key, so it is issued outside in fact. Marking it is a catalogue change and is not done here. **What the operator will see:** no new condition. letta and supabase have no health tool, so neither says it waits; each stays healthy by its container state. For ADR 0283's `needs-operator` ("Needs you: type … at …'s desk prompt") to show, each module needs a health tool that answers `waits`. That is catalogue work (follow-up). The one notification this rollout raises is the usual push to ace. **Limit of the list:** no controller verb says a module secret's origin (made or given). "Not given" above rests on the hand-act log, which goes back to 2026-10-06, and on the absence of a `secret-given` condition. A give before 2026-10-06 cannot be ruled out through verbs; if there was one, that module keeps its value unchanged. A verb that lists origins is a gap I did not fill here. ## What changes - `cmd/mesh-controller/plan.go`: for a plain own secret issued outside, the composition reads only a value a person gave (`inventory.GivenOwnSecret`, `origin = 'accepted'`), on the send path and on every read path. It never calls `SecretForModule` for one, so nothing is minted. A value the mesh made for one earlier is not read as given. A value given under an old sealing key is refused on the send with the same words as a family's member (`givenUnderAnOldKey`, now shared by both). - `internal/catalogue/declaration.go`: when such a secret is not given, no file is placed (before: `NotMadeError`, which in practice never happened because the send had minted one), and nothing restarts on it (`secretsReadBy`). - `internal/catalogue/secrets_into_files.go`: where a module's file says `${secret:<name>}` for such a secret and nobody gave it, the placeholder becomes empty (`outsideNotGiven`, `intoFile`). Without this, every module that names its outside secret in an env file (letta, supabase) would stop composing ace as a whole. - `internal/inventory/secrets.go`: `GivenOwnSecret`. **Design limit I chose:** "the module is told it was not given" means no file and an empty value in a file that names it. An empty `KEY=` is what software reads as "not set". No row is deleted from the store: a made row for an outside secret is ignored, not removed, so nothing is destroyed and `secret accept`/`give` overwrites it as before. ## How it was tested - `internal/catalogue/outside_not_given_test.go`: not given means no file, the env file says `VENDOR_KEY=`, it is filled only from the secret the mesh makes, and there is no `restart-on`. Given means placed, filled and restarted on. A secret the mesh makes that was not made is still a `NotMadeError`. - `cmd/mesh-controller/outside_not_given_test.go` (store-backed): the send makes no value and places none. A value made earlier with `SecretForModule` is not placed. After `AcceptSecretForModule` the given value is placed. `Reading` and `Foreseeing` compose without it, foresee nothing and write nothing. - All three new behaviour tests fail on main (checked by stashing the fix): "assistant needs a secret called "vendor-key" and none was made for it" and "a secret nobody gave was placed: …". - `sh merge-check.sh` against a throwaway PostgreSQL 17 passes on 62e8eac (gofmt, vet, `go test -race ./...` and the store tests). The head 5801ab7 only moves `givenUnderAnOldKey` up the file to stay clear of #253's hunks; build, vet and the catalogue tests pass on it. ## Order A controller rollout: merge only while `mesh-controller.plans` says done. This PR shares no file with #255 or #257. It shares `plan.go` with #253 and `plan.go` and `declaration.go` with #256, and merges cleanly with both (`git merge-tree`). It needs nothing from another repository. Fixes issue 401.
Author
Contributor

Delivery novox/mesh-controller@c3b4f187e195 — failed since 2026-10-12T16:00:21Z

Covered: covered after its failure: a later walk that contains it was delivered: plan-1791826579427234545 (novox/mesh-controller at d8f36a8f into main, done, contains its merge 1e28342e)

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Machines

  • mesh-controller on novox: passed — healthy 3 times over 4m14s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: failed — ace failed what it was sent

Transitions

  • 2026-10-12 15:19 (new) → proposed (announced): novox/mesh-controller#262's head announced
  • 2026-10-12 15:27 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 15:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 15:48 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 15:48 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 16:00 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@c3b4f187e195` — **failed** since 2026-10-12T16:00:21Z **Covered**: covered after its failure: a later walk that contains it was delivered: plan-1791826579427234545 (novox/mesh-controller at d8f36a8f into main, done, contains its merge 1e28342e) **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine **Machines** - mesh-controller on novox: passed — healthy 3 times over 4m14s - mesh-controller on the rest running it: sent - build-agent on ace: failed — ace failed what it was sent **Transitions** - 2026-10-12 15:19 (new) → proposed (announced): novox/mesh-controller#262's head announced - 2026-10-12 15:27 proposed → checked (checked): the verdict names this commit - 2026-10-12 15:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 15:48 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 15:48 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 16:00 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 5801ab77

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go

Run by the build seat on shanks as build-1791809016016661389 (builds --log build-1791809016016661389).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:39:28Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:39:28Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.035s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	254.775s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.039s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.053s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.047s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.208s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.091s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.291s
ok  	github.com/novox/mesh-controller/internal/builder	18.242s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.666s
ok  	github.com/novox/mesh-controller/internal/conditions	2.635s
ok  	github.com/novox/mesh-controller/internal/envfile	1.048s
ok  	github.com/novox/mesh-controller/internal/facts	1.055s
ok  	github.com/novox/mesh-controller/internal/identity	4.774s
ok  	github.com/novox/mesh-controller/internal/inventory	95.976s
ok  	github.com/novox/mesh-controller/internal/lease	17.708s
ok  	github.com/novox/mesh-controller/internal/licences	4.286s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.048s
ok  	github.com/novox/mesh-controller/internal/link	60.850s
ok  	github.com/novox/mesh-controller/internal/lint	2.383s
ok  	github.com/novox/mesh-controller/internal/outward	1.085s
ok  	github.com/novox/mesh-controller/internal/overlay	1.070s
ok  	github.com/novox/mesh-controller/internal/secrets	1.538s
ok  	github.com/novox/mesh-controller/internal/store	3.453s
ok  	github.com/novox/mesh-controller/internal/testbus	1.261s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.41s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.39s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.37s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.43s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.31s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.45s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.44s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.41s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.46s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.45s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.25s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.28s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.26s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.24s)
**Merge check** at `5801ab77` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go Run by the build seat on shanks as `build-1791809016016661389` (`builds --log build-1791809016016661389`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:39:28Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:39:28Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.035s ok github.com/novox/mesh-controller/cmd/mesh-controller 254.775s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.039s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.053s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.047s ok github.com/novox/mesh-controller/examples/route-proxy 1.208s ok github.com/novox/mesh-controller/internal/artifacts 1.091s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.291s ok github.com/novox/mesh-controller/internal/builder 18.242s ok github.com/novox/mesh-controller/internal/catalogue 7.666s ok github.com/novox/mesh-controller/internal/conditions 2.635s ok github.com/novox/mesh-controller/internal/envfile 1.048s ok github.com/novox/mesh-controller/internal/facts 1.055s ok github.com/novox/mesh-controller/internal/identity 4.774s ok github.com/novox/mesh-controller/internal/inventory 95.976s ok github.com/novox/mesh-controller/internal/lease 17.708s ok github.com/novox/mesh-controller/internal/licences 4.286s ok github.com/novox/mesh-controller/internal/licences/adapters 1.048s ok github.com/novox/mesh-controller/internal/link 60.850s ok github.com/novox/mesh-controller/internal/lint 2.383s ok github.com/novox/mesh-controller/internal/outward 1.085s ok github.com/novox/mesh-controller/internal/overlay 1.070s ok github.com/novox/mesh-controller/internal/secrets 1.538s ok github.com/novox/mesh-controller/internal/store 3.453s ok github.com/novox/mesh-controller/internal/testbus 1.261s ok github.com/novox/mesh-controller/internal/token 1.017s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.42s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.41s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.39s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.37s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.43s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.31s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.45s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.44s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.41s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.46s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.45s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.25s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.28s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.26s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.24s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 5801ab7

Independent review for issue 401 (the mesh makes a random value for an own secret issued outside the mesh that nobody gave).

No given value is dropped. The store tells given from made by module_secret.origin. Every path a person gives through (AcceptGivenSecret and AcceptSecretForModule, both via acceptOwn) writes origin = 'accepted'. Only SecretForModule, remakeOwn and remakeShared write 'made'. For an outside secret none of them can overwrite a given value: rotation refuses it (RotateModuleSecret), the replace-after-start sweep in given.go re-checks MeshMayMake(), which is false for outside, and SecretForModule returns early on a current row and refuses an accepted row under an old key. On rows older than the column: migration 0013 (2026-08-31 00:32) gave every existing row 'made'. AcceptSecretForModule first appeared 4 hours earlier (0262873), and its only caller then was the builder's broker, which is not marked outside. The issued-by marker and the replace-after-start rule both arrived on 2026-10-06 (e51c6a2), and letta's and supabase's marks also arrived that day (mesh-catalog b1bd5c8). So no value given before the origin column can belong to an outside secret, and GivenOwnSecret's origin = 'accepted' filter cannot miss a real give. No rows are deleted.

No other kind of secret is affected. The new branch in renderingFor is gated on own.IssuedBy == IssuedOutside. compose, secretsReadBy and intoFile change only for an outside secret with an empty value. Secrets the mesh makes still go through SecretForModule, ModuleSecretIfIssued or WouldMakeSecretForModule as before. TestAnOwnSecretTheMeshMakesIsStillRefusedWhenNotMade keeps the NotMadeError for them. On today's catalogues no outside secret is a provision's shared credential (ProvisionsSharing): only letta, supabase, mounts (a family), nzbgeek and nzbget are marked outside, and none names one as credential.own. So remakeShared cannot hand a consumer a value the provider no longer gets.

No restart loop. The empty substitution is the same on every compose, so supabase-studio's restart-on: studio-env fires once, when the file changes, and then holds still. secretsReadBy drops the not-given secret from what restarts, so nothing restarts on a file that is not placed.

Composition elsewhere is unharmed. Only env files name these secrets (letta server.env, supabase studio-env.env), and KEY= is valid there. intoFile now always writes content back, but the content is unchanged unless a placeholder was emptied. It leaves out secrets when nothing remains, so a file with no placeholder left carries no secrets map. Nothing on the foreseen path changes: the outside branch continues before it.

The old made rows are never sent. Send, Reading and Foreseeing all take the outside branch before any read of an unfiltered row. TestTheSendMakesNoValueForAnOutsideSecretNobodyGave covers a row made earlier with SecretForModule.

Verified locally.

  • sh merge-check.sh at 5801ab7 against a throwaway PostgreSQL 18 exits 0: gofmt, go vet, go test -race ./... (26 packages ok) and every listed store test PASS.
  • The 5 new tests pass at head, the 2 store-backed ones included.
  • On main with only the test files (plus GivenOwnSecret, so they build), all three behaviour tests fail with the expected messages: "assistant needs a secret called "vendor-key" and none was made for it", "a secret nobody gave was placed: …" and "a secret nobody gave is composed".
  • Required checks at 5801ab7, both read: mesh/merge-gate success ("every machine composes with the change as it did without") and mesh/repo-check success.

Non-blocking.

  1. TestTheSendMakesNoValueForAnOutsideSecretNobodyGave and TestAQuestionComposesWithoutAnOutsideSecretNobodyGave need the store, but they are not in testdata/store-tests, which merge-check.sh says a pull request adds its own store tests to (issue 459). Without a store they skip and the skip passes unseen. Please add them in a follow-up, or here if the head moves anyway.
  2. No test covers the refusal for an outside secret given under an old sealing key (givenUnderAnOldKey on the send, skipped on a read). The code is shared with the family path and reads correctly.
  3. As the PR body says, letta and supabase show no "waits" until each has a health tool. The operator sees nothing new except the push to ace and one supabase-studio restart.
Verdict: approve at 5801ab7 Independent review for issue 401 (the mesh makes a random value for an own secret issued outside the mesh that nobody gave). **No given value is dropped.** The store tells given from made by `module_secret.origin`. Every path a person gives through (`AcceptGivenSecret` and `AcceptSecretForModule`, both via `acceptOwn`) writes `origin = 'accepted'`. Only `SecretForModule`, `remakeOwn` and `remakeShared` write `'made'`. For an outside secret none of them can overwrite a given value: rotation refuses it (`RotateModuleSecret`), the replace-after-start sweep in given.go re-checks `MeshMayMake()`, which is false for outside, and `SecretForModule` returns early on a current row and refuses an accepted row under an old key. On rows older than the column: migration 0013 (2026-08-31 00:32) gave every existing row `'made'`. `AcceptSecretForModule` first appeared 4 hours earlier (0262873), and its only caller then was the builder's `broker`, which is not marked outside. The `issued-by` marker and the replace-after-start rule both arrived on 2026-10-06 (e51c6a2), and letta's and supabase's marks also arrived that day (mesh-catalog b1bd5c8). So no value given before the origin column can belong to an outside secret, and `GivenOwnSecret`'s `origin = 'accepted'` filter cannot miss a real give. No rows are deleted. **No other kind of secret is affected.** The new branch in `renderingFor` is gated on `own.IssuedBy == IssuedOutside`. `compose`, `secretsReadBy` and `intoFile` change only for an outside secret with an empty value. Secrets the mesh makes still go through `SecretForModule`, `ModuleSecretIfIssued` or `WouldMakeSecretForModule` as before. `TestAnOwnSecretTheMeshMakesIsStillRefusedWhenNotMade` keeps the `NotMadeError` for them. On today's catalogues no outside secret is a provision's shared credential (`ProvisionsSharing`): only letta, supabase, mounts (a family), nzbgeek and nzbget are marked outside, and none names one as `credential.own`. So `remakeShared` cannot hand a consumer a value the provider no longer gets. **No restart loop.** The empty substitution is the same on every compose, so supabase-studio's `restart-on: studio-env` fires once, when the file changes, and then holds still. `secretsReadBy` drops the not-given secret from what restarts, so nothing restarts on a file that is not placed. **Composition elsewhere is unharmed.** Only env files name these secrets (letta `server.env`, supabase `studio-env.env`), and `KEY=` is valid there. `intoFile` now always writes `content` back, but the content is unchanged unless a placeholder was emptied. It leaves out `secrets` when nothing remains, so a file with no placeholder left carries no `secrets` map. Nothing on the foreseen path changes: the outside branch `continue`s before it. **The old made rows are never sent.** Send, Reading and Foreseeing all take the outside branch before any read of an unfiltered row. `TestTheSendMakesNoValueForAnOutsideSecretNobodyGave` covers a row made earlier with `SecretForModule`. **Verified locally.** - `sh merge-check.sh` at 5801ab7 against a throwaway PostgreSQL 18 exits 0: gofmt, `go vet`, `go test -race ./...` (26 packages ok) and every listed store test PASS. - The 5 new tests pass at head, the 2 store-backed ones included. - On main with only the test files (plus `GivenOwnSecret`, so they build), all three behaviour tests fail with the expected messages: "assistant needs a secret called "vendor-key" and none was made for it", "a secret nobody gave was placed: …" and "a secret nobody gave is composed". - Required checks at 5801ab7, both read: `mesh/merge-gate` success ("every machine composes with the change as it did without") and `mesh/repo-check` success. **Non-blocking.** 1. `TestTheSendMakesNoValueForAnOutsideSecretNobodyGave` and `TestAQuestionComposesWithoutAnOutsideSecretNobodyGave` need the store, but they are not in `testdata/store-tests`, which merge-check.sh says a pull request adds its own store tests to (issue 459). Without a store they skip and the skip passes unseen. Please add them in a follow-up, or here if the head moves anyway. 2. No test covers the refusal for an outside secret given under an old sealing key (`givenUnderAnOldKey` on the send, skipped on a read). The code is shared with the family path and reads correctly. 3. As the PR body says, letta and supabase show no "waits" until each has a health tool. The operator sees nothing new except the push to ace and one supabase-studio restart.
Author
Contributor

Merge check at 6c3cf18d

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: FAIL — its merge-check.sh failed: --- FAIL: TestModuleCheckPassesTheCatalogue (1.04s); and TestEveryCatalogueManifestParses, TestNoCatalogueManifestNamesAnInstallation, TestEveryCatalogueIdentityFitsWhatItRequires, TestEveryCatalogueManifestDeclaresWhatItMounts

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests

Run by the build seat on ace as build-1791810978949323338 (builds --log build-1791810978949323338).

anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
anchor is not counted as on the network: it does not resolve: these assignments cannot be applied:
  - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node
notes on laptop:
  + places.data.owner
  + places.data.path
  + x
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
notes on laptop:
  ~ x
  the layer it replaced is kept: settings show notes --node laptop --history
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
{
  "places": {
    "data": {
      "owner": "1001:1001",
      "path": "/srv/notes"
    }
  },
  "x": 1
}
  set by an unnamed account at a shell on Ace through settings at 2026-10-12 13:23
keycloak on anchor:
  + issuer
  + x
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
power on anchor:
  + lid
  + x
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
keycloak on anchor:
  ~ x
  the layer it replaced is kept: settings show keycloak --node anchor --history
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
claude-code on laptop:
  + managed_settings.permissions.allow
  run `plan laptop --diff` to see what it changes, `push laptop` to send it
claude-code on the whole mesh:
  + mcp_servers.listener.type
  + mcp_servers.listener.url
  run `push --behind` to send it to the machines running it
{
  "managed_settings": {
    "permissions": {
      "allow": [
        "Bash"
      ]
    }
  }
}
  set at the controller's terminal by an unnamed account at a shell on Ace at 2026-10-12 13:23
keycloak on anchor:
  + url
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
{
  "url": "https://id.example"
}
  set at the controller's terminal by an unnamed account at a shell on Ace at 2026-10-12 13:23
notifier on anchor:
  + font
  run `plan anchor --diff` to see what it changes, `push anchor` to send it
plan-tier: tier 0 built; sent 12 module(s) to anchor first in one send (m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12), the rest once its gate passes
plan-tier: m01 passed its gate on anchor (healthy 3 times over 0s); the rest are sent
plan-tier: tier 0 built; sent m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12 to laptop, one send each
plan-tier: done — novox/mesh-catalog at c2, 1 tier(s)
plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, node-tools), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound)
plan-tier: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); app1 passed on its own and is kept; passed on their own and kept: app2; node-tools failed its gate on anchor in tier 0: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); put back node-tools to c1 on anchor, in one send; none reported left as it was
plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, app3), the rest once its gate passes
app1's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
app2's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
app3's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full
plan-tier: app1 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app2 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app3 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; put back app1 to c1, app2 to c1, app3 to c1 on anchor, in one send; none reported left as it was
plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes
plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back
plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back; none reported left as it was
  tier 0: plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer
plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts
plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; node-tools was put back when it broke; passed on their own and kept: app1; none reported left as it was
plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (app1, node-tools), the rest once its gate passes
node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer
plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts
plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; app1 passed on its own and is kept; none reported left as it was
plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes
plan-tier: node-tools passed its gate on anchor (healthy 3 times over 0s); the rest are sent
plan-tier: tier 0 built; sent node-tools, app1 to laptop, one send each
plan-tier: done — novox/mesh-catalog at c2, 1 tier(s)
plan-308-live (novox/mesh-catalog at c8c8c8c8) is let go by mesh-delivery; its first tier is asked at the next pass
plan-308-live stopped by a person at tier 0 of 1; what was asked still builds and registers, nothing further is asked or sent
this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found
plan-308-stop stopped at tier 0 of 1; what was asked still builds and registers, nothing further is asked
this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found
plan-308-close closed at tier 0 of 1; what was asked still builds and registers, nothing further is asked
  tier 0: plan-308-retry retried at tier 0 of 2: asked a as build-1791811397672731851; the plan goes on from there as any plan does
this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found
release-1791811398175324033: 2 build(s) wait for a gate on anchor, laptop; one machine at a time, each judged
release-1791811398175324033 releases it; `plans release-1791811398175324033` says where it is
build-1791811398626733740:  could not build https://forge.example/novox/a.git:
cancelled by hand
plan-308-cancel: a failed to build in tier 0; the tiers after it are not asked
cancelled build-1791811398626733740 (https://forge.example/novox/a.git, waiting): deleted from the node-build-agent queue and recorded failed, cancelled by hand — a plan that asked for it fails with that
took the controller lease at epoch 1 (controller@Ace pid 2005 since 2026-10-12T13:18:57Z)
build-1791811398693272463:  could not build https://forge.example/novox/a.git:
cancelled by hand
plan-308-clear: a failed to build in tier 0; the tiers after it are not asked
  cancelled build-1791811398693272463 (https://forge.example/novox/a.git, waiting): deleted from the node-build-agent queue and recorded failed, cancelled by hand — a plan that asked for it fails with that
1 waiting ask(s) cancelled
gave the controller lease back (epoch 1)
  tier 0: rebuild asked as build-1791811399249649156, joining plan-308-rebuild at tier 0 (novox/a at c0ffee): the plan takes this build as a's outcome; the plan had failed and builds again from this tier
the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison
this act by hand could NOT be recorded in the hand-act log, and is done anyway: this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus
plan-308-again-plans: its end is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router holds what it touched until its bound
plan-308-again-plans stopped at tier 0 of 2; what was asked still builds and registers, nothing further is asked
the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison
  tier 0: plan-308-again-plans: its start is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router does not hold what it touches
plan-308-again-plans retried at tier 0 of 2: asked a as build-1791811399725699471; the plan goes on from there as any plan does
plan-308-again-plans: a failed to build in tier 0; the tiers after it are not asked
the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison
this act by hand could NOT be recorded in the hand-act log, and is done anyway: this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus
plan-308-again-rebuild: its end is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router holds what it touched until its bound
plan-308-again-rebuild stopped at tier 0 of 2; what was asked still builds and registers, nothing further is asked
  tier 0: plan-308-again-rebuild: its start is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router does not hold what it touches
rebuild asked as build-1791811399826654753, joining plan-308-again-rebuild at tier 0 (novox/a at c0ffee): the plan takes this build as a's outcome; the plan had failed and builds again from this tier
plan-308-again-rebuild: a failed to build in tier 0; the tiers after it are not asked
FAIL
FAIL	github.com/novox/mesh-controller/cmd/mesh-controller	261.990s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.025s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.031s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.023s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.188s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.053s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.453s
ok  	github.com/novox/mesh-controller/internal/builder	17.194s
--- FAIL: TestEveryCatalogueManifestParses (0.79s)
    catalogue_check_test.go:26: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:39: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
    catalogue_check_test.go:52: 126 manifests, 71 named endpoints, 30 routed endpoints resolved
--- FAIL: TestNoCatalogueManifestNamesAnInstallation (1.35s)
    catalogue_check_test.go:62: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:75: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
--- FAIL: TestEveryCatalogueIdentityFitsWhatItRequires (0.06s)
    catalogue_check_test.go:124: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:137: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
--- FAIL: TestEveryCatalogueManifestDeclaresWhatItMounts (0.70s)
    mounts_test.go:75: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    mounts_test.go:85: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
FAIL
FAIL	github.com/novox/mesh-controller/internal/catalogue	7.593s
ok  	github.com/novox/mesh-controller/internal/conditions	2.802s
ok  	github.com/novox/mesh-controller/internal/envfile	1.114s
ok  	github.com/novox/mesh-controller/internal/facts	1.081s
ok  	github.com/novox/mesh-controller/internal/identity	5.248s
ok  	github.com/novox/mesh-controller/internal/inventory	101.382s
ok  	github.com/novox/mesh-controller/internal/lease	17.741s
ok  	github.com/novox/mesh-controller/internal/licences	4.739s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.088s
ok  	github.com/novox/mesh-controller/internal/link	61.666s
ok  	github.com/novox/mesh-controller/internal/lint	2.544s
ok  	github.com/novox/mesh-controller/internal/outward	1.130s
ok  	github.com/novox/mesh-controller/internal/overlay	1.108s
ok  	github.com/novox/mesh-controller/internal/secrets	1.547s
ok  	github.com/novox/mesh-controller/internal/store	3.693s
ok  	github.com/novox/mesh-controller/internal/testbus	1.339s
ok  	github.com/novox/mesh-controller/internal/token	1.028s
FAIL
--- what failed, picked from the whole of its output (the whole is in the build's log)
--- FAIL: TestModuleCheckPassesTheCatalogue (1.04s)
    check_test.go:61: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    check_test.go:68: the catalogue does not pass its own check: 1 problem(s) in 126 manifest(s)
        /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
        adwaita: ok, 4 tool(s)
        artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module
        asus-zephyrus-g14: ok, 11 tool(s); WARNING: asusd, supergfxd, upower stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        audit-logger: ok, keeps trail (valuable), spool (valuable)
        avahi: ok, 4 tool(s); WARNING: daemon stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        baserow: ok, keeps data (valuable), ready: server by its image's own check every 30s; WARNING: runtime-config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
        blueman: ok, 3 tool(s)
        bluetooth: ok, 9 tool(s); WARNING: daemon stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        build-agent: ok, keeps workspace (cache); WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        ca-trust: ok; WARNING: trust stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        claude-code: ok, 45 tool(s), keeps state servers, holdings, config, proposals, reads claude-licence-manager.bindings, keeps agent-home (valuable); WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
        claude-licence-manager: ok, keeps state bindings, reads claude-code.holdings; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
        clipmenu: ok, 3 tool(s)
        confluence: ok
        cups: ok, 7 tool(s); WARNING: socket, scheduler stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        dbus: ok, 5 tool(s); WARNING: system-bus stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        de-spiegel: ok; WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        desk-channel: ok, 1 tool(s), invokes seat:node-notifier.send, keeps state shown; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
        disk-load: ok, 4 tool(s)
        distribution: ok, keeps registry (rebuildable); WARNING: store stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        dmenu: ok, 2 tool(s)
        dnsmasq: ok, 3 tool(s), ready: service by unit every 30s; watch by its tool dnsmasq_health every 20s
        docker: ok, 22 tool(s), invokes seat:mesh-controller.images; WARNING: socket, runtime, prune stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        docker-compose: ok, 9 tool(s)
        dunst: ok, 6 tool(s)
        fail2ban: ok, 1 tool(s); WARNING: run stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
        feh: ok, 2 tool(s)
FAIL	github.com/novox/mesh-controller/cmd/mesh-controller	261.990s
--- FAIL: TestEveryCatalogueManifestParses (0.79s)
    catalogue_check_test.go:26: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:39: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
    catalogue_check_test.go:52: 126 manifests, 71 named endpoints, 30 routed endpoints resolved
--- FAIL: TestNoCatalogueManifestNamesAnInstallation (1.35s)
    catalogue_check_test.go:62: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:75: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
--- FAIL: TestEveryCatalogueIdentityFitsWhatItRequires (0.06s)
    catalogue_check_test.go:124: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    catalogue_check_test.go:137: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
--- FAIL: TestEveryCatalogueManifestDeclaresWhatItMounts (0.70s)
    mounts_test.go:75: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check
    mounts_test.go:85: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version)
FAIL	github.com/novox/mesh-controller/internal/catalogue	7.593s
**Merge check** at `6c3cf18d` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **FAIL** — its merge-check.sh failed: --- FAIL: TestModuleCheckPassesTheCatalogue (1.04s); and TestEveryCatalogueManifestParses, TestNoCatalogueManifestNamesAnInstallation, TestEveryCatalogueIdentityFitsWhatItRequires, TestEveryCatalogueManifestDeclaresWhatItMounts **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests Run by the build seat on ace as `build-1791810978949323338` (`builds --log build-1791810978949323338`). ``` anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is left out of the rest of the mesh: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node anchor is not counted as on the network: it does not resolve: these assignments cannot be applied: - rival-one and rival-two both claim "the-seat", and only one thing may hold it per node notes on laptop: + places.data.owner + places.data.path + x run `plan laptop --diff` to see what it changes, `push laptop` to send it notes on laptop: ~ x the layer it replaced is kept: settings show notes --node laptop --history run `plan laptop --diff` to see what it changes, `push laptop` to send it { "places": { "data": { "owner": "1001:1001", "path": "/srv/notes" } }, "x": 1 } set by an unnamed account at a shell on Ace through settings at 2026-10-12 13:23 keycloak on anchor: + issuer + x run `plan anchor --diff` to see what it changes, `push anchor` to send it power on anchor: + lid + x run `plan anchor --diff` to see what it changes, `push anchor` to send it keycloak on anchor: ~ x the layer it replaced is kept: settings show keycloak --node anchor --history run `plan anchor --diff` to see what it changes, `push anchor` to send it claude-code on laptop: + managed_settings.permissions.allow run `plan laptop --diff` to see what it changes, `push laptop` to send it claude-code on the whole mesh: + mcp_servers.listener.type + mcp_servers.listener.url run `push --behind` to send it to the machines running it { "managed_settings": { "permissions": { "allow": [ "Bash" ] } } } set at the controller's terminal by an unnamed account at a shell on Ace at 2026-10-12 13:23 keycloak on anchor: + url run `plan anchor --diff` to see what it changes, `push anchor` to send it { "url": "https://id.example" } set at the controller's terminal by an unnamed account at a shell on Ace at 2026-10-12 13:23 notifier on anchor: + font run `plan anchor --diff` to see what it changes, `push anchor` to send it plan-tier: tier 0 built; sent 12 module(s) to anchor first in one send (m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12), the rest once its gate passes plan-tier: m01 passed its gate on anchor (healthy 3 times over 0s); the rest are sent plan-tier: tier 0 built; sent m01, m02, m03, m04, m05, m06, m07, m08, m09, m10, m11, m12 to laptop, one send each plan-tier: done — novox/mesh-catalog at c2, 1 tier(s) plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, node-tools), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound) plan-tier: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); app1 passed on its own and is kept; passed on their own and kept: app2; node-tools failed its gate on anchor in tier 0: not healthy within -1s of its apply: raised since it was sent: machine.anchor.core-behind — anchor runs the node tools it was last sent, not yet reported applied, and no plan is rolling them out (its settle window runs to the gate's bound); put back node-tools to c1 on anchor, in one send; none reported left as it was plan-tier: tier 0 built; sent 3 module(s) to anchor first in one send (app1, app2, app3), the rest once its gate passes app1's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full app2's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full app3's build c2 failed its gate on anchor and was put back to c1: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full plan-tier: app1 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app2 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; app3 failed its gate on anchor in tier 0: not healthy within -1s of its apply: anchor as a whole: raised since it was sent: machine.anchor.disk-full — anchor's root file system is full; put back app1 to c1, app2 to c1, app3 to c1 on anchor, in one send; none reported left as it was plan-gate: tier 0 built; sent 1 module(s) to anchor first in one send (app), the rest once its gate passes plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back plan-gate: the send to anchor in tier 0 failed its gate: not healthy within -1s of its apply: anchor has not reported on what it was sent; app was left as it was — anchor already ran app c2, or a build identical to it, before the send, so nothing of it moved and nothing is put back; none reported left as it was tier 0: plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; node-tools was put back when it broke; passed on their own and kept: app1; none reported left as it was plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (app1, node-tools), the rest once its gate passes node-tools's build c2 failed its gate on anchor and was put back to c1: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer plan-tier: put back at once: node-tools (the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer); the rest of the send judged to their own verdicts plan-tier: the send to anchor in tier 0 failed its gate: the witness on anchor judged the node-tools c2 and rolled-back: the node tools did not answer; app1 passed on its own and is kept; none reported left as it was plan-tier: tier 0 built; sent 2 module(s) to anchor first in one send (node-tools, app1), the rest once its gate passes plan-tier: node-tools passed its gate on anchor (healthy 3 times over 0s); the rest are sent plan-tier: tier 0 built; sent node-tools, app1 to laptop, one send each plan-tier: done — novox/mesh-catalog at c2, 1 tier(s) plan-308-live (novox/mesh-catalog at c8c8c8c8) is let go by mesh-delivery; its first tier is asked at the next pass plan-308-live stopped by a person at tier 0 of 1; what was asked still builds and registers, nothing further is asked or sent this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found plan-308-stop stopped at tier 0 of 1; what was asked still builds and registers, nothing further is asked this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found plan-308-close closed at tier 0 of 1; what was asked still builds and registers, nothing further is asked tier 0: plan-308-retry retried at tier 0 of 2: asked a as build-1791811397672731851; the plan goes on from there as any plan does this act by hand could NOT be recorded in the hand-act log, and is done anyway: the hand-act log mesh-controller_hand-acts is not on the bus — the controller asserts it at its start, so one older than this has not: nats: bucket not found release-1791811398175324033: 2 build(s) wait for a gate on anchor, laptop; one machine at a time, each judged release-1791811398175324033 releases it; `plans release-1791811398175324033` says where it is build-1791811398626733740: could not build https://forge.example/novox/a.git: cancelled by hand plan-308-cancel: a failed to build in tier 0; the tiers after it are not asked cancelled build-1791811398626733740 (https://forge.example/novox/a.git, waiting): deleted from the node-build-agent queue and recorded failed, cancelled by hand — a plan that asked for it fails with that took the controller lease at epoch 1 (controller@Ace pid 2005 since 2026-10-12T13:18:57Z) build-1791811398693272463: could not build https://forge.example/novox/a.git: cancelled by hand plan-308-clear: a failed to build in tier 0; the tiers after it are not asked cancelled build-1791811398693272463 (https://forge.example/novox/a.git, waiting): deleted from the node-build-agent queue and recorded failed, cancelled by hand — a plan that asked for it fails with that 1 waiting ask(s) cancelled gave the controller lease back (epoch 1) tier 0: rebuild asked as build-1791811399249649156, joining plan-308-rebuild at tier 0 (novox/a at c0ffee): the plan takes this build as a's outcome; the plan had failed and builds again from this tier the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison this act by hand could NOT be recorded in the hand-act log, and is done anyway: this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus plan-308-again-plans: its end is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router holds what it touched until its bound plan-308-again-plans stopped at tier 0 of 2; what was asked still builds and registers, nothing further is asked the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison tier 0: plan-308-again-plans: its start is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router does not hold what it touches plan-308-again-plans retried at tier 0 of 2: asked a as build-1791811399725699471; the plan goes on from there as any plan does plan-308-again-plans: a failed to build in tier 0; the tiers after it are not asked the bus cannot be reached (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): what this does is not said, and is found by comparison this act by hand could NOT be recorded in the hand-act log, and is done anyway: this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus plan-308-again-rebuild: its end is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router holds what it touched until its bound plan-308-again-rebuild stopped at tier 0 of 2; what was asked still builds and registers, nothing further is asked tier 0: plan-308-again-rebuild: its start is kept and could NOT be said as plan-moved (this control plane has no MESH_BUS_NATS, so it cannot reach the mesh's bus): the router does not hold what it touches rebuild asked as build-1791811399826654753, joining plan-308-again-rebuild at tier 0 (novox/a at c0ffee): the plan takes this build as a's outcome; the plan had failed and builds again from this tier plan-308-again-rebuild: a failed to build in tier 0; the tiers after it are not asked FAIL FAIL github.com/novox/mesh-controller/cmd/mesh-controller 261.990s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.025s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.031s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.023s ok github.com/novox/mesh-controller/examples/route-proxy 1.188s ok github.com/novox/mesh-controller/internal/artifacts 1.053s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.453s ok github.com/novox/mesh-controller/internal/builder 17.194s --- FAIL: TestEveryCatalogueManifestParses (0.79s) catalogue_check_test.go:26: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:39: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) catalogue_check_test.go:52: 126 manifests, 71 named endpoints, 30 routed endpoints resolved --- FAIL: TestNoCatalogueManifestNamesAnInstallation (1.35s) catalogue_check_test.go:62: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:75: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) --- FAIL: TestEveryCatalogueIdentityFitsWhatItRequires (0.06s) catalogue_check_test.go:124: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:137: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) --- FAIL: TestEveryCatalogueManifestDeclaresWhatItMounts (0.70s) mounts_test.go:75: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check mounts_test.go:85: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) FAIL FAIL github.com/novox/mesh-controller/internal/catalogue 7.593s ok github.com/novox/mesh-controller/internal/conditions 2.802s ok github.com/novox/mesh-controller/internal/envfile 1.114s ok github.com/novox/mesh-controller/internal/facts 1.081s ok github.com/novox/mesh-controller/internal/identity 5.248s ok github.com/novox/mesh-controller/internal/inventory 101.382s ok github.com/novox/mesh-controller/internal/lease 17.741s ok github.com/novox/mesh-controller/internal/licences 4.739s ok github.com/novox/mesh-controller/internal/licences/adapters 1.088s ok github.com/novox/mesh-controller/internal/link 61.666s ok github.com/novox/mesh-controller/internal/lint 2.544s ok github.com/novox/mesh-controller/internal/outward 1.130s ok github.com/novox/mesh-controller/internal/overlay 1.108s ok github.com/novox/mesh-controller/internal/secrets 1.547s ok github.com/novox/mesh-controller/internal/store 3.693s ok github.com/novox/mesh-controller/internal/testbus 1.339s ok github.com/novox/mesh-controller/internal/token 1.028s FAIL --- what failed, picked from the whole of its output (the whole is in the build's log) --- FAIL: TestModuleCheckPassesTheCatalogue (1.04s) check_test.go:61: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check check_test.go:68: the catalogue does not pass its own check: 1 problem(s) in 126 manifest(s) /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) adwaita: ok, 4 tool(s) artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module asus-zephyrus-g14: ok, 11 tool(s); WARNING: asusd, supergfxd, upower stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) audit-logger: ok, keeps trail (valuable), spool (valuable) avahi: ok, 4 tool(s); WARNING: daemon stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) baserow: ok, keeps data (valuable), ready: server by its image's own check every 30s; WARNING: runtime-config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) blueman: ok, 3 tool(s) bluetooth: ok, 9 tool(s); WARNING: daemon stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) build-agent: ok, keeps workspace (cache); WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) ca-trust: ok; WARNING: trust stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) claude-code: ok, 45 tool(s), keeps state servers, holdings, config, proposals, reads claude-licence-manager.bindings, keeps agent-home (valuable); WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) claude-licence-manager: ok, keeps state bindings, reads claude-code.holdings; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) clipmenu: ok, 3 tool(s) confluence: ok cups: ok, 7 tool(s); WARNING: socket, scheduler stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) dbus: ok, 5 tool(s); WARNING: system-bus stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) de-spiegel: ok; WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) desk-channel: ok, 1 tool(s), invokes seat:node-notifier.send, keeps state shown; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) disk-load: ok, 4 tool(s) distribution: ok, keeps registry (rebuildable); WARNING: store stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) dmenu: ok, 2 tool(s) dnsmasq: ok, 3 tool(s), ready: service by unit every 30s; watch by its tool dnsmasq_health every 20s docker: ok, 22 tool(s), invokes seat:mesh-controller.images; WARNING: socket, runtime, prune stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) docker-compose: ok, 9 tool(s) dunst: ok, 6 tool(s) fail2ban: ok, 1 tool(s); WARNING: run stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) feh: ok, 2 tool(s) FAIL github.com/novox/mesh-controller/cmd/mesh-controller 261.990s --- FAIL: TestEveryCatalogueManifestParses (0.79s) catalogue_check_test.go:26: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:39: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) catalogue_check_test.go:52: 126 manifests, 71 named endpoints, 30 routed endpoints resolved --- FAIL: TestNoCatalogueManifestNamesAnInstallation (1.35s) catalogue_check_test.go:62: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:75: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) --- FAIL: TestEveryCatalogueIdentityFitsWhatItRequires (0.06s) catalogue_check_test.go:124: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check catalogue_check_test.go:137: /var/lib/build-agent/workspace/check/mesh-catalog/modules/betterbird/module.json: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) --- FAIL: TestEveryCatalogueManifestDeclaresWhatItMounts (0.70s) mounts_test.go:75: judged against /var/lib/build-agent/workspace/check/mesh-catalog as cloned beside this check mounts_test.go:85: betterbird: this is not a module manifest: json: unknown field "url" (read without build.artifacts[1].names-on-purpose, build.artifacts[1].sha256, build.artifacts[1].url, build.artifacts[1].version, build.artifacts[1].within, build.artifacts[2].file, build.artifacts[2].names-on-purpose, build.artifacts[2].sha256, build.artifacts[2].url, build.artifacts[2].version) FAIL github.com/novox/mesh-controller/internal/catalogue 7.593s ```
jschoubben force-pushed fix/401-an-outside-secret-not-given-is-not-made from 6c3cf18dfc to 65408432af 2026-10-12 13:27:36 +00:00 Compare
Author
Contributor

Merge check at 65408432

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests

Run by the build seat on ace as build-1791811669518011775 (builds --log build-1791811669518011775).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:22:45Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T13:22:45Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.041s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	277.610s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.064s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.123s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.039s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.147s
ok  	github.com/novox/mesh-controller/internal/builder	45.387s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.879s
ok  	github.com/novox/mesh-controller/internal/conditions	2.771s
ok  	github.com/novox/mesh-controller/internal/envfile	1.128s
ok  	github.com/novox/mesh-controller/internal/facts	1.064s
ok  	github.com/novox/mesh-controller/internal/identity	4.744s
ok  	github.com/novox/mesh-controller/internal/inventory	109.977s
ok  	github.com/novox/mesh-controller/internal/lease	17.778s
ok  	github.com/novox/mesh-controller/internal/licences	4.343s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.119s
ok  	github.com/novox/mesh-controller/internal/link	65.676s
ok  	github.com/novox/mesh-controller/internal/lint	2.493s
ok  	github.com/novox/mesh-controller/internal/outward	1.093s
ok  	github.com/novox/mesh-controller/internal/overlay	1.150s
ok  	github.com/novox/mesh-controller/internal/secrets	1.555s
ok  	github.com/novox/mesh-controller/internal/store	3.584s
ok  	github.com/novox/mesh-controller/internal/testbus	1.339s
ok  	github.com/novox/mesh-controller/internal/token	1.021s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.44s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.42s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.43s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.34s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.51s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.47s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.43s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.43s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.50s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.49s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.47s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.54s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.26s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.26s)
**Merge check** at `65408432` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests Run by the build seat on ace as `build-1791811669518011775` (`builds --log build-1791811669518011775`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:22:45Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T13:22:45Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.041s ok github.com/novox/mesh-controller/cmd/mesh-controller 277.610s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.014s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.064s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.014s ok github.com/novox/mesh-controller/examples/route-proxy 1.123s ok github.com/novox/mesh-controller/internal/artifacts 1.039s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.147s ok github.com/novox/mesh-controller/internal/builder 45.387s ok github.com/novox/mesh-controller/internal/catalogue 7.879s ok github.com/novox/mesh-controller/internal/conditions 2.771s ok github.com/novox/mesh-controller/internal/envfile 1.128s ok github.com/novox/mesh-controller/internal/facts 1.064s ok github.com/novox/mesh-controller/internal/identity 4.744s ok github.com/novox/mesh-controller/internal/inventory 109.977s ok github.com/novox/mesh-controller/internal/lease 17.778s ok github.com/novox/mesh-controller/internal/licences 4.343s ok github.com/novox/mesh-controller/internal/licences/adapters 1.119s ok github.com/novox/mesh-controller/internal/link 65.676s ok github.com/novox/mesh-controller/internal/lint 2.493s ok github.com/novox/mesh-controller/internal/outward 1.093s ok github.com/novox/mesh-controller/internal/overlay 1.150s ok github.com/novox/mesh-controller/internal/secrets 1.555s ok github.com/novox/mesh-controller/internal/store 3.584s ok github.com/novox/mesh-controller/internal/testbus 1.339s ok github.com/novox/mesh-controller/internal/token 1.021s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.44s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.42s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.43s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.34s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.51s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.47s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.43s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.43s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.50s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.49s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.47s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.54s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.26s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.26s) ```
jschoubben force-pushed fix/401-an-outside-secret-not-given-is-not-made from 65408432af to c53a8c48b0 2026-10-12 13:52:25 +00:00 Compare
Author
Contributor

Merge check at c53a8c48

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests

Run by the build seat on shanks as build-1791813158486945418 (builds --log build-1791813158486945418).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:33:41Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T13:33:41Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.039s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	260.741s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.048s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.062s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.059s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.211s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.094s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.413s
ok  	github.com/novox/mesh-controller/internal/builder	37.729s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.804s
ok  	github.com/novox/mesh-controller/internal/conditions	2.661s
ok  	github.com/novox/mesh-controller/internal/envfile	1.062s
ok  	github.com/novox/mesh-controller/internal/facts	1.068s
ok  	github.com/novox/mesh-controller/internal/identity	4.786s
ok  	github.com/novox/mesh-controller/internal/inventory	97.645s
ok  	github.com/novox/mesh-controller/internal/lease	17.721s
ok  	github.com/novox/mesh-controller/internal/licences	4.361s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.044s
ok  	github.com/novox/mesh-controller/internal/link	61.043s
ok  	github.com/novox/mesh-controller/internal/lint	2.408s
ok  	github.com/novox/mesh-controller/internal/outward	1.089s
ok  	github.com/novox/mesh-controller/internal/overlay	1.073s
ok  	github.com/novox/mesh-controller/internal/secrets	1.570s
ok  	github.com/novox/mesh-controller/internal/store	3.503s
ok  	github.com/novox/mesh-controller/internal/testbus	1.257s
ok  	github.com/novox/mesh-controller/internal/token	1.015s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.41s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.45s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.31s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.45s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.45s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.41s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.48s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.46s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.40s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.41s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.49s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.47s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.27s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.28s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.26s)
**Merge check** at `c53a8c48` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go, testdata/store-tests Run by the build seat on shanks as `build-1791813158486945418` (`builds --log build-1791813158486945418`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:33:41Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T13:33:41Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/outside_not_given_test.go, internal/catalogue/outside_not_given_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.039s ok github.com/novox/mesh-controller/cmd/mesh-controller 260.741s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.048s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.062s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.059s ok github.com/novox/mesh-controller/examples/route-proxy 1.211s ok github.com/novox/mesh-controller/internal/artifacts 1.094s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.413s ok github.com/novox/mesh-controller/internal/builder 37.729s ok github.com/novox/mesh-controller/internal/catalogue 7.804s ok github.com/novox/mesh-controller/internal/conditions 2.661s ok github.com/novox/mesh-controller/internal/envfile 1.062s ok github.com/novox/mesh-controller/internal/facts 1.068s ok github.com/novox/mesh-controller/internal/identity 4.786s ok github.com/novox/mesh-controller/internal/inventory 97.645s ok github.com/novox/mesh-controller/internal/lease 17.721s ok github.com/novox/mesh-controller/internal/licences 4.361s ok github.com/novox/mesh-controller/internal/licences/adapters 1.044s ok github.com/novox/mesh-controller/internal/link 61.043s ok github.com/novox/mesh-controller/internal/lint 2.408s ok github.com/novox/mesh-controller/internal/outward 1.089s ok github.com/novox/mesh-controller/internal/overlay 1.073s ok github.com/novox/mesh-controller/internal/secrets 1.570s ok github.com/novox/mesh-controller/internal/store 3.503s ok github.com/novox/mesh-controller/internal/testbus 1.257s ok github.com/novox/mesh-controller/internal/token 1.015s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.43s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.41s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.45s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.31s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.45s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.45s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.41s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.48s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.46s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.40s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.41s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.49s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.47s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.27s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.26s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.28s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.25s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.26s) ```
Author
Contributor

Re-check at c53a8c48b0: git range-diff against the approved 5801ab7 shows the fix commit unchanged (5801ab7 = 6091b23); the only new commit adds the two store tests to testdata/store-tests, which is review 62's non-blocking point 1. mesh/merge-gate and mesh/repo-check pass at this head. Review 62's approval carries to this head.

Re-check at c53a8c48b00d41a3036c8f567abc0606e15cb399: git range-diff against the approved 5801ab7 shows the fix commit unchanged (5801ab7 = 6091b23); the only new commit adds the two store tests to testdata/store-tests, which is review 62's non-blocking point 1. mesh/merge-gate and mesh/repo-check pass at this head. Review 62's approval carries to this head.
jschoubben added 2 commits 2026-10-12 15:18:59 +00:00
The send minted a random value for a plain own secret marked issued-by outside and placed it, so a
module could not tell "not given" from "given and wrong" (ADR 0228). It now places only a value a
person gave: not given is no file, an empty value where a module's file names it, and nothing to
restart on, as ADR 0283 decided for a family's member. A value the mesh made for one earlier is not
read as given.
Name issue 401's two store tests, so a skip without the store fails the check (issue 459's rule)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery covered after its failure: a later walk that contains it was delivered: plan-1791826579427234545 (novox/mesh-controller at d8f36a8f into ma…
c3b4f187e1
jschoubben force-pushed fix/401-an-outside-secret-not-given-is-not-made from c53a8c48b0 to c3b4f187e1 2026-10-12 15:18:59 +00:00 Compare
Author
Contributor

Rebased onto main 3cfc121, pushed with lease from c53a8c4. The new head is c3b4f187e1. The only change resolves the conflict in testdata/store-tests that #256 caused: main's TestADirectoryOwnersKeyIsRefusedThroughAVerb line is kept, and this PR's two lines follow it.

Range-diff against c53a8c4:

  • Commit 1 (6091b23, now edd33f2): unchanged (=).
  • Commit 2 (c53a8c4, now c3b4f18): the same two added lines, now after main's new line. Nothing else changed.

git merge-tree shows this head merges cleanly with main, with #268 and with #266, and all three merge together. merge-check.sh passes against a throwaway Postgres 18, including both of issue 401's store tests.

Rebased onto main 3cfc121, pushed with lease from c53a8c4. The new head is c3b4f187e195596e18e16177924d9d96cb7db1e6. The only change resolves the conflict in `testdata/store-tests` that #256 caused: main's `TestADirectoryOwnersKeyIsRefusedThroughAVerb` line is kept, and this PR's two lines follow it. Range-diff against c53a8c4: - Commit 1 (6091b23, now edd33f2): unchanged (`=`). - Commit 2 (c53a8c4, now c3b4f18): the same two added lines, now after main's new line. Nothing else changed. `git merge-tree` shows this head merges cleanly with main, with #268 and with #266, and all three merge together. `merge-check.sh` passes against a throwaway Postgres 18, including both of issue 401's store tests.
Author
Contributor

Merge check at c3b4f187

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Run by the build seat on g14 as build-1791818368093520572 (builds --log build-1791818368093520572).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:54:57Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T14:54:57Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.070s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	285.809s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.017s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.036s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.031s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.188s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.067s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	5.806s
ok  	github.com/novox/mesh-controller/internal/builder	42.506s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.915s
ok  	github.com/novox/mesh-controller/internal/conditions	2.679s
ok  	github.com/novox/mesh-controller/internal/envfile	1.043s
ok  	github.com/novox/mesh-controller/internal/facts	1.033s
ok  	github.com/novox/mesh-controller/internal/identity	6.802s
ok  	github.com/novox/mesh-controller/internal/inventory	106.798s
ok  	github.com/novox/mesh-controller/internal/lease	17.714s
ok  	github.com/novox/mesh-controller/internal/licences	6.414s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.008s
ok  	github.com/novox/mesh-controller/internal/link	68.552s
ok  	github.com/novox/mesh-controller/internal/lint	2.181s
ok  	github.com/novox/mesh-controller/internal/outward	1.045s
ok  	github.com/novox/mesh-controller/internal/overlay	1.038s
ok  	github.com/novox/mesh-controller/internal/secrets	1.455s
ok  	github.com/novox/mesh-controller/internal/store	5.087s
ok  	github.com/novox/mesh-controller/internal/testbus	1.168s
ok  	github.com/novox/mesh-controller/internal/token	1.015s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.35s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.33s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.59s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.26s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.46s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.44s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.42s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.37s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.38s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.37s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.35s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.40s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.44s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.43s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.22s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.22s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.23s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s)
**Merge check** at `c3b4f187` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine Run by the build seat on g14 as `build-1791818368093520572` (`builds --log build-1791818368093520572`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:54:57Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T14:54:57Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.070s ok github.com/novox/mesh-controller/cmd/mesh-controller 285.809s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.017s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.036s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.031s ok github.com/novox/mesh-controller/examples/route-proxy 1.188s ok github.com/novox/mesh-controller/internal/artifacts 1.067s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 5.806s ok github.com/novox/mesh-controller/internal/builder 42.506s ok github.com/novox/mesh-controller/internal/catalogue 7.915s ok github.com/novox/mesh-controller/internal/conditions 2.679s ok github.com/novox/mesh-controller/internal/envfile 1.043s ok github.com/novox/mesh-controller/internal/facts 1.033s ok github.com/novox/mesh-controller/internal/identity 6.802s ok github.com/novox/mesh-controller/internal/inventory 106.798s ok github.com/novox/mesh-controller/internal/lease 17.714s ok github.com/novox/mesh-controller/internal/licences 6.414s ok github.com/novox/mesh-controller/internal/licences/adapters 1.008s ok github.com/novox/mesh-controller/internal/link 68.552s ok github.com/novox/mesh-controller/internal/lint 2.181s ok github.com/novox/mesh-controller/internal/outward 1.045s ok github.com/novox/mesh-controller/internal/overlay 1.038s ok github.com/novox/mesh-controller/internal/secrets 1.455s ok github.com/novox/mesh-controller/internal/store 5.087s ok github.com/novox/mesh-controller/internal/testbus 1.168s ok github.com/novox/mesh-controller/internal/token 1.015s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.36s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.35s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.33s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.59s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.26s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.46s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.44s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.42s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.37s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.38s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.37s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.35s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.40s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.44s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.43s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.22s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.22s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.23s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s) ```
Author
Contributor

Re-check at c3b4f187e1: git range-diff shows the fix commit identical to the approved 5801ab7 (6091b23 = edd33f2); the second commit still adds only the same two lines to testdata/store-tests (after main's new line). Review 62's approval carries to this head. Held until rollouts can reach ace.

Re-check at c3b4f187e195596e18e16177924d9d96cb7db1e6: git range-diff shows the fix commit identical to the approved 5801ab7 (6091b23 = edd33f2); the second commit still adds only the same two lines to testdata/store-tests (after main's new line). Review 62's approval carries to this head. Held until rollouts can reach ace.
mesh-admin merged commit 1e28342ede into main 2026-10-12 15:48:12 +00:00
mesh-admin deleted branch fix/401-an-outside-secret-not-given-is-not-made 2026-10-12 15:48:12 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#262