novox/mesh-controller
7
0
Fork 0
Code Issues Pull Requests 6 Releases Wiki Activity

Resolve a config value from four sources: default, mesh config, node config, the module on the node (hq issue 630) #303

Closed
mesh-admin wants to merge 8 commits from fix/630-config-values-from-four-sources into main
pull from: fix/630-config-values-from-four-sources
merge into: :main
Conversation 2 Commits 8 Files Changed 36
+2097 -79
mesh-admin commented 2026-10-13 13:20:08 +00:00
Contributor
Copy Link
Copy Source

Implements the controller part of novox/hq issue 630 (config values from four sources, the most specific winning).

What changed

  • Manifest preferences (internal/catalogue/preferences.go): {"<key>": {"type": "number|string|boolean", "default": …, "predefined": "<key on the list>", "why": "…"}}. Old settings entries of kind preference are still read as preferences (type inferred from the default's JSON type). The manifest parse refuses an unknown type, a default not of the declared type, no default, no why, and a key declared under both settings and preferences.
  • Resolution for one module on one node: manifest default → mesh config[predefined] → node config[predefined] → the module's own layer on the node. SettingsFor now returns the mesh-config and node-config layers (marked Layer.Config) under the module's own layer, so every place that fills ${setting:…} (declaration composition, served facts, JudgeSettings, Effective, the listings) uses them. Like a default, a config layer fills ${setting:…} only and never reaches a mergeable file. A preference without predefined reads only its default and its module-assignment value.
  • Sources are said as default, mesh config, node config (<node>), <module> on <node> (the settings listing said the node before; it now says <module> on <node>).
  • Registration refuses a predefined not on the list, or a type other than the list's (RegisterModule, the builder, the module check, the merge gate).
  • No module layer for the whole mesh: settings set/settings propose without a node are refused ("there is no module layer for the whole mesh"). KeepSettings (the merge gate raising a store from facts) still keeps one the snapshot holds, and clearing a left-over one still works.
  • Trusted settings (issue 339/340, ADR 0277): unchanged. config with module and node runs the same refuseTerminalSettingsThroughAVerb judgement as settings set, so a trusted file's key is still refused through a verb. Only preference keys can be set through config.

The verb: config (new seat verb of mesh-controller; config CLI subcommand)

Arguments: key, value (JSON; a bare word is a string), node, module, clear ("true"), history ("true"), why.

  • no key: the listing — the predefined keys with their mesh and node config, then each module's preferences with the value on each node and its source; node/module narrow it.
  • key + value + why: mesh config; with node, node config; with module + node, the module's own value on that node.
  • key + clear + why: removes it; the next source down applies.
  • key + history: past mesh (or with node, node) config values.
  • Refused: a key not on the list for mesh/node config, a value of the wrong type, a module without node, a module key that is not one of its preferences, a set/clear without why.
  • Each set/clear is written to the hand-act log (verb config, the proven caller, the why) before it is done; listed in handActVerbs as a person's decision, not a repair.
  • Push: like settings, it does not push. It answers which nodes the value reaches and the push <nodes> to send it ("takes effect at the next push").

How the list arrives

The controller learns manifests only through builds, so predefined.json travels the same way:

  1. The builder reads predefined.json at the root of the cloned repository at the commit built (if present), parses it strictly, refuses the build when the manifest's preferences disagree with it, and returns it as BuildResult.predefined (raw JSON, omitted when absent).
  2. The controller, when it takes in a build whose repository's last path element is mesh-catalog, replaces its stored list with it before registering the module (so a preference and the key it needs can land in one commit).
  3. The merge gate reads predefined.json at the root of the change's tree and composes the change with that list; the facts snapshot carries the list and mesh/node config (predefined, config, and config per machine), so the gate composes with what the mesh holds.
  4. The module check finds predefined.json in the manifest's directory or above it, up to the repository root, and refuses a predefined not on it; with no file found it notes it and leaves it to registration.

File format (catalogue root): {"font-size": {"type": "number", "why": "…"}}, types number, string, boolean; unknown fields refused.

Order of delivery: this controller (and the builder, built from this repository) must be delivered before the catalogue change that adds predefined.json and preferences: the running controller's strict parser refuses the unknown preferences field, and an older builder does not carry the list. Until a catalogue build with the file lands, the list is empty and any manifest using predefined is refused at registration.

Store (migration 0096-config-values-come-from-four-sources)

  • predefined_key (key pk, type check in (number,string,boolean), why, repository, commit, listed_at) — replaced whole.
  • config (key, node uuid null = mesh, value jsonb, set_at, set_by, why not null), unique per key for the mesh and per (key, node).
  • config_history (key, node, value, set_at, set_by, why, replaced_at, replaced_by set|clear, replaced_why).
  • Data move: each whole-mesh module layer (settings row with node null) is laid under the layer of every node the module is assigned to (deep merge as composition merged, the node's values winning). Every node layer replaced and the whole-mesh layer itself are copied to settings_history with replaced_by = moved-to-nodes; then the whole-mesh rows are deleted. Known one: artifact-store-tools older-store-names → novox's layer. A whole-mesh layer of a module assigned nowhere (or only pulled in as a requirement, without an assignment row) is kept only in the history.
  • This repository has no separate consolidated schema: a fresh install runs every numbered migration, so the migration is the schema for both.

Tests

  • internal/catalogue/preferences_test.go: the list read strictly; preferences declared and refused; predefined not on the list / other type; config layers fill ${setting:} in order and never a mergeable file.
  • internal/inventory/config_test.go: each of the four sources in turn, most specific winning, clearing each falls back, history with why; refusals (not predefined, wrong type, no why, unknown node, module value without node); registration refusals; the 0096 data move (merge, history, unassigned node untouched).
  • cmd/mesh-controller/config_test.go: the verb's line and refusals; end to end through the verb into g14-like dunstrc content as composed (cleared → 10; mesh 11; node 13; dunst on node 15; then each clear falls back); the module check against predefined.json.
  • Existing settings/trust tests adjusted for no whole-mesh module layer (they keep one with KeepSettings where they test an existing one).
  • Run locally: gofmt, go vet ./..., go test ./... and sh merge-check.sh all pass against a throwaway PostgreSQL 18.6 (the mesh runs 17; TestTheStoreTheTestsRunIsTheStoreTheMeshRuns passed regardless).

Acceptance (live)

After this and the catalogue change are delivered, on g14's dunst: with no config, g14's dunstrc says font = Inter 10; config key=font-size value=11 why=… → 11 in g14's dunstrc after push g14; config key=font-size node=g14 value=13 → 13; config key=font-size node=g14 module=dunst value=15 → 15; clearing each in reverse falls back 13 → 11 → 10. g14's current dunst layer (font-size 13, width 500) is a module-assignment value and stays as it is.

Implements the controller part of novox/hq issue 630 (config values from four sources, the most specific winning). ## What changed - **Manifest `preferences`** (`internal/catalogue/preferences.go`): `{"<key>": {"type": "number|string|boolean", "default": …, "predefined": "<key on the list>", "why": "…"}}`. Old `settings` entries of kind `preference` are still read as preferences (type inferred from the default's JSON type). The manifest parse refuses an unknown type, a default not of the declared type, no default, no why, and a key declared under both `settings` and `preferences`. - **Resolution** for one module on one node: manifest default → mesh config[predefined] → node config[predefined] → the module's own layer on the node. `SettingsFor` now returns the mesh-config and node-config layers (marked `Layer.Config`) under the module's own layer, so every place that fills `${setting:…}` (declaration composition, served facts, `JudgeSettings`, `Effective`, the listings) uses them. Like a default, a config layer fills `${setting:…}` only and never reaches a mergeable file. A preference without `predefined` reads only its default and its module-assignment value. - **Sources are said** as `default`, `mesh config`, `node config (<node>)`, `<module> on <node>` (the `settings` listing said `the node` before; it now says `<module> on <node>`). - **Registration refuses** a `predefined` not on the list, or a type other than the list's (`RegisterModule`, the builder, the module check, the merge gate). - **No module layer for the whole mesh**: `settings set`/`settings propose` without a node are refused ("there is no module layer for the whole mesh"). `KeepSettings` (the merge gate raising a store from facts) still keeps one the snapshot holds, and clearing a left-over one still works. - **Trusted settings** (issue 339/340, ADR 0277): unchanged. `config` with module and node runs the same `refuseTerminalSettingsThroughAVerb` judgement as `settings set`, so a trusted file's key is still refused through a verb. Only preference keys can be set through `config`. ## The verb: `config` (new seat verb of mesh-controller; `config` CLI subcommand) Arguments: `key`, `value` (JSON; a bare word is a string), `node`, `module`, `clear` ("true"), `history` ("true"), `why`. - no key: the listing — the predefined keys with their mesh and node config, then each module's preferences with the value on each node and its source; `node`/`module` narrow it. - `key` + `value` + `why`: mesh config; with `node`, node config; with `module` + `node`, the module's own value on that node. - `key` + `clear` + `why`: removes it; the next source down applies. - `key` + `history`: past mesh (or with `node`, node) config values. - Refused: a key not on the list for mesh/node config, a value of the wrong type, a module without node, a module key that is not one of its preferences, a set/clear without why. - Each set/clear is written to the hand-act log (verb `config`, the proven caller, the why) before it is done; listed in `handActVerbs` as a person's decision, not a repair. - **Push: like `settings`, it does not push.** It answers which nodes the value reaches and the `push <nodes>` to send it ("takes effect at the next push"). ## How the list arrives The controller learns manifests only through builds, so `predefined.json` travels the same way: 1. The **builder** reads `predefined.json` at the **root of the cloned repository** at the commit built (if present), parses it strictly, refuses the build when the manifest's preferences disagree with it, and returns it as `BuildResult.predefined` (raw JSON, omitted when absent). 2. The **controller**, when it takes in a build whose repository's last path element is `mesh-catalog`, replaces its stored list with it **before** registering the module (so a preference and the key it needs can land in one commit). 3. The **merge gate** reads `predefined.json` at the root of the change's tree and composes the change with that list; the facts snapshot carries the list and mesh/node config (`predefined`, `config`, and `config` per machine), so the gate composes with what the mesh holds. 4. The **module check** finds `predefined.json` in the manifest's directory or above it, up to the repository root, and refuses a `predefined` not on it; with no file found it notes it and leaves it to registration. File format (catalogue root): `{"font-size": {"type": "number", "why": "…"}}`, types `number`, `string`, `boolean`; unknown fields refused. **Order of delivery:** this controller (and the builder, built from this repository) must be delivered before the catalogue change that adds `predefined.json` and `preferences`: the running controller's strict parser refuses the unknown `preferences` field, and an older builder does not carry the list. Until a catalogue build with the file lands, the list is empty and any manifest using `predefined` is refused at registration. ## Store (migration 0096-config-values-come-from-four-sources) - `predefined_key (key pk, type check in (number,string,boolean), why, repository, commit, listed_at)` — replaced whole. - `config (key, node uuid null = mesh, value jsonb, set_at, set_by, why not null)`, unique per key for the mesh and per (key, node). - `config_history (key, node, value, set_at, set_by, why, replaced_at, replaced_by set|clear, replaced_why)`. - **Data move**: each whole-mesh module layer (`settings` row with node null) is laid under the layer of every node the module is assigned to (deep merge as composition merged, the node's values winning). Every node layer replaced and the whole-mesh layer itself are copied to `settings_history` with `replaced_by = moved-to-nodes`; then the whole-mesh rows are deleted. Known one: artifact-store-tools `older-store-names` → novox's layer. A whole-mesh layer of a module assigned nowhere (or only pulled in as a requirement, without an assignment row) is kept only in the history. - This repository has no separate consolidated schema: a fresh install runs every numbered migration, so the migration is the schema for both. ## Tests - `internal/catalogue/preferences_test.go`: the list read strictly; preferences declared and refused; `predefined` not on the list / other type; config layers fill `${setting:}` in order and never a mergeable file. - `internal/inventory/config_test.go`: each of the four sources in turn, most specific winning, clearing each falls back, history with why; refusals (not predefined, wrong type, no why, unknown node, module value without node); registration refusals; the 0096 data move (merge, history, unassigned node untouched). - `cmd/mesh-controller/config_test.go`: the verb's line and refusals; end to end through the verb into g14-like `dunstrc` content as composed (cleared → 10; mesh 11; node 13; dunst on node 15; then each clear falls back); the module check against `predefined.json`. - Existing settings/trust tests adjusted for no whole-mesh module layer (they keep one with `KeepSettings` where they test an existing one). - Run locally: `gofmt`, `go vet ./...`, `go test ./...` and `sh merge-check.sh` all pass against a throwaway PostgreSQL 18.6 (the mesh runs 17; `TestTheStoreTheTestsRunIsTheStoreTheMeshRuns` passed regardless). ## Acceptance (live) After this and the catalogue change are delivered, on g14's dunst: with no config, g14's dunstrc says `font = Inter 10`; `config key=font-size value=11 why=…` → 11 in g14's dunstrc after `push g14`; `config key=font-size node=g14 value=13` → 13; `config key=font-size node=g14 module=dunst value=15` → 15; clearing each in reverse falls back 13 → 11 → 10. g14's current dunst layer (font-size 13, width 500) is a module-assignment value and stays as it is.
mesh-admin added 8 commits 2026-10-13 13:20:08 +00:00
Declare preferences with a type and a predefined key, and lay mesh and node config between default and node (hq issue 630) 3d16515771 
A preference may fall back to one reviewed mesh-wide or node-wide value instead of a module layer for the whole mesh; like a default, config fills ${setting:} only.
Carry the catalogue's predefined.json with a build, and declare the config verb (hq issue 630) fba6a7c454 
The controller only learns manifests through builds, so the list of predefined keys travels the same way: the builder reads it at the catalogue's root, judges the manifest against it and hands it on.
Keep mesh and node config with their history, and move whole-mesh module layers onto each assigned node (hq issue 630) df5254f308 
An assignment is one module on one node, so a new whole-mesh layer is refused and the ones held are laid under each assigned node's layer, every replaced layer kept, so no machine composes differently.
Test the four sources, the refusals and the move of whole-mesh module layers (hq issue 630) ea4c318404
Add the config command: mesh, node and module values in one call, with why and history (hq issue 630) 0c31ca0eaf 
One place to set each of the three sources over a default, refusing what is not a predefined key and a module value without a node, recorded in the hand-act log like any act by hand.
Keep the list from a catalogue build, and carry it and mesh and node config through the facts and the gate (hq issue 630) 3f9b935c25 
The merge gate must compose with the same config the mesh holds, and judge a catalogue change against the list it brings.
Serve config as a seat verb, and say each value's source as one of the four (hq issue 630) c9b63f61bd 
The listings named a node's own value "the node", which now could be node config; they say "<module> on <node>" for the module's own value instead.
Test config end to end into a composed file, and hold the settings tests to no whole-mesh module layer (hq issue 630)
mesh/delivery stopped: the pull request closed unmerged
Details
mesh/merge-gate out of date: judged against trunk 6f1a05366c1d, the trunk is now 8ddf8b700558; judged again on a recheck or when it is merged
Details
mesh/repo-check out of date: judged against trunk 6f1a05366c1d, the trunk is now 8ddf8b700558; judged again on a recheck or when it is merged
Details
660649eeed
mesh-admin commented 2026-10-13 13:20:42 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-controller@660649eeed1c — stopped since 2026-10-13T22:07:43Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Transitions

  • 2026-10-13 13:20 (new) → proposed (announced): novox/mesh-controller#303's head announced
  • 2026-10-13 13:26 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 13:26 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 17:22 ready → proposed (trunk moved): out of date: judged against trunk 6f1a05366c, the trunk is now 8ddf8b700558; judged again on a recheck or when it is merged
  • 2026-10-13 22:07 proposed → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@660649eeed1c` — **stopped** since 2026-10-13T22:07:43Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Transitions** - 2026-10-13 13:20 (new) → proposed (announced): novox/mesh-controller#303's head announced - 2026-10-13 13:26 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 13:26 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 17:22 ready → proposed (trunk moved): out of date: judged against trunk 6f1a05366c1d, the trunk is now 8ddf8b700558; judged again on a recheck or when it is merged - 2026-10-13 22:07 proposed → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin commented 2026-10-13 13:26:35 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 660649ee
Judged: head 660649eeed1c merged into trunk 6f1a05366c1d; read beside it: mesh-catalog a84d0094a0a3, mesh-controller-main 6f1a05366c1d, mesh-host 0e92ef3d1b21, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/config_test.go, cmd/mesh-controller/facts_test.go, cmd/mesh-controller/settings_effective_test.go, cmd/mesh-controller/terminal_settings_test.go, internal/catalogue/preferences_test.go, internal/inventory/config_test.go, internal/inventory/forget_test.go, internal/inventory/settings_judged_test.go, internal/inventory/unseen_test.go

Run by the build seat on ace as build-1791897639024454067 (builds --log build-1791897639024454067).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 59 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T13:17:29Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T13:17:29Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/config_test.go, cmd/mesh-controller/facts_test.go, cmd/mesh-controller/settings_effective_test.go, cmd/mesh-controller/terminal_settings_test.go, internal/catalogue/preferences_test.go, internal/inventory/config_test.go, internal/inventory/forget_test.go, internal/inventory/settings_judged_test.go and internal/inventory/unseen_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.045s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	182.684s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.032s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.042s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.184s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.079s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.380s
ok  	github.com/novox/mesh-controller/internal/builder	38.214s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.945s
ok  	github.com/novox/mesh-controller/internal/conditions	2.744s
ok  	github.com/novox/mesh-controller/internal/envfile	1.048s
ok  	github.com/novox/mesh-controller/internal/facts	1.043s
ok  	github.com/novox/mesh-controller/internal/identity	5.337s
ok  	github.com/novox/mesh-controller/internal/inventory	35.922s
ok  	github.com/novox/mesh-controller/internal/lease	17.674s
ok  	github.com/novox/mesh-controller/internal/licences	4.377s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.054s
ok  	github.com/novox/mesh-controller/internal/link	59.702s
ok  	github.com/novox/mesh-controller/internal/lint	2.444s
ok  	github.com/novox/mesh-controller/internal/outward	1.097s
ok  	github.com/novox/mesh-controller/internal/overlay	1.074s
ok  	github.com/novox/mesh-controller/internal/secrets	1.460s
ok  	github.com/novox/mesh-controller/internal/store	3.605s
ok  	github.com/novox/mesh-controller/internal/testbus	1.269s
ok  	github.com/novox/mesh-controller/internal/token	1.019s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.22s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.23s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.23s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.21s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.20s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.18s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.96s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.25s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.14s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.25s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.25s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.22s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.20s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.27s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.21s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.25s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.22s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.23s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.22s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.20s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.23s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.31s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.29s)
  ./cmd/mesh-controller --- PASS: TestReplay201 (0.16s)
  ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.16s)
  ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.16s)
  ./cmd/mesh-controller --- PASS: TestReplay401 (0.30s)
  ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.25s)
  ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.31s)
  ./cmd/mesh-controller --- PASS: TestReplay340 (0.26s)
  ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.20s)
  ./cmd/mesh-controller --- PASS: TestReplay349 (0.21s)
  ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.15s)
  ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.08s)
  ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.48s)
  ./cmd/mesh-controller --- PASS: TestReplay164 (0.29s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.08s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.08s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.10s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.07s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.07s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s)
  ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s)
  ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.07s)
  ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.08s)
  ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.09s)
  ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.08s)
**Merge check** at `660649ee` Judged: head `660649eeed1c` merged into trunk `6f1a05366c1d`; read beside it: mesh-catalog `a84d0094a0a3`, mesh-controller-main `6f1a05366c1d`, mesh-host `0e92ef3d1b21`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/config_test.go, cmd/mesh-controller/facts_test.go, cmd/mesh-controller/settings_effective_test.go, cmd/mesh-controller/terminal_settings_test.go, internal/catalogue/preferences_test.go, internal/inventory/config_test.go, internal/inventory/forget_test.go, internal/inventory/settings_judged_test.go, internal/inventory/unseen_test.go Run by the build seat on ace as `build-1791897639024454067` (`builds --log build-1791897639024454067`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 59 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T13:17:29Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T13:17:29Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/config_test.go, cmd/mesh-controller/facts_test.go, cmd/mesh-controller/settings_effective_test.go, cmd/mesh-controller/terminal_settings_test.go, internal/catalogue/preferences_test.go, internal/inventory/config_test.go, internal/inventory/forget_test.go, internal/inventory/settings_judged_test.go and internal/inventory/unseen_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.045s ok github.com/novox/mesh-controller/cmd/mesh-controller 182.684s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.032s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.042s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.026s ok github.com/novox/mesh-controller/examples/route-proxy 1.184s ok github.com/novox/mesh-controller/internal/artifacts 1.079s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.380s ok github.com/novox/mesh-controller/internal/builder 38.214s ok github.com/novox/mesh-controller/internal/catalogue 8.945s ok github.com/novox/mesh-controller/internal/conditions 2.744s ok github.com/novox/mesh-controller/internal/envfile 1.048s ok github.com/novox/mesh-controller/internal/facts 1.043s ok github.com/novox/mesh-controller/internal/identity 5.337s ok github.com/novox/mesh-controller/internal/inventory 35.922s ok github.com/novox/mesh-controller/internal/lease 17.674s ok github.com/novox/mesh-controller/internal/licences 4.377s ok github.com/novox/mesh-controller/internal/licences/adapters 1.054s ok github.com/novox/mesh-controller/internal/link 59.702s ok github.com/novox/mesh-controller/internal/lint 2.444s ok github.com/novox/mesh-controller/internal/outward 1.097s ok github.com/novox/mesh-controller/internal/overlay 1.074s ok github.com/novox/mesh-controller/internal/secrets 1.460s ok github.com/novox/mesh-controller/internal/store 3.605s ok github.com/novox/mesh-controller/internal/testbus 1.269s ok github.com/novox/mesh-controller/internal/token 1.019s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.22s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.23s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.23s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.21s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.20s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.18s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.96s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.25s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.14s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.25s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.25s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.22s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.20s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.27s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.21s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.25s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.22s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.23s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.22s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.20s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.23s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.31s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.29s) ./cmd/mesh-controller --- PASS: TestReplay201 (0.16s) ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.16s) ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.16s) ./cmd/mesh-controller --- PASS: TestReplay401 (0.30s) ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.25s) ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.31s) ./cmd/mesh-controller --- PASS: TestReplay340 (0.26s) ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.20s) ./cmd/mesh-controller --- PASS: TestReplay349 (0.21s) ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.19s) ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.15s) ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.19s) ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.08s) ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.48s) ./cmd/mesh-controller --- PASS: TestReplay164 (0.29s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.08s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.08s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.10s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.07s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.07s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s) ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s) ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.07s) ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.08s) ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.09s) ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.08s) ```
mesh-admin closed this pull request 2026-10-13 21:46:49 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#303