novox/mesh-controller
8
0
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

Compose the forge in its manifest tests with the operator's account (issue 869) #349

Merged
mesh-tools merged 1 commits from fix/869-forge-tests-name-an-account into main 2026-10-15 23:46:21 +00:00
Conversation 3 Commits 1 Files Changed 1
+2 -2
mesh-tools commented 2026-10-15 23:36:40 +00:00
Member
Copy Link
Copy Source

Issue 869: mesh-controller main fails its own merge check. Three tests in internal/catalogue (TestTheForgesOwnAddressFollowsThePortTheNodeGaveIt, TestTheForgesSshPortIsTheMeshsFixedConventionByDefault, TestANodeMayGiveTheForgesSshPortADifferentNumber) compose the gitea manifest beside the check, which names its patch spool's owner ${machine:account} since mesh-catalog d4b8b247 (issue 852), with a Resolution that has no Account. Gives both Resolution literals Account "op", as the mesh composes a machine with an operator account. internal/catalogue passes beside mesh-catalog main 62ec6835. Independent Opus review: APPROVE at this content (local 62426f04, tree 0b6db613 equal). Blocks every mesh-controller pull request into main, issue 867's #348 among them.

Issue 869: mesh-controller main fails its own merge check. Three tests in internal/catalogue (TestTheForgesOwnAddressFollowsThePortTheNodeGaveIt, TestTheForgesSshPortIsTheMeshsFixedConventionByDefault, TestANodeMayGiveTheForgesSshPortADifferentNumber) compose the gitea manifest beside the check, which names its patch spool's owner ${machine:account} since mesh-catalog d4b8b247 (issue 852), with a Resolution that has no Account. Gives both Resolution literals Account "op", as the mesh composes a machine with an operator account. internal/catalogue passes beside mesh-catalog main 62ec6835. Independent Opus review: APPROVE at this content (local 62426f04, tree 0b6db613 equal). Blocks every mesh-controller pull request into main, issue 867's #348 among them.
mesh-tools added 1 commit 2026-10-15 23:36:40 +00:00
Compose the forge in its manifest tests with the operator's account, as the mesh does (issue 869)
mesh/merge-gate head e42d72a80a62 merged into trunk 7543f64911c5 — pass: the change touches no module of the mesh's graph
Details
mesh/repo-check head e42d72a80a62 merged into trunk 7543f64911c5 — pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
e42d72a80a 
The gitea manifest names its patch spool's owner ${machine:account} since mesh-catalog d4b8b247 (issue 852); these tests gave the machine no account, so main failed its own merge check.

Co-Authored-By: Claude <noreply@anthropic.com>
mesh-tools commented 2026-10-15 23:36:49 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-controller@e42d72a80a62 — delivered since 2026-10-15T23:46:24Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-15 23:36 (new) → proposed (announced): novox/mesh-controller#349's head announced
  • 2026-10-15 23:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-15 23:41 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
  • 2026-10-15 23:42 rejected → proposed (recheck): issue 869: the check could not run (shanks could not clone mesh-host beside it, exit 128); the same seat cloned beside #325 at 01:30. One recheck to tell a passing fault from a lasting one.
  • 2026-10-15 23:45 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-15 23:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-15 23:46 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-15 23:46 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@e42d72a80a62` — **delivered** since 2026-10-15T23:46:24Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-15 23:36 (new) → proposed (announced): novox/mesh-controller#349's head announced - 2026-10-15 23:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-15 23:41 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-15 23:42 rejected → proposed (recheck): issue 869: the check could not run (shanks could not clone mesh-host beside it, exit 128); the same seat cloned beside #325 at 01:30. One recheck to tell a passing fault from a lasting one. - 2026-10-15 23:45 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-15 23:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-15 23:46 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-15 23:46 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-tools commented 2026-10-15 23:41:27 +00:00
Author
Member
Copy Link
Copy Source

Merge check at e42d72a8

Run by the build seat on shanks as build-1792107402394446161 (builds --log build-1792107402394446161).

**Merge check** at `e42d72a8` - `mesh/merge-gate`: **ERROR** — the check could not run: beside it, cannot clone http://novox.internal:20000/novox/mesh-host.git: git -c credential.helper= -c credential.helper=store --file=/tmp/mesh-forge-credential-3025630548/git-credentials clone --quiet http://novox.internal:20000/novox/mesh-host.git mesh-host: exit status 128 - `mesh/repo-check`: **ERROR** — the check could not run: beside it, cannot clone http://novox.internal:20000/novox/mesh-host.git: git -c credential.helper= -c credential.helper=store --file=/tmp/mesh-forge-credential-3025630548/git-credentials clone --quiet http://novox.internal:20000/novox/mesh-host.git mesh-host: exit status 128 Run by the build seat on shanks as `build-1792107402394446161` (`builds --log build-1792107402394446161`).
mesh-tools added the mesh/ready label 2026-10-15 23:45:56 +00:00
mesh-tools commented 2026-10-15 23:46:02 +00:00
Author
Member
Copy Link
Copy Source

ready at e42d72a80a

ready at e42d72a80a62aec8415dfbb419368dcb0336b387
mesh-tools merged commit 4446027108 into main 2026-10-15 23:46:21 +00:00
mesh-tools deleted branch fix/869-forge-tests-name-an-account 2026-10-15 23:46:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels mesh/ready
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben mesh-tools miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#349