Pin mesh-sdk at the fix that refuses an unresolvable machine alone (issue 1833) #437

Merged

mesh-tools merged 2 commits from fix/1833-one-machine-alone into main 2026-10-22 16:10:20 +00:00

Conversation 2 Commits 2 Files Changed 5

+25 -8

mesh-tools commented 2026-10-22 13:47:38 +00:00

Member

Copy Link

Copy Source

Issue 1833 (critical): one machine whose own modules could not be resolved held every send to every machine.

Delivery group fix/1833-one-machine-alone: mesh-sdk (the fix, in go/compose) and this pull request, which pins mesh-sdk at bd7731f3 (v0.1.14-0.20261022132648-bd7731f3588c), re-vendors it (only compose/network.go changes) and moves testdata/beside/CAPTURED to it. No controller code changes: compose_input.go reads every machine's place before resolution.

Try: build-1792675658499047472 passed at 28a278c1 (unit level 1530 tests in 1.98 s).

Reviewed-by: reviewer-1833@shanks at 28a278c146
Pushed-by: fix-1833@shanks

Issue 1833 (critical): one machine whose own modules could not be resolved held every send to every machine. Delivery group `fix/1833-one-machine-alone`: mesh-sdk (the fix, in go/compose) and this pull request, which pins mesh-sdk at bd7731f3 (v0.1.14-0.20261022132648-bd7731f3588c), re-vendors it (only compose/network.go changes) and moves testdata/beside/CAPTURED to it. No controller code changes: compose_input.go reads every machine's place before resolution. Try: build-1792675658499047472 passed at 28a278c1 (unit level 1530 tests in 1.98 s). Reviewed-by: reviewer-1833@shanks at 28a278c1462a0a2ab1a6e404a089315bbd728dd5 Pushed-by: fix-1833@shanks

mesh-tools added 2 commits 2026-10-22 13:47:38 +00:00

Take mesh-sdk at c154bde: a machine that does not resolve keeps its place on the private network, so it alone is refused (issue 1833) ... c34ab0e43a

One machine whose modules could not be resolved left the private network uncomposable when it was the hub, and every
send to every machine was held. The SDK now keeps a refused machine at the place the controller already holds for it.

Take mesh-sdk at bd7731f: a machine that does not resolve keeps its name and its address in the mesh as well as its tunnel (issue 1833) 28a278c146

mesh-tools commented 2026-10-22 13:47:48 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-controller@28a278c1462a — delivered since 2026-10-22T16:38:22Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

• tier 0: mesh-controller
• tier 1: build-agent
• ace: receives build-agent
• g14: receives build-agent
• novox: receives mesh-controller, build-agent
• shanks: receives build-agent
• build-agent keeps data (ADR 0233): what it holds is backed up before it moves
• grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Group fix/1833-one-machine-alone: novox/mesh-controller@28a278c146, novox/mesh-sdk@bd7731f358

• composed together: pass — every machine composes with the change as it did without (4 of 4 compose)

Machines

• mesh-controller on every machine running it: sent
• mesh-sdk on every machine running it: sent
• build-agent on every machine running it: sent
• mesh-tools on every machine running it: sent
• audit-logger on every machine running it: sent
• baserow on every machine running it: sent
• bazarr on every machine running it: sent
• bookshelf on every machine running it: sent
• confluence on every machine running it: sent
• gitea on every machine running it: sent
• gitlab on every machine running it: sent
• grafana on every machine running it: sent
• home-assistant on every machine running it: sent
• icecast on every machine running it: sent
• influxdb on every machine running it: sent
• jackett on every machine running it: sent
• jira on every machine running it: sent
• kometa on every machine running it: sent
• lab on every machine running it: sent
• letta on every machine running it: sent
• lidarr on every machine running it: sent
• mesh-catalog on every machine running it: sent
• model-usage on every machine running it: sent
• mosquitto on every machine running it: sent
• netcheck on every machine running it: sent
• nextcloud on every machine running it: sent
• nodered on every machine running it: sent
• ombi on every machine running it: sent
• openai-consumer on every machine running it: sent
• radarr on every machine running it: sent
• redis on every machine running it: sent
• route-adapter on every machine running it: sent
• searxng on every machine running it: sent
• showcase on every machine running it: sent
• sonarr on every machine running it: sent
• tautulli on every machine running it: sent
• umami on every machine running it: sent
• unifi on every machine running it: sent
• zsh on every machine running it: sent

Transitions

• 2026-10-22 13:59 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-22 13:59 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-22 14:01 ready → proposed (trunk moved): out of date: judged against trunk 8f2d22db0c, the trunk is now b8f77577fed2; judged again on a recheck or when it is merged
• 2026-10-22 15:42 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-22 15:42 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
• 2026-10-22 15:43 rejected → proposed (recheck): lead-47@shanks: the check failed in a test on main that #437 does not touch (TestTheRestGateWaitsForTheProvisioner, a database name holding a colon, issue 1853, first meeting); the same test passed in mesh-controller #438's check at 17:15. Asked again so the 1833 group is judged on its own change; a second failure starts 1853's fix.
• 2026-10-22 15:43 proposed → proposed (check lost): its check build-1792676875362712196, asked 1h55m28s ago, is held by no entry of the build queue (neither waiting nor in flight): lost, asked again — asked as build-1792683808171454376
• 2026-10-22 15:55 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-22 15:55 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-22 16:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-22 16:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-22 16:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@28a278c1462a` — **delivered** since 2026-10-22T16:38:22Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Group** `fix/1833-one-machine-alone`: novox/mesh-controller@28a278c1462a, novox/mesh-sdk@bd7731f3588c - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on every machine running it: sent - mesh-sdk on every machine running it: sent - build-agent on every machine running it: sent - mesh-tools on every machine running it: sent - audit-logger on every machine running it: sent - baserow on every machine running it: sent - bazarr on every machine running it: sent - bookshelf on every machine running it: sent - confluence on every machine running it: sent - gitea on every machine running it: sent - gitlab on every machine running it: sent - grafana on every machine running it: sent - home-assistant on every machine running it: sent - icecast on every machine running it: sent - influxdb on every machine running it: sent - jackett on every machine running it: sent - jira on every machine running it: sent - kometa on every machine running it: sent - lab on every machine running it: sent - letta on every machine running it: sent - lidarr on every machine running it: sent - mesh-catalog on every machine running it: sent - model-usage on every machine running it: sent - mosquitto on every machine running it: sent - netcheck on every machine running it: sent - nextcloud on every machine running it: sent - nodered on every machine running it: sent - ombi on every machine running it: sent - openai-consumer on every machine running it: sent - radarr on every machine running it: sent - redis on every machine running it: sent - route-adapter on every machine running it: sent - searxng on every machine running it: sent - showcase on every machine running it: sent - sonarr on every machine running it: sent - tautulli on every machine running it: sent - umami on every machine running it: sent - unifi on every machine running it: sent - zsh on every machine running it: sent **Transitions** - 2026-10-22 13:59 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-22 13:59 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-22 14:01 ready → proposed (trunk moved): out of date: judged against trunk 8f2d22db0caa, the trunk is now b8f77577fed2; judged again on a recheck or when it is merged - 2026-10-22 15:42 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-22 15:42 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-22 15:43 rejected → proposed (recheck): lead-47@shanks: the check failed in a test on main that #437 does not touch (TestTheRestGateWaitsForTheProvisioner, a database name holding a colon, issue 1853, first meeting); the same test passed in mesh-controller #438's check at 17:15. Asked again so the 1833 group is judged on its own change; a second failure starts 1853's fix. - 2026-10-22 15:43 proposed → proposed (check lost): its check build-1792676875362712196, asked 1h55m28s ago, is held by no entry of the build queue (neither waiting nor in flight): lost, asked again — asked as build-1792683808171454376 - 2026-10-22 15:55 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-22 15:55 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-22 16:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-22 16:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-22 16:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-22 15:42:28 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: not merged. This pull request's checks passed at 28a278c146, and now its check failed: judged by its group's composed check (head 28a278c146 merged into trunk 11e364bd43). A new head, or a recheck that passes, asks the operator again.

mesh-delivery: **not merged.** This pull request's checks passed at 28a278c1462a0a2ab1a6e404a089315bbd728dd5, and now its check failed: judged by its group's composed check (head 28a278c1462a merged into trunk 11e364bd439f). A new head, or a recheck that passes, asks the operator again.

mesh-tools merged commit 41c9628757 into main 2026-10-22 16:10:20 +00:00

mesh-tools deleted branch fix/1833-one-machine-alone 2026-10-22 16:10:21 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#437