gitea's ssh port test matched a manifest mistake; resolver test used Names, not Machines #59

2026-09-25T15:23:41Z

jschoubben commented

2026-09-25 15:23:41 +00:00

Two independent, pre-existing test fixes found while investigating failing tests tonight — neither caused by tonight's other work, both real.

TestTheForgesSshPortIsGivenByTheNumberTheForgeCallsIt exercised a settings override from 2222 to 222, but 2222 was never a real port anywhere — a mistake in gitea's own manifest (fixed separately in mesh-catalog). Split into two tests: the fixed default with no override, and a genuine override case for a hypothetical node whose predecessor used a different number.

TestTheResolverAndWhatAsksItComposeOnOneMachine set Rendering.Names but FactNodeZones reads Rendering.Machines (issue 111 split the two apart) — a loose end from that merge.

Full suite passes except the three TestTheBuildersCarriedPackageBinding* tests, which are a real, separately-filed gap (hq issue 117) left failing on purpose.

Two independent, pre-existing test fixes found while investigating failing tests tonight — neither caused by tonight's other work, both real. `TestTheForgesSshPortIsGivenByTheNumberTheForgeCallsIt` exercised a settings override from `2222` to `222`, but `2222` was never a real port anywhere — a mistake in gitea's own manifest (fixed separately in mesh-catalog). Split into two tests: the fixed default with no override, and a genuine override case for a hypothetical node whose predecessor used a different number. `TestTheResolverAndWhatAsksItComposeOnOneMachine` set `Rendering.Names` but `FactNodeZones` reads `Rendering.Machines` (issue 111 split the two apart) — a loose end from that merge. Full suite passes except the three `TestTheBuildersCarriedPackageBinding*` tests, which are a real, separately-filed gap (hq issue 117) left failing on purpose.

jschoubben added 1 commit 2026-09-25 15:23:42 +00:00

gitea's ssh port test matched a manifest mistake; resolver test used Names, not Machines af26ed2e07

TestTheForgesSshPortIsGivenByTheNumberTheForgeCallsIt exercised a settings
override from '2222' to 222 — but 2222 was never a real port anywhere,
just a mistake in gitea's own manifest (fixed alongside this: listens.port
is now 22, the container's real internal sshd port, matching every other
module's convention, and ports declares 222:22 directly — 222 has always
been the real, fixed public git-ssh port, needing no per-node override).
Split into two tests: the fixed default with no override, and a genuine
override case for a hypothetical node whose predecessor used a different
number, keyed correctly by 22.

TestTheResolverAndWhatAsksItComposeOnOneMachine set Rendering.Names but
FactNodeZones reads Rendering.Machines (novox/hq issue 111 split the two
apart: every name the mesh serves vs. the machines subset) — a loose end
from that merge, not exercised until now. Both are the same map in this
test's scenario, so both fields are set.

jschoubben merged commit 2652287fe1 into main

2026-09-25 15:23:49 +00:00

jschoubben deleted branch fix/gitea-ssh-port-and-resolver-machines-test

2026-09-25 15:23:49 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#59