Fill ${setting:} in a service's unit name, and refuse a value that makes no unit name #171

Merged

mesh-admin merged 2 commits from feat/setting-in-a-unit-name into main 2026-10-09 00:32:51 +00:00

Conversation 4 Commits 2 Files Changed 3

+234 -6

2 Commits

Author	SHA1	Message	Date
jochen	eb5f9d2f53	Allow a setting in a unit's name only as a template's whole instance, never leading with a dash, at most 64 characters ... Third review of mesh-catalog #147. A setting anywhere else in a unit's name could make the unit another unit or another kind; it is now refused where the manifest is read. A value beginning with '-' would be read by systemctl as an option, and a long one is no pool's name.	2026-10-09 01:51:37 +02:00
jochen	e4d2868679	Fill ${setting:} in a service's unit name, and refuse a value that makes no unit name ... A module that holds the distribution's scrub timer for the pool the operator names (zfs-scrub-weekly@<pool>.timer) cannot write the pool into its definition (hq ADR 0112). Settings were substituted only into file content, so the unit reached the machine as "zfs-scrub-weekly@${setting:scrub-pool}.timer", a unit no machine has, and the apply failed far from its cause (second review of mesh-catalog #147). A service's unit now takes ${setting:} from the same layers a file does, and is refused by key when nothing sets it. A value is also refused unless it is only letters, digits, ':', '_', '.' and '-': the name ends up in unit files and systemctl arguments, and a space, a slash or a newline must never reach them. A key a unit asks for is not called stray.	2026-10-09 01:32:32 +02:00