Say a walk's phases out of order unknown, never a negative time (hq issue 382) #208

Merged
mesh-admin merged 1 commits from fix/382-phases-out-of-order into main 2026-10-10 19:36:52 +00:00
Contributor

Follow-up to #206, found by the review of mesh-catalog #188 and seen live: #206's own walk kept its first send (18:51:53.762) 783 ms before its build (18:51:54.545), and delivery-walks said send-first measured at -783 ms.

A moment recorded before the one before it now makes both phases unknown (said "out of order"): the earlier one's measured time joins the unknown time, the later one has no time, and the walk goes on from the later moment. Measured phases plus unknown time still equal the total; nothing negative is said or kept as a walk-phase duration.

Test: TestMomentsOutOfOrderAreUnknownNeverNegative replays #206's case on the recorded walk. internal/inventory passes whole against postgres 17.

Not changed: walk-phase durations already kept from #206's walk (one row of -783 ms under core/send-first, if it was kept) age out with the others; the store is not edited by hand.

Follow-up to #206, found by the review of mesh-catalog #188 and seen live: #206's own walk kept its first send (18:51:53.762) 783 ms before its build (18:51:54.545), and delivery-walks said send-first measured at -783 ms. A moment recorded before the one before it now makes both phases unknown (said "out of order"): the earlier one's measured time joins the unknown time, the later one has no time, and the walk goes on from the later moment. Measured phases plus unknown time still equal the total; nothing negative is said or kept as a walk-phase duration. Test: TestMomentsOutOfOrderAreUnknownNeverNegative replays #206's case on the recorded walk. internal/inventory passes whole against postgres 17. Not changed: walk-phase durations already kept from #206's walk (one row of -783 ms under core/send-first, if it was kept) age out with the others; the store is not edited by hand.
mesh-admin added 1 commit 2026-10-10 19:15:56 +00:00
Say a walk's phases out of order unknown, never a negative time (hq issue 382)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
12d4025d30
#206's own walk kept its first send 783 ms before its build, and delivery
walks said send-first measured at -783 ms. A moment recorded before the
one before it now makes both phases unknown: the earlier one's time joins
the unknown time, the later one has none, and the walk goes on from the
later moment. Measured phases and unknown time still add up to the total.
Author
Contributor

Delivery novox/mesh-controller@12d4025d303a — delivered since 2026-10-10T19:48:25Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m37s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m30s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-10 19:16 (new) → proposed (announced): novox/mesh-controller#208's head announced
  • 2026-10-10 19:21 proposed → checked (checked): the verdict names this commit
  • 2026-10-10 19:21 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-10 19:38 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-10 19:38 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-10 19:48 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@12d4025d303a` — **delivered** since 2026-10-10T19:48:25Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m37s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m30s - build-agent on the rest running it: sent **Transitions** - 2026-10-10 19:16 (new) → proposed (announced): novox/mesh-controller#208's head announced - 2026-10-10 19:21 proposed → checked (checked): the verdict names this commit - 2026-10-10 19:21 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-10 19:38 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-10 19:38 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-10 19:48 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 12d4025d

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/inventory/walkphases_test.go

Run by the build seat on ace as build-1791659766851665108 (builds --log build-1791659766851665108).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T19:11:59Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-10T19:11:59Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/inventory/walkphases_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.033s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	201.356s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.021s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.118s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.089s
ok  	github.com/novox/mesh-controller/internal/broker	2.609s
ok  	github.com/novox/mesh-controller/internal/builder	2.463s
ok  	github.com/novox/mesh-controller/internal/catalogue	4.573s
ok  	github.com/novox/mesh-controller/internal/conditions	2.481s
ok  	github.com/novox/mesh-controller/internal/envfile	1.064s
ok  	github.com/novox/mesh-controller/internal/facts	1.056s
ok  	github.com/novox/mesh-controller/internal/identity	4.177s
ok  	github.com/novox/mesh-controller/internal/inventory	76.130s
ok  	github.com/novox/mesh-controller/internal/lease	17.686s
ok  	github.com/novox/mesh-controller/internal/licences	3.752s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.051s
ok  	github.com/novox/mesh-controller/internal/link	51.399s
ok  	github.com/novox/mesh-controller/internal/lint	2.090s
ok  	github.com/novox/mesh-controller/internal/outward	1.085s
ok  	github.com/novox/mesh-controller/internal/overlay	1.079s
ok  	github.com/novox/mesh-controller/internal/secrets	1.437s
ok  	github.com/novox/mesh-controller/internal/store	3.310s
ok  	github.com/novox/mesh-controller/internal/testbus	1.234s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `12d4025d` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/inventory/walkphases_test.go Run by the build seat on ace as `build-1791659766851665108` (`builds --log build-1791659766851665108`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T19:11:59Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-10T19:11:59Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/inventory/walkphases_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.033s ok github.com/novox/mesh-controller/cmd/mesh-controller 201.356s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.013s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.021s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.014s ok github.com/novox/mesh-controller/examples/route-proxy 1.118s ok github.com/novox/mesh-controller/internal/artifacts 1.089s ok github.com/novox/mesh-controller/internal/broker 2.609s ok github.com/novox/mesh-controller/internal/builder 2.463s ok github.com/novox/mesh-controller/internal/catalogue 4.573s ok github.com/novox/mesh-controller/internal/conditions 2.481s ok github.com/novox/mesh-controller/internal/envfile 1.064s ok github.com/novox/mesh-controller/internal/facts 1.056s ok github.com/novox/mesh-controller/internal/identity 4.177s ok github.com/novox/mesh-controller/internal/inventory 76.130s ok github.com/novox/mesh-controller/internal/lease 17.686s ok github.com/novox/mesh-controller/internal/licences 3.752s ok github.com/novox/mesh-controller/internal/licences/adapters 1.051s ok github.com/novox/mesh-controller/internal/link 51.399s ok github.com/novox/mesh-controller/internal/lint 2.090s ok github.com/novox/mesh-controller/internal/outward 1.085s ok github.com/novox/mesh-controller/internal/overlay 1.079s ok github.com/novox/mesh-controller/internal/secrets 1.437s ok github.com/novox/mesh-controller/internal/store 3.310s ok github.com/novox/mesh-controller/internal/testbus 1.234s ok github.com/novox/mesh-controller/internal/token 1.016s ```
mesh-admin merged commit c06a2cd972 into main 2026-10-10 19:36:52 +00:00
mesh-admin deleted branch fix/382-phases-out-of-order 2026-10-10 19:36:52 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#208