A provider whose wait fails its check lists who waits on it (issue 450) #221

Merged
mesh-admin merged 1 commits from fix/450-a-provider-whose-wait-fails-lists-its-waiters into main 2026-10-11 02:19:02 +00:00
Contributor

Fixes novox/hq issue 450 (consumers held under a provider whose wait failed its check are never listed on the provider's condition). Follows mesh-controller #216 (issue 405) under ADR 0292 and ADR 0283.

Cause. The holding read every machine's newest statement as stored, which is what the machine said with its waits unchecked. A provider whose wait fails the check (ADR 0283 decision 3) is judged unhealthy and raises module.<m>.<machine>.unhealthy, but sayWaiters read it as waiting, built the needs-operator key, found it not open and returned nil. The held consumers were not listed and the condition was not made urgent.

Fix. holding.checked(machine) reads a statement as it was judged: checkWaiting against the wait facts (manifests from the holding's catalogue, given secrets read through readWaitFacts, memoised on the holding). sayWaiters and providerState both use it. Consumers of a provider whose wait failed are therefore held under it as under any unhealthy provider, never as waiting for the operator, also before the provider's own condition opens. ADR 0292's rules hold: only covered consumers are held under a truly waiting provider, and a needs-operator condition stays a warning.

Tests (no store).

  • TestAProviderWhoseWaitFailedItsCheckListsWhoWaitsOnIt fails on main: the consumer is held (only the provider's condition is open), but that condition does not list shop on laptop (... says it waits for the secret certificate, which db does not declare, 0 look(s) ...). It passes with the fix.
  • TestAProviderWaitingForASecretAlreadyGivenIsUnhealthyToItsConsumers covers the issue's exact case: a licence that was already given makes the consumer held as under an unhealthy provider, with no waits.
  • #216's fixture holdingOf now declares the database's licence and backup-key as own secrets issued outside the mesh and reads nothing given on anchor. Its waits named undeclared secrets, which only passed because the holding never checked them.

go vet ./... and go test ./cmd/mesh-controller/ -count=1 pass. The change touches no file of the open PRs #218, #219 or #220.

Fixes novox/hq issue 450 (consumers held under a provider whose wait failed its check are never listed on the provider's condition). Follows mesh-controller #216 (issue 405) under ADR 0292 and ADR 0283. **Cause.** The holding read every machine's newest statement as stored, which is what the machine said with its waits unchecked. A provider whose wait fails the check (ADR 0283 decision 3) is judged unhealthy and raises `module.<m>.<machine>.unhealthy`, but `sayWaiters` read it as waiting, built the needs-operator key, found it not open and returned nil. The held consumers were not listed and the condition was not made urgent. **Fix.** `holding.checked(machine)` reads a statement as it was judged: `checkWaiting` against the wait facts (manifests from the holding's catalogue, given secrets read through `readWaitFacts`, memoised on the holding). `sayWaiters` and `providerState` both use it. Consumers of a provider whose wait failed are therefore held under it as under any unhealthy provider, never as waiting for the operator, also before the provider's own condition opens. ADR 0292's rules hold: only covered consumers are held under a truly waiting provider, and a needs-operator condition stays a warning. **Tests (no store).** - `TestAProviderWhoseWaitFailedItsCheckListsWhoWaitsOnIt` fails on main: the consumer is held (only the provider's condition is open), but that condition does not list `shop on laptop` (`... says it waits for the secret certificate, which db does not declare, 0 look(s) ...`). It passes with the fix. - `TestAProviderWaitingForASecretAlreadyGivenIsUnhealthyToItsConsumers` covers the issue's exact case: a licence that was already given makes the consumer held as under an unhealthy provider, with no waits. - #216's fixture `holdingOf` now declares the database's `licence` and `backup-key` as own secrets issued outside the mesh and reads nothing given on anchor. Its waits named undeclared secrets, which only passed because the holding never checked them. `go vet ./...` and `go test ./cmd/mesh-controller/ -count=1` pass. The change touches no file of the open PRs #218, #219 or #220.
mesh-admin added 1 commit 2026-10-11 01:29:23 +00:00
Check a provider's waits before saying who waits on it (issue 450)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
ed45cc6415
A provider whose wait fails the check raises unhealthy, but the holding read
its stored statement with the wait unchecked: sayWaiters built the
needs-operator key, found it not open and listed no held consumer. The
holding now reads each statement as judged (ADR 0283 decision 3), in
sayWaiters and in the provider's state its consumers are held by.
Author
Contributor

Delivery novox/mesh-controller@ed45cc64156e — delivered since 2026-10-11T02:26:03Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m38s
  • mesh-delivery on novox: passed — judged with mesh-controller: healthy 3 times over 3m38s
  • mesh-controller on the rest running it: sent
  • mesh-delivery on the rest running it: sent

Transitions

  • 2026-10-11 01:29 (new) → proposed (announced): novox/mesh-controller#221's head announced
  • 2026-10-11 01:34 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 01:34 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 02:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 02:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 02:26 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@ed45cc64156e` — **delivered** since 2026-10-11T02:26:03Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m38s - mesh-delivery on novox: passed — judged with mesh-controller: healthy 3 times over 3m38s - mesh-controller on the rest running it: sent - mesh-delivery on the rest running it: sent **Transitions** - 2026-10-11 01:29 (new) → proposed (announced): novox/mesh-controller#221's head announced - 2026-10-11 01:34 proposed → checked (checked): the verdict names this commit - 2026-10-11 01:34 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 02:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 02:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 02:26 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at ed45cc64

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on ace as build-1791682172828875500 (builds --log build-1791682172828875500).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:27:53Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T01:27:53Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.032s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	204.825s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.017s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.109s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.046s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	2.649s
ok  	github.com/novox/mesh-controller/internal/builder	2.547s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.506s
ok  	github.com/novox/mesh-controller/internal/conditions	2.470s
ok  	github.com/novox/mesh-controller/internal/envfile	1.047s
ok  	github.com/novox/mesh-controller/internal/facts	1.050s
ok  	github.com/novox/mesh-controller/internal/identity	4.167s
ok  	github.com/novox/mesh-controller/internal/inventory	78.150s
ok  	github.com/novox/mesh-controller/internal/lease	17.708s
ok  	github.com/novox/mesh-controller/internal/licences	3.808s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.044s
ok  	github.com/novox/mesh-controller/internal/link	51.945s
ok  	github.com/novox/mesh-controller/internal/lint	2.158s
ok  	github.com/novox/mesh-controller/internal/outward	1.076s
ok  	github.com/novox/mesh-controller/internal/overlay	1.068s
ok  	github.com/novox/mesh-controller/internal/secrets	1.460s
ok  	github.com/novox/mesh-controller/internal/store	3.343s
ok  	github.com/novox/mesh-controller/internal/testbus	1.245s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
**Merge check** at `ed45cc64` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on ace as `build-1791682172828875500` (`builds --log build-1791682172828875500`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:27:53Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T01:27:53Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.032s ok github.com/novox/mesh-controller/cmd/mesh-controller 204.825s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.013s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.017s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.109s ok github.com/novox/mesh-controller/internal/artifacts 1.046s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 2.649s ok github.com/novox/mesh-controller/internal/builder 2.547s ok github.com/novox/mesh-controller/internal/catalogue 6.506s ok github.com/novox/mesh-controller/internal/conditions 2.470s ok github.com/novox/mesh-controller/internal/envfile 1.047s ok github.com/novox/mesh-controller/internal/facts 1.050s ok github.com/novox/mesh-controller/internal/identity 4.167s ok github.com/novox/mesh-controller/internal/inventory 78.150s ok github.com/novox/mesh-controller/internal/lease 17.708s ok github.com/novox/mesh-controller/internal/licences 3.808s ok github.com/novox/mesh-controller/internal/licences/adapters 1.044s ok github.com/novox/mesh-controller/internal/link 51.945s ok github.com/novox/mesh-controller/internal/lint 2.158s ok github.com/novox/mesh-controller/internal/outward 1.076s ok github.com/novox/mesh-controller/internal/overlay 1.068s ok github.com/novox/mesh-controller/internal/secrets 1.460s ok github.com/novox/mesh-controller/internal/store 3.343s ok github.com/novox/mesh-controller/internal/testbus 1.245s ok github.com/novox/mesh-controller/internal/token 1.017s ```
mesh-admin merged commit 45b4ae92bc into main 2026-10-11 02:19:02 +00:00
mesh-admin deleted branch fix/450-a-provider-whose-wait-fails-lists-its-waiters 2026-10-11 02:19:03 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#221