A failed repository check names what failed, from its whole output (issue 460) #222

Merged
mesh-admin merged 1 commits from fix/460-a-failed-check-names-what-failed into main 2026-10-11 08:47:57 +00:00
Contributor

Fixes novox/hq issue 460.

Why the name was lost. ownCheck named a failure with whatFailed(own.String()), and own is a tail whose String() keeps the last 200 lines (reportLines). Go prints a failing package's log lines after its --- FAIL: lines, so on #218 (build build-1791681063292749541) the store-backed package's logs pushed --- FAIL: out of those 200 lines, and the summary fell back to FAIL\t…/cmd/mesh-controller\t268.072s (the build's log shows exactly that summary). On #220 the four --- FAIL: lines were about 30 lines from the end, inside the tail, so they were named. The report had the same limit: the last 200 lines, then the controller's front cut to 60 KiB. The build's log never held the script's output: ownCheck wrote it only into the report's tail.

What changes (all in internal/builder; cmd/mesh-controller/checks.go and #220's files are not touched):

  • A failures writer reads the output as it streams and keeps, whole: each --- FAIL: line with its deeper-indented messages, panic: / fatal error: with up to 40 following lines, a WARNING: DATA RACE report from rule to rule, each FAIL\t<pkg> line, a build error with its # pkg header, and gofmt's list. The bounds are 400 lines and 32 KiB in all, 1 KiB per line, with a count of what was left out.
  • The repository layer's summary is named from that: the first failure whole, then further failing tests by name (up to 5, then "and N more"). A panic, data race or build error outside any test now comes before a bare FAIL\t<pkg>.
  • The verdict's report ends with --- what failed, picked from the whole of its output. Being at the end, it survives the controller's 60 KiB front cut.
  • Every line of the script's output goes into the build's log (builds with log) as an output line. The cap is 8,000 lines and 4 KiB per line, because EVENTS keeps 10,000 messages per subject and one build's log is one subject. Past the cap, the log says how many lines it left out, then gives the picked failure lines.

Tests use output captured from real go test runs (in testdata/issue460, see CAPTURED): a failure early in a long run, a -race run of every package, a panic, a data race and a build error. On main, four of them fail for the reason in the issue. The early failure is said as FAIL\texample.com/cap/early\t0.003s, which is #218's shape. The -race run names the later TestAMapIsNil instead of the first failure. The build error is said as a bare [build failed]. The build's log holds 0 of 609 lines. The tests of the new Failed field and of the bounds need the new code to compile. go vet ./... is clean, and go test ./internal/builder ./cmd/mesh-builder passes.

The build seat (build-agent) must be rebuilt for this to take effect, because the check runs there.

Fixes novox/hq issue 460. **Why the name was lost.** `ownCheck` named a failure with `whatFailed(own.String())`, and `own` is a `tail` whose `String()` keeps the last 200 lines (`reportLines`). Go prints a failing package's log lines after its `--- FAIL:` lines, so on #218 (build build-1791681063292749541) the store-backed package's logs pushed `--- FAIL:` out of those 200 lines, and the summary fell back to `FAIL\t…/cmd/mesh-controller\t268.072s` (the build's log shows exactly that summary). On #220 the four `--- FAIL:` lines were about 30 lines from the end, inside the tail, so they were named. The report had the same limit: the last 200 lines, then the controller's front cut to 60 KiB. The build's log never held the script's output: `ownCheck` wrote it only into the report's tail. **What changes** (all in `internal/builder`; `cmd/mesh-controller/checks.go` and #220's files are not touched): - A `failures` writer reads the output as it streams and keeps, whole: each `--- FAIL:` line with its deeper-indented messages, `panic:` / `fatal error:` with up to 40 following lines, a `WARNING: DATA RACE` report from rule to rule, each `FAIL\t<pkg>` line, a build error with its `# pkg` header, and gofmt's list. The bounds are 400 lines and 32 KiB in all, 1 KiB per line, with a count of what was left out. - The repository layer's summary is named from that: the first failure whole, then further failing tests by name (up to 5, then "and N more"). A panic, data race or build error outside any test now comes before a bare `FAIL\t<pkg>`. - The verdict's report ends with `--- what failed, picked from the whole of its output`. Being at the end, it survives the controller's 60 KiB front cut. - Every line of the script's output goes into the build's log (`builds` with `log`) as an `output` line. The cap is 8,000 lines and 4 KiB per line, because EVENTS keeps 10,000 messages per subject and one build's log is one subject. Past the cap, the log says how many lines it left out, then gives the picked failure lines. **Tests** use output captured from real `go test` runs (in `testdata/issue460`, see CAPTURED): a failure early in a long run, a -race run of every package, a panic, a data race and a build error. On main, four of them fail for the reason in the issue. The early failure is said as `FAIL\texample.com/cap/early\t0.003s`, which is #218's shape. The -race run names the later `TestAMapIsNil` instead of the first failure. The build error is said as a bare `[build failed]`. The build's log holds 0 of 609 lines. The tests of the new `Failed` field and of the bounds need the new code to compile. `go vet ./...` is clean, and `go test ./internal/builder ./cmd/mesh-builder` passes. The build seat (build-agent) must be rebuilt for this to take effect, because the check runs there.
mesh-admin added 1 commit 2026-10-11 02:24:49 +00:00
Name what failed in a repository check from its whole output, not its tail (issue 460)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
1747e33923
A long run's logs pushed the --- FAIL lines out of the last 200 lines the
summary was named from, so a failed check could not say which test failed.
Pick the lines that name a failure as the output streams, keep them whole at
the end of the verdict's report, and say the whole output in the build's log.
Author
Contributor

Delivery novox/mesh-controller@1747e339239a — delivered since 2026-10-11T08:59:48Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m37s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m34s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-11 02:25 (new) → proposed (announced): novox/mesh-controller#222's head announced
  • 2026-10-11 02:31 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 02:31 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 08:50 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 08:50 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 08:59 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@1747e339239a` — **delivered** since 2026-10-11T08:59:48Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m37s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m34s - build-agent on the rest running it: sent **Transitions** - 2026-10-11 02:25 (new) → proposed (announced): novox/mesh-controller#222's head announced - 2026-10-11 02:31 proposed → checked (checked): the verdict names this commit - 2026-10-11 02:31 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 08:50 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 08:50 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 08:59 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 1747e339

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/builder/failures_test.go, internal/builder/testdata/issue460/CAPTURED, internal/builder/testdata/issue460/a-build-error.txt, internal/builder/testdata/issue460/a-data-race.txt, internal/builder/testdata/issue460/a-long-run-failing-early.txt, internal/builder/testdata/issue460/a-panic.txt, internal/builder/testdata/issue460/a-race-run-of-every-package.txt

Run by the build seat on g14 as build-1791685505208021630 (builds --log build-1791685505208021630).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T02:23:28Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T02:23:28Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/builder/failures_test.go, internal/builder/testdata/issue460/CAPTURED, internal/builder/testdata/issue460/a-build-error.txt, internal/builder/testdata/issue460/a-data-race.txt, internal/builder/testdata/issue460/a-long-run-failing-early.txt, internal/builder/testdata/issue460/a-panic.txt and internal/builder/testdata/issue460/a-race-run-of-every-package.txt read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.036s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	223.930s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.012s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.023s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.153s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.050s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	2.601s
ok  	github.com/novox/mesh-controller/internal/builder	3.343s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.186s
ok  	github.com/novox/mesh-controller/internal/conditions	2.370s
ok  	github.com/novox/mesh-controller/internal/envfile	1.031s
ok  	github.com/novox/mesh-controller/internal/facts	1.034s
ok  	github.com/novox/mesh-controller/internal/identity	4.085s
ok  	github.com/novox/mesh-controller/internal/inventory	76.486s
ok  	github.com/novox/mesh-controller/internal/lease	17.702s
ok  	github.com/novox/mesh-controller/internal/licences	3.720s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.012s
ok  	github.com/novox/mesh-controller/internal/link	51.828s
ok  	github.com/novox/mesh-controller/internal/lint	2.053s
ok  	github.com/novox/mesh-controller/internal/outward	1.036s
ok  	github.com/novox/mesh-controller/internal/overlay	1.026s
ok  	github.com/novox/mesh-controller/internal/secrets	1.412s
ok  	github.com/novox/mesh-controller/internal/store	3.226s
ok  	github.com/novox/mesh-controller/internal/testbus	1.174s
ok  	github.com/novox/mesh-controller/internal/token	1.021s
**Merge check** at `1747e339` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/builder/failures_test.go, internal/builder/testdata/issue460/CAPTURED, internal/builder/testdata/issue460/a-build-error.txt, internal/builder/testdata/issue460/a-data-race.txt, internal/builder/testdata/issue460/a-long-run-failing-early.txt, internal/builder/testdata/issue460/a-panic.txt, internal/builder/testdata/issue460/a-race-run-of-every-package.txt Run by the build seat on g14 as `build-1791685505208021630` (`builds --log build-1791685505208021630`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T02:23:28Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T02:23:28Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/builder/failures_test.go, internal/builder/testdata/issue460/CAPTURED, internal/builder/testdata/issue460/a-build-error.txt, internal/builder/testdata/issue460/a-data-race.txt, internal/builder/testdata/issue460/a-long-run-failing-early.txt, internal/builder/testdata/issue460/a-panic.txt and internal/builder/testdata/issue460/a-race-run-of-every-package.txt read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.036s ok github.com/novox/mesh-controller/cmd/mesh-controller 223.930s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.012s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.023s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.153s ok github.com/novox/mesh-controller/internal/artifacts 1.050s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 2.601s ok github.com/novox/mesh-controller/internal/builder 3.343s ok github.com/novox/mesh-controller/internal/catalogue 6.186s ok github.com/novox/mesh-controller/internal/conditions 2.370s ok github.com/novox/mesh-controller/internal/envfile 1.031s ok github.com/novox/mesh-controller/internal/facts 1.034s ok github.com/novox/mesh-controller/internal/identity 4.085s ok github.com/novox/mesh-controller/internal/inventory 76.486s ok github.com/novox/mesh-controller/internal/lease 17.702s ok github.com/novox/mesh-controller/internal/licences 3.720s ok github.com/novox/mesh-controller/internal/licences/adapters 1.012s ok github.com/novox/mesh-controller/internal/link 51.828s ok github.com/novox/mesh-controller/internal/lint 2.053s ok github.com/novox/mesh-controller/internal/outward 1.036s ok github.com/novox/mesh-controller/internal/overlay 1.026s ok github.com/novox/mesh-controller/internal/secrets 1.412s ok github.com/novox/mesh-controller/internal/store 3.226s ok github.com/novox/mesh-controller/internal/testbus 1.174s ok github.com/novox/mesh-controller/internal/token 1.021s ```
mesh-admin merged commit e7bcc107c8 into main 2026-10-11 08:47:57 +00:00
mesh-admin deleted branch fix/460-a-failed-check-names-what-failed 2026-10-11 08:47:57 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#222