Let a module keep a log the controller creates and never removes, and warn before a bucket or log is full (ADR 0297) #231

Merged
mesh-admin merged 4 commits from adr-0297-module-logs into main 2026-10-12 00:42:56 +00:00
Contributor

Implements the controller's part of novox/hq ADR 0297 (a module may declare a log of operations), for issue 501 (a bucket fills toward its cap with no warning) and issue 502 (the audit trail lasts only seven days).

What changes

  1. Catalogue (internal/catalogue/logs.go): logs next to state: a bare name or {name, max-mib}. A name is one plain token (the state-name rule), unique among the module's logs. max-mib is 1..8192, 1024 by default, and an explicit 0 is refused. Unknown fields are refused. A module that keeps a log must have a one-token name. The broker-holder check counts logs with state. module check prints each log with its cap.
  2. Bus (internal/broker/log.go, jetstream.go): Log.Config() is the stream exactly as the shared contract fixes it: LOG_<module>_<name>, subjects mesh.log.<module>.<name>.>, file storage, limits retention, MaxAge 0, MaxMsgs -1, MaxMsgsPerSubject -1, MaxBytes = cap, MaxMsgSize 260 KiB (a 256 KiB value plus 4 KiB of headers), Discard New, AllowDirect, DenyDelete, DenyPurge, one replica, and a description. EnsureLog is create-or-update only. RaiseLogs asserts every declared log and reports the LOG_ streams that nothing declares, the same way undeclared buckets are reported. Logs are raised at controller start and before memberships are issued, in both places buckets are.
  3. Membership and grants: Membership.logs = [{name, stream, subject, writes}] for the owner's own logs only. The runtime (and a module on its own account) is granted, per log, only mesh.log.<m>.<n>.>, $JS.API.STREAM.INFO.<stream>, $JS.API.DIRECT.GET.<stream> and $JS.API.DIRECT.GET.<stream>.>.
  4. Fill condition (cmd/mesh-controller/bucket_log_fill.go, self-check probe D-fill):
    • Every module's bucket and log is read from the bus on its own.
    • At 75% of MaxBytes or more it raises bucket-or-log-filling, which names the module, the bucket or log and its fill. It is kept between 70% and 75% while open, and cleared below 70%.
    • A bucket or log that cannot be read raises bucket-or-log-unread with its reason (confirmed on a second check), and the others are still judged. Its fill warning is kept only when that condition was read back as open. When the condition cannot be read either, nothing is said of its fill.

Reviewers' checklist

  • (a) Nothing deletes or recreates a log or bucket. TestNoPathDeletesALogOrABucket scans every non-test Go file for stream or bucket deletes and purges. The only exception is the lease's own purge. LogAsserter has no remove method.
  • (b) Stream config: TestALogsStreamIsAsTheDecisionFixesIt compares it field by field. TestALogIsAssertedInPlaceAndNeverRemoved runs against a real server.
  • (c) Membership JSON: TestAMembershipListsItsModulesLogs asserts the exact logs/name/stream/subject/writes JSON.
  • (d) Grants: TestTheRuntimeIsGrantedItsModulesLogsAndNoMore asserts the exact list.
  • (e) Thresholds and unreadable streams:
    • TestAFillingBucketOrLogIsRaisedAtThreeQuartersAndClearedBelowSevenTenths covers the 75% raise and the clear below 70%.
    • TestAnUnreadableBucketOrLogIsSaidAndTheRestAreStillJudged covers an unreadable bucket or log beside readable ones.
    • TestNothingIsSaidOfAFillWhenNeitherItNorItsConditionCanBeRead covers the case where neither the stream nor its condition can be read.
  • (f) Words: controller, node-engine, bus, module, bucket, log; never bare "store" for a bucket or log.

sh merge-check.sh passes locally: gofmt, vet, and the whole suite under the race detector. The store-backed tests skip without MESH_TEST_POSTGRES.

Do not merge before the runtime (mesh-tools) and SDK parts of ADR 0297 are reviewed alongside. The controller part is safe on its own: no catalogue module declares logs yet.

Implements the controller's part of novox/hq ADR 0297 (a module may declare a log of operations), for issue 501 (a bucket fills toward its cap with no warning) and issue 502 (the audit trail lasts only seven days). ## What changes 1. **Catalogue** (`internal/catalogue/logs.go`): `logs` next to `state`: a bare name or `{name, max-mib}`. A name is one plain token (the state-name rule), unique among the module's logs. `max-mib` is 1..8192, 1024 by default, and an explicit 0 is refused. Unknown fields are refused. A module that keeps a log must have a one-token name. The broker-holder check counts `logs` with `state`. `module check` prints each log with its cap. 2. **Bus** (`internal/broker/log.go`, `jetstream.go`): `Log.Config()` is the stream exactly as the shared contract fixes it: `LOG_<module>_<name>`, subjects `mesh.log.<module>.<name>.>`, file storage, limits retention, MaxAge 0, MaxMsgs -1, MaxMsgsPerSubject -1, MaxBytes = cap, MaxMsgSize 260 KiB (a 256 KiB value plus 4 KiB of headers), Discard New, AllowDirect, DenyDelete, DenyPurge, one replica, and a description. `EnsureLog` is create-or-update only. `RaiseLogs` asserts every declared log and reports the `LOG_` streams that nothing declares, the same way undeclared buckets are reported. Logs are raised at controller start and before memberships are issued, in both places buckets are. 3. **Membership and grants**: `Membership.logs` = `[{name, stream, subject, writes}]` for the owner's own logs only. The runtime (and a module on its own account) is granted, per log, only `mesh.log.<m>.<n>.>`, `$JS.API.STREAM.INFO.<stream>`, `$JS.API.DIRECT.GET.<stream>` and `$JS.API.DIRECT.GET.<stream>.>`. 4. **Fill condition** (`cmd/mesh-controller/bucket_log_fill.go`, self-check probe `D-fill`): - Every module's bucket and log is read from the bus on its own. - At 75% of MaxBytes or more it raises `bucket-or-log-filling`, which names the module, the bucket or log and its fill. It is kept between 70% and 75% while open, and cleared below 70%. - A bucket or log that cannot be read raises `bucket-or-log-unread` with its reason (confirmed on a second check), and the others are still judged. Its fill warning is kept only when that condition was read back as open. When the condition cannot be read either, nothing is said of its fill. ## Reviewers' checklist - (a) Nothing deletes or recreates a log or bucket. `TestNoPathDeletesALogOrABucket` scans every non-test Go file for stream or bucket deletes and purges. The only exception is the lease's own purge. `LogAsserter` has no remove method. - (b) Stream config: `TestALogsStreamIsAsTheDecisionFixesIt` compares it field by field. `TestALogIsAssertedInPlaceAndNeverRemoved` runs against a real server. - (c) Membership JSON: `TestAMembershipListsItsModulesLogs` asserts the exact `logs`/`name`/`stream`/`subject`/`writes` JSON. - (d) Grants: `TestTheRuntimeIsGrantedItsModulesLogsAndNoMore` asserts the exact list. - (e) Thresholds and unreadable streams: - `TestAFillingBucketOrLogIsRaisedAtThreeQuartersAndClearedBelowSevenTenths` covers the 75% raise and the clear below 70%. - `TestAnUnreadableBucketOrLogIsSaidAndTheRestAreStillJudged` covers an unreadable bucket or log beside readable ones. - `TestNothingIsSaidOfAFillWhenNeitherItNorItsConditionCanBeRead` covers the case where neither the stream nor its condition can be read. - (f) Words: controller, node-engine, bus, module, bucket, log; never bare "store" for a bucket or log. `sh merge-check.sh` passes locally: gofmt, vet, and the whole suite under the race detector. The store-backed tests skip without `MESH_TEST_POSTGRES`. Do not merge before the runtime (mesh-tools) and SDK parts of ADR 0297 are reviewed alongside. The controller part is safe on its own: no catalogue module declares `logs` yet.
mesh-admin added 1 commit 2026-10-11 17:23:11 +00:00
Let a module declare a log the controller creates and never removes (ADR 0297)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
7bd61332cb
The issue tracker's history lasts seven days on the events stream and its
bucket fills toward a cap with no warning (issues 501, 502). A module may
now declare `logs`; the controller creates each as a stream on the bus
(create-or-update, never deleted or recreated, reported when undeclared),
issues it to the owner's assignments in their membership, grants the
runtime exactly the append and direct-read subjects, and raises a
condition when any module's bucket or log reaches 75% of its cap, cleared
below 70%.
Author
Contributor

Delivery novox/mesh-controller@6b77dd96f443 — delivered since 2026-10-12T00:55:49Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m38s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m33s
  • build-agent on the rest running it: sent
  • route-proxy on ace: passed — healthy 1 times over 1m47s
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-12 00:30 (new) → proposed (announced): novox/mesh-controller#231's head announced
  • 2026-10-12 00:37 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 00:37 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 00:44 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 00:44 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 00:55 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@6b77dd96f443` — **delivered** since 2026-10-12T00:55:49Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m38s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m33s - build-agent on the rest running it: sent - route-proxy on ace: passed — healthy 1 times over 1m47s - route-proxy on the rest running it: sent **Transitions** - 2026-10-12 00:30 (new) → proposed (announced): novox/mesh-controller#231's head announced - 2026-10-12 00:37 proposed → checked (checked): the verdict names this commit - 2026-10-12 00:37 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 00:44 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 00:44 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 00:55 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Review (independent): CHANGES — head 7bd6133 reviewed

One item fails, and it is small: the operator-facing wording of the fill condition. Everything else passes, including the merge-check run locally.

Fails

  1. Glossary. The glossary's store entry (hq 00-META/glossary.md:153-156) says bare store means the one postgres server "and nothing else". The condition's operator-facing words use it for a bucket or log instead:
  • cmd/mesh-controller/plain_words.go:610: Headline "A module's store on the bus is filling up"
  • cmd/mesh-controller/plain_words.go:614: Resolved "The store has room again"
  • cmd/mesh-controller/store_fill.go:32: kind store-filling

The per-observation Summary, Headline and Resolved in store_fill.go say "bucket" or "log" correctly. Only the kind's generic words and the kind name are wrong. Suggested fix: "A module's bucket or log on the bus is filling up", "It has room again", and a kind such as bucket-or-log-filling. ADR 0297 §6 itself says "the store", so the decision needs the same word fixed. No retired word (control plane, substrate, the host) appears in the added lines.

Passes

  1. Catalogue logs:
  • internal/catalogue/logs.go accepts the short and the full form.
  • An unknown field is refused (DisallowUnknownFields, :51).
  • An explicit 0 is refused (:59).
  • The name rule uses stateName, and a module name with a dot is refused.
  • A duplicate is refused (:94).
  • Caps run from 1 to 8192, default 1024.
  • Tests cover the edges.
  1. Stream config (internal/broker/log.go:81-99) matches the contract field by field: LOG_<m>_<n>, mesh.log.<m>.<n>.>, File, Limits, MaxAge 0, MaxMsgsPerSubject -1, MaxBytes = MiB×2^20, MaxMsgSize 256 KiB + 4 KiB, DiscardNew, AllowDirect, DenyDelete, DenyPurge, Replicas 1, and a Description. MaxMsgs -1 is an addition and is harmless.

  2. No delete path:

  • EnsureLog uses CreateOrUpdateStream only (jetstream.go:459-470).
  • RaiseLogs only reports undeclared LOG_ streams (log.go:174).
  • No DeleteStream or Purge exists in non-vendor code.
  • Lowering a log's max-mib later is also safe. The vendored server's enforceBytesLimit returns early unless Discard is Old (vendor/.../server/filestore.go:4742-4745), so an update never drops entries.
  1. Membership: LogIssued{name,stream,subject,writes} (log.go:113) is the same JSON that mesh-tools #28 decodes (node-tools/internal/bus/log.go LogIssued, bus.go:70 json:"logs"). The subject is sent without .>, and the runtime appends .+key. Only the owner's d.Logs are issued.

  2. Grants (log.go:130) are publish mesh.log.<m>.<n>.>, $JS.API.STREAM.INFO.<stream>, $JS.API.DIRECT.GET.<stream> and .<stream>.>. These cover every runtime call in #28:

  • the append is a RequestMsg on the subject
  • the batch read is a PublishRequest on DIRECT.GET.<stream>
  • the last entry is read on DIRECT.GET.<stream>.<subject>.<key>
  • the info is STREAM.INFO.<stream>

The runtime makes no consumer. A module on its own account (KindModule, nats.go:752) gets logGrants right beside stateGrants, exactly as buckets are granted there, which is consistent. The runtime gets the union over the modules it carries (nats.go:844), as with state.

  1. Fill condition (store_fill.go:67-68):
  • It raises at 75% or more, compared in bytes, not rounded percent.
  • It is kept at 70–75% only while open, and cleared below 70%.
  • It names the module, the bucket or log, and the fill in MiB and percent.
  • Tests cover 75% exactly, 75% minus 1 byte, 70% exactly, 70% minus 1 byte, the 72% band open and not open, and no cap.

Live, nats.nats_buckets shows no module bucket near the threshold. The largest are mesh-issues_issues at 11,165,302 bytes (17% of 64 MiB) and mesh-delivery_deliveries at 9,108,028 bytes (14%). Nothing would raise on delivery.

  1. Logs are created where buckets are: raiseTheBus at start (push.go:1497) and issueMemberships (push.go:1305-1311), both after RaiseBuckets. A failing EnsureLog returns an error with a reason, so it is never silent. It blocks the same scope a failing EnsureBucket does (the whole send, or the start), and no more.

  2. sh merge-check.sh exited 0 at 7bd6133. Every package was ok, cmd/mesh-controller included.

  3. Required checks at 7bd6133: mesh/merge-gate was pending ("building on ace since 19:23"), and mesh/repo-check was missing. The forge says mergeable: false.

Notes, not blocking

  • probeStoreFill returns an error for the whole probe on one store's non-NotFound StreamInfo error (store_fill.go:153), so one unreadable stream hides every other store's fill. You could skip that store and name it instead.
  • A bad log declaration (for example a subject that overlaps a stream made by hand) now fails controller start and every push. Buckets already behave that way, so this is consistent, but the blast radius is the whole mesh.
Review (independent): CHANGES — head 7bd6133 reviewed One item fails, and it is small: the operator-facing wording of the fill condition. Everything else passes, including the merge-check run locally. **Fails** 10. Glossary. The glossary's `store` entry (hq `00-META/glossary.md:153-156`) says bare *store* means the one postgres server "and nothing else". The condition's operator-facing words use it for a bucket or log instead: - `cmd/mesh-controller/plain_words.go:610`: Headline "A module's store on the bus is filling up" - `cmd/mesh-controller/plain_words.go:614`: Resolved "The store has room again" - `cmd/mesh-controller/store_fill.go:32`: kind `store-filling` The per-observation Summary, Headline and Resolved in `store_fill.go` say "bucket" or "log" correctly. Only the kind's generic words and the kind name are wrong. Suggested fix: "A module's bucket or log on the bus is filling up", "It has room again", and a kind such as `bucket-or-log-filling`. ADR 0297 §6 itself says "the store", so the decision needs the same word fixed. No retired word (control plane, substrate, the host) appears in the added lines. **Passes** 1. Catalogue `logs`: - `internal/catalogue/logs.go` accepts the short and the full form. - An unknown field is refused (`DisallowUnknownFields`, :51). - An explicit 0 is refused (:59). - The name rule uses `stateName`, and a module name with a dot is refused. - A duplicate is refused (:94). - Caps run from 1 to 8192, default 1024. - Tests cover the edges. 2. Stream config (`internal/broker/log.go:81-99`) matches the contract field by field: `LOG_<m>_<n>`, `mesh.log.<m>.<n>.>`, File, Limits, MaxAge 0, MaxMsgsPerSubject -1, MaxBytes = MiB×2^20, MaxMsgSize 256 KiB + 4 KiB, DiscardNew, AllowDirect, DenyDelete, DenyPurge, Replicas 1, and a Description. MaxMsgs -1 is an addition and is harmless. 3. No delete path: - `EnsureLog` uses `CreateOrUpdateStream` only (`jetstream.go:459-470`). - `RaiseLogs` only reports undeclared `LOG_` streams (`log.go:174`). - No `DeleteStream` or `Purge` exists in non-vendor code. - Lowering a log's `max-mib` later is also safe. The vendored server's `enforceBytesLimit` returns early unless Discard is Old (`vendor/.../server/filestore.go:4742-4745`), so an update never drops entries. 4. Membership: `LogIssued{name,stream,subject,writes}` (`log.go:113`) is the same JSON that mesh-tools #28 decodes (`node-tools/internal/bus/log.go` `LogIssued`, `bus.go:70` `json:"logs"`). The subject is sent without `.>`, and the runtime appends `.`+key. Only the owner's `d.Logs` are issued. 5. Grants (`log.go:130`) are publish `mesh.log.<m>.<n>.>`, `$JS.API.STREAM.INFO.<stream>`, `$JS.API.DIRECT.GET.<stream>` and `.<stream>.>`. These cover every runtime call in #28: - the append is a `RequestMsg` on the subject - the batch read is a `PublishRequest` on `DIRECT.GET.<stream>` - the last entry is read on `DIRECT.GET.<stream>.<subject>.<key>` - the info is `STREAM.INFO.<stream>` The runtime makes no consumer. A module on its own account (KindModule, `nats.go:752`) gets `logGrants` right beside `stateGrants`, exactly as buckets are granted there, which is consistent. The runtime gets the union over the modules it carries (`nats.go:844`), as with state. 6. Fill condition (`store_fill.go:67-68`): - It raises at 75% or more, compared in bytes, not rounded percent. - It is kept at 70–75% only while open, and cleared below 70%. - It names the module, the bucket or log, and the fill in MiB and percent. - Tests cover 75% exactly, 75% minus 1 byte, 70% exactly, 70% minus 1 byte, the 72% band open and not open, and no cap. Live, `nats.nats_buckets` shows no module bucket near the threshold. The largest are `mesh-issues_issues` at 11,165,302 bytes (17% of 64 MiB) and `mesh-delivery_deliveries` at 9,108,028 bytes (14%). Nothing would raise on delivery. 7. Logs are created where buckets are: `raiseTheBus` at start (`push.go:1497`) and `issueMemberships` (`push.go:1305-1311`), both after `RaiseBuckets`. A failing `EnsureLog` returns an error with a reason, so it is never silent. It blocks the same scope a failing `EnsureBucket` does (the whole send, or the start), and no more. 8. `sh merge-check.sh` exited 0 at 7bd6133. Every package was ok, `cmd/mesh-controller` included. 9. Required checks at 7bd6133: `mesh/merge-gate` was pending ("building on ace since 19:23"), and `mesh/repo-check` was missing. The forge says mergeable: false. **Notes, not blocking** - `probeStoreFill` returns an error for the whole probe on one store's non-NotFound `StreamInfo` error (`store_fill.go:153`), so one unreadable stream hides every other store's fill. You could skip that store and name it instead. - A bad log declaration (for example a subject that overlaps a stream made by hand) now fails controller start and every push. Buckets already behave that way, so this is consistent, but the blast radius is the whole mesh.
Author
Contributor

Merge check at 7bd61332

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on ace as build-1791739395677168205 (builds --log build-1791739395677168205).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:21:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T17:21:39Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.036s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	205.900s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.018s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.111s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.053s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.786s
ok  	github.com/novox/mesh-controller/internal/builder	15.035s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.884s
ok  	github.com/novox/mesh-controller/internal/conditions	2.475s
ok  	github.com/novox/mesh-controller/internal/envfile	1.056s
ok  	github.com/novox/mesh-controller/internal/facts	1.054s
ok  	github.com/novox/mesh-controller/internal/identity	4.235s
ok  	github.com/novox/mesh-controller/internal/inventory	80.320s
ok  	github.com/novox/mesh-controller/internal/lease	17.694s
ok  	github.com/novox/mesh-controller/internal/licences	3.862s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.054s
ok  	github.com/novox/mesh-controller/internal/link	58.523s
ok  	github.com/novox/mesh-controller/internal/lint	2.146s
ok  	github.com/novox/mesh-controller/internal/outward	1.075s
ok  	github.com/novox/mesh-controller/internal/overlay	1.067s
ok  	github.com/novox/mesh-controller/internal/secrets	1.452s
ok  	github.com/novox/mesh-controller/internal/store	3.301s
ok  	github.com/novox/mesh-controller/internal/testbus	1.206s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
**Merge check** at `7bd61332` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on ace as `build-1791739395677168205` (`builds --log build-1791739395677168205`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:21:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T17:21:39Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.036s ok github.com/novox/mesh-controller/cmd/mesh-controller 205.900s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.014s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.018s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.111s ok github.com/novox/mesh-controller/internal/artifacts 1.053s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.786s ok github.com/novox/mesh-controller/internal/builder 15.035s ok github.com/novox/mesh-controller/internal/catalogue 6.884s ok github.com/novox/mesh-controller/internal/conditions 2.475s ok github.com/novox/mesh-controller/internal/envfile 1.056s ok github.com/novox/mesh-controller/internal/facts 1.054s ok github.com/novox/mesh-controller/internal/identity 4.235s ok github.com/novox/mesh-controller/internal/inventory 80.320s ok github.com/novox/mesh-controller/internal/lease 17.694s ok github.com/novox/mesh-controller/internal/licences 3.862s ok github.com/novox/mesh-controller/internal/licences/adapters 1.054s ok github.com/novox/mesh-controller/internal/link 58.523s ok github.com/novox/mesh-controller/internal/lint 2.146s ok github.com/novox/mesh-controller/internal/outward 1.075s ok github.com/novox/mesh-controller/internal/overlay 1.067s ok github.com/novox/mesh-controller/internal/secrets 1.452s ok github.com/novox/mesh-controller/internal/store 3.301s ok github.com/novox/mesh-controller/internal/testbus 1.206s ok github.com/novox/mesh-controller/internal/token 1.017s ```
jschoubben added 1 commit 2026-10-11 17:31:02 +00:00
Name the fill condition for buckets and logs, and judge each one on its own
mesh/delivery superseded: a newer head of the same pull request
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
c432b9b5f6
Review of #231: "store" is the glossary's word for the postgres server, so
the condition is bucket-or-log-filling. And one stream that cannot be read
no longer fails the whole check: it is said as unread with its reason, an
open fill condition for it is kept, and every other bucket and log is
still judged (ADR 0297 §6).
Author
Contributor

Review (independent): CHANGES — head c432b9b reviewed (diff since 7bd6133)

The rename fixes the glossary finding, and reading each bucket or log on its own fixes the earlier note. One new behaviour can raise false warnings, so this is CHANGES.

Fails: an unreadable condition is taken as open, and that fabricates fill conditions (cmd/mesh-controller/bucket_log_fill.go, judgeFills with the open closure in probeFill)

When a stream cannot be read, judgeFills calls open(fillKey(s)). The closure answers isOpen || err != nil, so a failed read of the condition counts as open, and keptFilling then says a bucket-or-log-filling observation. When the condition was never open, c is empty, and the summary falls back to "... was filling when it was last read", which is not true.

Both reads go to the same bus: StreamInfo and the conditions bucket. A slow or partly answering bus therefore fails both reads in one run. Every declared bucket and log (about 29 buckets live today, plus logs) would then get a fill observation at Warning with no fill evidence. It is not confirmed (Confirm is false), so it raises on that single run. That breaks "evidence over assertion".

This is not what confirm.go does, although the comment says it is. isOpen there only lets a confirmed finding that was actually observed raise one look early. It never makes a finding of a kind nobody observed.

Fix: in the unread path, keep the fill condition only when the read of the condition succeeded and said open. Have openFill return the error and call keptFilling only when the error is nil and the condition is open. The bucket-or-log-unread observation already says what is unknown. Add a test: a stream read fails and the condition read fails, and nothing of kind bucket-or-log-filling is said.

In the readable path, treating an error as open is contained and acceptable. It can only keep or raise a fill condition for a bucket or log measured at 70% or more, which is real evidence.

Passes

  • Glossary: the added lines contain no bare "store", "control plane", "substrate" or "the host". The kinds are bucket-or-log-filling and bucket-or-log-unread. The headlines say "A module's bucket or log on the bus is filling up" and "... could not be read", and the resolved lines say "It has room again" and "It can be read again". The PR title still says "a filling store"; please rename it too.
  • Reading each one on its own: one bucket or log that cannot be read no longer hides the others. bucket-or-log-unread is Confirm: true, so it raises on the second look in a row, and it is registered under Raises (doctor.go). Its tests cover this.
  • Fill thresholds and edges: unchanged from 7bd6133.
  • sh merge-check.sh exited 0 at c432b9b, with 26 packages ok and no failure.

Required checks at c432b9b (read once): mesh/merge-gate is pending ("building on ace since 19:31"), and mesh/repo-check is missing. The forge says mergeable: false.

Review (independent): CHANGES — head c432b9b reviewed (diff since 7bd6133) The rename fixes the glossary finding, and reading each bucket or log on its own fixes the earlier note. One new behaviour can raise false warnings, so this is CHANGES. **Fails: an unreadable condition is taken as open, and that fabricates fill conditions** (`cmd/mesh-controller/bucket_log_fill.go`, `judgeFills` with the `open` closure in `probeFill`) When a stream cannot be read, `judgeFills` calls `open(fillKey(s))`. The closure answers `isOpen || err != nil`, so a failed read of the condition counts as open, and `keptFilling` then says a `bucket-or-log-filling` observation. When the condition was never open, `c` is empty, and the summary falls back to "... was filling when it was last read", which is not true. Both reads go to the same bus: `StreamInfo` and the conditions bucket. A slow or partly answering bus therefore fails both reads in one run. Every declared bucket and log (about 29 buckets live today, plus logs) would then get a fill observation at Warning with no fill evidence. It is not confirmed (`Confirm` is false), so it raises on that single run. That breaks "evidence over assertion". This is not what `confirm.go` does, although the comment says it is. `isOpen` there only lets a confirmed finding that was actually observed raise one look early. It never makes a finding of a kind nobody observed. Fix: in the unread path, keep the fill condition only when the read of the condition succeeded and said open. Have `openFill` return the error and call `keptFilling` only when the error is nil and the condition is open. The `bucket-or-log-unread` observation already says what is unknown. Add a test: a stream read fails and the condition read fails, and nothing of kind `bucket-or-log-filling` is said. In the readable path, treating an error as open is contained and acceptable. It can only keep or raise a fill condition for a bucket or log measured at 70% or more, which is real evidence. **Passes** - **Glossary:** the added lines contain no bare "store", "control plane", "substrate" or "the host". The kinds are `bucket-or-log-filling` and `bucket-or-log-unread`. The headlines say "A module's bucket or log on the bus is filling up" and "... could not be read", and the resolved lines say "It has room again" and "It can be read again". The PR title still says "a filling store"; please rename it too. - **Reading each one on its own:** one bucket or log that cannot be read no longer hides the others. `bucket-or-log-unread` is `Confirm: true`, so it raises on the second look in a row, and it is registered under `Raises` (`doctor.go`). Its tests cover this. - **Fill thresholds and edges:** unchanged from 7bd6133. - **`sh merge-check.sh`** exited 0 at c432b9b, with 26 packages ok and no failure. **Required checks at c432b9b** (read once): `mesh/merge-gate` is pending ("building on ace since 19:31"), and `mesh/repo-check` is missing. The forge says mergeable: false.
jschoubben added 1 commit 2026-10-11 17:34:45 +00:00
Keep a fill warning for an unreadable bucket or log only when its condition was read open
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
bf82d30865
Second review of #231: when neither the stream nor its condition can be
read, nothing is known of its fill, so none is said; the unread warning
covers it. Only a condition read back as open is kept, with its own words.
mesh-admin changed title from Let a module keep a log the controller creates and never removes, and say a filling store before it is full (ADR 0297) to Let a module keep a log the controller creates and never removes, and warn before a bucket or log is full (ADR 0297) 2026-10-11 17:35:01 +00:00
Author
Contributor

Review (independent): APPROVE — head bf82d30 reviewed (diff since c432b9b, and the whole PR as of 7bd6133 and c432b9b)

The finding from the second review is fixed:

  • openFill now returns its error (cmd/mesh-controller/bucket_log_fill.go).
  • For an unreadable bucket or log, judgeFills keeps the fill condition only when the condition read succeeded and said open (cerr == nil && isOpen).
  • keptFilling uses only the open condition's own severity and summary. The invented fallback summary is gone.
  • For a readable bucket or log, a condition that cannot be read is still taken as open. That only keeps or raises a fill measured at 70% or more, so it rests on evidence and stays contained.
  • The new test TestNothingIsSaidOfAFillWhenNeitherItNorItsConditionCanBeRead covers both paths: no fill is said for the unreadable log, its unread finding is said, and the bucket at 72% is kept.
  • The PR title no longer uses "store".

Nothing else changed since c432b9b, and every other checklist item passed in the earlier reviews.

sh merge-check.sh exited 0 at bf82d30, with 26 packages ok and no failure.

Required checks at bf82d30 (read once):

  • mesh/merge-gate: pending ("building on g14 since 19:35").
  • mesh/repo-check: missing.
  • The forge says mergeable: false.

This approval holds only once both required checks are green and read at this head.

Review (independent): APPROVE — head bf82d30 reviewed (diff since c432b9b, and the whole PR as of 7bd6133 and c432b9b) The finding from the second review is fixed: - `openFill` now returns its error (`cmd/mesh-controller/bucket_log_fill.go`). - For an unreadable bucket or log, `judgeFills` keeps the fill condition only when the condition read succeeded and said open (`cerr == nil && isOpen`). - `keptFilling` uses only the open condition's own severity and summary. The invented fallback summary is gone. - For a readable bucket or log, a condition that cannot be read is still taken as open. That only keeps or raises a fill measured at 70% or more, so it rests on evidence and stays contained. - The new test `TestNothingIsSaidOfAFillWhenNeitherItNorItsConditionCanBeRead` covers both paths: no fill is said for the unreadable log, its unread finding is said, and the bucket at 72% is kept. - The PR title no longer uses "store". Nothing else changed since c432b9b, and every other checklist item passed in the earlier reviews. `sh merge-check.sh` exited 0 at bf82d30, with 26 packages ok and no failure. Required checks at bf82d30 (read once): - `mesh/merge-gate`: pending ("building on g14 since 19:35"). - `mesh/repo-check`: missing. - The forge says mergeable: false. This approval holds only once both required checks are green and read at this head.
Author
Contributor

Merge check at c432b9b5

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go

Run by the build seat on ace as build-1791739863875266566 (builds --log build-1791739863875266566).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:21:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T17:21:39Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.046s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	203.499s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.035s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.044s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.037s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.123s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.073s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.835s
ok  	github.com/novox/mesh-controller/internal/builder	14.896s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.900s
ok  	github.com/novox/mesh-controller/internal/conditions	2.468s
ok  	github.com/novox/mesh-controller/internal/envfile	1.042s
ok  	github.com/novox/mesh-controller/internal/facts	1.047s
ok  	github.com/novox/mesh-controller/internal/identity	4.161s
ok  	github.com/novox/mesh-controller/internal/inventory	80.532s
ok  	github.com/novox/mesh-controller/internal/lease	17.678s
ok  	github.com/novox/mesh-controller/internal/licences	3.770s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.028s
ok  	github.com/novox/mesh-controller/internal/link	58.493s
ok  	github.com/novox/mesh-controller/internal/lint	2.137s
ok  	github.com/novox/mesh-controller/internal/outward	1.062s
ok  	github.com/novox/mesh-controller/internal/overlay	1.056s
ok  	github.com/novox/mesh-controller/internal/secrets	1.437s
ok  	github.com/novox/mesh-controller/internal/store	3.326s
ok  	github.com/novox/mesh-controller/internal/testbus	1.204s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `c432b9b5` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go Run by the build seat on ace as `build-1791739863875266566` (`builds --log build-1791739863875266566`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:21:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T17:21:39Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.046s ok github.com/novox/mesh-controller/cmd/mesh-controller 203.499s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.035s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.044s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.037s ok github.com/novox/mesh-controller/examples/route-proxy 1.123s ok github.com/novox/mesh-controller/internal/artifacts 1.073s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.835s ok github.com/novox/mesh-controller/internal/builder 14.896s ok github.com/novox/mesh-controller/internal/catalogue 6.900s ok github.com/novox/mesh-controller/internal/conditions 2.468s ok github.com/novox/mesh-controller/internal/envfile 1.042s ok github.com/novox/mesh-controller/internal/facts 1.047s ok github.com/novox/mesh-controller/internal/identity 4.161s ok github.com/novox/mesh-controller/internal/inventory 80.532s ok github.com/novox/mesh-controller/internal/lease 17.678s ok github.com/novox/mesh-controller/internal/licences 3.770s ok github.com/novox/mesh-controller/internal/licences/adapters 1.028s ok github.com/novox/mesh-controller/internal/link 58.493s ok github.com/novox/mesh-controller/internal/lint 2.137s ok github.com/novox/mesh-controller/internal/outward 1.062s ok github.com/novox/mesh-controller/internal/overlay 1.056s ok github.com/novox/mesh-controller/internal/secrets 1.437s ok github.com/novox/mesh-controller/internal/store 3.326s ok github.com/novox/mesh-controller/internal/testbus 1.204s ok github.com/novox/mesh-controller/internal/token 1.016s ```
Author
Contributor

Merge check at bf82d308

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go

Run by the build seat on g14 as build-1791740109665224075 (builds --log build-1791740109665224075).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:31:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T17:31:39Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy

notes:
  - cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go and internal/catalogue/logs_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.082s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	232.054s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.009s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.020s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.010s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.151s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.046s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	5.644s
ok  	github.com/novox/mesh-controller/internal/builder	16.702s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.418s
ok  	github.com/novox/mesh-controller/internal/conditions	2.444s
ok  	github.com/novox/mesh-controller/internal/envfile	1.030s
ok  	github.com/novox/mesh-controller/internal/facts	1.034s
ok  	github.com/novox/mesh-controller/internal/identity	9.955s
ok  	github.com/novox/mesh-controller/internal/inventory	82.629s
ok  	github.com/novox/mesh-controller/internal/lease	17.626s
ok  	github.com/novox/mesh-controller/internal/licences	9.545s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.006s
ok  	github.com/novox/mesh-controller/internal/link	60.277s
ok  	github.com/novox/mesh-controller/internal/lint	2.012s
ok  	github.com/novox/mesh-controller/internal/outward	1.030s
ok  	github.com/novox/mesh-controller/internal/overlay	1.023s
ok  	github.com/novox/mesh-controller/internal/secrets	1.330s
ok  	github.com/novox/mesh-controller/internal/store	5.250s
ok  	github.com/novox/mesh-controller/internal/testbus	1.158s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `bf82d308` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go Run by the build seat on g14 as `build-1791740109665224075` (`builds --log build-1791740109665224075`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:31:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T17:31:39Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy notes: - cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go and internal/catalogue/logs_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.082s ok github.com/novox/mesh-controller/cmd/mesh-controller 232.054s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.009s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.020s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.010s ok github.com/novox/mesh-controller/examples/route-proxy 1.151s ok github.com/novox/mesh-controller/internal/artifacts 1.046s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 5.644s ok github.com/novox/mesh-controller/internal/builder 16.702s ok github.com/novox/mesh-controller/internal/catalogue 7.418s ok github.com/novox/mesh-controller/internal/conditions 2.444s ok github.com/novox/mesh-controller/internal/envfile 1.030s ok github.com/novox/mesh-controller/internal/facts 1.034s ok github.com/novox/mesh-controller/internal/identity 9.955s ok github.com/novox/mesh-controller/internal/inventory 82.629s ok github.com/novox/mesh-controller/internal/lease 17.626s ok github.com/novox/mesh-controller/internal/licences 9.545s ok github.com/novox/mesh-controller/internal/licences/adapters 1.006s ok github.com/novox/mesh-controller/internal/link 60.277s ok github.com/novox/mesh-controller/internal/lint 2.012s ok github.com/novox/mesh-controller/internal/outward 1.030s ok github.com/novox/mesh-controller/internal/overlay 1.023s ok github.com/novox/mesh-controller/internal/secrets 1.330s ok github.com/novox/mesh-controller/internal/store 5.250s ok github.com/novox/mesh-controller/internal/testbus 1.158s ok github.com/novox/mesh-controller/internal/token 1.016s ```
jschoubben added 1 commit 2026-10-12 00:30:30 +00:00
Merge remote-tracking branch 'origin/main' into adr-0297-module-logs
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
6b77dd96f4
Author
Contributor

Review (independent): APPROVE — head 6b77dd9 reviewed (the merge of origin/main b12da96 into bf82d30)

1. The merge brings only main's changes.

  • 6b77dd9 has parents bf82d30 and b12da96, and b12da96 is origin/main.
  • On the 16 files this PR touches, git diff bf82d30 6b77dd9 makes exactly the changes git diff fad6555 b12da96 makes, line for line. The merge added nothing of its own there.
  • git diff origin/main...6b77dd9 equals the reviewed git diff fad6555 bf82d30 but for blob hashes and hunk offsets: the same 16 files, the same added and removed lines.

2. #230's grants step (issue 490) and grantsOnlyIn.

  • Raising logs cannot trip the guard. grantsOnlyIn (release.go:993) judges the composed declaration inside sendToEach's compose loop (push.go around 1239), before anything is sent. RaiseLogs runs later, in issueMemberships, on the way through deliver, and only creates or updates LOG_ streams on the bus. It never touches the declaration, the builds, or what was last sent. That is the same place and the same kind of act as RaiseBuckets right before it.
  • When a module newly declares a log, Users() grants its principal, and the runtime that carries it, publish on mesh.log.<m>.<n>.>, STREAM.INFO and DIRECT.GET. Only the content of the bus's user list changes. otherThanTheList (release.go:1062) lets exactly a change to the list's content through, so the grants step carries it. The membership's new logs field goes over the bus, not in the declaration, so grantsOnlyIn never sees it. A runtime without mesh-tools #28 ignores the unknown field.
  • If the manifest change also moves the module's build, grantsOnlyIn refuses the grants step as other than grants, and the normal plan carries it. That is the intended behaviour.
  • One side effect is worth knowing: a grants step now also creates a newly declared log's stream, as it already creates a newly declared bucket. That is consistent and causes no harm.

3. sh merge-check.sh at 6b77dd9 exited 0, with 26 packages ok. It also printed "NOT STORE-CHECKED: no MESH_TEST_POSTGRES, so the store tests listed in testdata/store-tests skipped". That harness came from main, and this PR touches no store code.

4. Required checks at 6b77dd9 (read once):

  • mesh/merge-gate: pending ("building on shanks since 02:30").
  • mesh/repo-check: missing.
  • The forge says mergeable: false.

This approval holds only once both required checks are green and read at this head.

Review (independent): APPROVE — head 6b77dd9 reviewed (the merge of origin/main b12da96 into bf82d30) **1. The merge brings only main's changes.** - 6b77dd9 has parents bf82d30 and b12da96, and b12da96 is origin/main. - On the 16 files this PR touches, `git diff bf82d30 6b77dd9` makes exactly the changes `git diff fad6555 b12da96` makes, line for line. The merge added nothing of its own there. - `git diff origin/main...6b77dd9` equals the reviewed `git diff fad6555 bf82d30` but for blob hashes and hunk offsets: the same 16 files, the same added and removed lines. **2. #230's grants step (issue 490) and `grantsOnlyIn`.** - Raising logs cannot trip the guard. `grantsOnlyIn` (`release.go:993`) judges the composed declaration inside `sendToEach`'s compose loop (`push.go` around 1239), before anything is sent. `RaiseLogs` runs later, in `issueMemberships`, on the way through `deliver`, and only creates or updates `LOG_` streams on the bus. It never touches the declaration, the builds, or what was last sent. That is the same place and the same kind of act as `RaiseBuckets` right before it. - When a module newly declares a log, `Users()` grants its principal, and the runtime that carries it, publish on `mesh.log.<m>.<n>.>`, `STREAM.INFO` and `DIRECT.GET`. Only the content of the bus's user list changes. `otherThanTheList` (`release.go:1062`) lets exactly a change to the list's content through, so the grants step carries it. The membership's new `logs` field goes over the bus, not in the declaration, so `grantsOnlyIn` never sees it. A runtime without mesh-tools #28 ignores the unknown field. - If the manifest change also moves the module's build, `grantsOnlyIn` refuses the grants step as other than grants, and the normal plan carries it. That is the intended behaviour. - One side effect is worth knowing: a grants step now also creates a newly declared log's stream, as it already creates a newly declared bucket. That is consistent and causes no harm. **3. `sh merge-check.sh` at 6b77dd9** exited 0, with 26 packages ok. It also printed "NOT STORE-CHECKED: no MESH_TEST_POSTGRES, so the store tests listed in testdata/store-tests skipped". That harness came from main, and this PR touches no store code. **4. Required checks at 6b77dd9** (read once): - `mesh/merge-gate`: pending ("building on shanks since 02:30"). - `mesh/repo-check`: missing. - The forge says mergeable: false. This approval holds only once both required checks are green and read at this head.
Author
Contributor

Merge check at 6b77dd96

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine
  • read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go

Run by the build seat on shanks as build-1791765056236629596 (builds --log build-1791765056236629596).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T00:25:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T00:25:39Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy

notes:
  - cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go and internal/catalogue/logs_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.044s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	251.228s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.044s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.037s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.246s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.075s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.400s
ok  	github.com/novox/mesh-controller/internal/builder	18.822s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.038s
ok  	github.com/novox/mesh-controller/internal/conditions	2.600s
ok  	github.com/novox/mesh-controller/internal/envfile	1.046s
ok  	github.com/novox/mesh-controller/internal/facts	1.041s
ok  	github.com/novox/mesh-controller/internal/identity	5.318s
ok  	github.com/novox/mesh-controller/internal/inventory	102.611s
ok  	github.com/novox/mesh-controller/internal/lease	17.693s
ok  	github.com/novox/mesh-controller/internal/licences	4.874s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.034s
ok  	github.com/novox/mesh-controller/internal/link	62.038s
ok  	github.com/novox/mesh-controller/internal/lint	2.454s
ok  	github.com/novox/mesh-controller/internal/outward	1.077s
ok  	github.com/novox/mesh-controller/internal/overlay	1.063s
ok  	github.com/novox/mesh-controller/internal/secrets	1.529s
ok  	github.com/novox/mesh-controller/internal/store	3.559s
ok  	github.com/novox/mesh-controller/internal/testbus	1.246s
ok  	github.com/novox/mesh-controller/internal/token	1.024s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.42s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.40s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.44s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.27s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.27s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.27s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.26s)
**Merge check** at `6b77dd96` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine - read by no module's build: cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go, internal/catalogue/logs_test.go Run by the build seat on shanks as `build-1791765056236629596` (`builds --log build-1791765056236629596`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T00:25:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T00:25:39Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy notes: - cmd/mesh-controller/bucket_log_fill_test.go, internal/broker/log_test.go and internal/catalogue/logs_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.044s ok github.com/novox/mesh-controller/cmd/mesh-controller 251.228s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.026s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.044s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.037s ok github.com/novox/mesh-controller/examples/route-proxy 1.246s ok github.com/novox/mesh-controller/internal/artifacts 1.075s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.400s ok github.com/novox/mesh-controller/internal/builder 18.822s ok github.com/novox/mesh-controller/internal/catalogue 8.038s ok github.com/novox/mesh-controller/internal/conditions 2.600s ok github.com/novox/mesh-controller/internal/envfile 1.046s ok github.com/novox/mesh-controller/internal/facts 1.041s ok github.com/novox/mesh-controller/internal/identity 5.318s ok github.com/novox/mesh-controller/internal/inventory 102.611s ok github.com/novox/mesh-controller/internal/lease 17.693s ok github.com/novox/mesh-controller/internal/licences 4.874s ok github.com/novox/mesh-controller/internal/licences/adapters 1.034s ok github.com/novox/mesh-controller/internal/link 62.038s ok github.com/novox/mesh-controller/internal/lint 2.454s ok github.com/novox/mesh-controller/internal/outward 1.077s ok github.com/novox/mesh-controller/internal/overlay 1.063s ok github.com/novox/mesh-controller/internal/secrets 1.529s ok github.com/novox/mesh-controller/internal/store 3.559s ok github.com/novox/mesh-controller/internal/testbus 1.246s ok github.com/novox/mesh-controller/internal/token 1.024s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.43s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.41s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.42s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.40s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.44s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.27s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.27s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.27s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.26s) ```
mesh-admin merged commit 3bd984c41e into main 2026-10-12 00:42:56 +00:00
mesh-admin deleted branch adr-0297-module-logs 2026-10-12 00:42:56 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#231