The store-tests step fails on a malformed line, a failed go test and a shortened list (issue 515) #238

Merged
mesh-admin merged 1 commits from fix/515-store-tests-step into main 2026-10-11 22:35:40 +00:00
Contributor

Fixes novox/hq issue 515, plus the mid-line result found on #232.

merge-check.sh's store-tests step:

  • Malformed line: a line of testdata/store-tests that is not exactly <package> <TestName> fails the check, naming the line. Before, a lone package ran nothing and the step passed.
  • go test's exit status: a package whose go test exits non-zero fails the step even when each listed test said PASS (a TestMain or a leak checker failing afterwards).
  • Shortened list: an entry origin/main's testdata/store-tests lists must stay listed while func <TestName>( still exists in that package's _test.go files; removing the test function removes the need. The check's clone holds origin/main (check_base.go already reads it); when it cannot be read the step fails, never passes.
  • Mid-line result (#232): --- PASS:, --- FAIL: or --- SKIP: followed by the exact test name and its (…) is found anywhere in a line, so a result written after open output reads as PASS or FAIL, not NOT RUN.

The judging is a function, runnable alone on a recorded output: sh merge-check.sh judge-store-tests <package> <status> <output-file> <name>….

How each gap was shown before/after (no store, fixtures):

  • Mid-line PASS: old step says NOT RUN; new says PASS, exit 0.
  • Mid-line FAIL: old says NOT RUN; new says FAIL, exit 1.
  • PASS line then FAIL package with go test exit 1: old passes; new prints FAIL: go test exited 1, exit 1.
  • Line ./internal/inventory alone, with a stub go that passes everything: old step exit 0, line unsaid; new refuses the line, exit 1.
  • Entry ./internal/inventory TestTheLastSendSaysWhatTheMachineAnswered deleted from the list: old exit 0; new names it as dropped while its test exists, exit 1.
  • Unchanged list: new passes.
Fixes novox/hq issue 515, plus the mid-line result found on #232. `merge-check.sh`'s store-tests step: - **Malformed line:** a line of testdata/store-tests that is not exactly `<package> <TestName>` fails the check, naming the line. Before, a lone package ran nothing and the step passed. - **go test's exit status:** a package whose `go test` exits non-zero fails the step even when each listed test said PASS (a TestMain or a leak checker failing afterwards). - **Shortened list:** an entry `origin/main`'s testdata/store-tests lists must stay listed while `func <TestName>(` still exists in that package's `_test.go` files; removing the test function removes the need. The check's clone holds `origin/main` (check_base.go already reads it); when it cannot be read the step fails, never passes. - **Mid-line result (#232):** `--- PASS:`, `--- FAIL:` or `--- SKIP:` followed by the exact test name and its `(…)` is found anywhere in a line, so a result written after open output reads as PASS or FAIL, not NOT RUN. The judging is a function, runnable alone on a recorded output: `sh merge-check.sh judge-store-tests <package> <status> <output-file> <name>…`. **How each gap was shown before/after (no store, fixtures):** - Mid-line PASS: old step says NOT RUN; new says PASS, exit 0. - Mid-line FAIL: old says NOT RUN; new says FAIL, exit 1. - PASS line then `FAIL` package with go test exit 1: old passes; new prints `FAIL: go test exited 1`, exit 1. - Line `./internal/inventory` alone, with a stub `go` that passes everything: old step exit 0, line unsaid; new refuses the line, exit 1. - Entry `./internal/inventory TestTheLastSendSaysWhatTheMachineAnswered` deleted from the list: old exit 0; new names it as dropped while its test exists, exit 1. - Unchanged list: new passes.
mesh-admin added 1 commit 2026-10-11 22:28:45 +00:00
Make the store-tests step fail on a malformed line, a failed go test and a shortened list
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
mesh/delivery delivered
e25fdf776f
The step let tests escape it: a one-field line ran nothing, go test's exit
status was ignored, a pull request could drop entries main lists, and a
result written mid-line by go test -v read as NOT RUN, hiding a FAIL
(novox/hq issue 515).
Author
Contributor

Delivery novox/mesh-controller@e25fdf776fba — delivered since 2026-10-11T22:35:55Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-11 22:28 (new) → proposed (announced): novox/mesh-controller#238's head announced
  • 2026-10-11 22:34 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 22:34 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 22:35 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 22:35 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@e25fdf776fba` — **delivered** since 2026-10-11T22:35:55Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-11 22:28 (new) → proposed (announced): novox/mesh-controller#238's head announced - 2026-10-11 22:34 proposed → checked (checked): the verdict names this commit - 2026-10-11 22:34 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 22:35 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 22:35 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin merged commit b26499bb9f into main 2026-10-11 22:35:40 +00:00
mesh-admin deleted branch fix/515-store-tests-step 2026-10-11 22:35:40 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#238