Give the unheld log test its own writer and memory, so it passes on a repeat (issue 486) #246

Merged
mesh-admin merged 1 commits from fix/486-the-unheld-log-test-stands-alone into main 2026-10-12 10:10:39 +00:00
Contributor

novox/hq issue 486 (note 6): TestOnlyTheServingControllerLogsEachChange failed on every repeat in one process, because logUnheld kept its "already logged" memory in package state, and the test swapped the global os.Stderr, which other tests in the package could see.

Change

  • logUnheld's memory and writer move into an unheldLogger (newUnheldLogger(out)). The package-level unheldLog is newUnheldLogger(os.Stderr), and the logUnheldChanges gate is unchanged, so production logs the same lines to the same place.
  • The test installs its own logger with a buffer, resets the gate, and restores both through t.Cleanup. It no longer touches os.Stderr. It also checks the line logged when a node's report becomes none.

Runs

  • main: go test -race -count=2 -run TestOnlyTheServingControllerLogsEachChange ./cmd/mesh-controller fails (unheld_report_test.go:103, the serving controller did not log a change).
  • branch: the same with -count=20 passes.
  • branch: go test -race ./cmd/mesh-controller passes twice (once uncached, 29 s).
novox/hq issue 486 (note 6): `TestOnlyTheServingControllerLogsEachChange` failed on every repeat in one process, because `logUnheld` kept its "already logged" memory in package state, and the test swapped the global `os.Stderr`, which other tests in the package could see. **Change** - `logUnheld`'s memory and writer move into an `unheldLogger` (`newUnheldLogger(out)`). The package-level `unheldLog` is `newUnheldLogger(os.Stderr)`, and the `logUnheldChanges` gate is unchanged, so production logs the same lines to the same place. - The test installs its own logger with a buffer, resets the gate, and restores both through `t.Cleanup`. It no longer touches `os.Stderr`. It also checks the line logged when a node's report becomes none. **Runs** - main: `go test -race -count=2 -run TestOnlyTheServingControllerLogsEachChange ./cmd/mesh-controller` fails (unheld_report_test.go:103, the serving controller did not log a change). - branch: the same with `-count=20` passes. - branch: `go test -race ./cmd/mesh-controller` passes twice (once uncached, 29 s).
mesh-admin added 1 commit 2026-10-12 09:41:54 +00:00
Give the unheld log test its own writer and memory, so it passes on a repeat (novox/hq issue 486)
mesh/delivery delivered
mesh/merge-gate pass: builds mesh-controller → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed
ac5d34f613
logUnheld kept what it had logged in package state and the test swapped os.Stderr, so a second run in one process logged nothing and failed.
Author
Contributor

Delivery novox/mesh-controller@ac5d34f61312 — delivered since 2026-10-12T10:17:32Z

Delivery plan — builds mesh-controller → novox; no bus step

  • tier 0: mesh-controller
  • novox: receives mesh-controller

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m41s
  • mesh-controller on the rest running it: sent

Transitions

  • 2026-10-12 09:42 (new) → proposed (announced): novox/mesh-controller#246's head announced
  • 2026-10-12 09:47 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 09:47 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 10:02 ready → proposed (recheck): checks 15 min old and main moved (#244, #245 merged, both touching cmd/mesh-controller); judge #246 again before merge
  • 2026-10-12 10:09 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 10:09 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 10:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 10:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 10:17 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@ac5d34f61312` — **delivered** since 2026-10-12T10:17:32Z **Delivery plan** — builds mesh-controller → novox; no bus step - tier 0: mesh-controller - novox: receives mesh-controller **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m41s - mesh-controller on the rest running it: sent **Transitions** - 2026-10-12 09:42 (new) → proposed (announced): novox/mesh-controller#246's head announced - 2026-10-12 09:47 proposed → checked (checked): the verdict names this commit - 2026-10-12 09:47 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 10:02 ready → proposed (recheck): checks 15 min old and main moved (#244, #245 merged, both touching cmd/mesh-controller); judge #246 again before merge - 2026-10-12 10:09 proposed → checked (checked): the verdict names this commit - 2026-10-12 10:09 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 10:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 10:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 10:17 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at ac5d34f6

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-controller → novox; no bus step

  • tier 0: mesh-controller
  • novox: receives mesh-controller
  • read by no module's build: cmd/mesh-controller/unheld_report_test.go

Run by the build seat on ace as build-1791798123054366826 (builds --log build-1791798123054366826).

--- the gate: mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T09:19:13Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T09:19:13Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-controller

notes:
  - cmd/mesh-controller/unheld_report_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.045s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	226.683s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.035s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.038s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.175s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.093s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.161s
ok  	github.com/novox/mesh-controller/internal/builder	16.368s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.692s
ok  	github.com/novox/mesh-controller/internal/conditions	2.633s
ok  	github.com/novox/mesh-controller/internal/envfile	1.042s
ok  	github.com/novox/mesh-controller/internal/facts	1.040s
ok  	github.com/novox/mesh-controller/internal/identity	4.728s
ok  	github.com/novox/mesh-controller/internal/inventory	88.807s
ok  	github.com/novox/mesh-controller/internal/lease	17.740s
ok  	github.com/novox/mesh-controller/internal/licences	4.327s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.095s
ok  	github.com/novox/mesh-controller/internal/link	60.005s
ok  	github.com/novox/mesh-controller/internal/lint	2.352s
ok  	github.com/novox/mesh-controller/internal/outward	1.137s
ok  	github.com/novox/mesh-controller/internal/overlay	1.092s
ok  	github.com/novox/mesh-controller/internal/secrets	1.473s
ok  	github.com/novox/mesh-controller/internal/store	3.555s
ok  	github.com/novox/mesh-controller/internal/testbus	1.259s
ok  	github.com/novox/mesh-controller/internal/token	1.022s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.38s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.36s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.26s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.25s)
**Merge check** at `ac5d34f6` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-controller → novox; no bus step - tier 0: mesh-controller - novox: receives mesh-controller - read by no module's build: cmd/mesh-controller/unheld_report_test.go Run by the build seat on ace as `build-1791798123054366826` (`builds --log build-1791798123054366826`). ``` --- the gate: mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T09:19:13Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T09:19:13Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-controller notes: - cmd/mesh-controller/unheld_report_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.045s ok github.com/novox/mesh-controller/cmd/mesh-controller 226.683s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.035s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.038s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.026s ok github.com/novox/mesh-controller/examples/route-proxy 1.175s ok github.com/novox/mesh-controller/internal/artifacts 1.093s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.161s ok github.com/novox/mesh-controller/internal/builder 16.368s ok github.com/novox/mesh-controller/internal/catalogue 7.692s ok github.com/novox/mesh-controller/internal/conditions 2.633s ok github.com/novox/mesh-controller/internal/envfile 1.042s ok github.com/novox/mesh-controller/internal/facts 1.040s ok github.com/novox/mesh-controller/internal/identity 4.728s ok github.com/novox/mesh-controller/internal/inventory 88.807s ok github.com/novox/mesh-controller/internal/lease 17.740s ok github.com/novox/mesh-controller/internal/licences 4.327s ok github.com/novox/mesh-controller/internal/licences/adapters 1.095s ok github.com/novox/mesh-controller/internal/link 60.005s ok github.com/novox/mesh-controller/internal/lint 2.352s ok github.com/novox/mesh-controller/internal/outward 1.137s ok github.com/novox/mesh-controller/internal/overlay 1.092s ok github.com/novox/mesh-controller/internal/secrets 1.473s ok github.com/novox/mesh-controller/internal/store 3.555s ok github.com/novox/mesh-controller/internal/testbus 1.259s ok github.com/novox/mesh-controller/internal/token 1.022s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.38s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.36s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.26s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.25s) ```
Author
Contributor

Merge check at ac5d34f6

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-controller → novox; no bus step

  • tier 0: mesh-controller
  • novox: receives mesh-controller
  • read by no module's build: cmd/mesh-controller/unheld_report_test.go

Run by the build seat on g14 as build-1791799364573570788 (builds --log build-1791799364573570788).

--- the gate: mesh-controller
mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T09:59:43Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T09:59:43Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-controller

notes:
  - cmd/mesh-controller/unheld_report_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.048s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	249.782s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.089s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	5.814s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.101s
ok  	github.com/novox/mesh-controller/examples/route-proxy	6.001s
ok  	github.com/novox/mesh-controller/internal/artifacts	5.845s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	8.928s
ok  	github.com/novox/mesh-controller/internal/builder	20.939s
ok  	github.com/novox/mesh-controller/internal/catalogue	12.522s
ok  	github.com/novox/mesh-controller/internal/conditions	7.317s
ok  	github.com/novox/mesh-controller/internal/envfile	5.824s
ok  	github.com/novox/mesh-controller/internal/facts	5.882s
ok  	github.com/novox/mesh-controller/internal/identity	9.373s
ok  	github.com/novox/mesh-controller/internal/inventory	101.769s
ok  	github.com/novox/mesh-controller/internal/lease	22.511s
ok  	github.com/novox/mesh-controller/internal/licences	9.124s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	4.740s
ok  	github.com/novox/mesh-controller/internal/link	64.939s
ok  	github.com/novox/mesh-controller/internal/lint	2.255s
ok  	github.com/novox/mesh-controller/internal/outward	1.058s
ok  	github.com/novox/mesh-controller/internal/overlay	1.033s
ok  	github.com/novox/mesh-controller/internal/secrets	1.514s
ok  	github.com/novox/mesh-controller/internal/store	3.313s
ok  	github.com/novox/mesh-controller/internal/testbus	1.215s
ok  	github.com/novox/mesh-controller/internal/token	1.021s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.37s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.37s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.33s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.24s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s)
**Merge check** at `ac5d34f6` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-controller → novox; no bus step - tier 0: mesh-controller - novox: receives mesh-controller - read by no module's build: cmd/mesh-controller/unheld_report_test.go Run by the build seat on g14 as `build-1791799364573570788` (`builds --log build-1791799364573570788`). ``` --- the gate: mesh-controller mesh-controller: ok, 57 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T09:59:43Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T09:59:43Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-controller notes: - cmd/mesh-controller/unheld_report_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.048s ok github.com/novox/mesh-controller/cmd/mesh-controller 249.782s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.089s ok github.com/novox/mesh-controller/examples/postgres-provisioner 5.814s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.101s ok github.com/novox/mesh-controller/examples/route-proxy 6.001s ok github.com/novox/mesh-controller/internal/artifacts 5.845s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 8.928s ok github.com/novox/mesh-controller/internal/builder 20.939s ok github.com/novox/mesh-controller/internal/catalogue 12.522s ok github.com/novox/mesh-controller/internal/conditions 7.317s ok github.com/novox/mesh-controller/internal/envfile 5.824s ok github.com/novox/mesh-controller/internal/facts 5.882s ok github.com/novox/mesh-controller/internal/identity 9.373s ok github.com/novox/mesh-controller/internal/inventory 101.769s ok github.com/novox/mesh-controller/internal/lease 22.511s ok github.com/novox/mesh-controller/internal/licences 9.124s ok github.com/novox/mesh-controller/internal/licences/adapters 4.740s ok github.com/novox/mesh-controller/internal/link 64.939s ok github.com/novox/mesh-controller/internal/lint 2.255s ok github.com/novox/mesh-controller/internal/outward 1.058s ok github.com/novox/mesh-controller/internal/overlay 1.033s ok github.com/novox/mesh-controller/internal/secrets 1.514s ok github.com/novox/mesh-controller/internal/store 3.313s ok github.com/novox/mesh-controller/internal/testbus 1.215s ok github.com/novox/mesh-controller/internal/token 1.021s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.37s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.37s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.33s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.39s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.24s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.23s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.25s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s) ```
mesh-admin merged commit f549647d18 into main 2026-10-12 10:10:39 +00:00
mesh-admin deleted branch fix/486-the-unheld-log-test-stands-alone 2026-10-12 10:10:40 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#246