Ask a node's engine which of its directories the walk would refuse, read-only (issue 358) #258

Merged
mesh-admin merged 1 commits from fix/358-judge-directories-read-only into main 2026-10-12 12:48:56 +00:00
Contributor

Why (issue 358). mesh-host #87 gives a mesh directory its mode and owner only through a walk from / that follows no link another account could make. A directory that walk refuses gates its module, and on the control-node that could stop mesh-controller or mesh-host. Before #87 merges, the operator is to see which directories it would refuse on every node, including novox, where no tool reads a path today. mesh-host #88 (same branch name, same delivery group) makes the engine answer that read-only. This is the controller's half.

What changes

  • node judge-directories <node> (cmd/mesh-controller/nodes.go) signs the ask with the mesh's key as a hand-over is, under its own context (novox-mesh judge-directories v1, link.AskJudgeDirectories). It asks the node's engine on mesh.node.<node>.ask.judge-directories and prints <node> (read-only: nothing on <node> was changed) followed by the engine's lines: one per directory, placed, would be refused: <why>, refused already by the placement guard, or below the home. A refusal from the engine fails the command, and an unknown node is never asked.
  • A seat verb an agent may call: mesh-controller.judge-directories {node} runs exactly node judge-directories <node>. node judge-directories joins node list and node show as the node lines a verb may run, and it is a reading verb, so it does not nudge status. It is in module.json and in the verb table with a description that says it is read-only.
  • Bus: each node is granted a subscribe on its own mesh.node.<node>.ask.judge-directories only. The writers table gives the publish to the controller alone (a judgement of a machine's directories asked of it). The golden testdata/composed.conf gains the one subject.

How it was tested

  • internal/link/judge_directories_test.go: asked against a real test bus, the ask is signed under its own context. The test checks it is not a hand-over's or a setuid search's signature, names this node and no path, carries a nonce and an expiry, and the answer comes back. A node with nothing listening fails, saying nothing was judged.
  • cmd/mesh-controller/handover_test.go: the line asks only one known node, fails on a refusal and prints nothing then, and prints the read-only header and the engine's lines. The verb runs node judge-directories novox and is refused without a node.
  • internal/broker: one publisher (the controller; a node, its node tools and a module are refused), and a node subscribes to its own subject and not another node's. The golden composition is updated.
  • sh merge-check.sh green locally. The store tests were skipped, because there is no MESH_TEST_POSTGRES here.

Order: lands with mesh-host #88 in one delivery group; both are needed before the verb answers. The bus's user list is re-composed by the push that follows. A controller rollout: merge only while mesh-controller.plans says no plan is mid-gate. #203 also changes internal/broker and the golden file; whichever merges second rebases.

Part of issue 358.

**Why** (issue 358). mesh-host #87 gives a mesh directory its mode and owner only through a walk from `/` that follows no link another account could make. A directory that walk refuses gates its module, and on the control-node that could stop mesh-controller or mesh-host. Before #87 merges, the operator is to see which directories it would refuse on every node, including novox, where no tool reads a path today. mesh-host #88 (same branch name, same delivery group) makes the engine answer that read-only. This is the controller's half. **What changes** - `node judge-directories <node>` (`cmd/mesh-controller/nodes.go`) signs the ask with the mesh's key as a hand-over is, under its own context (`novox-mesh judge-directories v1`, `link.AskJudgeDirectories`). It asks the node's engine on `mesh.node.<node>.ask.judge-directories` and prints `<node> (read-only: nothing on <node> was changed)` followed by the engine's lines: one per directory, `placed`, `would be refused: <why>`, `refused already by the placement guard`, or `below the home`. A refusal from the engine fails the command, and an unknown node is never asked. - **A seat verb an agent may call**: `mesh-controller.judge-directories {node}` runs exactly `node judge-directories <node>`. `node judge-directories` joins `node list` and `node show` as the node lines a verb may run, and it is a reading verb, so it does not nudge `status`. It is in `module.json` and in the verb table with a description that says it is read-only. - **Bus**: each node is granted a subscribe on its own `mesh.node.<node>.ask.judge-directories` only. The writers table gives the publish to the controller alone (`a judgement of a machine's directories asked of it`). The golden `testdata/composed.conf` gains the one subject. **How it was tested** - `internal/link/judge_directories_test.go`: asked against a real test bus, the ask is signed under its own context. The test checks it is not a hand-over's or a setuid search's signature, names this node and no path, carries a nonce and an expiry, and the answer comes back. A node with nothing listening fails, saying nothing was judged. - `cmd/mesh-controller/handover_test.go`: the line asks only one known node, fails on a refusal and prints nothing then, and prints the read-only header and the engine's lines. The verb runs `node judge-directories novox` and is refused without a node. - `internal/broker`: one publisher (the controller; a node, its node tools and a module are refused), and a node subscribes to its own subject and not another node's. The golden composition is updated. - `sh merge-check.sh` green locally. The store tests were skipped, because there is no MESH_TEST_POSTGRES here. **Order**: lands with mesh-host #88 in one delivery group; both are needed before the verb answers. The bus's user list is re-composed by the push that follows. A controller rollout: merge only while `mesh-controller.plans` says no plan is mid-gate. #203 also changes `internal/broker` and the golden file; whichever merges second rebases. Part of issue 358.
mesh-admin added 1 commit 2026-10-12 12:17:15 +00:00
Ask a node's engine which of its directories the walk would refuse, read-only (issue 358)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
mesh/delivery-group group fix/358-judge-directories-read-only merged: every member is merged
7385d9c092
Before the node-engine gives a mesh directory its mode and owner only through
a walk that follows no link another account could make, the operator is to
see which directories that walk would refuse on every node, the control-node
included, where no tool reads a path. `node judge-directories <node>` signs
the ask as a hand-over is, under its own context, and prints the engine's
one line per directory; it changes nothing, so it is a seat verb an agent may
call. The node is granted the subject, the controller alone its publish.
Author
Contributor

Delivery novox/mesh-controller@7385d9c092cc — delivered since 2026-10-12T13:00:44Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Group fix/358-judge-directories-read-only, in order: novox/mesh-controller@7385d9c092 → novox/mesh-host@b92fb68116

Machines

  • mesh-controller on novox: passed — healthy 3 times over 4m12s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m15s
  • build-agent on the rest running it: sent
  • route-proxy on ace: passed — healthy 1 times over 1m32s
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-12 12:17 (new) → proposed (announced): novox/mesh-controller#258's head announced
  • 2026-10-12 12:24 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:24 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 12:49 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 12:49 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 13:00 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@7385d9c092cc` — **delivered** since 2026-10-12T13:00:44Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine **Group** `fix/358-judge-directories-read-only`, in order: novox/mesh-controller@7385d9c092cc → novox/mesh-host@b92fb6811610 - novox/mesh-controller@7385d9c092cc before novox/mesh-host@b92fb6811610: built by, over engine before controller - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 3 times over 4m12s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m15s - build-agent on the rest running it: sent - route-proxy on ace: passed — healthy 1 times over 1m32s - route-proxy on the rest running it: sent **Transitions** - 2026-10-12 12:17 (new) → proposed (announced): novox/mesh-controller#258's head announced - 2026-10-12 12:24 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:24 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 12:49 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 12:49 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 13:00 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 7385d9c0

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine
  • read by no module's build: cmd/mesh-controller/handover_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/broker/writers_test.go, internal/link/judge_directories_test.go

Run by the build seat on g14 as build-1791807456070585779 (builds --log build-1791807456070585779).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:11:38Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:11:38Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy

notes:
  - cmd/mesh-controller/handover_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/broker/writers_test.go and internal/link/judge_directories_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.040s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	248.722s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.029s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.037s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.029s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.206s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.060s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.244s
ok  	github.com/novox/mesh-controller/internal/builder	16.321s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.957s
ok  	github.com/novox/mesh-controller/internal/conditions	2.623s
ok  	github.com/novox/mesh-controller/internal/envfile	1.037s
ok  	github.com/novox/mesh-controller/internal/facts	1.040s
ok  	github.com/novox/mesh-controller/internal/identity	4.941s
ok  	github.com/novox/mesh-controller/internal/inventory	86.702s
ok  	github.com/novox/mesh-controller/internal/lease	17.708s
ok  	github.com/novox/mesh-controller/internal/licences	4.675s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.013s
ok  	github.com/novox/mesh-controller/internal/link	59.599s
ok  	github.com/novox/mesh-controller/internal/lint	2.199s
ok  	github.com/novox/mesh-controller/internal/outward	1.044s
ok  	github.com/novox/mesh-controller/internal/overlay	1.031s
ok  	github.com/novox/mesh-controller/internal/secrets	1.470s
ok  	github.com/novox/mesh-controller/internal/store	3.299s
ok  	github.com/novox/mesh-controller/internal/testbus	1.181s
ok  	github.com/novox/mesh-controller/internal/token	1.020s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.35s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.30s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.40s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.26s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.40s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.39s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.35s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.35s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.39s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.20s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.21s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.20s)
**Merge check** at `7385d9c0` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine - read by no module's build: cmd/mesh-controller/handover_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/broker/writers_test.go, internal/link/judge_directories_test.go Run by the build seat on g14 as `build-1791807456070585779` (`builds --log build-1791807456070585779`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:11:38Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:11:38Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy notes: - cmd/mesh-controller/handover_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/broker/writers_test.go and internal/link/judge_directories_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.040s ok github.com/novox/mesh-controller/cmd/mesh-controller 248.722s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.029s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.037s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.029s ok github.com/novox/mesh-controller/examples/route-proxy 1.206s ok github.com/novox/mesh-controller/internal/artifacts 1.060s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.244s ok github.com/novox/mesh-controller/internal/builder 16.321s ok github.com/novox/mesh-controller/internal/catalogue 6.957s ok github.com/novox/mesh-controller/internal/conditions 2.623s ok github.com/novox/mesh-controller/internal/envfile 1.037s ok github.com/novox/mesh-controller/internal/facts 1.040s ok github.com/novox/mesh-controller/internal/identity 4.941s ok github.com/novox/mesh-controller/internal/inventory 86.702s ok github.com/novox/mesh-controller/internal/lease 17.708s ok github.com/novox/mesh-controller/internal/licences 4.675s ok github.com/novox/mesh-controller/internal/licences/adapters 1.013s ok github.com/novox/mesh-controller/internal/link 59.599s ok github.com/novox/mesh-controller/internal/lint 2.199s ok github.com/novox/mesh-controller/internal/outward 1.044s ok github.com/novox/mesh-controller/internal/overlay 1.031s ok github.com/novox/mesh-controller/internal/secrets 1.470s ok github.com/novox/mesh-controller/internal/store 3.299s ok github.com/novox/mesh-controller/internal/testbus 1.181s ok github.com/novox/mesh-controller/internal/token 1.020s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.38s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.36s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.35s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.30s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.40s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.26s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.40s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.39s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.35s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.35s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.39s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.20s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.22s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.21s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.22s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.20s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 7385d9c

Independent review of PR #258 (issue 358), the controller half of mesh-host #88, at head 7385d9c092. I made a fresh clone and read the whole diff. go vet ./... and go test -race ./... pass. sh merge-check.sh passes with MESH_TEST_POSTGRES set to a throwaway local Postgres 18, so the store tests listed in testdata/store-tests ran and passed. They were not skipped.

Signing context matches #88's verifier exactly

  • The controller's JudgeDirectoriesContext is "novox-mesh judge-directories v1\n", byte for byte the constant mesh-host #88 verifies against in believed. The subject mesh.node.<node>.ask.judge-directories is the same on both sides, and each side has a test pinning both strings.
  • The ask is built by the shared signAsk (expiry and nonce filled, signature over context plus the ask's bytes as they travel) with HandOverAsk{Node, By} and no Path. That is exactly what #88 requires with withPath=false. The link test verifies that the signature does not verify under the hand-over's or the setuid search's context.

Grants are minimal

  • Node: gains a subscribe on mesh.node.<own>.ask.judge-directories only (golden composed.conf), with the existing allow_responses: {max: 1} for the one reply. The test checks a node does not get another node's subject.
  • Publish: no new grant. The controller already publishes mesh.node.>. The new writers-table row gives the subject to the controller alone, and TestADirectoryJudgementAskHasOnePublisher refuses a node, its node tools and a module.

The verb is read-only and cannot be bent

  • Fixed command: mesh-controller.judge-directories {node} maps to the fixed argv node judge-directories <node>. judge-directories is added to nodeReads, beside list and show, and to readingVerbs, so it does not nudge status.
  • Arguments: the line takes exactly one argument. It refuses none, two, or one starting with -. It asks only a node the inventory knows (NodeByName), so no other subject can be reached through the name.
  • Other nodes: even a mis-routed ask would be refused, because the engine checks the signed Node against itself.
  • Signature: the verb has no path that skips it. The only ask it can make is signed by the controller with the mesh's key, under this context, which #88 accepts only for a read-only judgement. A captured ask is single-use (nonce) and short-lived, and it cannot be replayed as a hand-over or a setuid search, because the contexts differ.
  • No writes: nothing is written on the controller's side. It does not record a hand-act, and it does not write to a store.
  • Refusals: a refusal from the engine fails the command and prints nothing.

Group check: on both mesh-host #88 (b92fb68) and this head, mesh/delivery-group is a success: "group fix/358-judge-directories-read-only ready: every member ready, and composed together they pass". mesh/merge-gate (it builds build-agent, mesh-controller and route-proxy for ace, g14, novox and shanks) and mesh/repo-check pass here.

Non-blocking

  • By is the caller from CallerVar. The engine refuses a By longer than its limit, and that refusal is loud, so this needs no change. It just means an unusually long caller name would show as a refusal, not a judgement.
  • As the body says: this is a controller rollout, so merge only while mesh-controller.plans says no plan is mid-gate, merge the group together, and rebase whichever of this and #203 lands second (both touch internal/broker and the golden file).
Verdict: approve at 7385d9c Independent review of PR #258 (issue 358), the controller half of mesh-host #88, at head 7385d9c092cc. I made a fresh clone and read the whole diff. `go vet ./...` and `go test -race ./...` pass. `sh merge-check.sh` passes with `MESH_TEST_POSTGRES` set to a throwaway local Postgres 18, so the store tests listed in testdata/store-tests ran and passed. They were not skipped. **Signing context matches #88's verifier exactly** - The controller's `JudgeDirectoriesContext` is `"novox-mesh judge-directories v1\n"`, byte for byte the constant mesh-host #88 verifies against in `believed`. The subject `mesh.node.<node>.ask.judge-directories` is the same on both sides, and each side has a test pinning both strings. - The ask is built by the shared `signAsk` (expiry and nonce filled, signature over context plus the ask's bytes as they travel) with `HandOverAsk{Node, By}` and no `Path`. That is exactly what #88 requires with `withPath=false`. The link test verifies that the signature does not verify under the hand-over's or the setuid search's context. **Grants are minimal** - **Node:** gains a subscribe on `mesh.node.<own>.ask.judge-directories` only (golden `composed.conf`), with the existing `allow_responses: {max: 1}` for the one reply. The test checks a node does not get another node's subject. - **Publish:** no new grant. The controller already publishes `mesh.node.>`. The new writers-table row gives the subject to the controller alone, and `TestADirectoryJudgementAskHasOnePublisher` refuses a node, its node tools and a module. **The verb is read-only and cannot be bent** - **Fixed command:** `mesh-controller.judge-directories {node}` maps to the fixed argv `node judge-directories <node>`. `judge-directories` is added to `nodeReads`, beside `list` and `show`, and to `readingVerbs`, so it does not nudge status. - **Arguments:** the line takes exactly one argument. It refuses none, two, or one starting with `-`. It asks only a node the inventory knows (`NodeByName`), so no other subject can be reached through the name. - **Other nodes:** even a mis-routed ask would be refused, because the engine checks the signed `Node` against itself. - **Signature:** the verb has no path that skips it. The only ask it can make is signed by the controller with the mesh's key, under this context, which #88 accepts only for a read-only judgement. A captured ask is single-use (nonce) and short-lived, and it cannot be replayed as a hand-over or a setuid search, because the contexts differ. - **No writes:** nothing is written on the controller's side. It does not record a hand-act, and it does not write to a store. - **Refusals:** a refusal from the engine fails the command and prints nothing. **Group check**: on both mesh-host #88 (b92fb68) and this head, `mesh/delivery-group` is a success: "group fix/358-judge-directories-read-only ready: every member ready, and composed together they pass". mesh/merge-gate (it builds build-agent, mesh-controller and route-proxy for ace, g14, novox and shanks) and mesh/repo-check pass here. **Non-blocking** - `By` is the caller from `CallerVar`. The engine refuses a `By` longer than its limit, and that refusal is loud, so this needs no change. It just means an unusually long caller name would show as a refusal, not a judgement. - As the body says: this is a controller rollout, so merge only while `mesh-controller.plans` says no plan is mid-gate, merge the group together, and rebase whichever of this and #203 lands second (both touch `internal/broker` and the golden file).
mesh-admin merged commit 27b13e4586 into main 2026-10-12 12:48:56 +00:00
mesh-admin deleted branch fix/358-judge-directories-read-only 2026-10-12 12:48:56 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#258