novox/mesh-controller
7
0
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

Admit a port from the machine's own local network, and never a public subnet (issue 154, ADR 0340) #299

Merged
mesh-admin merged 2 commits from fix/154-local-network into main 2026-10-13 13:07:12 +00:00
Conversation 6 Commits 2 Files Changed 14
+643 -17
mesh-admin commented 2026-10-13 09:20:44 +00:00
Contributor
Copy Link
Copy Source

after: novox/mesh-host

Issue 154; decision: novox/hq ADR 0340. Companion: mesh-host fix/154-local-network (reports the networks). Nothing in the catalogue changes: ace's modules move to local-network later, one at a time.

What it does

  • Source (§1): local-network is accepted by a manifest's listens.from and by expose; an unknown source is still refused.
  • Reach (§4): local-network is a fifth reach value beside machine/internal/public/both: the internal name only, the mesh's authority, and the filter source local-network.
  • Judging (§2, §3): catalogue.JudgeLocalNetworks counts a reported network only when it lies wholly in 10/8, 172.16/12, 192.168/16 or fc00::/7 and is on a link the machine reported as facing outside. A public subnet, a link-local one, one only overlapping a private range (10.0.0.0/7, 100.64/10, ::/0), the private network's own link and a bridge never count; each is judged with why.
  • Filter (§5, §6): a local-network rule is rendered on its own port only, from the mesh addresses plus the counted networks, in the input and forward chains. With none counted, the rule set says so and admits the port from the private network only, never widened to anywhere. In widest it sits between mesh and anywhere.
  • Shown (§8): plan <node> says each local-network port and the networks it resolved to, or none. node <node> lists every attached network, whether it counts and why. The flip preview says what a local-network port stays open to.
  • On an adopted node the opening is the mesh's part only (the found firewall admits the LAN; an opening has no word for it, and everywhere would open it to the internet). The guard (ADR 0103) does not treat it as mesh-only.
  • The networks are read from the profile the node already stores (machine.networks): no schema change.

Design limits chosen (say if wrong)

  • The source local-network in a manifest means the same as the reach: the private network AND the local networks (ADR 0340 §4), so it covers mesh.
  • The merge gate's snapshot carries no networks, so a gate composition renders a local-network port as "none reported". Nothing in the catalogue uses it yet.

Tests (fail on main: the identifiers do not exist there)

  • internal/catalogue localnetwork_test.go: only a private network on an outward link counts (the public /24, link-local, tunnel and bridge do not); a network not wholly in a private range does not count; a local-network port is admitted from its networks and the mesh in both chains, never anywhere, and the mesh-only port is not widened; none is said and not widened; a manifest may listen from it and lan is refused; the reach is internal plus the local network; ordering mesh < local-network < anywhere; an adopted node's opening is mesh only.
  • internal/inventory machine_test.go: the node-engine's networks are read.
  • cmd/mesh-controller local_network_test.go: node shows which networks count and why; an older engine, no networks and never reported are each said; the flip preview names the networks or that none was reported.

gofmt, go vet ./... and go test ./... pass (without -race and without MESH_TEST_POSTGRES: store tests skipped; load limit on g14).

Fixes issue 154 (with the mesh-host PR).

after: novox/mesh-host Issue 154; decision: novox/hq ADR 0340. Companion: mesh-host fix/154-local-network (reports the networks). Nothing in the catalogue changes: ace's modules move to `local-network` later, one at a time. **What it does** - Source (§1): `local-network` is accepted by a manifest's `listens.from` and by `expose`; an unknown source is still refused. - Reach (§4): `local-network` is a fifth reach value beside machine/internal/public/both: the internal name only, the mesh's authority, and the filter source `local-network`. - Judging (§2, §3): `catalogue.JudgeLocalNetworks` counts a reported network only when it lies wholly in 10/8, 172.16/12, 192.168/16 or fc00::/7 and is on a link the machine reported as facing outside. A public subnet, a link-local one, one only overlapping a private range (10.0.0.0/7, 100.64/10, ::/0), the private network's own link and a bridge never count; each is judged with why. - Filter (§5, §6): a `local-network` rule is rendered on its own port only, from the mesh addresses plus the counted networks, in the input and forward chains. With none counted, the rule set says so and admits the port from the private network only, never widened to anywhere. In `widest` it sits between mesh and anywhere. - Shown (§8): `plan <node>` says each local-network port and the networks it resolved to, or none. `node <node>` lists every attached network, whether it counts and why. The flip preview says what a local-network port stays open to. - On an adopted node the opening is the mesh's part only (the found firewall admits the LAN; an opening has no word for it, and everywhere would open it to the internet). The guard (ADR 0103) does not treat it as mesh-only. - The networks are read from the profile the node already stores (`machine.networks`): no schema change. **Design limits chosen (say if wrong)** - The source `local-network` in a manifest means the same as the reach: the private network AND the local networks (ADR 0340 §4), so it covers `mesh`. - The merge gate's snapshot carries no networks, so a gate composition renders a local-network port as "none reported". Nothing in the catalogue uses it yet. **Tests (fail on main: the identifiers do not exist there)** - internal/catalogue localnetwork_test.go: only a private network on an outward link counts (the public /24, link-local, tunnel and bridge do not); a network not wholly in a private range does not count; a local-network port is admitted from its networks and the mesh in both chains, never anywhere, and the mesh-only port is not widened; none is said and not widened; a manifest may listen from it and `lan` is refused; the reach is internal plus the local network; ordering mesh < local-network < anywhere; an adopted node's opening is mesh only. - internal/inventory machine_test.go: the node-engine's `networks` are read. - cmd/mesh-controller local_network_test.go: node shows which networks count and why; an older engine, no networks and never reported are each said; the flip preview names the networks or that none was reported. gofmt, `go vet ./...` and `go test ./...` pass (without -race and without MESH_TEST_POSTGRES: store tests skipped; load limit on g14). Fixes issue 154 (with the mesh-host PR).
mesh-admin added 1 commit 2026-10-13 09:20:44 +00:00
Admit a port from the machine's own local network, and never a public subnet (issue 154, ADR 0340)
mesh/delivery-group group fix/154-local-network checking: 0 of 2 member(s) ready
Details
mesh/merge-gate out of date: judged against trunk 1826b68a22b5, the trunk is now 404b4409e70e; judged again on a recheck or when it is merged
Details
mesh/repo-check out of date: judged against trunk 1826b68a22b5, the trunk is now 404b4409e70e; judged again on a recheck or when it is merged
Details
mesh/delivery superseded: a newer head of the same pull request
Details
6e6cd5e26d 
A local service could only be declared public, which says the internet. local-network is a source and a reach: the private network and the private networks the machine reported on a link facing outside, judged here, shown by plan and node, and said in the rule set when there are none.
mesh-admin commented 2026-10-13 09:21:34 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-controller@4cc8588afb87 — delivered since 2026-10-13T13:26:37Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Group fix/154-local-network, in order: novox/mesh-host@cb7b71dcc5 → novox/mesh-controller@4cc8588afb

Machines

  • build-agent on ace: passed — healthy 3 times over 2m40s
  • mesh-host on ace: passed — judged with build-agent: healthy 3 times over 2m40s
  • mesh-controller on novox: passed — healthy 3 times over 3m32s
  • build-agent on the rest running it: sent
  • mesh-host on the rest running it: sent
  • mesh-controller on the rest running it: sent

Transitions

  • 2026-10-13 11:21 (new) → proposed (announced): novox/mesh-controller#299's head announced
  • 2026-10-13 11:27 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 11:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 12:38 ready → proposed (trunk moved): out of date: judged against trunk 584aa2d7d7, the trunk is now f3875a6b6019; judged again on a recheck or when it is merged
  • 2026-10-13 13:01 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 13:01 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 13:09 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 13:09 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-13 13:26 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@4cc8588afb87` — **delivered** since 2026-10-13T13:26:37Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Group** `fix/154-local-network`, in order: novox/mesh-host@cb7b71dcc568 → novox/mesh-controller@4cc8588afb87 - novox/mesh-host@cb7b71dcc568 before novox/mesh-controller@4cc8588afb87: declared, over built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - build-agent on ace: passed — healthy 3 times over 2m40s - mesh-host on ace: passed — judged with build-agent: healthy 3 times over 2m40s - mesh-controller on novox: passed — healthy 3 times over 3m32s - build-agent on the rest running it: sent - mesh-host on the rest running it: sent - mesh-controller on the rest running it: sent **Transitions** - 2026-10-13 11:21 (new) → proposed (announced): novox/mesh-controller#299's head announced - 2026-10-13 11:27 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 11:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 12:38 ready → proposed (trunk moved): out of date: judged against trunk 584aa2d7d7a5, the trunk is now f3875a6b6019; judged again on a recheck or when it is merged - 2026-10-13 13:01 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 13:01 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 13:09 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 13:09 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-13 13:26 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin commented 2026-10-13 09:27:00 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 6e6cd5e2
Judged: head 6e6cd5e26db6 merged into trunk 1826b68a22b5; read beside it: mesh-catalog 45d01e77c26d, mesh-controller-main 1826b68a22b5, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go

Run by the build seat on ace as build-1791883293011832441 (builds --log build-1791883293011832441).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T09:19:10Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T09:19:10Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go and internal/inventory/machine_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.036s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	151.656s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.028s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.051s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.034s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.175s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.115s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.151s
ok  	github.com/novox/mesh-controller/internal/builder	34.383s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.064s
ok  	github.com/novox/mesh-controller/internal/conditions	2.602s
ok  	github.com/novox/mesh-controller/internal/envfile	1.048s
ok  	github.com/novox/mesh-controller/internal/facts	1.050s
ok  	github.com/novox/mesh-controller/internal/identity	4.617s
ok  	github.com/novox/mesh-controller/internal/inventory	30.532s
ok  	github.com/novox/mesh-controller/internal/lease	17.692s
ok  	github.com/novox/mesh-controller/internal/licences	3.852s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.064s
ok  	github.com/novox/mesh-controller/internal/link	57.973s
ok  	github.com/novox/mesh-controller/internal/lint	2.365s
ok  	github.com/novox/mesh-controller/internal/outward	1.084s
ok  	github.com/novox/mesh-controller/internal/overlay	1.070s
ok  	github.com/novox/mesh-controller/internal/secrets	1.438s
ok  	github.com/novox/mesh-controller/internal/store	3.363s
ok  	github.com/novox/mesh-controller/internal/testbus	1.249s
ok  	github.com/novox/mesh-controller/internal/token	1.023s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.19s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.21s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.21s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.20s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.18s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.16s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.96s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.22s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.12s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.23s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.23s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.20s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.20s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.24s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.19s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.22s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.19s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.18s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.18s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.18s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.21s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.27s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.25s)
  ./cmd/mesh-controller --- PASS: TestReplay201 (0.15s)
  ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.14s)
  ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.15s)
  ./cmd/mesh-controller --- PASS: TestReplay401 (0.27s)
  ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.21s)
  ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.28s)
  ./cmd/mesh-controller --- PASS: TestReplay340 (0.22s)
  ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay349 (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.16s)
  ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.14s)
  ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.17s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.07s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.07s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.09s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.06s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.06s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s)
  ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.06s)
  ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.06s)
**Merge check** at `6e6cd5e2` Judged: head `6e6cd5e26db6` merged into trunk `1826b68a22b5`; read beside it: mesh-catalog `45d01e77c26d`, mesh-controller-main `1826b68a22b5`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go Run by the build seat on ace as `build-1791883293011832441` (`builds --log build-1791883293011832441`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T09:19:10Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T09:19:10Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go and internal/inventory/machine_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.036s ok github.com/novox/mesh-controller/cmd/mesh-controller 151.656s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.028s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.051s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.034s ok github.com/novox/mesh-controller/examples/route-proxy 1.175s ok github.com/novox/mesh-controller/internal/artifacts 1.115s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.151s ok github.com/novox/mesh-controller/internal/builder 34.383s ok github.com/novox/mesh-controller/internal/catalogue 8.064s ok github.com/novox/mesh-controller/internal/conditions 2.602s ok github.com/novox/mesh-controller/internal/envfile 1.048s ok github.com/novox/mesh-controller/internal/facts 1.050s ok github.com/novox/mesh-controller/internal/identity 4.617s ok github.com/novox/mesh-controller/internal/inventory 30.532s ok github.com/novox/mesh-controller/internal/lease 17.692s ok github.com/novox/mesh-controller/internal/licences 3.852s ok github.com/novox/mesh-controller/internal/licences/adapters 1.064s ok github.com/novox/mesh-controller/internal/link 57.973s ok github.com/novox/mesh-controller/internal/lint 2.365s ok github.com/novox/mesh-controller/internal/outward 1.084s ok github.com/novox/mesh-controller/internal/overlay 1.070s ok github.com/novox/mesh-controller/internal/secrets 1.438s ok github.com/novox/mesh-controller/internal/store 3.363s ok github.com/novox/mesh-controller/internal/testbus 1.249s ok github.com/novox/mesh-controller/internal/token 1.023s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.19s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.21s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.21s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.20s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.18s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.16s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.96s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.22s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.12s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.23s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.23s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.20s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.20s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.24s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.19s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.22s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.19s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.18s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.18s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.18s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.21s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.27s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.25s) ./cmd/mesh-controller --- PASS: TestReplay201 (0.15s) ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.14s) ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.15s) ./cmd/mesh-controller --- PASS: TestReplay401 (0.27s) ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.21s) ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.28s) ./cmd/mesh-controller --- PASS: TestReplay340 (0.22s) ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.19s) ./cmd/mesh-controller --- PASS: TestReplay349 (0.19s) ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.16s) ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.14s) ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.17s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.07s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.07s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.09s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.06s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.06s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s) ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.06s) ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.06s) ```
mesh-admin left a comment
Author
Contributor
Copy Link
Copy Source

Verdict: request changes at 6e6cd5e26d

Every clause of ADR 0340 is built and, with one exception below, tested:

  • §1 (source): local-network is accepted by listens.from and expose; an unknown source ("lan") is still refused (TestAManifestMayListenFromTheLocalNetwork).
  • §2/§3 (judging): catalogue.JudgeLocalNetworks counts a network only when it lies wholly in a private range and is on a link reported as facing outside; the tunnel's own link and a container bridge never count regardless of address (TestOnlyAPrivateNetworkOnALinkFacingOutsideCounts); a network overlapping a private range without lying wholly inside it (10.0.0.0/7, 172.0.0.0/8) does not count either (TestANetworkNotWhollyInAPrivateRangeDoesNotCount).
  • §4 (reach): local-network is a fifth reach value, resolves to the internal name only (not the public one) and FromLocalNetwork (TestTheLocalNetworkReachIsInternalWithTheLocalNetworkAdded); widest() places it strictly between mesh and anywhere (TestTheLocalNetworkSitsBetweenTheMeshAndAnywhere).
  • §5 (filter per port): AsNftablesWithLocal renders the local-network rule on that port's rule alone, in both chains, admitting the mesh addresses plus the counted networks and never the public subnet (TestALocalNetworkPortIsAdmittedFromItsNetworksAndTheMesh); a mesh-only port on the same machine is not widened by the machine having a local network.
  • §6 (nothing resolved is closed and said): with no counted networks, the rule set says "wanted the local network, and this machine reported no private network," admits the port from the private network only, and never renders a bare "accept" (anywhere) (TestNoLocalNetworkIsSaidAndNotWidened). The same fail-safe holds at the controller level: judgedNetworks returns nil when the machine never reported (!had) or Machine is nil, which flows through to an empty CountedLocalNetworks, never a substitution of FromEverywhere.
  • §7 (companion, mesh-host): internal/inventory.AttachedNetwork and MadeOf.Networks read exactly what mesh-host #107 reports (TestAMachinesAttachedNetworksAreRead).
  • §8 (plan and node): plan prints LocalNetworkPort.Said() for every local-network port, naming the networks or "none" (TestTheLocalNetworkSitsBetweenTheMeshAndAnywhere's sibling tests, and cmd/mesh-controller/plan.go's declarationWith/planCommand changes); node's localNetworkLines shows every attached network with whether it counts and why, and separately distinguishes "not said — never reported" from "not said — older node-engine" from "none counts" (TestNodeShowsWhichAttachedNetworksCountAndWhy, TestNodeSaysWhenNoNetworkWasSaid).

Fails-safe for an older node-engine that reports no subnets: confirmed at both the inventory layer (TestAProfileWithoutTheFactsIsAnOlderNodeEngineNotNothing predates this PR and still holds: !had is distinct from "had, no networks") and in this PR's own TestNodeSaysWhenNoNetworkWasSaid, which asserts the older-node-engine case reads "older than the one that says it," not an empty/zero account. On an adopted node, catalogue.Openings widens FromLocalNetwork to OpeningFromMesh only, never OpeningFromEverywhere, so an adopted machine's own found firewall — not the mesh's opening — is what is trusted for the LAN part; this cannot drift to "anywhere" by this code path.

One gap, which is why this is request-changes rather than approve: the task (and ADR 0340 §2) asks that a public subnet never counts, "including IPv6 global addresses, CGNAT 100.64/10 and link-local, with a test for each." CGNAT (100.64.0.0/10) and link-local (fe80::/64, with its Why asserted) each have a dedicated, named case. There is no equivalent case for a genuine global-unicast IPv6 address (e.g. something in 2000::/3) asserting it is judged not-counted with a "public"-style Why, the way TestOnlyAPrivateNetworkOnALinkFacingOutsideCounts does for the IPv4 public /24. The only non-ULA, non-link-local IPv6 case exercised is the degenerate "::/0" in TestANetworkNotWhollyInAPrivateRangeDoesNotCount, which is a default-route mask, not a real address, and that test only asserts Counts is false, not why. I traced the code (judgeOne falls through to "public, never counted" for any address netip.Addr.IsPrivate reports false for IPv6, which a global unicast address is) and believe the behaviour is correct, but the mesh's own rule — a rule is checked, or it is indistinguishable from a wrong one — asks for the test to say so, not for me to trust the trace. Please add one case with a real global IPv6 network judged and its Why asserted to contain "public," alongside the existing CGNAT and link-local cases.

Everything else checked:

  • go vet ./... is clean.
  • go test ./... passes every package (store tests skipped for lack of MESH_TEST_POSTGRES, as the PR body says).
  • go test -race on the touched packages (internal/catalogue, internal/inventory, cmd/mesh-controller) passes.
  • ./merge-check.sh exits 0.
  • None of JudgeLocalNetworks, FromLocalNetwork or ReachLocalNetwork exist on main (internal/catalogue/localnetwork.go is absent there), so the new tests fail on main as claimed.
  • The checks on this head are currently out of date, not green: mesh/merge-gate and mesh/repo-check both read "out of date: judged against trunk 1826b68a22, the trunk is now 404b4409e70e; judged again on a recheck or when it is merged" as of this review. That is a queue-position fact, not a defect in the diff, but it means a fresh mesh-delivery.recheck is needed before this can be merged regardless of this review's verdict.

Note 9 on issue 154 (fix-154@g14's pause) lists what was left: reading the gate and repo-check on both heads, independent review, merge, delivery, live proof on ace. This review completes the independent-review step; the rest (recheck, merge, delivery, live proof) is still open and is not a gap in the code itself.

Verdict: request changes at 6e6cd5e26db6f8fe53f9ffb95d3c5a3a6c84f1b1 Every clause of ADR 0340 is built and, with one exception below, tested: - §1 (source): local-network is accepted by listens.from and expose; an unknown source ("lan") is still refused (TestAManifestMayListenFromTheLocalNetwork). - §2/§3 (judging): catalogue.JudgeLocalNetworks counts a network only when it lies wholly in a private range and is on a link reported as facing outside; the tunnel's own link and a container bridge never count regardless of address (TestOnlyAPrivateNetworkOnALinkFacingOutsideCounts); a network overlapping a private range without lying wholly inside it (10.0.0.0/7, 172.0.0.0/8) does not count either (TestANetworkNotWhollyInAPrivateRangeDoesNotCount). - §4 (reach): local-network is a fifth reach value, resolves to the internal name only (not the public one) and FromLocalNetwork (TestTheLocalNetworkReachIsInternalWithTheLocalNetworkAdded); widest() places it strictly between mesh and anywhere (TestTheLocalNetworkSitsBetweenTheMeshAndAnywhere). - §5 (filter per port): AsNftablesWithLocal renders the local-network rule on that port's rule alone, in both chains, admitting the mesh addresses plus the counted networks and never the public subnet (TestALocalNetworkPortIsAdmittedFromItsNetworksAndTheMesh); a mesh-only port on the same machine is not widened by the machine having a local network. - §6 (nothing resolved is closed and said): with no counted networks, the rule set says "wanted the local network, and this machine reported no private network," admits the port from the private network only, and never renders a bare "accept" (anywhere) (TestNoLocalNetworkIsSaidAndNotWidened). The same fail-safe holds at the controller level: judgedNetworks returns nil when the machine never reported (!had) or Machine is nil, which flows through to an empty CountedLocalNetworks, never a substitution of FromEverywhere. - §7 (companion, mesh-host): internal/inventory.AttachedNetwork and MadeOf.Networks read exactly what mesh-host #107 reports (TestAMachinesAttachedNetworksAreRead). - §8 (plan and node): plan prints LocalNetworkPort.Said() for every local-network port, naming the networks or "none" (TestTheLocalNetworkSitsBetweenTheMeshAndAnywhere's sibling tests, and cmd/mesh-controller/plan.go's declarationWith/planCommand changes); node's localNetworkLines shows every attached network with whether it counts and why, and separately distinguishes "not said — never reported" from "not said — older node-engine" from "none counts" (TestNodeShowsWhichAttachedNetworksCountAndWhy, TestNodeSaysWhenNoNetworkWasSaid). Fails-safe for an older node-engine that reports no subnets: confirmed at both the inventory layer (TestAProfileWithoutTheFactsIsAnOlderNodeEngineNotNothing predates this PR and still holds: !had is distinct from "had, no networks") and in this PR's own TestNodeSaysWhenNoNetworkWasSaid, which asserts the older-node-engine case reads "older than the one that says it," not an empty/zero account. On an adopted node, catalogue.Openings widens FromLocalNetwork to OpeningFromMesh only, never OpeningFromEverywhere, so an adopted machine's own found firewall — not the mesh's opening — is what is trusted for the LAN part; this cannot drift to "anywhere" by this code path. One gap, which is why this is request-changes rather than approve: the task (and ADR 0340 §2) asks that a public subnet never counts, "including IPv6 global addresses, CGNAT 100.64/10 and link-local, with a test for each." CGNAT (100.64.0.0/10) and link-local (fe80::/64, with its Why asserted) each have a dedicated, named case. There is no equivalent case for a genuine global-unicast IPv6 address (e.g. something in 2000::/3) asserting it is judged not-counted with a "public"-style Why, the way TestOnlyAPrivateNetworkOnALinkFacingOutsideCounts does for the IPv4 public /24. The only non-ULA, non-link-local IPv6 case exercised is the degenerate "::/0" in TestANetworkNotWhollyInAPrivateRangeDoesNotCount, which is a default-route mask, not a real address, and that test only asserts Counts is false, not why. I traced the code (judgeOne falls through to "public, never counted" for any address netip.Addr.IsPrivate reports false for IPv6, which a global unicast address is) and believe the behaviour is correct, but the mesh's own rule — a rule is checked, or it is indistinguishable from a wrong one — asks for the test to say so, not for me to trust the trace. Please add one case with a real global IPv6 network judged and its Why asserted to contain "public," alongside the existing CGNAT and link-local cases. Everything else checked: - `go vet ./...` is clean. - `go test ./...` passes every package (store tests skipped for lack of MESH_TEST_POSTGRES, as the PR body says). - `go test -race` on the touched packages (internal/catalogue, internal/inventory, cmd/mesh-controller) passes. - `./merge-check.sh` exits 0. - None of JudgeLocalNetworks, FromLocalNetwork or ReachLocalNetwork exist on main (internal/catalogue/localnetwork.go is absent there), so the new tests fail on main as claimed. - The checks on this head are currently out of date, not green: mesh/merge-gate and mesh/repo-check both read "out of date: judged against trunk 1826b68a22b5, the trunk is now 404b4409e70e; judged again on a recheck or when it is merged" as of this review. That is a queue-position fact, not a defect in the diff, but it means a fresh mesh-delivery.recheck is needed before this can be merged regardless of this review's verdict. Note 9 on issue 154 (fix-154@g14's pause) lists what was left: reading the gate and repo-check on both heads, independent review, merge, delivery, live proof on ace. This review completes the independent-review step; the rest (recheck, merge, delivery, live proof) is still open and is not a gap in the code itself.
jschoubben added 1 commit 2026-10-13 11:20:53 +00:00
Test that a global IPv6 subnet is public and never counts as the local network (issue 154, ADR 0340)
mesh/merge-gate head 4cc8588afb87 merged into trunk 0a1dc5f93fcb — pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every …
Details
mesh/repo-check head 4cc8588afb87 merged into trunk 0a1dc5f93fcb — pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
mesh/delivery-group group fix/154-local-network delivered: every member is delivered
Details
4cc8588afb 
The review asked for the IPv6 side of the rule that local-network cannot open a port to the internet.
mesh-admin commented 2026-10-13 11:27:00 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 4cc8588a
Judged: head 4cc8588afb87 merged into trunk 584aa2d7d7a5; read beside it: mesh-catalog 19ecad261cf2, mesh-controller-main 584aa2d7d7a5, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go

Run by the build seat on shanks as build-1791890473899922637 (builds --log build-1791890473899922637).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T11:13:29Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T11:13:29Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go and internal/inventory/machine_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.045s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	175.693s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.045s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.067s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.247s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.090s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.481s
ok  	github.com/novox/mesh-controller/internal/builder	41.608s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.569s
ok  	github.com/novox/mesh-controller/internal/conditions	2.686s
ok  	github.com/novox/mesh-controller/internal/envfile	1.058s
ok  	github.com/novox/mesh-controller/internal/facts	1.061s
ok  	github.com/novox/mesh-controller/internal/identity	4.971s
ok  	github.com/novox/mesh-controller/internal/inventory	35.584s
ok  	github.com/novox/mesh-controller/internal/lease	17.706s
ok  	github.com/novox/mesh-controller/internal/licences	4.226s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.056s
ok  	github.com/novox/mesh-controller/internal/link	59.118s
ok  	github.com/novox/mesh-controller/internal/lint	2.533s
ok  	github.com/novox/mesh-controller/internal/outward	1.096s
ok  	github.com/novox/mesh-controller/internal/overlay	1.075s
ok  	github.com/novox/mesh-controller/internal/secrets	1.538s
ok  	github.com/novox/mesh-controller/internal/store	3.546s
ok  	github.com/novox/mesh-controller/internal/testbus	1.242s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.22s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.23s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.22s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.21s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.20s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.17s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.97s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.25s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.13s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.25s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.25s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.21s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.21s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.27s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.21s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.25s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.21s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.21s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.21s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.21s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.23s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.30s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.29s)
  ./cmd/mesh-controller --- PASS: TestReplay201 (0.16s)
  ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.15s)
  ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.16s)
  ./cmd/mesh-controller --- PASS: TestReplay401 (0.28s)
  ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.23s)
  ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.29s)
  ./cmd/mesh-controller --- PASS: TestReplay340 (0.25s)
  ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.20s)
  ./cmd/mesh-controller --- PASS: TestReplay349 (0.21s)
  ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.18s)
  ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.15s)
  ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.08s)
  ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.48s)
  ./cmd/mesh-controller --- PASS: TestReplay164 (0.29s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.08s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.09s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.10s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.07s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.07s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s)
  ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s)
  ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.08s)
  ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.08s)
  ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.08s)
  ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.08s)
**Merge check** at `4cc8588a` Judged: head `4cc8588afb87` merged into trunk `584aa2d7d7a5`; read beside it: mesh-catalog `19ecad261cf2`, mesh-controller-main `584aa2d7d7a5`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go Run by the build seat on shanks as `build-1791890473899922637` (`builds --log build-1791890473899922637`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T11:13:29Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T11:13:29Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go and internal/inventory/machine_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.045s ok github.com/novox/mesh-controller/cmd/mesh-controller 175.693s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.045s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.067s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.026s ok github.com/novox/mesh-controller/examples/route-proxy 1.247s ok github.com/novox/mesh-controller/internal/artifacts 1.090s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.481s ok github.com/novox/mesh-controller/internal/builder 41.608s ok github.com/novox/mesh-controller/internal/catalogue 8.569s ok github.com/novox/mesh-controller/internal/conditions 2.686s ok github.com/novox/mesh-controller/internal/envfile 1.058s ok github.com/novox/mesh-controller/internal/facts 1.061s ok github.com/novox/mesh-controller/internal/identity 4.971s ok github.com/novox/mesh-controller/internal/inventory 35.584s ok github.com/novox/mesh-controller/internal/lease 17.706s ok github.com/novox/mesh-controller/internal/licences 4.226s ok github.com/novox/mesh-controller/internal/licences/adapters 1.056s ok github.com/novox/mesh-controller/internal/link 59.118s ok github.com/novox/mesh-controller/internal/lint 2.533s ok github.com/novox/mesh-controller/internal/outward 1.096s ok github.com/novox/mesh-controller/internal/overlay 1.075s ok github.com/novox/mesh-controller/internal/secrets 1.538s ok github.com/novox/mesh-controller/internal/store 3.546s ok github.com/novox/mesh-controller/internal/testbus 1.242s ok github.com/novox/mesh-controller/internal/token 1.016s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.22s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.23s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.22s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.21s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.20s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.17s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.97s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.25s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.13s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.25s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.25s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.21s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.21s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.27s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.21s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.25s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.21s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.21s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.21s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.21s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.23s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.30s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.29s) ./cmd/mesh-controller --- PASS: TestReplay201 (0.16s) ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.15s) ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.16s) ./cmd/mesh-controller --- PASS: TestReplay401 (0.28s) ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.23s) ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.29s) ./cmd/mesh-controller --- PASS: TestReplay340 (0.25s) ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.20s) ./cmd/mesh-controller --- PASS: TestReplay349 (0.21s) ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.18s) ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.15s) ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.19s) ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.08s) ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.48s) ./cmd/mesh-controller --- PASS: TestReplay164 (0.29s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.08s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.09s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.10s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.07s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.07s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.07s) ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s) ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.08s) ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.08s) ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.08s) ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.08s) ```
mesh-admin left a comment
Author
Contributor
Copy Link
Copy Source

Verdict: approve at 4cc8588afb

Independent review, issue 154, ADR 0340. The forge refuses a tool's APPROVED event (ADR 0266), so this verdict is posted as a comment review.

The code is approved. It must not be merged until mesh/merge-gate and mesh/repo-check are rechecked and green: both are pending at this head, marked out of date (judged against trunk 584aa2d7d7, trunk is now f3875a6b60).

What I checked against ADR 0340:

  • Clause 1 (source): manifest listens.from and expose accept local-network; any other unknown source is still refused (internal/catalogue/manifest.go:1895, filtering.go:155).
  • Clause 2 (private ranges only): judgeOne in internal/catalogue/localnetwork.go counts a network only when its masked prefix lies wholly in 10/8, 172.16/12, 192.168/16 or fc00::/7. A network that is public, link-local, loopback, unparseable, or only overlaps a private range (such as 10.0.0.0/7) is refused, and the reason is said. A 4-in-6 prefix falls through to "not wholly in a private range", so it is refused too.
  • Clause 3 (uplink only): the tunnel link and any link not in the machine's reported outward links are refused before the range test.
  • Clause 4 (reach): ReachLocalNetwork maps to FromLocalNetwork, takes the internal name only (WantsPublicName excludes it) and therefore the mesh's own authority. No other switch on reach values elsewhere misses it.
  • Clause 5 (per port): AsNftablesWithLocal renders the counted networks plus the mesh addresses on that port's own rule, in both the input chain and the forward chain. It never renders a machine-wide rule and never renders a bare dport accept.
  • Clause 6 (nothing resolved): with no counted network, the input chain says so in a comment and admits the port from the mesh only. It is not widened to anywhere.
  • Clause 8 (shown): plan prints LocalNetworkPort.Said() for each such port, and node prints every attached network with its verdict and the reason.
  • Wire format: MadeOf.Networks (networks, with link and network) matches mesh-host#107 at cb7b71dc (outward.Network, profile.Machine.Networks).

Modules that do not ask for local-network keep their behaviour. AsNftables wraps the new function with nil local networks. In widest, the order machine < mesh < anywhere is kept, with local-network inserted between mesh and anywhere. The guard still treats only FromMesh ports as mesh-only, which agrees with ADR 0340's consequence on ADR 0103. On an adopted node the opening is mesh-only, so the port is never widened to everywhere.

Tests, run in a clone at this head: nice -n 15 env GOFLAGS=-p=2 GOMAXPROCS=4 go test ./... passed in every package. go test -race on internal/catalogue, internal/inventory and cmd/mesh-controller passed. gofmt and go vet reported nothing on the touched packages. Store tests were skipped because MESH_TEST_POSTGRES was not set.

Non-blocking notes, for follow-up only:

  1. internal/catalogue/filtering.go, FromLocalNetwork case of the forward chain (about line 527): when no local network is counted, the forward chain writes no comment, while the input chain does. Clause 6 is met by the input chain and by plan; adding the comment would make the two chains consistent.
  2. The local-network saddr rules are not bound to the link the subnet was reported on (no iifname). If a machine has both a public and a private uplink, a spoofed private source arriving on the public link would match. TCP replies would route back to the LAN, so this matters mainly for UDP. The existing FromMesh rules work the same way, and ADR 0340 §5 does not ask for link binding. It is a possible hardening, not a deviation from the decision.
  3. The merge gate's snapshot carries no networks, so a gate composition renders a local-network port as "none reported". The PR description says so, and nothing in the catalogue uses local-network yet.
Verdict: approve at 4cc8588afb874c31fc549d19102aadcf0e42a658 Independent review, issue 154, ADR 0340. The forge refuses a tool's APPROVED event (ADR 0266), so this verdict is posted as a comment review. The code is approved. It must not be merged until mesh/merge-gate and mesh/repo-check are rechecked and green: both are pending at this head, marked out of date (judged against trunk 584aa2d7d7a5, trunk is now f3875a6b6019). What I checked against ADR 0340: - Clause 1 (source): manifest `listens.from` and `expose` accept `local-network`; any other unknown source is still refused (internal/catalogue/manifest.go:1895, filtering.go:155). - Clause 2 (private ranges only): judgeOne in internal/catalogue/localnetwork.go counts a network only when its masked prefix lies wholly in 10/8, 172.16/12, 192.168/16 or fc00::/7. A network that is public, link-local, loopback, unparseable, or only overlaps a private range (such as 10.0.0.0/7) is refused, and the reason is said. A 4-in-6 prefix falls through to "not wholly in a private range", so it is refused too. - Clause 3 (uplink only): the tunnel link and any link not in the machine's reported outward links are refused before the range test. - Clause 4 (reach): ReachLocalNetwork maps to FromLocalNetwork, takes the internal name only (WantsPublicName excludes it) and therefore the mesh's own authority. No other switch on reach values elsewhere misses it. - Clause 5 (per port): AsNftablesWithLocal renders the counted networks plus the mesh addresses on that port's own rule, in both the input chain and the forward chain. It never renders a machine-wide rule and never renders a bare dport accept. - Clause 6 (nothing resolved): with no counted network, the input chain says so in a comment and admits the port from the mesh only. It is not widened to anywhere. - Clause 8 (shown): plan prints LocalNetworkPort.Said() for each such port, and node prints every attached network with its verdict and the reason. - Wire format: MadeOf.Networks (`networks`, with `link` and `network`) matches mesh-host#107 at cb7b71dc (outward.Network, profile.Machine.Networks). Modules that do not ask for local-network keep their behaviour. AsNftables wraps the new function with nil local networks. In `widest`, the order machine < mesh < anywhere is kept, with local-network inserted between mesh and anywhere. The guard still treats only FromMesh ports as mesh-only, which agrees with ADR 0340's consequence on ADR 0103. On an adopted node the opening is mesh-only, so the port is never widened to everywhere. Tests, run in a clone at this head: `nice -n 15 env GOFLAGS=-p=2 GOMAXPROCS=4 go test ./...` passed in every package. `go test -race` on internal/catalogue, internal/inventory and cmd/mesh-controller passed. gofmt and go vet reported nothing on the touched packages. Store tests were skipped because MESH_TEST_POSTGRES was not set. Non-blocking notes, for follow-up only: 1. internal/catalogue/filtering.go, FromLocalNetwork case of the forward chain (about line 527): when no local network is counted, the forward chain writes no comment, while the input chain does. Clause 6 is met by the input chain and by plan; adding the comment would make the two chains consistent. 2. The local-network saddr rules are not bound to the link the subnet was reported on (no `iifname`). If a machine has both a public and a private uplink, a spoofed private source arriving on the public link would match. TCP replies would route back to the LAN, so this matters mainly for UDP. The existing FromMesh rules work the same way, and ADR 0340 §5 does not ask for link binding. It is a possible hardening, not a deviation from the decision. 3. The merge gate's snapshot carries no networks, so a gate composition renders a local-network port as "none reported". The PR description says so, and nothing in the catalogue uses local-network yet.
mesh-admin commented 2026-10-13 13:01:41 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 4cc8588a
Judged: head 4cc8588afb87 merged into trunk 0a1dc5f93fcb; read beside it: mesh-catalog 0d723484a84a, mesh-controller-main 0a1dc5f93fcb, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go

Run by the build seat on ace as build-1791896195781073605 (builds --log build-1791896195781073605).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T12:48:29Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T12:48:29Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.038s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	151.959s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.022s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.129s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.053s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.998s
ok  	github.com/novox/mesh-controller/internal/builder	34.112s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.768s
ok  	github.com/novox/mesh-controller/internal/conditions	2.591s
ok  	github.com/novox/mesh-controller/internal/envfile	1.061s
ok  	github.com/novox/mesh-controller/internal/facts	1.062s
ok  	github.com/novox/mesh-controller/internal/identity	4.468s
ok  	github.com/novox/mesh-controller/internal/inventory	30.930s
ok  	github.com/novox/mesh-controller/internal/lease	17.724s
ok  	github.com/novox/mesh-controller/internal/licences	3.597s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.059s
ok  	github.com/novox/mesh-controller/internal/link	57.673s
ok  	github.com/novox/mesh-controller/internal/lint	2.277s
ok  	github.com/novox/mesh-controller/internal/outward	1.056s
ok  	github.com/novox/mesh-controller/internal/overlay	1.051s
ok  	github.com/novox/mesh-controller/internal/secrets	1.404s
ok  	github.com/novox/mesh-controller/internal/store	3.332s
ok  	github.com/novox/mesh-controller/internal/testbus	1.212s
ok  	github.com/novox/mesh-controller/internal/token	1.018s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.20s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.21s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.19s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.19s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.18s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.15s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.95s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.22s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.13s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.23s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.23s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.19s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.19s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.24s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.19s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.22s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.19s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.19s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.18s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.28s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.21s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.26s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.26s)
  ./cmd/mesh-controller --- PASS: TestReplay201 (0.14s)
  ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.13s)
  ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.14s)
  ./cmd/mesh-controller --- PASS: TestReplay401 (0.26s)
  ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.22s)
  ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.27s)
  ./cmd/mesh-controller --- PASS: TestReplay340 (0.23s)
  ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay349 (0.19s)
  ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.17s)
  ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.14s)
  ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.17s)
  ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.07s)
  ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.43s)
  ./cmd/mesh-controller --- PASS: TestReplay164 (0.26s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.07s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.08s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.09s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.06s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.06s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.06s)
  ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s)
  ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.06s)
  ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.07s)
  ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.08s)
  ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.07s)
**Merge check** at `4cc8588a` Judged: head `4cc8588afb87` merged into trunk `0a1dc5f93fcb`; read beside it: mesh-catalog `0d723484a84a`, mesh-controller-main `0a1dc5f93fcb`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/local_network_test.go, internal/catalogue/localnetwork_test.go, internal/inventory/machine_test.go Run by the build seat on ace as `build-1791896195781073605` (`builds --log build-1791896195781073605`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T12:48:29Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T12:48:29Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.038s ok github.com/novox/mesh-controller/cmd/mesh-controller 151.959s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.014s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.022s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.014s ok github.com/novox/mesh-controller/examples/route-proxy 1.129s ok github.com/novox/mesh-controller/internal/artifacts 1.053s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.998s ok github.com/novox/mesh-controller/internal/builder 34.112s ok github.com/novox/mesh-controller/internal/catalogue 7.768s ok github.com/novox/mesh-controller/internal/conditions 2.591s ok github.com/novox/mesh-controller/internal/envfile 1.061s ok github.com/novox/mesh-controller/internal/facts 1.062s ok github.com/novox/mesh-controller/internal/identity 4.468s ok github.com/novox/mesh-controller/internal/inventory 30.930s ok github.com/novox/mesh-controller/internal/lease 17.724s ok github.com/novox/mesh-controller/internal/licences 3.597s ok github.com/novox/mesh-controller/internal/licences/adapters 1.059s ok github.com/novox/mesh-controller/internal/link 57.673s ok github.com/novox/mesh-controller/internal/lint 2.277s ok github.com/novox/mesh-controller/internal/outward 1.056s ok github.com/novox/mesh-controller/internal/overlay 1.051s ok github.com/novox/mesh-controller/internal/secrets 1.404s ok github.com/novox/mesh-controller/internal/store 3.332s ok github.com/novox/mesh-controller/internal/testbus 1.212s ok github.com/novox/mesh-controller/internal/token 1.018s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.20s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.21s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.19s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.19s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.18s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.15s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (1.95s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.22s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.13s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.23s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.23s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.19s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.19s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.24s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.19s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.22s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.19s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.19s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.18s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.28s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.21s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.26s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.26s) ./cmd/mesh-controller --- PASS: TestReplay201 (0.14s) ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.13s) ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.14s) ./cmd/mesh-controller --- PASS: TestReplay401 (0.26s) ./cmd/mesh-controller --- PASS: TestReplay201ThePlansSend (0.22s) ./cmd/mesh-controller --- PASS: TestPlanAndNodeListAnOptionalRequirementLeftUnbound (0.27s) ./cmd/mesh-controller --- PASS: TestReplay340 (0.23s) ./cmd/mesh-controller --- PASS: TestOnlyATrustedFilesNamedKeyIsRefusedThroughAVerb (0.19s) ./cmd/mesh-controller --- PASS: TestReplay349 (0.19s) ./cmd/mesh-controller --- PASS: TestReplay348AFaultFromBeforeTheSendFailsNoGate (0.17s) ./cmd/mesh-controller --- PASS: TestReplay239AModuleNameIsNotTakenOverByAnotherRepository (0.14s) ./cmd/mesh-controller --- PASS: TestAWalkThatMovedNothingSaysWhichModulesMatchedWhatRuns (0.17s) ./cmd/mesh-controller --- PASS: TestReplay614ANewSDKPlansTheToolchainAndThenItsBundles (0.07s) ./cmd/mesh-controller --- PASS: TestOneAcceptForAProviderIsPlacedForEveryConsumer (0.43s) ./cmd/mesh-controller --- PASS: TestReplay164 (0.26s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.07s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.08s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.09s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.08s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.06s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.06s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.06s) ./internal/inventory --- PASS: TestAWalksRestIsReadFromEachMachinesOwnSend (0.07s) ./internal/inventory --- PASS: TestAStoredBuildWithASilentMergeableFileIsStillReadAndComposed (0.06s) ./internal/inventory --- PASS: TestACredentialIssuedOutsideIsNeverMade (0.07s) ./internal/inventory --- PASS: TestOneAcceptForAProviderIsSealedToEveryConsumer (0.08s) ./internal/inventory --- PASS: TestASharedOwnSecretIssuedOutsideIsNeverMade (0.07s) ```
mesh-admin merged commit 6f1a05366c into main 2026-10-13 13:07:12 +00:00
mesh-admin deleted branch fix/154-local-network 2026-10-13 13:07:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mesh-admin
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#299