novox/mesh-controller
8
0
Fork 0
Code Issues Pull Requests 6 Releases Wiki Activity

The merge gate judges a moved module as a real build hands it its templates (issue 876) #353

Merged
mesh-tools merged 1 commits from fix/876-gate-judges-moved-modules into feat/57-config-and-provisioning 2026-10-16 08:14:05 +00:00
Conversation 2 Commits 1 Files Changed 3
+52 -5
mesh-tools commented 2026-10-16 08:08:21 +00:00
Member
Copy Link
Copy Source

Issue 876: the merge gate refused every moved module as "marked moved and names no template" (mesh-catalog #328, 29 problems), because it inlined the templates before its stand-in build, so Resolve never made the module's handed record and the strict re-read refused it.

Fix: the gate keeps the manifest as written, reads its templates from the tree, and its stand-in build carries their texts in the templates archive, as a real build does; Resolve then hands the module. The gate's earlier judging of the inlined manifest is unchanged.

Tests (unit, no database): TestReplay876 calls the gate (shelfWithChange) on a moved module and fails with the old call; a moved module naming no template is still refused. Packages run in 0.03 s.

Local head 0f3f3d18 (tree f97886c5). Review (Opus): round 1 APPROVE at c3afdf1a, round 2 on 0f3f3d18. Not a member of the 57-config-and-provisioning group (own branch name). Follow-up outside feature 57: issue 892 (module add).

Issue 876: the merge gate refused every moved module as "marked moved and names no template" (mesh-catalog #328, 29 problems), because it inlined the templates before its stand-in build, so Resolve never made the module's handed record and the strict re-read refused it. Fix: the gate keeps the manifest as written, reads its templates from the tree, and its stand-in build carries their texts in the templates archive, as a real build does; Resolve then hands the module. The gate's earlier judging of the inlined manifest is unchanged. Tests (unit, no database): TestReplay876 calls the gate (shelfWithChange) on a moved module and fails with the old call; a moved module naming no template is still refused. Packages run in 0.03 s. Local head 0f3f3d18 (tree f97886c5). Review (Opus): round 1 APPROVE at c3afdf1a, round 2 on 0f3f3d18. Not a member of the 57-config-and-provisioning group (own branch name). Follow-up outside feature 57: issue 892 (module add).
mesh-tools added 1 commit 2026-10-16 08:08:22 +00:00
Judge a moved module in the merge gate as a real build hands it its templates, so the gate no longer refuses every moved module (issue 876)
mesh/merge-gate head efc5f901afb7 merged into trunk cf897e89fe31 — pass: [release feat/57-config-and-provisioning, judged by its controller 93b947cc53b5] t…
Details
mesh/repo-check head efc5f901afb7 merged into trunk cf897e89fe31 — pass: [release feat/57-config-and-provisioning, judged by its controller 93b947cc53b5] i…
Details
mesh/delivery delivered
Details
efc5f901af
mesh-tools commented 2026-10-16 08:08:24 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-controller@efc5f901afb7 — delivered since 2026-10-16T08:14:09Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-16 08:08 (new) → proposed (announced): novox/mesh-controller#353's head announced
  • 2026-10-16 08:13 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-16 08:13 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-16 08:14 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-16 08:14 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@efc5f901afb7` — **delivered** since 2026-10-16T08:14:09Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-16 08:08 (new) → proposed (announced): novox/mesh-controller#353's head announced - 2026-10-16 08:13 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 08:13 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 08:14 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 08:14 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-tools added the mesh/ready label 2026-10-16 08:08:53 +00:00
mesh-tools commented 2026-10-16 08:08:58 +00:00
Author
Member
Copy Link
Copy Source

ready at efc5f901af

Review (Opus): round 1 APPROVE (c3afdf1a), round 2 APPROVE (0f3f3d18, tree f97886c5 = this head's tree).

ready at efc5f901afb7d35ca678ee3f2cf331362ac4d94b Review (Opus): round 1 APPROVE (c3afdf1a), round 2 APPROVE (0f3f3d18, tree f97886c5 = this head's tree).
mesh-tools merged commit 6a6628a769 into feat/57-config-and-provisioning 2026-10-16 08:14:05 +00:00
mesh-tools deleted branch fix/876-gate-judges-moved-modules 2026-10-16 08:14:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels mesh/ready
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben mesh-tools miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#353