Every machine was named twice over; only a machine on the private network is named (issue 079) #41

Merged
jschoubben merged 4 commits from multiple-fixes into main 2026-09-22 00:19:14 +00:00
Owner
  • The hosts-file and resolver-zones facts appended .internal to names the control plane had already suffixed, writing anchor.internal.internal on every machine. The facts now take the suffix the control plane composed the names with (Rendering.Suffix, from overlay.Suffix()), so it is written once, whatever the operator chose. The test fixture is keyed as production keys it; a test holds both keyings to the same files and an operator's own suffix to itself.
  • The names follow the resolver's rule for "on the private network": a machine that is placed but does not run the module that puts it there is not named (a name resolving to an address that does not answer hangs). One predicate, onTheNetwork, for both; a controller test unassigns one machine's networking and reads the names back.

Found by running the large mesh bed end to end. go test ./... with the test store passes. Proof: mesh.test.ts 21/21 with the controller image rebuilt from 6a64aba. Companion MRs on multiple-fixes: mesh-catalog, mesh-lab, hq.

- The hosts-file and resolver-zones facts appended `.internal` to names the control plane had already suffixed, writing `anchor.internal.internal` on every machine. The facts now take the suffix the control plane composed the names with (`Rendering.Suffix`, from `overlay.Suffix()`), so it is written once, whatever the operator chose. The test fixture is keyed as production keys it; a test holds both keyings to the same files and an operator's own suffix to itself. - The names follow the resolver's rule for "on the private network": a machine that is placed but does not run the module that puts it there is not named (a name resolving to an address that does not answer hangs). One predicate, `onTheNetwork`, for both; a controller test unassigns one machine's networking and reads the names back. Found by running the large mesh bed end to end. `go test ./...` with the test store passes. Proof: mesh.test.ts 21/21 with the controller image rebuilt from 6a64aba. Companion MRs on `multiple-fixes`: mesh-catalog, mesh-lab, hq.
jschoubben added 3 commits 2026-09-21 23:55:40 +00:00
jschoubben added 1 commit 2026-09-22 00:04:30 +00:00
jschoubben merged commit ff26ea959d into main 2026-09-22 00:19:14 +00:00
jschoubben deleted branch multiple-fixes 2026-09-22 00:19:14 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#41