Register every done key once at the start, and write a node's own composition last (issue 1945) #459

Merged
mesh-tools merged 2 commits from fix/r6-fp2-seen into main 2026-10-25 04:21:28 +00:00
Member

The controller registered a module's finished build only from an updates-only watch, so builds whose done keys were written or interrupted across the controller's restart at 02:34 were never registered: no new-form fingerprint, no credential, and the assigner held their wants (rule 6), the refilling provisioner client's among them (issue 1945 note 17). Now every catalogued module's done key is taken in once at the start, after the watch is open (e67916bb). And writeNodeCompositions writes module compositions first and the node's own last, skipping the node's own when any module composition of the pass failed, so a node's own composition never strips a module whose own composition isn't written (eafd1883).

MERGE ONLY AFTER mesh-host #136 runs on all four nodes: registering the lost builds moves modules out of each node's own composition.

Tries: try-1792889850154893642 passed on eafd1883.
Reviewed-by: reviewer-r6m@shanks at eafd1883f6
Pushed-by: lead-47@shanks

The controller registered a module's finished build only from an updates-only watch, so builds whose done keys were written or interrupted across the controller's restart at 02:34 were never registered: no new-form fingerprint, no credential, and the assigner held their wants (rule 6), the refilling provisioner client's among them (issue 1945 note 17). Now every catalogued module's done key is taken in once at the start, after the watch is open (e67916bb). And writeNodeCompositions writes module compositions first and the node's own last, skipping the node's own when any module composition of the pass failed, so a node's own composition never strips a module whose own composition isn't written (eafd1883). MERGE ONLY AFTER mesh-host #136 runs on all four nodes: registering the lost builds moves modules out of each node's own composition. Tries: try-1792889850154893642 passed on eafd1883. Reviewed-by: reviewer-r6m@shanks at eafd1883f65ca8c099d1ceac3f96148f5d5b4798 Pushed-by: lead-47@shanks
mesh-tools added 2 commits 2026-10-25 01:05:24 +00:00
Write a node's own composition last, and not in a pass where a module's composition failed (issue 1945)
mesh/delivery merged: source.main moved to novox/mesh-controller@0fff3efd4e0b
mesh/check pass eafd1883f65c on 0fff3efd4e0b | unit 953 run, 171 kept, 2 skipped | integration 1612 run, 232 kept, 7 skipped | over bound: integration…
eafd1883f6
Author
Member

Delivery novox/mesh-controller@eafd1883f65c — merged since 2026-10-25T04:21:30Z

Source — source.main moved to novox/mesh-controller@0fff3efd4e. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-25 01:05 (new) → proposed (announced): novox/mesh-controller#459's head announced
  • 2026-10-25 01:12 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail
  • 2026-10-25 04:21 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@eafd1883f65c` — **merged** since 2026-10-25T04:21:30Z **Source** — source.main moved to novox/mesh-controller@0fff3efd4e0b. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-25 01:05 (new) → proposed (announced): novox/mesh-controller#459's head announced - 2026-10-25 01:12 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail - 2026-10-25 04:21 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 0fff3efd4e into main 2026-10-25 04:21:28 +00:00
mesh-tools deleted branch fix/r6-fp2-seen 2026-10-25 04:21:28 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#459