Kept compositions follow config changes from a durable consumer, so going back to an earlier build keeps today's config (issue 1945, ADR 0545) #466

Merged

jschoubben merged 7 commits from fix/1945-kept-compositions-follow-config into main 2026-10-25 18:37:58 +00:00

Conversation 1 Commits 7 Files Changed 7

+472 -48

7 Commits

Author	SHA1	Message	Date
jschoubben	ff3cc47027	Let the kept compositions' pass end at the stop (issue 1945, ADR 0545, review 3) ... followKept went on composing every kept key, and the config consumer every touched node, after the controller was told to stop. Both now check the stop before each key and each node; the writes of an unfinished batch are refused at once, so the next controller takes them. Research 072: milestone 2, the composer reacting to the change of an input.	2026-10-25 18:43:38 +01:00
jschoubben	31a2bcdb3c	Read each resolved config key once when the consumer is made, so values set before this release reach the kept compositions (issue 1945, ADR 0545, review 3) ... The config consumer delivered new writes only, and mesh-config never writes an unchanged value again: g14's mesh-build-go capacity of 2, set before this release, would never reach its kept compositions carrying 0. A newly made durable now reads each key's last value once, through the same gather, per-write lock and acknowledgement; its deliver policy is set before its first delivery. Acknowledgements are synchronous and sent past the stop, and one the bus refuses is said by its key. Research 072: milestone 2, the composer reacting to the change of an input.	2026-10-25 18:38:45 +01:00
jschoubben	2df47d7b1c	Merge branch 'fix/1945-take-in-consumer' into fix/1945-kept-compositions-follow-config	2026-10-25 18:30:53 +01:00
jschoubben	e40b1e70db	Follow config from a durable consumer, compose again only what changed since, and hold the node only for a write (issue 1945, ADR 0545, review) ... The start composed every kept composition of every module on every node, each a whole node composed in memory under the node's lock: 10 to 50 minutes at a start, holding take-ins back. Now the writes of mesh-config_resolved are read from the durable consumer mesh-controller-config-follow, acknowledged once the change is composed, so a restart composes again only what was written since the last change handled, and a first start nothing it did not hear. The node's lock is taken for each write alone. A consumer that cannot be made or read raises config-not-followed and is tried again a minute later, cleared once it reads. The controller's account is granted that consumer's acknowledgements where mesh-config serves, as its verb is. Research 072: milestone 2, the composer reacting to the change of an input.	2026-10-25 18:27:43 +01:00
jschoubben	6b116586fc	Merge branch 'fix/1945-take-in-consumer' into fix/1945-kept-compositions-follow-config	2026-10-25 18:21:58 +01:00
jschoubben	81e335e42d	Say why a node with no compositions answers none to compose again (ADR 0545, the empty-on-error rule)	2026-10-25 18:15:22 +01:00
jschoubben	2407bfb9ff	Compose kept compositions again when a module's config changes (issue 1945, ADR 0545) ... The controller composed a module only at the fingerprint it is registered at, so each of the up to five compositions kept for going back carried the config of the moment it was made: a want back to an earlier mesh-build-go on g14 put its capacity back to 0. Nothing composed a node when mesh-config's resolved values changed, either. Now a write of mesh-config_resolved (<node>.<module>.<key>), heard from that bucket's watch and gathered for a second, drops the controller's 5 s reading of the values, composes the node, and composes every kept fingerprint of the touched modules on that node again from its own build's manifest with today's inputs, writing only the compositions whose digest differs. A starting controller does it once for every node, for a change no controller heard. The two replaced-controller tests are one table test with the kept cases. Research 072: milestone 2, the composer reacting to the change of an input.	2026-10-25 18:14:03 +01:00