Two tests that main broke: bus users after issue 195, and the event consumer made from now (issue 248) #52

2026-10-05T16:07:01Z

mesh-admin commented

2026-10-05 16:07:01 +00:00

Both changes were mine and their own runs missed these, because the tests skip without a store:

TestAnAssignedModuleBecomesAUserWithWhatItDeclared (postgres) still expected a module with no broker secret to be a bus user; since #270 (issue 195) it is not. The test module now declares one, and a second module without one is asserted to be no user.
TestNatsTheEventsTheControllerFollowsArriveAndAreAcknowledged (NATS) published right after starting the controller; since #51 (issue 248) its event consumer is made from now and does not replay what came before it. The test now waits for the consumer.

Full suite with a fresh postgres and a fresh NATS: all packages pass. (Other internal/link NATS failures seen on the long-lived shared test server are leftovers there; on a fresh server they pass.)

Both changes were mine and their own runs missed these, because the tests skip without a store: - `TestAnAssignedModuleBecomesAUserWithWhatItDeclared` (postgres) still expected a module with no `broker` secret to be a bus user; since #270 (issue 195) it is not. The test module now declares one, and a second module without one is asserted to be no user. - `TestNatsTheEventsTheControllerFollowsArriveAndAreAcknowledged` (NATS) published right after starting the controller; since #51 (issue 248) its event consumer is made from now and does not replay what came before it. The test now waits for the consumer. Full suite with a fresh postgres and a fresh NATS: all packages pass. (Other `internal/link` NATS failures seen on the long-lived shared test server are leftovers there; on a fresh server they pass.)

mesh-admin added 2 commits 2026-10-05 16:07:01 +00:00

Test the bus users as issue 195 made them: an account-reading module is one, another is not 625d02862c

The postgres-backed test still expected a module that declares no broker
secret to be a bus user, and failed on main since #270; it skips without a
database, so the change's own run did not see it.

Publish the followed events once the controller's consumer exists 0b07e68cb8

Made from now since issue 248, the consumer does not replay what was
published before it; the test raced the controller's start and published
first.

mesh-admin merged commit bb3cd6437b into main

2026-10-05 16:10:01 +00:00

mesh-admin deleted branch fix/the-bus-user-test-follows-issue-195

2026-10-05 16:10:02 +00:00

mesh-admin commented

2026-10-06 23:10:12 +00:00

Delivery novox/mesh-controller@bb3cd6437b19 — held since 2026-10-06T23:05:28Z

Held for a person: merged without a passing check: only a person decides that it goes on — mesh-delivery.release with why lets it go on.

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

tier 0: mesh-controller
tier 1: build-agent
tier 2: route-proxy
ace: receives build-agent, route-proxy
g14: receives build-agent
novox: receives mesh-controller, build-agent, route-proxy
shanks: receives build-agent
build-agent keeps data (ADR 0233): what it holds is backed up before it moves
route-proxy provides route: its consumers are sent again after it
route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Transitions

2026-10-06 23:05 (new) → proposed (announced): novox/mesh-controller#52 merged; its head was not heard by this owner, so it is made from the forge's word
2026-10-06 23:05 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

**Delivery** `novox/mesh-controller@bb3cd6437b19` — **held** since 2026-10-06T23:05:28Z Held for a person: merged without a passing check: only a person decides that it goes on — `mesh-delivery.release` with why lets it go on. **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Transitions** - 2026-10-06 23:05 (new) → proposed (announced): novox/mesh-controller#52 merged; its head was not heard by this owner, so it is made from the forge's word - 2026-10-06 23:05 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin referenced this pull request

2026-10-08 08:45:35 +00:00

Resolve a group's order rules by precedence, not as a cycle (hq issue 309) #134

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#52