novox/mesh-controller
Archived
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Keep the account of the sent declaration over an older one (hq issue 267) #74

Merged
mesh-admin merged 1 commits from fix/stale-report-overwrites into main 2026-10-05 23:47:10 +00:00
Conversation 1 Commits 1 Files Changed 3
+85 -2
mesh-admin commented 2026-10-05 23:46:46 +00:00
Contributor
Copy Link
Copy Source

node_report is one row per node, last write wins, and it decides whether a release plan moves on. A report carrying machine facts (outward links, held, firewall...) skips the design-25 staleness check in reported, so a reconcile report about an older declaration that arrived after the newer apply's report replaced it.

Enrolment.Heard now records the machine-facts half of any report as before, but when the report names a declaration other than node.sent it does not replace the stored account (RecordDoing) or owned list; it logs that it kept the facts and not the account. DoingOf now returns Declared.

Tests (need MESH_TEST_POSTGRES / make check): TestAnAccountOfAnOlderDeclarationDoesNotReplaceTheNewer (fails without the fix), TestAnAccountOfTheSentDeclarationReplacesTheKeptOne. gofmt, go vet, go test -p 1 ./... with postgres clean.

Pairs with novox/mesh-host (same branch name); hq issue 267.

`node_report` is one row per node, last write wins, and it decides whether a release plan moves on. A report carrying machine facts (outward links, held, firewall...) skips the design-25 staleness check in `reported`, so a reconcile report about an older declaration that arrived after the newer apply's report replaced it. `Enrolment.Heard` now records the machine-facts half of any report as before, but when the report names a declaration other than `node.sent` it does not replace the stored account (`RecordDoing`) or owned list; it logs that it kept the facts and not the account. `DoingOf` now returns `Declared`. Tests (need MESH_TEST_POSTGRES / `make check`): `TestAnAccountOfAnOlderDeclarationDoesNotReplaceTheNewer` (fails without the fix), `TestAnAccountOfTheSentDeclarationReplacesTheKeptOne`. gofmt, go vet, go test -p 1 ./... with postgres clean. Pairs with novox/mesh-host (same branch name); hq issue 267.
mesh-admin added 1 commit 2026-10-05 23:46:46 +00:00
Keep the account of the sent declaration over an older one (hq issue 267) 09c0c6b367 
The last report stored per node decides whether a release plan moves on,
and it was whichever arrived last. A report about a declaration the mesh
has moved past now records what it says about the machine but leaves the
account of the apply alone, so arrival order cannot undo the newer.
mesh-admin merged commit e096b4595a into main 2026-10-05 23:47:10 +00:00
mesh-admin deleted branch fix/stale-report-overwrites 2026-10-05 23:47:10 +00:00
mesh-admin commented 2026-10-06 23:10:25 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-controller@e096b4595a23 — held since 2026-10-06T23:05:28Z

Held for a person: merged without a passing check: only a person decides that it goes on — mesh-delivery.release with why lets it go on.

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Transitions

  • 2026-10-06 23:05 (new) → proposed (announced): novox/mesh-controller#74 merged; its head was not heard by this owner, so it is made from the forge's word
  • 2026-10-06 23:05 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@e096b4595a23` — **held** since 2026-10-06T23:05:28Z Held for a person: merged without a passing check: only a person decides that it goes on — `mesh-delivery.release` with why lets it go on. **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Transitions** - 2026-10-06 23:05 (new) → proposed (announced): novox/mesh-controller#74 merged; its head was not heard by this owner, so it is made from the forge's word - 2026-10-06 23:05 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#74