jochen
2eb9a22c24
Two controllers could both act (issue 204), a reconcile's report could overtake the apply after it and the digest decided (issue 267), and a grant could make a second writer of a machine's report. - The lease (internal/lease, ADR 0229): mesh-controller_lease key `holder`, 15 s age, renewed every 5 s by compare-and-set; the epoch is the revision it was taken at. The gate is the clock (stops 3 s before expiry); a refused renewal is a loss and the process exits; a holder that stops gives it back. serve takes it before asserting the bus. Epochs kept in the store (migration 0068 controller_epoch) as a floor: a bucket raised from nothing is compacted past it. Unleased (no epoch, S12 urgent) only when nobody holds it and the bus will not let it be written. A shell command acts under the holder's epoch, or its own lease when none. - Declarations carry `epoch` inside the signed envelope, only to a machine whose latest account carried a report_sequence (mesh-host #35); would-send is composed with the epoch last sent. Allot and the send both pass the gate. - Reports: contract in internal/link/order.go (epoch, sequence, report_sequence, older_than, refused_older). Accounts kept by epoch, then sequence, then report sequence; older refused, counted; unordered reports keep the digest rule. Plans by compare-and-set on a revision, with epoch. Conditions and calls carry the epoch and are not written off the lease. - S12 and S13 (naming the writer by epoch) watched, D5 run; reset of the bucket said. Writers table compiled in and enforced in PermissionsFor; the controller no longer publishes mesh.control.>. A contract per consumed kind, and the empty-on-error lint over the repository. - mesh-host pinned to its main with the epoch in the validator (D1 validates the envelope as sent). Needs mesh-host's genesis lock with the lease grant (mesh-host PR) for TestTheInstallersFirstUserListIsWhatTheControllerWouldCompose.
76 lines
2.9 KiB
Go
76 lines
2.9 KiB
Go
package inventory
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// A plan is a record the mesh keeps and resumes (novox/hq ADR 0162): written whole, read back open,
|
|
// advanced, and gone from the open ones when done.
|
|
func TestAPlanIsKeptAdvancedAndResumedFromTheStore(t *testing.T) {
|
|
inv := ForTest(t)
|
|
ctx := t.Context()
|
|
p := Plan{ID: "plan-1", Repository: "novox/mesh-tools", Commit: "abc", Created: time.Now().UTC(),
|
|
State: PlanBuilding, Tiers: [][]string{{"mesh-tools"}, {"builder"}, {"shop"}},
|
|
Modules: map[string]*PlanModule{"mesh-tools": {}, "builder": {}, "shop": {}}}
|
|
if err := inv.SavePlan(ctx, &p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
open, err := inv.OpenPlans(ctx)
|
|
if err != nil || len(open) != 1 || open[0].ID != "plan-1" || len(open[0].Tiers) != 3 {
|
|
t.Fatalf("the plan was not kept whole: %v %+v", err, open)
|
|
}
|
|
// Another controller picks it up where it was left: a tier advanced and a module built.
|
|
now := time.Now().UTC()
|
|
resumed := open[0]
|
|
resumed.Tier = 1
|
|
resumed.Modules["mesh-tools"].State = "built"
|
|
resumed.Modules["mesh-tools"].BuiltAt = &now
|
|
resumed.State = PlanRolling
|
|
resumed.Note = "tier 0 built; waiting for builder on anchor to be applied"
|
|
if err := inv.SavePlan(ctx, &resumed); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
again, err := inv.PlanByID(ctx, "plan-1")
|
|
if err != nil || again.Tier != 1 || again.Modules["mesh-tools"].State != "built" || again.State != PlanRolling {
|
|
t.Fatalf("the advanced plan did not come back as left: %v %+v", err, again)
|
|
}
|
|
again.State = PlanDone
|
|
if err := inv.SavePlan(ctx, &again); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if open, _ = inv.OpenPlans(ctx); len(open) != 0 {
|
|
t.Fatalf("a done plan is not open: %+v", open)
|
|
}
|
|
if recent, _ := inv.RecentPlans(ctx, 5); len(recent) != 1 || recent[0].State != PlanDone {
|
|
t.Fatalf("a done plan is still among the recent ones: %+v", recent)
|
|
}
|
|
}
|
|
|
|
// novox/hq issue 254: a plan keeps the branch its merge went into, and a superseded plan is not open.
|
|
func TestASupersededPlanIsNotOpen(t *testing.T) {
|
|
inv := ForTest(t)
|
|
ctx := t.Context()
|
|
p := Plan{ID: "plan-1", Repository: "novox/mesh-catalog", Branch: "main", Commit: "abc",
|
|
Created: time.Now().UTC(), State: PlanBuilding, Tiers: [][]string{{"gitea"}},
|
|
Modules: map[string]*PlanModule{"gitea": {}}}
|
|
if err := inv.SavePlan(ctx, &p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
kept, err := inv.PlanByID(ctx, "plan-1")
|
|
if err != nil || kept.Branch != "main" {
|
|
t.Fatalf("the branch was not kept: %v %+v", err, kept)
|
|
}
|
|
kept.State = PlanSuperseded
|
|
kept.Note = "superseded at tier 0 by plan-2"
|
|
if err := inv.SavePlan(ctx, &kept); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if open, err := inv.OpenPlans(ctx); err != nil || len(open) != 0 {
|
|
t.Fatalf("a superseded plan is still open: %v %+v", err, open)
|
|
}
|
|
if recent, _ := inv.RecentPlans(ctx, 5); len(recent) != 1 || recent[0].State != PlanSuperseded {
|
|
t.Fatalf("a superseded plan is not among the recent ones as superseded: %+v", recent)
|
|
}
|
|
}
|