jochen
e11caecdad
The controller's machine moves it from the container to a process by starting the process first and removing the container once the process is up (mesh-host's `replaces`). For that moment two controllers share the store and the bus. Checked what each does: - the seat's verbs: a queue group per seat, each call answered once. Safe. - the controller's consumers on CONTROL and EVENTS: push consumers with no delivery group, so the second bind is refused with "consumer is already bound" and serve exited. The process would restart for ever, the host would never see it up, and the container would never go. The second controller now stands by and binds when the first lets go (tested on a real bus; fails without the change). - plans: read, changed and saved whole by the 30s timer, by build outcomes, by a merge and by `plans stop`. Two timers would each ask a tier the other had just asked. Working the plans now takes a session-level advisory lock on the inventory: the timer skips while another holds it, the other paths wait for it. Build asks happen only inside plan work and are covered by the same lock.
39 lines
1.2 KiB
Go
39 lines
1.2 KiB
Go
package inventory
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// novox/hq issue 213: while a machine hands its controller over from the container to the process,
|
|
// two controllers run on one store for a moment. Working the plans is one act at a time across them.
|
|
func TestThePlansAreWorkedByOneControllerAtATime(t *testing.T) {
|
|
first := ForTest(t)
|
|
// A second controller: its own connections to the same store.
|
|
second, err := Open(t.Context())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(second.Close)
|
|
|
|
release, err := first.HoldPlans(t.Context(), false)
|
|
if err != nil {
|
|
t.Fatalf("the plans could not be held when nobody held them: %v", err)
|
|
}
|
|
t.Cleanup(release) // a pool closing waits for a connection still held; release is idempotent
|
|
if _, err := second.HoldPlans(t.Context(), false); !errors.Is(err, ErrPlansBusy) {
|
|
t.Fatalf("a second controller held the plans while the first did: %v", err)
|
|
}
|
|
// A waiter gets them once they are let go.
|
|
was := HoldPoll
|
|
HoldPoll = 10 * time.Millisecond
|
|
defer func() { HoldPoll = was }()
|
|
go func() { time.Sleep(50 * time.Millisecond); release() }()
|
|
again, err := second.HoldPlans(t.Context(), true)
|
|
if err != nil {
|
|
t.Fatalf("a waiting controller never got the plans once they were let go: %v", err)
|
|
}
|
|
again()
|
|
}
|