mesh-controller/internal/builder/bundle_integration_test.go

//go:build integration

package builder

import (
	"context"
	"strings"
	"testing"
)

func TestABundleIsCompiledAndPackedWithNoDockerfile(t *testing.T) {
	r, workspace := aRepository(t, aBundle, map[string]string{"index.ts": "console.log(1)"})
	held := map[string]string{"mesh-tools/build": "registry.invalid/mesh-tools/build@sha256:" + strings.Repeat("b", 64)}

	got, err := Build(context.Background(), compiling{r}.run, r,
		"https://forge.invalid/greeter.git", "", "", workspace, held, Npmrc{}, GitCredential{}, nil)
	if err != nil {
		t.Fatalf("a module with a language and no Dockerfile did not build: %v", err)
	}

	// Compiled in the toolchain the mesh chose, not in one the module named.
	var compiled string
	for _, line := range r.ran {
		if strings.HasPrefix(line, "docker run") {
			compiled = line
		}
	}
	if compiled == "" {
		t.Fatalf("nothing was compiled:\n%s", strings.Join(r.ran, "\n"))
	}
	if !strings.Contains(compiled, "mesh-tools/build@sha256:") {
		t.Fatalf("the compile did not run in the mesh's own toolchain: %s", compiled)
	}
	if strings.Contains(strings.Join(r.ran, "\n"), "docker build") {
		t.Fatalf("a bundle invoked a Dockerfile build, which is the thing it exists to avoid:\n%s",
			strings.Join(r.ran, "\n"))
	}

	// And pinned by a digest of what came out, like any other artifact.
	digest, _ := got.Manifest.Resources[0]["digest"].(string)
	if !strings.HasPrefix(digest, "sha256:") {
		t.Fatalf("the bundle was not pinned: %v", got.Manifest.Resources[0])
	}

	// **One file per entrypoint and launcher, in the toolchain's bundler** (novox/hq ADR 0193). A
	// second run in the same toolchain image bundles each into the artifact's bundled output, the SDK
	// inlined, refusing by name in an image that predates the bundler; and the toolchain's
	// node_modules is no longer copied into a bundle that keeps nothing external.
	var bundling []string
	for _, line := range r.ran {
		if strings.HasPrefix(line, "docker run") && strings.Contains(line, "esbuild") {
			bundling = append(bundling, line)
		}
	}
	if len(bundling) != 2 {
		t.Fatalf("want one bundling run for the entrypoints and one for the launchers:\n%s", strings.Join(r.ran, "\n"))
	}
	for _, want := range []string{"mesh-tools/build@sha256:", "predates one-file bundles", "--bundle", "--format=esm",
		"--platform=node", "--outdir=" + Out("code") + ".bundled", Out("code") + "/index.js"} {
		if !strings.Contains(bundling[0], want) {
			t.Errorf("the entrypoints' bundling lacks %q: %s", want, bundling[0])
		}
	}
	if !strings.Contains(bundling[1], Out("code")+"/index.serve.mjs") || !strings.Contains(bundling[1], "--out-extension:.js=.mjs") {
		t.Errorf("the launcher is not bundled under its own name: %s", bundling[1])
	}
	if strings.Contains(strings.Join(r.ran, "\n"), "/app/runtime") {
		t.Errorf("the toolchain's node_modules was copied into a bundle that keeps nothing external:\n%s", strings.Join(r.ran, "\n"))
	}
	if strings.Index(strings.Join(r.ran, "\n"), "--outDir") > strings.Index(strings.Join(r.ran, "\n"), "esbuild") {
		t.Fatal("the bundler ran before the compile wrote its output")
	}
}

func TestABundleKeepingAPackageExternalCarriesTheToolchainsModules(t *testing.T) {
	manifest := strings.Replace(aBundle, `"entrypoints":["index.js"]`, `"entrypoints":["index.js"],"external":["sharp"]`, 1)
	r, workspace := aRepository(t, manifest, map[string]string{"index.ts": "console.log(1)"})
	held := map[string]string{"mesh-tools/build": "registry.invalid/mesh-tools/build@sha256:" + strings.Repeat("b", 64)}
	if _, err := Build(context.Background(), compiling{r}.run, r,
		"https://forge.invalid/greeter.git", "", "", workspace, held, Npmrc{}, GitCredential{}, nil); err != nil {
		t.Fatal(err)
	}
	all := strings.Join(r.ran, "\n")
	if !strings.Contains(all, "--external:sharp") || !strings.Contains(all, "/app/runtime") {
		t.Errorf("an external package was not kept as an import with the toolchain's modules beside it:\n%s", all)
	}
}

func TestABundleWhoseToolchainIsNotHeldIsRefusedFirst(t *testing.T) {
	r, workspace := aRepository(t, aBundle, map[string]string{"index.ts": "console.log(1)"})

	_, err := Build(context.Background(), compiling{r}.run, r,
		"https://forge.invalid/greeter.git", "", "", workspace, nil, Npmrc{}, GitCredential{}, nil)
	if err == nil {
		t.Fatal("a bundle was built with no toolchain to compile it in")
	}
	if !strings.Contains(err.Error(), "mesh-tools") {
		t.Fatalf("the refusal does not name what has to be built first: %v", err)
	}
	for _, line := range r.ran {
		if strings.HasPrefix(line, "docker run") {
			t.Fatalf("a compile was attempted before the refusal: %s", line)
		}
	}
}

func TestABundleInAnUnknownLanguageIsRefused(t *testing.T) {
	manifest := strings.Replace(aBundle, `"language":"typescript"`, `"language":"cobol"`, 1)
	r, workspace := aRepository(t, manifest, map[string]string{"index.ts": "x"})

	_, err := Build(context.Background(), compiling{r}.run, r,
		"https://forge.invalid/greeter.git", "", "", workspace,
		map[string]string{"mesh-tools/build": "registry.invalid/x@sha256:" + strings.Repeat("c", 64)}, Npmrc{}, GitCredential{}, nil)
	if err == nil {
		t.Fatal("a language nothing can compile was accepted")
	}
	if !strings.Contains(err.Error(), "typescript") {
		t.Fatalf("the refusal does not say what would have worked: %v", err)
	}
}

func TestTwoBundlesInOneModuleArePackedSeparately(t *testing.T) {
	const two = `{"module":"greeter","version":"1",
	  "build":{"artifacts":[
	    {"name":"daemon","kind":"bundle","language":"typescript","entrypoints":["index.js"]},
	    {"name":"tools","kind":"bundle","language":"typescript","entrypoints":["index.js"]}]},
	  "resources":[
	    {"id":"a","type":"archive","path":"/opt/greeter/daemon","artifact":"daemon"},
	    {"id":"b","type":"archive","path":"/opt/greeter/tools","artifact":"tools"}]}`

	r, workspace := aRepository(t, two, map[string]string{"index.ts": "console.log(1)"})
	held := map[string]string{"mesh-tools/build": "registry.invalid/mesh-tools/build@sha256:" + strings.Repeat("b", 64)}

	got, err := Build(context.Background(), compiling{r}.run, r,
		"https://forge.invalid/greeter.git", "", "", workspace, held, Npmrc{}, GitCredential{}, nil)
	if err != nil {
		t.Fatalf("a module with two bundles did not build: %v", err)
	}

	// Compiled into two different places. Only the compile lines: the copy of each bundle's
	// dependencies names the same directory again, deliberately.
	var outputs []string
	for _, line := range r.ran {
		if !strings.Contains(line, "--outDir") {
			continue
		}
		for _, part := range strings.Fields(line) {
			if strings.HasPrefix(part, ".mesh-build/") {
				outputs = append(outputs, part)
			}
		}
	}
	if len(outputs) != 2 || outputs[0] == outputs[1] {
		t.Fatalf("two bundles did not get their own output directories: %v", outputs)
	}

	// And published as two artifacts, each with its own digest.
	if len(r.archives) != 2 {
		t.Fatalf("expected two archives published, got %v", r.archives)
	}
	first, _ := got.Manifest.Resources[0]["digest"].(string)
	second, _ := got.Manifest.Resources[1]["digest"].(string)
	if first == "" || second == "" {
		t.Fatalf("a bundle was not pinned: %v", got.Manifest.Resources)
	}
}