Fetch part: the TypeScript module's group package ({name, version} or {repository, commit, ref}), which the checker hands the Node fetch and the part lacked; typed in the three seats and the sdk, a node check ask fixture (B2g gap; ADR 0607 §3, ADR 0500 §5; issue 1966)

Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
2026-11-05 16:48:37 +01:00
parent b79b94b19d
commit 6b32e8257d
13 changed files with 135 additions and 1 deletions
@@ -251,6 +251,15 @@ type FetchBesideItem struct {
 	Repository string `json:"repository"`
 }

+// FetchPackage is the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's.
+type FetchPackage struct {
+	Commit     string `json:"commit,omitempty"`
+	Name       string `json:"name,omitempty"`
+	Ref        string `json:"ref,omitempty"`
+	Repository string `json:"repository,omitempty"`
+	Version    string `json:"version,omitempty"`
+}
+
 // Fetch is what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside.
 type Fetch struct {
 	// the trunk commit a merge preview merges onto
@@ -261,6 +270,8 @@ type Fetch struct {
 	Commit string `json:"commit"`
 	// the module's directory in the repository ("." for its root), with paths
 	Dir string `json:"dir,omitempty"`
+	// the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's
+	Package *FetchPackage `json:"package,omitempty"`
 	// the version (a full commit) of each mesh package to build against, by its module path
 	Packages map[string]string `json:"packages,omitempty"`
 	// the paths the module names, relative to dir
@@ -251,6 +251,15 @@ type FetchBesideItem struct {
 	Repository string `json:"repository"`
 }

+// FetchPackage is the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's.
+type FetchPackage struct {
+	Commit     string `json:"commit,omitempty"`
+	Name       string `json:"name,omitempty"`
+	Ref        string `json:"ref,omitempty"`
+	Repository string `json:"repository,omitempty"`
+	Version    string `json:"version,omitempty"`
+}
+
 // Fetch is what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside.
 type Fetch struct {
 	// the trunk commit a merge preview merges onto
@@ -261,6 +270,8 @@ type Fetch struct {
 	Commit string `json:"commit"`
 	// the module's directory in the repository ("." for its root), with paths
 	Dir string `json:"dir,omitempty"`
+	// the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's
+	Package *FetchPackage `json:"package,omitempty"`
 	// the version (a full commit) of each mesh package to build against, by its module path
 	Packages map[string]string `json:"packages,omitempty"`
 	// the paths the module names, relative to dir
@@ -251,6 +251,15 @@ type FetchBesideItem struct {
 	Repository string `json:"repository"`
 }

+// FetchPackage is the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's.
+type FetchPackage struct {
+	Commit     string `json:"commit,omitempty"`
+	Name       string `json:"name,omitempty"`
+	Ref        string `json:"ref,omitempty"`
+	Repository string `json:"repository,omitempty"`
+	Version    string `json:"version,omitempty"`
+}
+
 // Fetch is what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside.
 type Fetch struct {
 	// the trunk commit a merge preview merges onto
@@ -261,6 +270,8 @@ type Fetch struct {
 	Commit string `json:"commit"`
 	// the module's directory in the repository ("." for its root), with paths
 	Dir string `json:"dir,omitempty"`
+	// the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's
+	Package *FetchPackage `json:"package,omitempty"`
 	// the version (a full commit) of each mesh package to build against, by its module path
 	Packages map[string]string `json:"packages,omitempty"`
 	// the paths the module names, relative to dir
@@ -39,6 +39,8 @@ func TestFixtures(t *testing.T) {
 			}, subjectIs: nil},
 		{name: "a build ask", subject: "mesh.seat.node-build-node.accept.delivery", given: "{\"asker\":\"mesh-delivery-builder\",\"build\":{\"artifacts\":[{\"artifact\":\"go\"}],\"module\":\"nats\"},\"id\":\"a1b2\",\"kind\":\"build\",\"language\":\"go\"}", wire: "{\"asker\":\"mesh-delivery-builder\",\"build\":{\"artifacts\":[{\"artifact\":\"go\"}],\"module\":\"nats\"},\"id\":\"a1b2\",\"kind\":\"build\",\"language\":\"go\"}",
 			decode: func(b []byte) (any, error) { var v DeliveryAccept; err := json.Unmarshal(b, &v); return v, err }, subjectIs: regexp.MustCompile("^mesh\\.seat\\.node-build-node\\.accept\\.delivery$")},
+		{name: "a check ask with the group's tagged package", subject: "mesh.seat.node-build-node.accept.check", given: "{\"asker\":\"mesh-delivery-checker\",\"at\":\"2026-11-05T10:00:00Z\",\"check\":{\"fetch\":{\"base\":\"89abcdef0123456789abcdef0123456789abcdef\",\"commit\":\"0123456789abcdef0123456789abcdef01234567\",\"package\":{\"name\":\"@novox/mesh-sdk\",\"version\":\"0.1.15-feat-x.1\"},\"ref\":\"refs/pull/7/head\",\"repository\":\"novox/mesh-delivery\"},\"kept\":true,\"levels\":[\"unit\",\"integration\"],\"node-names\":[\"ace\",\"g14\"],\"toolchain\":{\"language\":\"typescript\",\"recipe\":\"1\",\"version\":\"26.12.0\"}},\"id\":\"c3d5\",\"kind\":\"check\",\"language\":\"typescript\",\"v\":1}", wire: "{\"asker\":\"mesh-delivery-checker\",\"at\":\"2026-11-05T10:00:00Z\",\"check\":{\"fetch\":{\"base\":\"89abcdef0123456789abcdef0123456789abcdef\",\"commit\":\"0123456789abcdef0123456789abcdef01234567\",\"package\":{\"name\":\"@novox/mesh-sdk\",\"version\":\"0.1.15-feat-x.1\"},\"ref\":\"refs/pull/7/head\",\"repository\":\"novox/mesh-delivery\"},\"kept\":true,\"levels\":[\"unit\",\"integration\"],\"node-names\":[\"ace\",\"g14\"],\"toolchain\":{\"language\":\"typescript\",\"recipe\":\"1\",\"version\":\"26.12.0\"}},\"id\":\"c3d5\",\"kind\":\"check\",\"language\":\"typescript\",\"v\":1}",
+			decode: func(b []byte) (any, error) { var v CheckAccept; err := json.Unmarshal(b, &v); return v, err }, subjectIs: regexp.MustCompile("^mesh\\.seat\\.node-build-node\\.accept\\.check$")},
 		{name: "a finished check step of a TypeScript merge preview", subject: "", given: "{\"ended\":\"2026-11-05T10:01:00Z\",\"id\":\"c3d6\",\"node\":\"ace\",\"result\":{\"fetch\":{\"base\":\"abcdef0123456789abcdef0123456789abcdef01\",\"changed\":[\"modules/m/package.json\"],\"commit\":\"0123456789abcdef0123456789abcdef01234567\",\"merge\":\"0123456789abcdef0123456789abcdef01234567\",\"modules\":[\"modules/m\"],\"trees\":{\"modules/m\":{\"manifest\":\"0581b699d9d05517e69b21f5cedbeb2eee8aba2b205280b561be731594d7feef\",\"tree\":\"0123456789abcdef0123456789abcdef01234567\"}},\"workspace\":\"mvii1sxt979f67\"}},\"started\":\"2026-11-05T10:00:00Z\",\"state\":\"passed\",\"tool\":\"check\",\"v\":1}", wire: "{\"ended\":\"2026-11-05T10:01:00Z\",\"id\":\"c3d6\",\"node\":\"ace\",\"result\":{\"fetch\":{\"base\":\"abcdef0123456789abcdef0123456789abcdef01\",\"changed\":[\"modules/m/package.json\"],\"commit\":\"0123456789abcdef0123456789abcdef01234567\",\"merge\":\"0123456789abcdef0123456789abcdef01234567\",\"modules\":[\"modules/m\"],\"trees\":{\"modules/m\":{\"manifest\":\"0581b699d9d05517e69b21f5cedbeb2eee8aba2b205280b561be731594d7feef\",\"tree\":\"0123456789abcdef0123456789abcdef01234567\"}},\"workspace\":\"mvii1sxt979f67\"}},\"started\":\"2026-11-05T10:00:00Z\",\"state\":\"passed\",\"tool\":\"check\",\"v\":1}",
 			decode: func(b []byte) (any, error) { var v StepsByNodeIDValue; err := json.Unmarshal(b, &v); return v, err }, subjectIs: nil},
 	}
@@ -467,6 +467,17 @@
          },
          "description": "the version (a full commit) of each mesh package to build against, by its module path"
        },
+        "package": {
+          "type": "object",
+          "description": "the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's",
+          "properties": {
+            "name": { "type": "string" },
+            "version": { "type": "string" },
+            "repository": { "type": "string" },
+            "commit": { "type": "string" },
+            "ref": { "type": "string" }
+          }
+        },
        "beside": {
          "type": "array",
          "items": {
@@ -60,6 +60,45 @@
      }
    }
  },
+  {
+    "name": "a check ask with the group's tagged package",
+    "of": "accept:check",
+    "subject": "mesh.seat.node-build-node.accept.check",
+    "given": {
+      "v": 1,
+      "id": "c3d5",
+      "kind": "check",
+      "language": "typescript",
+      "asker": "mesh-delivery-checker",
+      "at": "2026-11-05T10:00:00Z",
+      "check": {
+        "fetch": {
+          "repository": "novox/mesh-delivery",
+          "commit": "0123456789abcdef0123456789abcdef01234567",
+          "ref": "refs/pull/7/head",
+          "base": "89abcdef0123456789abcdef0123456789abcdef",
+          "package": {
+            "name": "@novox/mesh-sdk",
+            "version": "0.1.15-feat-x.1"
+          }
+        },
+        "levels": [
+          "unit",
+          "integration"
+        ],
+        "kept": true,
+        "toolchain": {
+          "language": "typescript",
+          "version": "26.12.0",
+          "recipe": "1"
+        },
+        "node-names": [
+          "ace",
+          "g14"
+        ]
+      }
+    }
+  },
  {
    "name": "a finished check step of a TypeScript merge preview",
    "of": "state:steps/<node>.<id>",
@@ -113,6 +113,7 @@ export type CurrentInput = buildStep.CurrentInput;
 export type Fetch = buildStep.Fetch;
 export type FetchAnswer = buildStep.FetchAnswer;
 export type FetchBesideItem = buildStep.FetchBesideItem;
+export type FetchPackage = buildStep.FetchPackage;
 export type FetchRefusal = buildStep.FetchRefusal;
 export type LevelAnswer = buildStep.LevelAnswer;
 export type LevelAnswerDigest = buildStep.LevelAnswerDigest;
@@ -67,6 +67,15 @@ export interface FetchBesideItem {
  "repository": string;
 }

+/** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+export interface FetchPackage {
+  "commit"?: string;
+  "name"?: string;
+  "ref"?: string;
+  "repository"?: string;
+  "version"?: string;
+}
+
 /** what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside */
 export interface Fetch {
  /** the trunk commit a merge preview merges onto */
@@ -77,6 +86,8 @@ export interface Fetch {
  "commit": string;
  /** the module's directory in the repository ("." for its root), with paths */
  "dir"?: string;
+  /** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+  "package"?: FetchPackage;
  /** the version (a full commit) of each mesh package to build against, by its module path */
  "packages"?: Record<string, string>;
  /** the paths the module names, relative to dir */
@@ -113,6 +113,7 @@ export type CurrentInput = buildStep.CurrentInput;
 export type Fetch = buildStep.Fetch;
 export type FetchAnswer = buildStep.FetchAnswer;
 export type FetchBesideItem = buildStep.FetchBesideItem;
+export type FetchPackage = buildStep.FetchPackage;
 export type FetchRefusal = buildStep.FetchRefusal;
 export type LevelAnswer = buildStep.LevelAnswer;
 export type LevelAnswerDigest = buildStep.LevelAnswerDigest;
@@ -67,6 +67,15 @@ export interface FetchBesideItem {
  "repository": string;
 }

+/** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+export interface FetchPackage {
+  "commit"?: string;
+  "name"?: string;
+  "ref"?: string;
+  "repository"?: string;
+  "version"?: string;
+}
+
 /** what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside */
 export interface Fetch {
  /** the trunk commit a merge preview merges onto */
@@ -77,6 +86,8 @@ export interface Fetch {
  "commit": string;
  /** the module's directory in the repository ("." for its root), with paths */
  "dir"?: string;
+  /** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+  "package"?: FetchPackage;
  /** the version (a full commit) of each mesh package to build against, by its module path */
  "packages"?: Record<string, string>;
  /** the paths the module names, relative to dir */
@@ -113,6 +113,7 @@ export type CurrentInput = buildStep.CurrentInput;
 export type Fetch = buildStep.Fetch;
 export type FetchAnswer = buildStep.FetchAnswer;
 export type FetchBesideItem = buildStep.FetchBesideItem;
+export type FetchPackage = buildStep.FetchPackage;
 export type FetchRefusal = buildStep.FetchRefusal;
 export type LevelAnswer = buildStep.LevelAnswer;
 export type LevelAnswerDigest = buildStep.LevelAnswerDigest;
@@ -67,6 +67,15 @@ export interface FetchBesideItem {
  "repository": string;
 }

+/** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+export interface FetchPackage {
+  "commit"?: string;
+  "name"?: string;
+  "ref"?: string;
+  "repository"?: string;
+  "version"?: string;
+}
+
 /** what a build module's fetch tool is asked: the repository and the full commit, the pull request's ref when only its head carries the commit, the trunk commit to merge onto for a merge preview, the module's directory and named paths, the mesh packages to build against, and the sibling repositories placed beside */
 export interface Fetch {
  /** the trunk commit a merge preview merges onto */
@@ -77,6 +86,8 @@ export interface Fetch {
  "commit": string;
  /** the module's directory in the repository ("." for its root), with paths */
  "dir"?: string;
+  /** the TypeScript module's group package: the group's tagged version of the SDK ({name, version}), placed from the registry in each member whatever its lock names, or the group's package member ({repository, commit, ref}), packed by the fetch and served to the members in place of the registry's */
+  "package"?: FetchPackage;
  /** the version (a full commit) of each mesh package to build against, by its module path */
  "packages"?: Record<string, string>;
  /** the paths the module names, relative to dir */
@@ -213,7 +213,20 @@ type Fetch struct {
 	Dir        string          `json:"dir,omitempty"`
 	Paths      []string        `json:"paths,omitempty"`
 	Packages   PackageVersions `json:"packages,omitempty"`
-	Beside     []FetchBeside   `json:"beside,omitempty"`
+	// Package is the TypeScript module's group package: the group's tagged version ({name, version}) or the group's package
+	// member ({repository, commit, ref}).
+	Package *FetchPackage `json:"package,omitempty"`
+	Beside  []FetchBeside `json:"beside,omitempty"`
+}
+
+// FetchPackage is the group package a TypeScript fetch takes (ADR 0607 §3, ADR 0500 §5): either the group's tagged version
+// (Name and Version) or the group's package member (Repository, Commit and Ref).
+type FetchPackage struct {
+	Name       string `json:"name,omitempty"`
+	Version    string `json:"version,omitempty"`
+	Repository string `json:"repository,omitempty"`
+	Commit     string `json:"commit,omitempty"`
+	Ref        string `json:"ref,omitempty"`
 }

 // FetchBeside is a sibling repository placed beside the fetched tree.