Say which artifacts the store check asks about: bundles and archives, whose blobs the collector deletes (issue 1937)

This commit is contained in:
2026-10-24 04:19:17 +02:00
parent 80a0183567
commit f0c5be8c30
@@ -68,9 +68,9 @@ type ClaimOptions struct {
Stored func(ctx context.Context, references []string) (gone []string, err error)
}
// StoredReferences are the references of a done build's bundles, archives and upstream copies that name a blob in the
// artifact store (`artifact-store://<module>/<artifact>/blobs/<digest>`): what the store's collector can delete. An image
// is a manifest, which the collector keeps, and a package lives in the package registry.
// StoredReferences are the references of a done build's bundles and archives that name a blob in the artifact store
// (`artifact-store://<module>/<artifact>/blobs/<digest>`): what the store's collector can delete. An image or an upstream
// copy is a manifest, which the collector keeps, and a package lives in the package registry.
func StoredReferences(b delivery.BuilderBuild) []string {
var out []string
for _, a := range b.Artifacts {
@@ -148,7 +148,7 @@ func Unreferenced(b delivery.BuilderBuild) bool {
// names it (ClaimOptions.Trunk): that is taken as it stands, with the done value, and its builder writes the new
// revision when the publishing build ends (ADR 0498 clause 6). From R4e one node builds each fingerprint (ADR 0478
// clause 4), so a key built on one node is never built again for a second;
// - a done key of the trunk's fingerprint whose bundle, archive or upstream copy the artifact store no longer holds
// - a done key of the trunk's fingerprint whose bundle or archive blob the artifact store no longer holds
// (ClaimOptions.Stored, issue 1937) is claimed building as a new revision and built whole, its step saying which;
// - a failed key is taken again as a new revision of the same key (ADR 0429 clause 18), except one failed for a kind no
// builder builds, for an upstream pinned by no digest or a package version taken (delivery.FailedUntilChanged: ADR 0478