The assigner calls the controller only with the arguments its contract declares, and a refused call is a condition (issue 774) #118

Merged

mesh-tools merged 2 commits from fix/held-module-and-assigner-contract into main 2026-10-30 21:17:41 +00:00

Conversation 3 Commits 2 Files Changed 24

+570 -45

2 Commits

Author	SHA1	Message	Date
jschoubben	8fe6442c47	Clear a refused pin's condition once the controller's pins agree, and take over a previous process's conditions only once the findings are read (issue 774) ... A pin made by hand, as the condition's Needs asks, changed nothing the assigner looked at, so its urgent condition never cleared, and a restart left every one raised. The assigner now reads the controller's pins (placement-export, asked again only after the controller's compositions change, never on a timer) and clears a pin's condition once they agree with the placement's after being seen differing, as a module's place already did. The first pass takes over the call conditions a previous process raised, pins and places alike, and retries at the next pass when the findings cannot be read.	2026-10-30 21:27:35 +01:00
jschoubben	1fef458c5f	Send the controller only the arguments its contract declares, and make a refused call a condition (issue 774) ... The assigner added "why" to every assign, unassign, pin and unpin since 2026-10-28; the controller's seat contract takes no such argument, so it refused each one and did nothing. No approved placement reached the controller's assignments, no bus account was minted for a newly placed module, and the refusal was only a journal line. Quick fix: drop "why" from ControllerCalls. Thorough fix: a contract test that every argument ControllerCalls gives, for every verb, is declared (and every required one given) in catalogue.ControllerVerbs, plus an urgent condition per pair whose call was refused (verb, node, module, the controller's words), cleared when a later call is answered or the two sources agree. Chosen: both here; a caller-side check of arguments against the seat's contract for every seat call belongs in mesh-sdk and is noted for the lead. The warrant stays in the assigner's own record (placement-changed, the hand-act log). Every module pins mesh-sdk eff81f1220e2 (in review).	2026-10-30 21:23:39 +01:00