Answer the controller's lease, what still depends on it and the lease write's check in one call (issue 774) #120

Merged

mesh-tools merged 2 commits from feat/lease-tool into main 2026-10-30 22:49:20 +00:00

Conversation 1 Commits 2 Files Changed 5

+650 -2

2 Commits

Author	SHA1	Message	Date
jschoubben	2dd5239726	Refuse the lease write's check when the indexer's manifests were not all read (issue 774) ... Review of 09791f5: with the indexer's modules bucket readable but empty, nothing was read, so nothing was found and both phases passed; the operator could have handed the lease away while an unkept read still stood. Judge now refuses when no manifest was read, or fewer of the indexer's modules than it holds (a provided manifest does not count for a missing one), saying why; a missing or refused manifest is named as before, now under test. The controller's grants leave the keep list: ADR 0571 §9 has no manifest read them from L7's delivery, changing ADR 0567 §10 and ADR 0547 §5's shadow compare, so the assigner's and the grants part's reads are refused, and a refusal names the record that ended a declaration where one does. Quick fix: the counts in the grants part's Judge, as here. Thorough fix: the same coverage rule in the shared mesh-sdk derivation once the keep list moves there; the quick one stands until then.	2026-10-30 23:41:11 +01:00
jschoubben	09791f5a82	Answer the controller's lease, what still depends on it and the lease write's check in one call (issue 774) ... The operator asked to remove the controller by finishing its hand-over; no tool said who holds the lease, which manifests still read, invoke or consume mesh-controller, or whether the lease write's check (ADR 0571 §13) would pass. grants_lease_check answers all three from bus state on the grants part, which already reads the lease, every manifest at the indexer's trunk and the bus's streams: the holder and what follows from it, every dependency with the record on the named keep list that keeps it, the controller's streams and buckets someone consumes, and the check run dry at the write (the three kept to it alone) and before its delivery, with reasons. Quick fix: the judgement and the keep list in the grants part, as here. Thorough fix: the keep list and the dependency derivation in mesh-sdk, shared by this tool and the §13 manifest tests in mesh-catalog, mesh-delivery and mesh-tools. Chosen quick: the tests do not exist yet and an sdk move needs a group; the move is named for the lead.	2026-10-30 23:30:09 +01:00