The watchman confirms a module unhealthy by time, and keeps a standing finding across its restart (issue 1952) #127

2026-10-31T21:02:58Z

mesh-tools commented

2026-10-31 21:02:58 +00:00

Issue 1952 (milestone L4 of design 47, ADR 0564 §4), approved by the operator on 2026-10-31 about 22:00.

Why: the watchman confirmed a module unhealthy only after two writes of its have in a row. A have that turns failed once and then stays the same is written once, so no finding was ever written; live, module.fail2ban.novox.unhealthy (the controller's) had no counterpart in the condition keeper's compare.

The change: a failed have starts a one-minute confirm signal and the warning is written if the have still says failed when it fires (ADR 0564 §4 names two statements in a row and no bound); the four-hour urgent signal starts beside it. A finding read back at start and replayed by a failed have is kept as it was: it is not confirmed again, a warning's urgent signal runs from its own Since, and an urgent finding stays urgent with no signal restarted.

Quick fix vs thorough fix: confirming by time is the thorough form here (no count of writes anywhere), in the one module that confirms.

Tests: WM3 rewritten (a steady failed have gets its finding after the bound; one that recovers within it gets none; the urgent signal after 4 h), a restart row, and two rows for a finding read back at start (warning and urgent), each failing on the old code. gofmt, go vet (with and without -tags integration) and go test pass. No new Test functions.

Reviewed-by: rev-l4@shanks at 8a658a4290

https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Issue 1952 (milestone L4 of design 47, ADR 0564 §4), approved by the operator on 2026-10-31 about 22:00. **Why:** the watchman confirmed a module unhealthy only after two writes of its have in a row. A have that turns failed once and then stays the same is written once, so no finding was ever written; live, `module.fail2ban.novox.unhealthy` (the controller's) had no counterpart in the condition keeper's compare. **The change:** a failed have starts a one-minute confirm signal and the warning is written if the have still says failed when it fires (ADR 0564 §4 names two statements in a row and no bound); the four-hour urgent signal starts beside it. A finding read back at start and replayed by a failed have is kept as it was: it is not confirmed again, a warning's urgent signal runs from its own Since, and an urgent finding stays urgent with no signal restarted. **Quick fix vs thorough fix:** confirming by time is the thorough form here (no count of writes anywhere), in the one module that confirms. **Tests:** WM3 rewritten (a steady failed have gets its finding after the bound; one that recovers within it gets none; the urgent signal after 4 h), a restart row, and two rows for a finding read back at start (warning and urgent), each failing on the old code. gofmt, go vet (with and without -tags integration) and go test pass. No new Test functions. Reviewed-by: rev-l4@shanks at 8a658a4290c965cc09ecb2e5322020da27f62234 https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

mesh-tools added 2 commits 2026-10-31 21:02:58 +00:00

Watchman: a module is unhealthy when its have still says failed a minute after it first did (issue 1952) fb8d2386b9

A have that turned failed once and stayed unchanged was written once, so the old count of two writes never fired and the
finding was never written (fail2ban on novox). Confirm by time, with a signal, also at a restart.
Quick: raise the count to one write (loses the confirmation). Thorough, chosen: confirm by a time bound, as ADR 0564 s4's
signals are keys that expire, so no write count is needed.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Watchman: an unhealthy finding read back at the start is kept as it was (issue 1952)

mesh/delivery merged: source.main moved to novox/mesh-delivery@91128d4f0af6

Details

mesh/check checking 8a658a4290c9 on 91128d4f0af6

8a658a4290

At a restart a standing finding is observed again by the replayed failed have: kept, not confirmed again, and its urgent
signal runs on from the finding's Since; an urgent one stays urgent with no signal restarted.
Quick: skip the confirm when a finding stands. Thorough, chosen: the same, plus urgency read from the finding itself.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

mesh-tools commented

2026-10-31 21:03:01 +00:00

Delivery novox/mesh-delivery@8a658a4290c9 — merged since 2026-10-31T21:34:08Z

Source — source.main moved to novox/mesh-delivery@91128d4f0a. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-31 21:02 (new) → proposed (announced): novox/mesh-delivery#127's head announced
2026-10-31 21:03 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-31 21:34 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@8a658a4290c9` — **merged** since 2026-10-31T21:34:08Z **Source** — source.main moved to novox/mesh-delivery@91128d4f0af6. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-31 21:02 (new) → proposed (announced): novox/mesh-delivery#127's head announced - 2026-10-31 21:03 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-31 21:34 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 91128d4f0a into main

2026-10-31 21:34:06 +00:00

mesh-tools deleted branch fix/watchman-confirm

2026-10-31 21:34:08 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#127