A pull request's check composes only after the change's own builds end (issue 1921) #164

Merged
mesh-tools merged 2 commits from fix/1921-compose-waits-builds into main 2026-11-07 13:28:38 +00:00
2 Commits
Author SHA1 Message Date
jschoubben c0da09d81f A pull request's check without a previewed candidate says its composition was not judged, not its manifests (issue 1921, review note)
mesh/delivery merged: source.main moved to novox/mesh-delivery@6bc232eb78b9
mesh/check checking c0da09d81f6e on 6bc232eb78b9
Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
2026-11-07 14:21:15 +01:00
jschoubben 3f9acf0223 A check composes only after the candidate's builds it waits on have ended (issue 1921)
mesh/delivery closed: a newer head of the same pull request
mesh/check failed: novox: not composed on novox: mesh-delivery-checker: frombus: mesh-delivery-checker is wanted at src… | 3f9acf022325 on b719dc0ecf27
The indexer writes a pull request's candidate first from its pull message alone, every module's
fingerprint "no merge preview is computed", and the fingerprints only with the preview, on the same
heads. A check that began on that first write kept its case: it waited on no build, said nothing,
and the engines, reading the previewed candidate, refused the module as not yet built (mesh-catalog
#624, mesh-delivery #163). Such a check now takes the previewed candidate before it judges the
manifests, waits on the builds and composes, as a whole try already does.

A build not ended within the build-wait-bound is named and the change is not composed, never an
engine's refusal of a fingerprint it has no done build of read as the change's.

Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
2026-11-07 12:48:11 +01:00