A take-in wait ends whoever learnt of it: taken under every key, and the watchman's seed ends what the indexer no longer holds (issue 1966) #202

Merged

mesh-tools merged 4 commits from fix/1966-take-in-ends-every-wait into main 2026-11-10 22:50:33 +00:00

Conversation 1 Commits 4 Files Changed 5

+160 -9

4 Commits

Author	SHA1	Message	Date
jschoubben	e82da39d29	Test that a seed indexer_pending could not answer ends nothing (issue 1966, note 197) ... seedTakeIn with a failing call and with an unreadable answer leaves a previous run's take-in-waits finding and a held wait standing; it fails if the error path seeded an empty answer. Builds: design 47 "Taken in by the indexer it names" (A wait is bounded, said and recoverable); 1966/AC195-5 Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ	2026-11-10 23:48:45 +01:00
jschoubben	3ed2a3dd33	The indexer says take-in.taken under every claimed entry's own key too (issue 1966, note 195) ... A merge waiting behind a gathered group is named by indexer_pending under its own key; when the group ends it joins the group's revision under the oldest member's key, so its own key was never said taken. takenWaits now also says every claimed entry's key, no key twice. T8 checks the merge behind the group ends under its own key. Builds: design 47 "Taken in by the indexer it names" (A wait is bounded, said and recoverable); 1966/AC195-1, AC195-3 Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ	2026-11-10 23:45:52 +01:00
jschoubben	393f69f766	The watchman's seed ends the waits and findings indexer_pending no longer names (issue 1966, note 195) ... SeedTakeIn, run once indexer_pending answered and after the findings of a previous run were read, ends every take-in wait, held wait and take-in-waits finding whose key the answer does not name, as a take-in.taken would. A seed that could not ask is not run, so ends nothing. Builds: design 47 "Taken in by the indexer it names" (A wait is bounded, said and recoverable: "At its start the watchman seeds its open waits from indexer_pending, and ends every take-in wait and take-in-waits finding it holds whose key indexer_pending no longer names"); 1966/AC195-5 Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ	2026-11-10 23:45:52 +01:00
jschoubben	c2e466e16c	The indexer says take-in.taken for every wait indexer_pending names (issue 1966, note 195) ... A merge taken in with no take-in.pending said for it (read from indexer_pending at a watchman restart, or said pending by the own-build-unknown path) ended with no taken event, so the watchman raised take-in-waits for a wait nothing held. takeInWholeBy now says taken for each wait WaitsOf names for the claimed entries (a revision by its oldest merge's key, a group by its g. key) as well as for its said waits, without saying a key twice. Drops are unchanged. Builds: design 47 "Taken in by the indexer it names" (A wait is bounded, said and recoverable); 1966/AC195-1, AC195-2, AC195-3, AC195-4 Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ	2026-11-10 23:45:46 +01:00